| 00:24:07 | *** codestasher has joined #openmrs |
| 00:47:16 | *** bwolfe has joined #openmrs |
| 00:47:16 | *** ChanServ sets mode: +o bwolfe |
| 01:05:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2242 (task created): Add more information to System Information page <http://dev.openmrs.org/ticket/2242> |
| 01:15:04 | *** nribeka has quit IRC |
| 01:38:42 | *** r0bby|android has joined #openmrs |
| 01:38:42 | *** ChanServ sets mode: +v r0bby|android |
| 01:51:13 | *** chopin has joined #openmrs |
| 01:51:13 | *** ChanServ sets mode: +v chopin |
| 01:59:26 | *** upul` has joined #openmrs |
| 01:59:26 | *** ChanServ sets mode: +v upul` |
| 02:00:26 | *** maveriick has joined #openmrs |
| 02:06:00 | *** robbyoconnor has joined #openmrs |
| 02:06:00 | *** ChanServ sets mode: +v robbyoconnor |
| 02:56:26 | *** openmrs_web954 has joined #openmrs |
| 03:05:46 | *** luzhuangwei has joined #openmrs |
| 03:08:17 | *** openmrs_web954 is now known as firzhan |
| 03:11:19 | *** chopin has quit IRC |
| 03:11:20 | *** jkeiper has joined #openmrs |
| 03:11:20 | *** ChanServ sets mode: +v jkeiper |
| 03:18:33 | *** jkeiper has quit IRC |
| 03:18:44 | *** luzhuangwei has quit IRC |
| 03:24:41 | *** Mkop has joined #openmrs |
| 03:24:41 | *** ChanServ sets mode: +v Mkop |
| 03:42:36 | *** jmiranda has joined #openmrs |
| 03:42:36 | *** ChanServ sets mode: +o jmiranda |
| 03:50:03 | *** gurbuz has quit IRC |
| 03:51:00 | *** firzhan has quit IRC |
| 04:06:30 | *** upul` has quit IRC |
| 04:18:21 | *** openmrs_web400 has joined #openmrs |
| 04:19:53 | *** openmrs_web400 has quit IRC |
| 04:22:13 | *** codestasher has quit IRC |
| 04:34:41 | *** umashanthi has joined #openmrs |
| 04:38:38 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12952]: maven: Fixing compile time utf-8 issue <http://dev.openmrs.org/changeset/12952> |
| 04:47:47 | *** Zabil has joined #openmrs |
| 05:11:46 | *** Mkop has quit IRC |
| 05:25:08 | *** gigasoft1 has joined #openmrs |
| 05:28:46 | *** umashanthi1 has joined #openmrs |
| 05:30:47 | *** Mkop has joined #openmrs |
| 05:30:47 | *** ChanServ sets mode: +v Mkop |
| 05:33:06 | *** umashanthi1 has left #openmrs |
| 05:33:13 | *** umashanthi1 has joined #openmrs |
| 05:33:25 | *** umashanthi1 has left #openmrs |
| 05:33:41 | *** umashanthi1 has joined #openmrs |
| 05:33:55 | *** umashanthi1 has left #openmrs |
| 05:34:35 | *** umashanthi has quit IRC |
| 05:55:45 | *** jmiranda has quit IRC |
| 05:56:50 | *** openmrs_web527 has joined #openmrs |
| 06:13:30 | *** gigasoft1 has quit IRC |
| 06:40:28 | *** openmrs_web019 has joined #openmrs |
| 06:40:53 | <openmrs_web019> nick:firzhan |
| 06:41:03 | *** openmrs_web019 is now known as firzhan |
| 06:46:19 | *** pascal` has joined #openmrs |
| 06:49:55 | *** pascal` has quit IRC |
| 06:56:51 | *** openmrs_web347 has joined #openmrs |
| 06:57:02 | *** openmrs_web347 is now known as saimanohar |
| 06:57:06 | <saimanohar> hi all |
| 06:57:10 | <saimanohar> nyone around |
| 06:58:44 | *** openmrs_web527 has quit IRC |
| 07:03:06 | <Mkop> no |
| 07:03:12 | *** pascal` has joined #openmrs |
| 07:03:12 | *** ChanServ sets mode: +v pascal` |
| 07:04:30 | *** openmrs_web474 has joined #openmrs |
| 07:04:39 | *** robbyoconnor has quit IRC |
| 07:04:46 | *** r0bby_ has joined #openmrs |
| 07:04:46 | *** ChanServ sets mode: +v r0bby_ |
| 07:05:11 | <openmrs_web474> hi pascal |
| 07:05:40 | *** saimanohar has quit IRC |
| 07:06:13 | *** openmrs_web474 is now known as saimanohar |
| 07:06:22 | <saimanohar> hey |
| 07:07:31 | <pascal`> hey saimanohar |
| 07:07:49 | <pascal`> !refer saimanohar [tabcomplete] |
| 07:07:49 | * OpenMRSBot refers saimanohar to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila! |
| 07:08:25 | <saimanohar> will all the projects listed in gsoc would get approved by google |
| 07:12:29 | *** mathiaslin has joined #openmrs |
| 07:33:56 | *** saimanohar has quit IRC |
| 07:41:24 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12953]: logmanager: fixed broken select none/all buttons on tools page <http://dev.openmrs.org/changeset/12953> |
| 07:42:16 | *** danielf` has joined #openmrs |
| 07:42:16 | *** ChanServ sets mode: +v danielf` |
| 07:43:23 | *** openmrs_web145 has joined #openmrs |
| 07:44:19 | *** openmrs_web145 has quit IRC |
| 08:11:30 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12954]: logmanager: moved log4j specific classes into .log4j package <http://dev.openmrs.org/changeset/12954> |
| 08:23:25 | *** Mkop has quit IRC |
| 08:24:45 | *** openmrs_web017 has joined #openmrs |
| 08:24:57 | *** openmrs_web017 is now known as saimanohar |
| 08:25:01 | <saimanohar> hi all |
| 08:25:14 | <saimanohar> guys i am a bit tensed |
| 08:40:28 | <pascal`> hi saimanohar |
| 08:40:34 | <pascal`> !beer saimanohar |
| 08:40:34 | * OpenMRSBot slides saimanohar a pint |
| 08:41:41 | <saimanohar> no i mean to say all my other friends got responses from there mentors asking some kinda questions |
| 08:41:57 | <saimanohar> i didnt get any notification |
| 08:42:11 | <saimanohar> i hope the project i applied for should get a slot from google |
| 08:45:08 | <pascal`> saimanohar, we're working through the projects |
| 08:45:22 | <pascal`> saimanohar, you should get some comments by tomorrow |
| 08:53:19 | <saimanohar> ok i would wait for them |
| 09:11:43 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12955]: logmanager: added new configuration page and renamed old config page to ⦠<http://dev.openmrs.org/changeset/12955> |
| 09:12:36 | *** saimanohar has quit IRC |
| 09:24:05 | *** openmrs_web327 has joined #openmrs |
| 09:24:15 | *** openmrs_web327 is now known as saimanohar |
| 09:41:24 | *** saimanohar has quit IRC |
| 09:53:09 | *** openmrs_web152 has joined #openmrs |
| 09:53:23 | *** openmrs_web152 has quit IRC |
| 10:10:05 | *** maveriick has quit IRC |
| 10:20:14 | *** Mkop has joined #openmrs |
| 10:20:14 | *** ChanServ sets mode: +v Mkop |
| 10:25:49 | *** Mkop has quit IRC |
| 10:28:26 | *** downeym has joined #openmrs |
| 10:28:26 | *** ChanServ sets mode: +o downeym |
| 10:29:16 | <downeym> hello world |
| 10:30:01 | *** r0bby|android has quit IRC |
| 10:30:59 | <pascal`> hey downeym |
| 10:35:12 | *** Flusher has joined #openmrs |
| 10:46:07 | <pascal`> downeym, for this week's call music: http://www.youtube.com/watch?v=nrZ8cAbTJLc |
| 10:46:17 | <pascal`> downeym, listen to it loudly if you can =D |
| 10:46:40 | <downeym> hahaha |
| 10:46:57 | <downeym> dubstep |
| 10:48:11 | <downeym> will see about using that ... am hoping to train our new project manager on using the conference system |
| 10:48:58 | <pascal`> (= |
| 10:51:58 | *** gigasoft1 has joined #openmrs |
| 10:55:54 | *** danielf` has quit IRC |
| 10:55:54 | *** pascal` has quit IRC |
| 11:01:01 | *** pascal` has joined #openmrs |
| 11:05:54 | *** ChanServ sets mode: +v pascal` |
| 11:12:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12956]: logmanager: added event injection form to tools page <http://dev.openmrs.org/changeset/12956> |
| 11:12:32 | *** danielf` has joined #openmrs |
| 11:12:32 | *** ChanServ sets mode: +v danielf` |
| 11:14:55 | <downeym> hey danielf` |
| 11:15:12 | <danielf`> hey downeym |
| 11:20:15 | *** gigasoft1 has quit IRC |
| 11:30:22 | *** openmrs_web956 has joined #openmrs |
| 11:30:24 | *** openmrs_web331 has joined #openmrs |
| 11:30:33 | *** openmrs_web956 has quit IRC |
| 11:30:36 | *** openmrs_web331 has quit IRC |
| 12:14:19 | *** Zabil has quit IRC |
| 12:25:31 | *** Keelaphone has joined #openmrs |
| 12:25:41 | *** chopin has joined #openmrs |
| 12:25:41 | *** ChanServ sets mode: +v chopin |
| 12:25:49 | *** Mkop has joined #openmrs |
| 12:25:49 | *** ChanServ sets mode: +v Mkop |
| 12:26:59 | <pascal`> hey chopin |
| 12:27:01 | <pascal`> hey Mkop |
| 12:27:19 | <pascal`> !bwolfe |
| 12:27:19 | <OpenMRSBot> pascal`: "bwolfe" --- (#1) is a Jedi, or (#2) Supreme Chancellor of OpenMRS |
| 12:27:26 | *** openmrs_web561 has joined #openmrs |
| 12:27:55 | *** openmrs_web561 has quit IRC |
| 12:28:10 | <downeym> !pascal` |
| 12:28:10 | <OpenMRSBot> downeym: "pascal`" --- not a valid command |
| 12:31:08 | <pascal`> !downeym |
| 12:31:08 | <OpenMRSBot> pascal`: "downeym" --- The evil overlord of OpenMRS |
| 12:33:35 | *** maveriick has joined #openmrs |
| 12:39:01 | *** openmrs_web611 has joined #openmrs |
| 12:39:23 | *** openmrs_web611 is now known as firzhan |
| 12:41:48 | <Mkop> hi pascal` |
| 12:41:51 | <Mkop> hi downeym |
| 12:42:01 | * Mkop is up bright and early today! |
| 12:42:04 | <Mkop> whoo hoo! |
| 12:43:41 | *** bwolfe has quit IRC |
| 12:44:43 | <downeym> good morning Mkop |
| 12:44:50 | * downeym woke up at 3 :D |
| 12:46:48 | *** jmiranda has joined #openmrs |
| 12:46:48 | *** ChanServ sets mode: +o jmiranda |
| 12:51:13 | <pascal`> hey jmiranda |
| 12:52:01 | *** jmiranda has quit IRC |
| 12:54:49 | * Mkop went to sleep at 4:30 and woke up at 6:30 |
| 12:56:12 | <Keelaphone> why the hell |
| 12:56:25 | <Mkop> a friend and I were going to a nearby prayer service at 6:45, and I asked him to wake me. he came to my room at 4:30 to sleep on my couch so he would be more likely to wake up on time, which I took as my signal to go to sleep myself |
| 12:56:49 | *** bwolfe has joined #openmrs |
| 12:56:49 | *** ChanServ sets mode: +o bwolfe |
| 12:56:56 | <Mkop> I am glad for the kick in my pants to mess up my sleep schedule - my current sleep schedule is totally whack |
| 12:56:59 | <downeym> all hail bwolfe |
| 12:57:04 | <Mkop> hail! |
| 12:57:12 | <Keelaphone> hi |
| 12:57:13 | <Mkop> it's raining, it's pouring, old bwolfe is snoring.... |
| 12:57:23 | <downeym> hail yes |
| 12:58:03 | *** gurbuz has joined #openmrs |
| 12:58:04 | * Mkop is gonna have an awesome productive day |
| 12:58:18 | <Mkop> which unfortunately must include closing IRC, I think |
| 12:58:30 | <downeym> fail |
| 12:58:36 | <downeym> Mkop: you'll miss our meeting |
| 12:58:38 | <downeym> !devmtg |
| 12:58:38 | <OpenMRSBot> downeym: "devmtg" --- Reminder: Developer meeting Thursday at 10:00 AM Eastern - http://openmrs.org/wiki/Developers_Conference_Call |
| 12:59:07 | <Mkop> correct |
| 12:59:14 | <Mkop> :-) |
| 12:59:21 | <Mkop> you're all a bunch of jerks anyway |
| 12:59:27 | * downeym writes Mkop a pass |
| 12:59:47 | <Mkop> does attending once mean that I need a pass to miss any future meetings? |
| 12:59:58 | <downeym> yes :P |
| 13:00:14 | <Mkop> ok |
| 13:00:26 | <Mkop> I hope you left the date slot blank on that pass |
| 13:00:52 | <downeym> i wrote some javascript to always put the thursday of the current week in the date field |
| 13:02:28 | <Mkop> nice |
| 13:03:08 | * Mkop hopes to graduate with good grades. I love #openmrs until it interferes with that. And thus today's absence. |
| 13:04:07 | <downeym> no fault there |
| 13:04:28 | <chopin> hey-o all |
| 13:05:01 | *** kennymac has joined #openmrs |
| 13:05:15 | <kennymac> hi all |
| 13:05:30 | <Mkop> hi chopin |
| 13:05:32 | <Mkop> hi kennymac |
| 13:06:24 | *** Zabil has joined #openmrs |
| 13:09:31 | *** openmrs_web992 has joined #openmrs |
| 13:09:53 | <Keelaphone> mkop: how do you intend on being productive after 2h of sleep |
| 13:10:01 | *** openmrs_web992 is now known as Ladyfa |
| 13:10:22 | <Mkop> I napped yesterday, for starts |
| 13:10:31 | <Ladyfa> hi everyone |
| 13:10:45 | <Mkop> second of all, productivity depends more on motivation than physical strength |
| 13:10:58 | <Mkop> hi Ladyfa |
| 13:11:38 | <Keelaphone> the best motivation won't help much at reduced mental capacity |
| 13:11:49 | <Keelaphone> ;] |
| 13:18:22 | *** Zabil has quit IRC |
| 13:20:35 | *** Zabil has joined #openmrs |
| 13:21:03 | *** openmrs_web641 has joined #openmrs |
| 13:25:09 | *** kennymacd has joined #openmrs |
| 13:25:19 | <Mkop> that's what coffee is for :-) |
| 13:26:28 | *** Ladyfa has quit IRC |
| 13:26:47 | <Keelaphone> youngsters... ;) |
| 13:27:30 | <downeym> dietcoke++ |
| 13:27:32 | *** openmrs_web641 has quit IRC |
| 13:28:06 | *** nribeka has joined #openmrs |
| 13:28:06 | *** ChanServ sets mode: +v nribeka |
| 13:28:42 | *** codestasher has joined #openmrs |
| 13:28:47 | *** Shazin has joined #openmrs |
| 13:29:04 | *** kennymac has quit IRC |
| 13:29:25 | <Mkop> in general, I'm not really one to work on little sleep |
| 13:29:30 | <Mkop> but today I'm gonna have to e |
| 13:29:32 | <Mkop> be* |
| 13:30:38 | <chopin> oy ... i wish we had implemented relationship types as RelationshipType { RelationshipSide a: "Doctor", RelationshipSide b: "Patient" } |
| 13:30:46 | *** kennymacd is now known as kennymac |
| 13:30:49 | <chopin> that way i could refer to RelationshipSide independently |
| 13:30:52 | <chopin> 8| |
| 13:31:52 | *** luzhuangwei has joined #openmrs |
| 13:31:59 | *** openmrs_web449 has joined #openmrs |
| 13:32:01 | *** openmrs_web449 is now known as mrosas |
| 13:32:04 | <mrosas> hello |
| 13:32:48 | <mrosas> i've got an issue here, i'm sending some info from my module controller to the view, but i can't make it to show up in the View |
| 13:33:07 | <mrosas> need some help, here is the code in both controller and view |
| 13:33:08 | <mrosas> http://pastebin.com/dw8hqT21 |
| 13:43:19 | <bwolfe> mrosas: I don't think you can use that with RedirectView |
| 13:46:34 | *** Keelaphone is now known as Keelhaul |
| 13:46:46 | *** ChanServ sets mode: +v Keelhaul |
| 13:46:47 | <mrosas> ok bwolfe, do you know what should i use? |
| 13:47:02 | *** Keelhaul is now known as Keelafone |
| 13:47:07 | <bwolfe> mrosas: depends what your full controller looks like |
| 13:47:34 | <bwolfe> mrosas: are you using spring annotations in your controller ? |
| 13:48:17 | <Keelafone> proper qwertz kb is so much faster than onscreen |
| 13:48:50 | *** umashanthi has joined #openmrs |
| 13:48:57 | *** Echidna is now known as Keelhaul |
| 13:49:17 | *** Keelhaul is now known as Echidna |
| 13:51:48 | <bwolfe> Keelafone: you have a "qwertz" keyboard?? I think you have some keys mixed up (which might be causing the slowdown). :-) |
| 13:52:00 | <mrosas> no bwolfe, not using annotations |
| 13:52:16 | <Echidna> bwolfe: http://www.biocrawler.com/w/images/d/d2/KeyboardLayout-German.png |
| 13:52:19 | <OpenMRSBot> <http://ln-s.net/5i_4> (at www.biocrawler.com) |
| 13:52:46 | <Echidna> bwolfe: notice the positions of { } |
| 13:52:50 | <Echidna> really sucks for writing code |
| 13:52:59 | <Echidna> gotta press the right ALT key |
| 13:53:08 | <bwolfe> mrosas: so do you have a formBackingObject method? or a referenceData method? |
| 13:53:30 | *** linyb04 has joined #openmrs |
| 13:53:32 | <mrosas> formBackingObject |
| 13:53:48 | <bwolfe> Echidna: ah, those silly umlauts |
| 13:53:53 | *** linyb04 has quit IRC |
| 13:54:03 | *** Keelafone has quit IRC |
| 13:54:45 | <bwolfe> what are you putting into the formBackingObject? why can't you put it there? for "extra" information to go to the page as it loads (alongside the formbacking object) just return "model", yourobject in the referenceData object |
| 13:56:59 | *** zeshan has joined #openmrs |
| 13:56:59 | *** ChanServ sets mode: +v zeshan |
| 13:57:40 | *** openmrs_web424 has joined #openmrs |
| 13:57:58 | *** openmrs_web424 is now known as judywawira |
| 13:59:53 | <downeym> !devmtg |
| 13:59:53 | <OpenMRSBot> downeym: "devmtg" --- Reminder: Developer meeting Thursday at 10:00 AM Eastern - http://openmrs.org/wiki/Developers_Conference_Call |
| 13:59:57 | <downeym> (that's now) :) |
| 14:00:07 | *** syhaas has joined #openmrs |
| 14:00:07 | *** ChanServ sets mode: +v syhaas |
| 14:01:12 | *** openmrs_web205 has joined #openmrs |
| 14:01:19 | *** openmrs_web205 is now known as Suneeth |
| 14:01:28 | *** openmrs_web948 has joined #openmrs |
| 14:01:34 | <downeym> We will be starting in about 5 minutes hopefully :) |
| 14:01:49 | *** openmrs_web948 is now known as saimanohar |
| 14:01:55 | *** nribeka has quit IRC |
| 14:02:07 | *** openmrs_web343 has joined #openmrs |
| 14:02:16 | *** openmrs_web343 is now known as r-friedman |
| 14:02:37 | <zeshan> Also, don't forget that we'll be webcasting portions of today's call. The webcast server is http://connect.openmrs.org. |
| 14:02:58 | <zeshan> We apologize in advance for any inconvenience caused by this delay. |
| 14:03:13 | *** jkeiper has joined #openmrs |
| 14:03:13 | *** ChanServ sets mode: +v jkeiper |
| 14:03:35 | <r-friedman> zeshan, we love music on hold |
| 14:03:37 | <zeshan> We also apologize for Jeramy. |
| 14:03:55 | <zeshan> Michael was experimenting with the hold music. We had some metallica earlier. |
| 14:03:58 | *** pascal` has quit IRC |
| 14:05:04 | *** danielf` has quit IRC |
| 14:05:40 | <zeshan> Evidently Michael feels the need to be more professional now... |
| 14:05:46 | *** openmrs_web204 has joined #openmrs |
| 14:05:51 | *** openmrs_web204 is now known as jmiranda |
| 14:06:00 | *** ChanServ sets mode: +o jmiranda |
| 14:06:15 | <downeym> ...wha? |
| 14:06:44 | *** chopin has quit IRC |
| 14:07:23 | *** raffael has joined #openmrs |
| 14:08:09 | <downeym> We'll be starting in a few minutes (hopefully) |
| 14:08:16 | *** danielf` has joined #openmrs |
| 14:08:16 | *** ChanServ sets mode: +v danielf` |
| 14:08:36 | *** mrosas has quit IRC |
| 14:10:03 | *** openmrs_web931 has joined #openmrs |
| 14:10:24 | *** openmrs_web931 is now known as Ladyfa |
| 14:13:28 | *** gigasoft1 has joined #openmrs |
| 14:13:36 | *** openmrs_web566 has joined #openmrs |
| 14:13:46 | *** openmrs_web566 is now known as docpaul |
| 14:13:47 | *** djazayeri has joined #openmrs |
| 14:13:47 | *** ChanServ sets mode: +o djazayeri |
| 14:13:52 | <kennymac> yeah it's noisy |
| 14:13:59 | <judywawira> the call is breaking up.. |
| 14:14:11 | <judywawira> but darius is clear |
| 14:14:24 | *** rcrichton has joined #openmrs |
| 14:14:24 | *** ChanServ sets mode: +v rcrichton |
| 14:14:25 | *** burke has joined #openmrs |
| 14:14:25 | *** ChanServ sets mode: +o burke |
| 14:14:29 | *** nribeka has joined #openmrs |
| 14:14:29 | *** ChanServ sets mode: +v nribeka |
| 14:14:32 | *** ChanServ sets mode: +o docpaul |
| 14:14:43 | <docpaul> hi people. :) |
| 14:14:53 | <danielf`> hi docpaul |
| 14:14:54 | <docpaul> there is no pepper in my paprikash |
| 14:14:59 | <djazayeri> what's the url for connect? |
| 14:15:03 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12957]: logmanager: added support for file, rolling file and daily rolling file ⦠<http://dev.openmrs.org/changeset/12957> || OpenMRS Tickets: Ticket #463 (enhancement closed): Internationalization issue: Person relationships <http://dev.openmrs.org/ticket/463#comment:3> |
| 14:15:07 | <docpaul> but i would be proud to partake of your pecan pie |
| 14:15:20 | <danielf`> djazayeri, http://connect.openmrs.org/ i think |
| 14:17:53 | <djazayeri> The 'manage addresses' should really go under "my profile" |
| 14:19:28 | *** openmrs_web762 has joined #openmrs |
| 14:19:44 | *** openmrs_web762 is now known as judy |
| 14:19:58 | *** judy is now known as judygichoya |
| 14:20:52 | *** judywawira has quit IRC |
| 14:21:56 | *** Ladyfa has quit IRC |
| 14:24:39 | <Suneeth> hi jmiranda |
| 14:24:53 | *** openmrs_web697 has joined #openmrs |
| 14:27:01 | *** Mkop has quit IRC |
| 14:27:08 | *** openmrs_web697 is now known as Ladyfa |
| 14:27:33 | *** Mkop has joined #openmrs |
| 14:27:33 | *** ChanServ sets mode: +v Mkop |
| 14:29:21 | *** ruwan_home has joined #openmrs |
| 14:29:59 | *** openmrs_web540 has joined #openmrs |
| 14:30:11 | *** Zabil has quit IRC |
| 14:30:13 | *** docpaul has quit IRC |
| 14:30:23 | <Mkop> <docpaul> there is no pepper in my paprikash <-- what's that supposed to mean? |
| 14:30:43 | <Mkop> or is it a "you have to be on the call to understand the joke" kind of thing? |
| 14:33:54 | <downeym> theres no lexicon for docpaul |
| 14:34:30 | <downeym> except perhaps /dev/random |
| 14:35:07 | *** docpaul has joined #openmrs |
| 14:35:07 | *** ChanServ sets mode: +o docpaul |
| 14:35:14 | *** wyclif has joined #openmrs |
| 14:35:15 | *** wyclif has quit IRC |
| 14:35:23 | <docpaul> haha, Mkop: http://www.youtube.com/watch?v=E6CtAauWe1U |
| 14:37:03 | *** wyclif has joined #openmrs |
| 14:37:08 | <wyclif> hey |
| 14:37:58 | <downeym> wyclif: register your nick :) |
| 14:38:19 | <downeym> !refer wyclif http://freenode.net/faq.shtml#registering |
| 14:38:19 | * OpenMRSBot refers wyclif to http://freenode.net/faq.shtml#registering |
| 14:39:07 | <danielf`> djazayeri, you can add me to the volunteers list |
| 14:39:47 | <wyclif> Type /msg OpenMRSBot !help |
| 14:40:02 | <wyclif> Type /msg |
| 14:40:09 | <djazayeri> http://openmrs.org/wiki/OpenMRS_2.0_User_Interface_Redesign |
| 14:40:12 | <OpenMRSBot> <http://ln-s.net/5iaB> (at openmrs.org) |
| 14:40:18 | <danielf`> http://openmrs.org/wiki/OpenMRS_2.0_UI_Framework |
| 14:40:19 | <OpenMRSBot> <http://ln-s.net/5iaC> (at openmrs.org) |
| 14:44:25 | *** Mkop has quit IRC |
| 14:45:56 | *** Zabil has joined #openmrs |
| 14:45:58 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2218 (defect closed): HTMLFormEntry: "Preview Form From File" doesn't handle international characters properly <http://dev.openmrs.org/ticket/2218#comment:1> || OpenMRS Tickets: Ticket #762 (enhancement closed): newPatientFormController should be based on Patient object <http://dev.openmrs.org/ticket/762#comment:3> || OpenMRS Changesets: Changeset [12959]: htmlformentry: updated version number to 1.6.3 <http://dev.openmrs.org/changeset/12959> || OpenMRS Changesets: Changeset [12958]: htmlformentry: fixed Preview HTML Forms From File so that it is overrides ⦠<http://dev.openmrs.org/changeset/12958> |
| 14:47:05 | *** firc has joined #openmrs |
| 14:47:34 | *** raffael has left #openmrs |
| 14:47:39 | *** raffael has joined #openmrs |
| 14:47:46 | *** pascal` has joined #openmrs |
| 14:47:52 | *** ChanServ sets mode: +v pascal` |
| 14:48:01 | <pascal`> hi |
| 14:48:28 | *** raffael has left #openmrs |
| 14:49:45 | *** raffael has joined #openmrs |
| 14:51:17 | *** raffael has left #openmrs |
| 14:51:45 | *** raffael has joined #openmrs |
| 14:52:23 | *** raffael has left #openmrs |
| 14:52:47 | *** raffael has joined #openmrs |
| 14:54:34 | *** raffael has left #openmrs |
| 14:54:55 | *** raffael has joined #openmrs |
| 14:55:02 | *** ChanServ sets mode: +v wyclif |
| 14:55:26 | <saimanohar> hi pascal |
| 14:57:17 | *** ChanServ sets mode: +v r-friedman |
| 15:00:18 | *** raffael has left #openmrs |
| 15:00:23 | *** raffael has joined #openmrs |
| 15:02:31 | *** Mkop has joined #openmrs |
| 15:02:31 | *** ChanServ sets mode: +v Mkop |
| 15:04:06 | *** nribeka has quit IRC |
| 15:04:10 | *** rcrichton_ has joined #openmrs |
| 15:04:10 | *** ChanServ sets mode: +v rcrichton_ |
| 15:05:08 | *** judygichoya has quit IRC |
| 15:05:18 | <saimanohar> pascal: just to inquire, has the project Genome Data Storage and Drug Resistance Prediction been slotted in gsoc? |
| 15:06:12 | *** rcrichton has quit IRC |
| 15:06:54 | *** raffael has left #openmrs |
| 15:07:01 | *** raffael has joined #openmrs |
| 15:10:52 | *** saimanohar has quit IRC |
| 15:10:53 | *** raffael has left #openmrs |
| 15:10:58 | *** raffael has joined #openmrs |
| 15:10:59 | *** Suneeth has quit IRC |
| 15:13:33 | <pascal`> nribeka++ |
| 15:13:41 | *** raffael has left #openmrs |
| 15:14:47 | *** openmrs_web648 has joined #openmrs |
| 15:15:20 | <Echidna> heh |
| 15:15:30 | *** maveriick has quit IRC |
| 15:15:30 | <Echidna> a lot of people in here |
| 15:17:05 | <bwolfe> they're all here for you Echidna |
| 15:17:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12961]: htmlformentry-1.5.x: fixed submission bug in Time Widget; bumped up ⦠<http://dev.openmrs.org/changeset/12961> || OpenMRS Changesets: Changeset [12960]: logmanager: added save button to tools page and replaced auto-save option ⦠<http://dev.openmrs.org/changeset/12960> || OpenMRS Modules: HTML Form Entry 1.5.4 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.5.4> || OpenMRS Modules: HTML Form Entry 1.6.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.6.3> |
| 15:18:12 | *** openmrs_web540 has quit IRC |
| 15:18:30 | *** Zabil has quit IRC |
| 15:18:44 | *** nribeka has joined #openmrs |
| 15:18:44 | *** ChanServ sets mode: +v nribeka |
| 15:19:26 | <r-friedman> djazayeri: how did yesterday go? |
| 15:20:04 | *** firzhan has quit IRC |
| 15:20:15 | <djazayeri> r-friedman: relatively brief discussion |
| 15:20:18 | *** danielf` has quit IRC |
| 15:20:34 | <Echidna> bwolfe: i knew this day would come eventually, i must flee |
| 15:20:35 | <r-friedman> djazayeri: any notes? |
| 15:21:44 | <r-friedman> how is hibernate helping us outside of smoothing out the use of a variety of DB products? |
| 15:22:11 | <djazayeri> we decided that the important first step is to see what the performance implication is of not changing anything, but telling callers of LogicService how to properly do multiple evals in a single transaction |
| 15:22:28 | <djazayeri> and if that solves the performance issue, then we don't change anything |
| 15:22:50 | <djazayeri> re hibernate: saves us from writing sql in various places |
| 15:23:21 | <r-friedman> lets you write HQL instead? |
| 15:23:39 | <nribeka> i'm writing some rule for djazayeri to test out the performance |
| 15:23:55 | <djazayeri> lets you write HQL or do "criteria queries" |
| 15:24:09 | <djazayeri> but also creating/saving/deleting objects is a one-liner |
| 15:24:41 | <r-friedman> does it help manage DB changes? |
| 15:24:49 | <djazayeri> not really |
| 15:24:55 | <djazayeri> changes from mysql to postgres: yes |
| 15:25:02 | <djazayeri> updates to the data model: no |
| 15:25:08 | <r-friedman> right |
| 15:25:40 | <nribeka> nosql ftw |
| 15:26:17 | <r-friedman> does it help with cache management? |
| 15:27:01 | *** Mkop has quit IRC |
| 15:28:33 | <r-friedman> last week there was an example where the DB object was copied to a new object to be mucked over by the interface |
| 15:28:48 | <r-friedman> we don't ever expose the hibernate object, do we? |
| 15:30:51 | *** rcrichton_ has quit IRC |
| 15:32:10 | <bwolfe> r-friedman: kind of. the object hibernate returns is a subclass of our main Patient/User/Obs/Encounter objects. |
| 15:32:32 | <bwolfe> typically that hibernate object is what is returned through the api, but the api thinks its getting a normal Patient/User/Obs/Encounter object |
| 15:33:02 | <nribeka> we need to code to a good infrastructure then bwolfe |
| 15:33:12 | <nribeka> that's totally not a laptop scale of data |
| 15:33:40 | <nribeka> so where is that infrastructure going to be? |
| 15:33:46 | <bwolfe> your laptop |
| 15:34:08 | <nribeka> dev becomes really slow (significantly slow than the kenya server) |
| 15:34:25 | <bwolfe> yeah |
| 15:34:54 | <nribeka> so the question is: is openmrs going to something like amazon s3 :P |
| 15:35:08 | <nribeka> going to have |
| 15:35:18 | <bwolfe> s3 is just a storage engine |
| 15:35:25 | <bwolfe> its a database essentially |
| 15:35:30 | *** jfloppy has joined #openmrs |
| 15:35:31 | <bwolfe> you can read/write to it via web services |
| 15:35:36 | <jfloppy> hi :) |
| 15:35:53 | <bwolfe> nribeka: you're thinking of amazon ec2 cloud servers |
| 15:35:59 | <nribeka> ooo :p |
| 15:36:12 | <nribeka> hi jfloppy |
| 15:36:15 | <bwolfe> downeym is working on putting demo on ec2 |
| 15:36:19 | <jfloppy> hi nribeka :) |
| 15:36:23 | <nribeka> aha ... nice bwolfe |
| 15:36:33 | <downeym> so ec2 is expensive |
| 15:36:38 | <downeym> more than verio |
| 15:36:46 | <bwolfe> wow, really? |
| 15:36:51 | <zeshan> its expensive if you need a persistent machine |
| 15:36:51 | <downeym> at least for something like demo that we want to run 24x7 |
| 15:36:53 | <nribeka> i'm definitely not going to load 2m patient in my lappie. poor lappie |
| 15:36:54 | <bwolfe> once you factor in how much we use it? |
| 15:37:01 | <zeshan> it's really cheap if you have a short term need |
| 15:37:05 | <downeym> what zeshan said |
| 15:37:17 | <r-friedman> bwolfe: so if you modify an object you get from the api, but don't yet write it back through the api, aren't hibernate activities going on behind the scene? |
| 15:38:02 | <bwolfe> r-friedman: yeah, theres a little feature where if you save any object back then any loaded (and modified) object is also saved |
| 15:38:06 | <bwolfe> "feature" |
| 15:40:01 | <nribeka> ah my poor lappie is survive ... |
| 15:40:37 | <r-friedman> bwolfe: seems like we are trying to micromanage hibernate |
| 15:41:14 | <r-friedman> bwolfe: should we let it know our object model and deal with it, make the api a facade? |
| 15:41:24 | *** gurbuz has quit IRC |
| 15:42:02 | <bwolfe> r-friedman: yeah, but that would take a lot of work (translating off of hbm objects onto api objects, then off of api and onto hbm to save) |
| 15:42:39 | <downeym> http://uits.iu.edu/page/amee |
| 15:44:41 | *** nribeka has quit IRC |
| 15:45:16 | <pascal`> downeym, yeah, this week's agenda wasn't that great |
| 15:45:36 | <r-friedman> meeting extended to consume the time |
| 15:45:41 | *** gurbuz has joined #openmrs |
| 15:46:42 | <downeym> agenda-- |
| 15:47:21 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12962]: * dump was missing some information like autoincrement, indexes, ⦠<http://dev.openmrs.org/changeset/12962> |
| 15:49:03 | <pascal`> downeym, I can hear |
| 15:49:22 | <umashanthi> downeym: yes, I can hear |
| 15:49:29 | <downeym> thanks :D |
| 15:50:27 | <umashanthi> today there wasn't any delay during the demo :) |
| 15:51:22 | <r-friedman> bwolfe: but how much time is hibernate taking with its background activities |
| 15:51:27 | *** docpaul has quit IRC |
| 15:51:46 | <bwolfe> r-friedman: over 9000 |
| 15:51:46 | <r-friedman> bwolfe: if its objects are untouched until save, then it won't be caching and writing |
| 15:52:14 | *** zeshan has quit IRC |
| 15:52:17 | *** luzhuangwei has quit IRC |
| 15:52:23 | <bwolfe> the caching is done at object load time |
| 15:52:54 | *** Flusher has left #openmrs |
| 15:53:33 | <r-friedman> bwolfe: right, but if the api gets a new object to write back, then why do we need hibernate updating the cached version? |
| 15:54:01 | <r-friedman> bwolfe: not quite what i meant |
| 15:54:07 | *** umashanthi has left #openmrs |
| 15:54:52 | <bwolfe> we don't |
| 15:55:28 | <r-friedman> if i get an encounter and edit it, hibernate is maintaining the cache, but then I go to save the encounter, is the same underlying hibernate object used? |
| 15:55:33 | *** jkeiper has quit IRC |
| 15:56:31 | *** ekrub has joined #openmrs |
| 15:56:31 | *** ChanServ sets mode: +o ekrub |
| 15:56:49 | <r-friedman> ekrub: thor to the fore |
| 15:57:34 | *** burke_away has joined #openmrs |
| 15:57:34 | *** ChanServ sets mode: +o burke_away |
| 15:57:41 | *** burke_away has quit IRC |
| 15:58:28 | *** firc has quit IRC |
| 15:58:55 | *** burke has quit IRC |
| 16:00:48 | *** r-friedman has quit IRC |
| 16:01:01 | *** ekrub has quit IRC |
| 16:02:51 | *** gurbuz has quit IRC |
| 16:15:43 | *** firc has joined #openmrs |
| 16:17:31 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2243 (enhancement created): Focused OpenMRS optimizations <http://dev.openmrs.org/ticket/2243> |
| 16:18:20 | *** ruwan_home_ has joined #openmrs |
| 16:19:10 | *** ruwan_home_ has quit IRC |
| 16:19:24 | *** ruwan_home_ has joined #openmrs |
| 16:20:37 | *** ruwan_home has quit IRC |
| 16:20:37 | *** ruwan_home_ is now known as ruwan_home |
| 16:26:42 | *** ruwan_home has quit IRC |
| 16:28:52 | *** Ladyfa has quit IRC |
| 16:29:18 | *** openmrs_web740 has joined #openmrs |
| 16:30:04 | *** openmrs_web740 has quit IRC |
| 16:38:28 | *** openmrs_web648 has quit IRC |
| 16:42:02 | *** gigasoft1 has quit IRC |
| 16:47:39 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12963]: htmlformentry: tweak to htmlformfromcontroller; no functional changes <http://dev.openmrs.org/changeset/12963> || OpenMRS Tickets: Ticket #2244 (defect created): OpenMrsUtils.getFileAsString() should specify UTF-8 as default <http://dev.openmrs.org/ticket/2244> |
| 17:01:51 | *** openmrs_web156 has joined #openmrs |
| 17:02:01 | *** openmrs_web156 is now known as firzhan |
| 17:07:39 | *** chopin has joined #openmrs |
| 17:07:39 | *** ChanServ sets mode: +v chopin |
| 17:10:25 | *** nribeka has joined #openmrs |
| 17:10:25 | *** ChanServ sets mode: +v nribeka |
| 17:14:00 | *** Mkop has joined #openmrs |
| 17:14:00 | *** ChanServ sets mode: +v Mkop |
| 17:17:47 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12964]: logmanager: added validation check for file path field of file appenders ⦠<http://dev.openmrs.org/changeset/12964> |
| 17:25:16 | *** mathiaslin has quit IRC |
| 17:32:55 | *** batkinson has joined #openmrs |
| 17:49:56 | *** firc has quit IRC |
| 17:51:09 | *** downeym has quit IRC |
| 17:54:56 | <firzhan> djazayeri: hi |
| 17:56:03 | <djazayeri> hi firzhan |
| 17:56:21 | <firzhan> djazayeri: This is about the ticket 2241 |
| 17:56:38 | <djazayeri> Yes? What's up? |
| 17:56:41 | <firzhan> i think currently we cant check only the date |
| 17:56:52 | <firzhan> bcoz of tht backwarads compatabilty |
| 17:56:55 | <firzhan> issue |
| 17:57:04 | *** Shazin has quit IRC |
| 17:57:05 | <djazayeri> Yes. |
| 17:57:16 | <djazayeri> You are right, the isDate() method cannot change its behavior |
| 17:57:45 | <djazayeri> I meant that we want to add another method (maybe "isDateOnly()") that checks for just Date. |
| 17:57:50 | <firzhan> djazayeri: So we have to check something on the object |
| 17:57:56 | <firzhan> thtz calling this method |
| 17:58:28 | <firzhan> yeah |
| 17:58:31 | <firzhan> u r correct |
| 17:58:34 | <firzhan> i got it |
| 17:58:40 | <djazayeri> sorry if I wasn't clar. |
| 17:58:41 | <djazayeri> clear |
| 17:58:47 | <firzhan> isDateOnly() |
| 17:58:51 | <firzhan> clear |
| 17:58:59 | <firzhan> sorry |
| 18:04:39 | <bwolfe> code review in 25 mins. http://openmrs.org/wiki/2010-04-15_Code_Review |
| 18:05:02 | *** docpaul has joined #openmrs |
| 18:05:02 | *** ChanServ sets mode: +o docpaul |
| 18:16:46 | *** openmrs_web809 has joined #openmrs |
| 18:17:47 | *** openmrs_web809 has quit IRC |
| 18:20:02 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2245 (task created): Refactor openmrs:format tag to consistently handle OpenmrsMetadata <http://dev.openmrs.org/ticket/2245> |
| 18:25:43 | *** r0bby_ is now known as robbyoconnor |
| 18:27:55 | *** Zabil has joined #openmrs |
| 18:32:27 | *** Zabil has quit IRC |
| 18:39:56 | *** docpaul_ has joined #openmrs |
| 18:39:56 | *** ChanServ sets mode: +o docpaul_ |
| 18:43:39 | *** docpaul has quit IRC |
| 18:43:40 | *** docpaul_ is now known as docpaul |
| 18:50:09 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12965]: logmanager: moved all configuration functions into service layer <http://dev.openmrs.org/changeset/12965> |
| 18:59:33 | *** astelmashenko has joined #openmrs |
| 19:08:30 | *** wyclif is now known as Guest63718 |
| 19:09:42 | *** firzhan has quit IRC |
| 19:16:26 | *** MalteF has joined #openmrs |
| 19:20:18 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12966]: chica_scorable_jit branch * added some inserts to chica_error_category ⦠<http://dev.openmrs.org/changeset/12966> |
| 19:50:14 | <robbyoconnor> oh my docpaul! |
| 19:50:15 | <robbyoconnor> :) |
| 19:50:37 | <docpaul> :) |
| 19:53:33 | *** gigasoft1 has joined #openmrs |
| 20:04:40 | *** batkinson has quit IRC |
| 20:19:03 | *** batkinson has joined #openmrs |
| 20:19:49 | *** Mkop has quit IRC |
| 20:21:07 | *** docpaul has quit IRC |
| 20:25:06 | *** MalteF has quit IRC |
| 20:27:25 | *** batkinson has quit IRC |
| 20:28:01 | *** batkinson has joined #openmrs |
| 20:28:52 | *** batkinson has quit IRC |
| 20:29:25 | *** batkinson has joined #openmrs |
| 20:33:01 | *** batkinson has quit IRC |
| 20:36:01 | *** chopin has quit IRC |
| 20:36:28 | *** batkinson has joined #openmrs |
| 20:41:08 | *** downeym has joined #openmrs |
| 20:41:08 | *** ChanServ sets mode: +o downeym |
| 20:41:36 | <downeym> hello world |
| 20:48:40 | <bwolfe> hello non-world-traveller |
| 20:49:12 | <bwolfe> downeym: were you flying delta? |
| 20:49:15 | <downeym> !beerme |
| 20:49:15 | <OpenMRSBot> downeym: (beerme <an alias, 1 argument>) -- Alias for "action slides $1 a pint". |
| 20:49:23 | <downeym> bwolfe: yeah |
| 20:49:25 | <bwolfe> downeym: you should've asked to be put on the Washington DC --> NBO flight |
| 20:49:34 | * bwolfe (isn't sure they actually still have that) |
| 20:49:45 | <downeym> nope |
| 20:50:02 | <downeym> i had them check for alternates like that :D |
| 20:50:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [12967]: chica_scorable_jit * display a message on the grease board indicating ⦠<http://dev.openmrs.org/changeset/12967> || Burke Mamlin: Improving OpenMRS Code Review <http://blog.burkeware.com/archives/118> |
| 20:53:50 | <bwolfe> downeym: that sucks |
| 20:54:05 | <bwolfe> now you'll probably get stuck with an extra crappy seat too :-( |
| 20:54:11 | <downeym> actually i got a better seat ;) |
| 20:54:51 | <downeym> bwolfe: FYI we are going with at least one VM from IU instead of EC2 or waiting on OSU (at least for now) |
| 20:55:32 | <bwolfe> downeym: yeah, burke broke that news. sounds fine with me |
| 20:55:41 | <bwolfe> are you going to get that set up before you go?! :-D :-D |
| 20:55:54 | <downeym> hahah maybe at this rate |
| 20:56:14 | <downeym> regardless i'll work on it while i'm out |
| 20:57:16 | <downeym> Guest63718 = wyclif ? |
| 20:58:25 | <bwolfe> downeym: does modules.openmrs.org need bounced? |
| 20:58:55 | <downeym> hmmm |
| 20:59:17 | <downeym> 42 session |
| 20:59:41 | <downeym> org.apache.tomcat.dbcp.dbcp.SQLNestedException: Cannot get a connection, pool error Timeout waiting for idle object |
| 21:07:17 | *** Guest63718 has quit IRC |
| 21:10:36 | *** astelmashenko has left #openmrs |
| 21:11:45 | <downeym> bwolfe: i am going to turn down the frequency on the monitors, i think the monitoring may be spawning too many sessions before they expire |
| 21:12:06 | <bwolfe> downeym: ha, could be |
| 21:12:26 | <downeym> and in turn, hurting performance from time to time |
| 21:12:30 | <bwolfe> downeym: or it could be that people are doing lots of ajax searches in their 1.7 openmrs installations :-) |
| 21:12:36 | <downeym> could be ;-) |
| 21:13:17 | <downeym> but that is the known unknown, the monitors are the known knowns, so we at least know them and can do something about it. who knows what the unknown unknowns might be doing |
| 21:14:18 | <bwolfe> I fear the unknown unknowns |
| 21:16:29 | <downeym> how do you know? |
| 21:22:00 | *** nribeka has quit IRC |
| 21:22:10 | <bwolfe> I don't |
| 21:23:01 | * downeym knows nothing |
| 21:50:51 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2232 (task closed): AlertRecipient does not have uuid column <http://dev.openmrs.org/ticket/2232#comment:2> || OpenMRS Changesets: Changeset [12968]: Added uuid column to AlertRecipient - #2232 <http://dev.openmrs.org/changeset/12968> |
| 21:56:32 | *** downeym has quit IRC |
| 21:59:29 | *** jfloppy has quit IRC |
| 22:03:51 | *** bwolfe has quit IRC |
| 22:14:21 | *** r0bby|android has joined #openmrs |
| 22:14:21 | *** ChanServ sets mode: +v r0bby|android |
| 22:17:12 | <kennymac> djazayeri, i see you were at the code review, were you involved in reviewing #2189? |
| 22:17:42 | <djazayeri> kennymac: what ticket is 2189 again? |
| 22:18:01 | <djazayeri> yes, I can comment on that. |
| 22:18:37 | <kennymac> djazayeri, it is the one involving changing a PersonService method to be able to ignore retired records |
| 22:18:46 | <kennymac> ahh |
| 22:19:11 | <kennymac> yeah, sorry have been afk, should I have been at the review since I was working on that ticket? |
| 22:19:12 | <djazayeri> did someone send you notes about this? |
| 22:19:29 | <djazayeri> We made some comments, and there are to-dos, but they aren't mentioned in a ticket comment yet. |
| 22:19:30 | <kennymac> I am looking at the notes at http://openmrs.org/wiki/2010-04-15_Code_Review |
| 22:19:55 | <djazayeri> We're still working on the logistics of code reviews. |
| 22:20:14 | <kennymac> I am just not sure exactly how this should be implemented, I am aware of the options but not sure which one it is people are wanting |
| 22:20:15 | <djazayeri> It would have been good if you'd been there, but we didn't give you any sort of notification that we'd be looking at that ticket. |
| 22:20:22 | <djazayeri> I can explain: |
| 22:20:54 | <kennymac> ahh ok, i see... just checking if I was expected to be there or not |
| 22:20:57 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1686 (enhancement closed): Change Password Improvements <http://dev.openmrs.org/ticket/1686#comment:44> || OpenMRS Changesets: Changeset [12970]: Change Password Improvements - #1686 Author: aravindm, sneha <http://dev.openmrs.org/changeset/12970> || OpenMRS Changesets: Changeset [12969]: perufitnessstudy. added los olivos and san martin de porres to peru ⦠<http://dev.openmrs.org/changeset/12969> |
| 22:21:07 | <djazayeri> The OpenMRS convention is that service methods *should* return retired metadata, unless specifically excluded. |
| 22:22:06 | <djazayeri> So the correct solution (which you didn't have any way of knowing) was to change the existing PersonService.getPersonAttributeType(~4 args) to have it return retired PersonAttributeTypes also |
| 22:22:31 | <djazayeri> Then the getPersonAttributeTypeByName method would just magically work, with minimally invasive changes. |
| 22:22:51 | <djazayeri> You added another service method which duplicated the existing one and added a boolean includeRetired. |
| 22:23:13 | <djazayeri> We decided that you didn't need to do that. |
| 22:23:51 | <kennymac> ok so PersonService.getPersonAttributeType(~4 args will remain to have 4 args and always return retired methods? |
| 22:23:56 | <djazayeri> Anyway, the point is that you can do this with many fewer lines of code, by just changing the behavior of an existing service method. |
| 22:23:56 | <djazayeri> yes |
| 22:24:10 | <djazayeri> it should be changed to return retired PersonAttributeTypes |
| 22:24:27 | <djazayeri> exactly |
| 22:25:21 | <kennymac> so i assume there are no developers relying on this opperating the way it does current, i.e. not returning retired methods? |
| 22:26:15 | <djazayeri> It is highly unlikely that anyone is relying on that. |
| 22:26:41 | <djazayeri> But we also decided that it's not okay to backport the fix to 1.5.4 or 1.6.2. |
| 22:27:01 | <djazayeri> If there are module developers relying on this (still unlikely) they should catch it during the 1.7-alpha/beta/RC process. |
| 22:28:00 | <kennymac> ahh i see, well it is good to clarify that, I don't think it would have been right for me to assume that this was the way to proceed without confirmation fromt he review, so cheers! |
| 22:28:59 | <kennymac> I will try to get patch up soon and just leave a comment that I spoke to you about it... |
| 22:32:04 | *** jmiranda has quit IRC |
| 22:43:37 | *** batkinson has quit IRC |
| 23:00:55 | *** downeym-mobile has joined #openmrs |
| 23:00:55 | *** downeym-mobile has quit IRC |
| 23:00:55 | *** downeym-mobile has joined #openmrs |
| 23:00:55 | *** ChanServ sets mode: +o downeym-mobile |
| 23:09:23 | *** r0bby|android has quit IRC |
| 23:09:28 | *** r0bby|android has joined #openmrs |
| 23:09:28 | *** ChanServ sets mode: +v r0bby|android |
| 23:13:15 | *** r0bby|android has quit IRC |
| 23:13:20 | *** r0bby|android has joined #openmrs |
| 23:13:20 | *** ChanServ sets mode: +v r0bby|android |
| 23:14:41 | *** r0bby|android has quit IRC |
| 23:21:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2240 (task closed): LocationTag has a 'tag' property that should be renamed to 'name' instead <http://dev.openmrs.org/ticket/2240#comment:9> || OpenMRS Changesets: Changeset [12971]: fixing #2240 - LocationTag has a 'tag' property that should be renamed to ⦠<http://dev.openmrs.org/changeset/12971> |
| 23:22:09 | <kennymac> djazayeri, changing the getPersonAttributeType method to return retired+non retired makes 2 unit tests fail that seem to rely on the previous behaviour, should I modify these unit tests to take into account the new behaviour? |
| 23:22:22 | <djazayeri> how do they fail? |
| 23:22:38 | <djazayeri> Were there retired PersonAttributeTypes in the standardTestDataset that they now return? |
| 23:22:45 | <djazayeri> if so, yes, you should change the tests. |
| 23:25:32 | <kennymac> djazayeri, they were not in the standardTestDataset they were in PersonServiceTest-createRetiredPersonAttributeType.xml, but yes they were retired PersonAttributeTypes |
| 23:25:42 | <djazayeri> okay, same idea. |
| 23:25:49 | <kennymac> yeah |
| 23:25:50 | <djazayeri> Yes, change the tests to expect retired PATs. |
| 23:26:04 | <kennymac> ok, np |
| 23:27:03 | *** Guest63718 has joined #openmrs |
| 23:28:34 | <Guest63718> hey |
| 23:28:47 | <djazayeri> hi Guest63718 . :-) |
| 23:28:56 | <Guest63718> this is wyclif |
| 23:29:02 | <Guest63718> lol |
| 23:29:48 | *** gigasoft1 has quit IRC |
| 23:29:55 | <Guest63718> changing back to my usual nick |
| 23:30:38 | *** Guest63718 has left #openmrs |
| 23:32:05 | *** Guest63718 has joined #openmrs |
| 23:33:19 | *** Guest63718 has quit IRC |
| 23:35:12 | <downeym-mobile> Wyclif hiding from us? :) |
| 23:35:35 | *** gigasoft1 has joined #openmrs |
| 23:36:34 | *** syhaas has left #openmrs |
| 23:40:32 | *** gigasoft1 has quit IRC |
| 23:48:23 | *** docpaul has joined #openmrs |
| 23:48:23 | *** ChanServ sets mode: +o docpaul |
| 23:51:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #2246 (task closed): users.uuid needs a not-null constraint <http://dev.openmrs.org/ticket/2246#comment:1> || OpenMRS Changesets: Changeset [12972]: fixing #2246: users.uuid needs a not-null constraint <http://dev.openmrs.org/changeset/12972> || OpenMRS Tickets: Ticket #2246 (task created): users.uuid needs a not-null constraint <http://dev.openmrs.org/ticket/2246> |
| 23:52:45 | *** Zabil has joined #openmrs |
| 23:54:00 | *** gigasoft1 has joined #openmrs |
| 23:55:02 | <robbyoconnor> !beerme dead people |
| 23:55:02 | * OpenMRSBot slides dead people a pint |
| 23:55:11 | <robbyoconnor> :) |
