00:01:03
|
*** Mkop has joined #openmrs
|
00:08:22
|
*** Mkop has quit IRC
|
00:11:35
|
*** Agnor has quit IRC
|
00:15:20
|
*** Mkop has joined #openmrs
|
00:28:30
|
*** Keelhaul has quit IRC
|
00:49:49
|
*** Mkop has quit IRC
|
01:19:00
|
*** Mkop has joined #openmrs
|
02:44:08
|
*** atomicturtle1 has joined #openmrs
|
03:35:34
|
*** upul has joined #openmrs
|
03:35:34
|
*** ChanServ sets mode: +v upul
|
03:37:48
|
<Mkop> jmiranda: you around?
|
03:38:58
|
<Mkop> upul: that's cool that you already have a working implementation :-)
|
03:42:49
|
<upul> Mkop: hope what it does is what is wanted
|
03:43:02
|
<Mkop> it sounds like it
|
03:43:11
|
<Mkop> though I'm not burke
|
04:00:29
|
<Mkop> yay, I'm finallly doing stuff for openmrs after a looong time
|
04:01:53
|
<Mkop> upul: question: I was thinking of working on
|
04:01:56
|
<Mkop> !ticket 151
|
04:01:56
|
<OpenMRSBot> Mkop: Ticket #151: http://dev.openmrs.org/ticket/151
|
04:03:28
|
<Mkop> why is WEB_INF/messages_en_GB.properties so small?
|
04:03:31
|
<Mkop> there's only like 10 lines
|
04:03:39
|
<Mkop> is that the only place with relevant messages?
|
04:04:31
|
<Mkop> oh, they're in messages.properties
|
04:04:41
|
<Mkop> nribeka: you around by chance?
|
04:04:50
|
<upul> Mkop: it fallback to messages.properties
|
04:05:15
|
<upul> if it cannot find the one in user locale's properties file
|
04:05:39
|
<nribeka> yes sir Mkop
|
04:05:51
|
<Mkop> nribeka: nevermind, upul came back
|
04:06:06
|
<nribeka> ooo ok ok
|
04:06:14
|
<nribeka> need to sleep
|
04:06:20
|
<nribeka> have fun guys ...
|
04:09:01
|
<Mkop> good night
|
04:12:38
|
<Mkop> provider.chw.id=Accompagnateur ID
|
04:12:38
|
<Mkop> provider.chw.names=Accompagnateur Full Name
|
04:12:59
|
<Mkop> that sounds french, does it really belong in messages.properties or messages_fr.properties?
|
04:13:14
|
<Mkop> i.e. is there an english translation for that?
|
04:14:15
|
<upul> Mkop: you should have the key in the messages.properties for everything, so that other locales can find them
|
04:14:41
|
<upul> may be it was written for spanish or some other language
|
04:14:55
|
<Mkop> I'm not suggesting removing the keys, I'm suggesting translating it back to english and having the french only appear in *_fr.properties
|
04:20:36
|
<upul> yes, it should be translated to english in the messages.properties
|
04:21:04
|
<upul> Mkop: one who developed the feature must have copied the original keys from the original language where the feature was used, may be
|
04:21:43
|
*** atomicturtle1 has quit IRC
|
04:22:47
|
<upul> Mkop: that's spanish i think, it's there in the es and it props files
|
04:23:14
|
<Mkop> no, it's french
|
04:23:43
|
<Mkop> web/WEB-INF/messages_es.properties:provider.chw.id=ID Acompañante
|
04:24:10
|
<upul> I see
|
04:24:11
|
<Mkop> I'm not finding that key anywhere in trunk though
|
04:24:39
|
<Mkop> oh, wait
|
04:25:53
|
<Mkop> hmm, I think it might have gotten removed with the reports stuff
|
04:26:23
|
<Mkop> do modules use the same messages.properties or a different one?
|
04:27:05
|
<upul> Mkop: they have there own properties files, but I probably think they can read these keys as well
|
04:27:21
|
<Mkop> I might write a script to check which of these messages are still used anywhere in core code and clean out messages that are no longer used
|
04:27:45
|
<upul> that's nice
|
04:29:07
|
*** upul has quit IRC
|
04:32:15
|
*** upul has joined #openmrs
|
04:32:16
|
*** ChanServ sets mode: +v upul
|
04:49:02
|
*** upul has quit IRC
|
04:59:49
|
*** upul has joined #openmrs
|
04:59:49
|
*** ChanServ sets mode: +v upul
|
05:36:34
|
<upul> Mkop: which language are going to write the script?
|
05:36:46
|
<Mkop> idk
|
05:36:56
|
<Mkop> either python or bash
|
05:37:11
|
<Mkop> bash = combination of grep and find, probably
|
05:37:23
|
<Mkop> that's prob what I'll do
|
05:37:40
|
<Mkop> though maybe a combination
|
05:37:49
|
<Mkop> use python to make a file with just the keys
|
05:38:07
|
<upul> Mkop: there are tools to find unused keys, see http://www.guh-software.de/jinto_en.html
|
05:39:24
|
<Mkop> ok, i'll take a look at that
|
05:40:53
|
<jmiranda> Mkop, i just got back to my computer
|
05:40:57
|
<jmiranda> heading to bed in a minute
|
05:41:01
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8907]: moduleID attribute is added to openmrs portlet tag in previewPage.jsp <http://dev.openmrs.org/changeset/8907> || OpenMRS Changesets: Changeset [8906]: value of success variable is changed <http://dev.openmrs.org/changeset/8906>
|
05:41:24
|
<jmiranda> Accompagnateur is french
|
05:41:43
|
<jmiranda> but it's used in our english locales (at least for PIH implementations)
|
05:42:09
|
<Mkop> why, just wondering?
|
05:42:32
|
<jmiranda> it's basically PIH vernacular for "community health workers"
|
05:42:53
|
<jmiranda> and it's used in FR or EN locales in our settings
|
05:42:56
|
<jmiranda> haiti, rwanda
|
05:43:32
|
<jmiranda> technically, it should be in the FR locale
|
05:43:49
|
<jmiranda> while community health worker is used in english
|
05:44:16
|
<jmiranda> but you should discuss that with darius if you really want to change it
|
05:44:23
|
<jmiranda> i'm pretty sure he would argue that it should stay
|
05:44:29
|
<Mkop> ok
|
05:44:50
|
<Mkop> I see no need to change it if there's a reason for the way it is
|
05:45:00
|
<jmiranda> just because of common it is in our clinics
|
05:45:19
|
<jmiranda> but it's worth bringing up
|
05:46:00
|
<Mkop> ok, I'll bring it up on the listserv later on
|
05:55:04
|
<jmiranda> Mkop, be diplomatic :) this might be a touchy subject
|
05:55:16
|
<Mkop> ok
|
05:55:17
|
<jmiranda> don't suggest that it's wrong
|
05:55:23
|
<jmiranda> just point out that you found it
|
05:55:35
|
<Mkop> I'll ask it as a question - "why is there french in messages. properties?"
|
05:56:22
|
<upul> Mkop: tell that jmiranda told you to ask it :-D
|
05:56:49
|
<Mkop> ".... because Justin said it's wrong and that whoever put it there is a moron"
|
05:56:51
|
<jmiranda> make it a statement :) "i was looking over the properties files and noticed some french in the default properties file"
|
05:56:55
|
<jmiranda> :)
|
05:56:59
|
<jmiranda> thanks upul
|
05:57:07
|
<upul> jmiranda: you are welcome
|
05:57:29
|
<jmiranda> i just know that some people will say that it definitely shouldn't be there
|
05:57:35
|
<jmiranda> and others will argue that it should be there
|
05:57:47
|
<jmiranda> and you'll start something that you weren't expecting to start :)
|
05:58:47
|
<Mkop> in any case, IIANM, that key belongs to reporting, which since got moved out of core
|
05:58:58
|
<Mkop> i.e. there are no references to that key anywhere in trunk
|
06:00:06
|
<Mkop> which leads me to the next question: (I can bring this up on the listserv also if you don't have an easy answer): is messages.properties only for core, or for modules as well? can we remove messages from there if core doesn't use them, or must we keep them there in case some module uses them?
|
06:01:46
|
<jmiranda> Mkop, modules should define their own properties
|
06:01:58
|
<jmiranda> with that said, they definitely use core properties
|
06:02:00
|
<Mkop> should, or actually do?
|
06:02:04
|
<jmiranda> so it's not safe to assume
|
06:02:31
|
<Mkop> so basically, once a key enters that file, it can never leave
|
06:02:52
|
<jmiranda> that's not a policy that has been set explicitly
|
06:03:00
|
<jmiranda> and i'm sure we can set up whatever policy we want
|
06:03:20
|
<jmiranda> we just need to let module developers know and give them a chance to upgrade
|
06:03:50
|
<jmiranda> for example, we could come up with a process to "deprecate" messages
|
06:03:58
|
<jmiranda> similar to our api
|
06:04:10
|
<jmiranda> bring it up
|
06:04:13
|
<Mkop> ok
|
06:04:19
|
<Mkop> will do
|
06:04:26
|
<jmiranda> that's definitely something we'd like to keep under control
|
06:04:36
|
<jmiranda> ok, i'm heading to bed guys
|
06:04:43
|
<jmiranda> have a good night/day
|
06:04:50
|
<upul> good night
|
06:06:33
|
<Mkop> good night justin
|
06:50:34
|
*** pascal` has joined #openmrs
|
07:24:29
|
*** Nzeyi has joined #openmrs
|
07:28:52
|
*** Nzeyi has quit IRC
|
08:07:43
|
<pascal`> hi upul, Mkop, r0bby, others
|
08:07:56
|
<Mkop> hi
|
08:08:01
|
<Mkop> I'm just going to sleep now actually
|
08:08:03
|
<Mkop> (as usual)
|
08:08:08
|
<upul> hi pascal`
|
08:08:15
|
<Mkop> I have class at 10:40 tomorrow morning
|
08:08:19
|
<Mkop> i.e. in 6.5 hours
|
08:08:26
|
<pascal`> Mkop, what class?
|
08:08:30
|
<Mkop> and I still need to sleep and do some other stuff before then
|
08:08:35
|
<Mkop> first day of the new semester
|
08:08:40
|
<pascal`> cool
|
08:08:40
|
<Mkop> macroeconomics
|
08:08:45
|
<pascal`> ic
|
08:09:18
|
<pascal`> i thought all the macroeconomics lecturers in the states would have been fired by now
|
08:09:19
|
<pascal`> =D
|
08:10:13
|
<Mkop> :-)
|
08:10:40
|
<Mkop> does SA have crimonology profs?
|
08:10:40
|
<pascal`> anyway, if its the first day, i'm sure it'll be fine if you're a bit tired
|
08:16:41
|
*** Mkop has quit IRC
|
08:23:45
|
*** upul has quit IRC
|
08:27:53
|
*** upul has joined #openmrs
|
08:27:53
|
*** ChanServ sets mode: +v upul
|
08:34:25
|
*** upul has quit IRC
|
09:06:29
|
*** upul has joined #openmrs
|
09:06:29
|
*** ChanServ sets mode: +v upul
|
09:57:49
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: How to detect when a module is being unloaded <http://forum.openmrs.org/viewtopic.php?f=8&t=470#p1721>
|
10:09:20
|
*** upul has quit IRC
|
10:10:49
|
*** xtian_ has joined #openmrs
|
10:11:06
|
<xtian_> hi
|
10:11:52
|
<xtian_> i just wanted to ask a simple question regarding the installation of openmrs..
|
10:12:38
|
<xtian_> well, ive successfully deployed it. but it seems that it cant create a runtime properties file
|
10:12:54
|
<xtian_> it cant make this file: C:\Application Data\OpenMRS\openmrs-runtime.properties
|
10:13:04
|
<xtian_> i think the problem is that I dont have a drive C
|
10:13:09
|
<xtian_> i have a drive E though
|
10:13:35
|
<xtian_> how do i manually configure openmrs so that it will make the file in drive E ?
|
10:13:56
|
<xtian_> that's the only question i have.
|
10:15:04
|
<pascal`> hi xtian_
|
10:15:44
|
<xtian_> hi pascal
|
10:15:48
|
<pascal`> take a look at http://openmrs.org/wiki/Overriding_OpenMRS_Default_Properties
|
10:15:49
|
<OpenMRSBot> <http://ln-s.net/1iOw> (at openmrs.org)
|
10:16:03
|
<pascal`> in fact, the wiki contains a bunch of useful information
|
10:16:11
|
<pascal`> it's always worth searching when you have a question :)
|
10:16:28
|
<xtian_> thanks ^^
|
10:17:10
|
<pascal`> any time
|
10:19:15
|
<xtian_> alright, now i just have to restart my pc. thanks again for the help
|
10:19:36
|
<pascal`> you shouldn't have to restart
|
10:22:16
|
*** xtian_ has quit IRC
|
11:01:53
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: OpenMRS is unable to create a runtime properties file <http://forum.openmrs.org/viewtopic.php?f=9&t=475#p1722>
|
11:59:29
|
*** bwolfe has joined #openmrs
|
11:59:29
|
*** ChanServ sets mode: +o bwolfe
|
12:01:33
|
<pascal`> hey bwolfe
|
12:02:38
|
<bwolfe> hi pascal`
|
12:05:57
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8908]: After removing un used imports <http://dev.openmrs.org/changeset/8908>
|
12:07:37
|
*** nribeka has quit IRC
|
12:13:25
|
<pascal`> bwolfe, am i correct in concluding that there isn't a way to get a module's scheduled task(s) inserted in to the scheduler_task_config automatically using xml config?
|
12:13:47
|
<pascal`> well, except maybe using the sqldiff file...
|
12:14:11
|
*** atomicturtle has joined #openmrs
|
12:21:53
|
*** atomicturtle has left #openmrs
|
12:26:09
|
*** pascal` has quit IRC
|
12:28:14
|
*** pascal` has joined #openmrs
|
12:29:34
|
*** bwolfe has quit IRC
|
12:35:49
|
*** bwolfe has joined #openmrs
|
12:35:49
|
*** ChanServ sets mode: +o bwolfe
|
12:37:31
|
*** nribeka has joined #openmrs
|
12:37:31
|
*** ChanServ sets mode: +v nribeka
|
12:37:38
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8910]: after removing un used imports <http://dev.openmrs.org/changeset/8910> || OpenMRS Changesets: Changeset [8909]: after adding log.info <http://dev.openmrs.org/changeset/8909>
|
12:52:21
|
*** nribeka has quit IRC
|
12:52:34
|
*** nribeka has joined #openmrs
|
12:52:34
|
*** ChanServ sets mode: +v nribeka
|
13:08:02
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: How to detect when a module is being unloaded <http://forum.openmrs.org/viewtopic.php?f=8&t=470#p1723>
|
13:13:18
|
*** upul has joined #openmrs
|
13:13:18
|
*** ChanServ sets mode: +v upul
|
13:29:04
|
*** sdefabbiakane has joined #openmrs
|
13:40:04
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: OpenMRS doesnt seem to run updates <http://forum.openmrs.org/viewtopic.php?f=9&t=472#p1724>
|
13:56:36
|
<pascal`> bwolfe, can you think of any reasons why it appears my scheduled task isn't running?
|
13:56:36
|
<pascal`> or ideas regarding how to go about debugging?
|
13:59:37
|
<bwolfe> pascal`: did you try to start it? :-P
|
14:05:33
|
<pascal`> jmiranda ^ ?
|
14:06:50
|
<jmiranda> hey pascal` i'd need a little more info
|
14:06:50
|
* pascal` wonders how to respond
|
14:06:50
|
<pascal`> yes
|
14:07:00
|
<jmiranda> are you seeing anything in the logs
|
14:07:24
|
<jmiranda> is this a task you wrote?
|
14:07:43
|
<pascal`> ok
|
14:07:46
|
<pascal`> seems like something is happening now, it's just hit the breakpoitn
|
14:09:06
|
<pascal`> yes, my own task
|
14:09:06
|
<pascal`> and btw, deleting and re-adding tasks doesn't seem to work nicely
|
14:09:09
|
<pascal`> ERROR - LazyInitializationException.<init>(19) |2009-07-06 16:08:13,472| could not initialize proxy - no Session
|
14:09:12
|
<pascal`> ok now i'm getting that, but I think I'm just doing it wrong
|
14:10:11
|
<pascal`> my task only started running after i restarted tomcat
|
14:10:17
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1616 (task created): Possible infinite recursion in RequiredDataHandler <http://dev.openmrs.org/ticket/1616> || OpenMRS Tickets: Ticket #1615 (task created): Add/Edit a Concept Rule <http://dev.openmrs.org/ticket/1615>
|
14:13:51
|
<pascal`> ok, so my new question is, is there something special that needs to be done in order to load and persist objects from a task?
|
14:13:51
|
<upul> jquery data tables are nice, only a single line and everything is there
|
14:19:04
|
<pascal`> upul, that does look cool
|
14:27:58
|
<pascal`> bwolfe, jmiranda, for a task, do I explicitly need to open and close a hibernate session, or what's the procedure?
|
14:28:51
|
<jmiranda> use Context.startSession()
|
14:29:01
|
<pascal`> ProcessHL7InQueueTask uses Context.openSession() and Context.closeSession() ... is that the recommended way of doing things?
|
14:29:03
|
<jmiranda> and Context.stopSession() inside your execute method
|
14:29:04
|
<jmiranda> pas
|
14:29:09
|
<jmiranda> pascal`, ^
|
14:30:12
|
<pascal`> it's weird because as I step through my task, it seems to get stuff from the db fine, but then at an arbitrary point (which I'm about to determine exactly), I get this lazy init exception... meh =\
|
14:31:38
|
<pascal`> yeah, i'd still like to understand what's happening though, because it seems I can retrieve data fine
|
14:32:14
|
<bwolfe> pascal`: if data is not getting persisted, its probably because your service is not @Transactional or it is @Transaction(readOnly=true).
|
14:33:22
|
<pascal`> I do use those annotations... but I'm getting this exception at a seemingly arbitrary place
|
14:33:37
|
<pascal`> i'm investigating... i'll let you know what i find...
|
14:34:21
|
<pascal`> crud, i dont have all the source attached
|
14:34:32
|
<pascal`> lets see what happens when i create sessions explictly
|
14:36:27
|
<pascal`> when you remove a module, tasks referencing classes in that module aren't removed. just fyi (=
|
14:38:20
|
<pascal`> cool! start/stopSession() seems to solve my problem
|
14:41:35
|
<bwolfe> pascal`: you mean garbage collected, or do you mean deleting the scheduled task?
|
14:41:43
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8912]: schedulerquartz: un-needed class <http://dev.openmrs.org/changeset/8912> || OpenMRS Tickets: Ticket #1617 (defect created): CGLibMapper should use OpenmrsClassLoader <http://dev.openmrs.org/ticket/1617> || OpenMRS Changesets: Changeset [8911]: dataintegrity: added the XML file uploading feature <http://dev.openmrs.org/changeset/8911>
|
14:42:09
|
<pascal`> i mean deleting the task
|
14:42:12
|
<pascal`> lets see...
|
14:43:01
|
<pascal`> hmm, it seems to be working now
|
14:43:08
|
<bwolfe> pascal`: thats by design. removing a module doesn't remove any of the underlying data. there is a ticket to add an "also delete all data related to this module checkbox" ticket
|
14:43:43
|
<pascal`> ok, cool
|
14:43:59
|
<pascal`> yeah, the adding and removing and stoping and starting of tasks seems to be working fine
|
14:44:22
|
<pascal`> i think when my task was bailing it was leaving the system in an inconsistent state which was messing things up
|
14:45:51
|
<pascal`> everything seems fine now
|
14:50:52
|
<pascal`> is there a way to force sync from repository with subclipse?
|
14:52:55
|
<sdefabbiakane> right click on project -> team -> synchronize with repository
|
14:53:00
|
<pascal`> yeah
|
14:53:14
|
<pascal`> but it looks like i still need to manually resolve conflicts
|
14:53:26
|
<sdefabbiakane> hm, not sure then
|
14:57:23
|
<bwolfe> pascal`: what do you mean by "sync with repository"? do you mean "take all the repository's changes and ignore mine to resolve the conflicts" ?
|
14:58:38
|
<pascal`> yeah
|
14:58:48
|
*** atomicturtle has joined #openmrs
|
14:59:03
|
<pascal`> basically force sync out the repo
|
14:59:10
|
<pascal`> overwriting everything on my machine
|
15:00:11
|
<pascal`> i think i've got it now tho, thanks
|
15:00:21
|
<pascal`> calling it a day, cheers ppl
|
15:00:23
|
*** pascal` has quit IRC
|
15:02:25
|
*** atomicturtle has left #openmrs
|
15:03:17
|
<bwolfe> just for future reference, there is a way to do this with svn on the command line: http://blog.eflow.org/archives/239
|
15:04:18
|
<upul> i was going to point the bwolfe's blog :-)
|
15:05:15
|
<bwolfe> upul: thanks! you must be one of my 2.5 loyal readers! ;-)
|
15:05:48
|
<upul> :-D lot better than mine
|
15:07:40
|
<jmiranda> bwolfe, i'm the .5
|
15:07:56
|
<bwolfe> I don't really like the openmrs feed. there are too many people that "read" my feed through that. so my feed stats say 7. :-/
|
15:08:20
|
<bwolfe> well crap, there must be something wrong with the wp feed stats plugin. now it says I only have 1 reader!
|
15:11:58
|
<bwolfe> thanks jmiranda :-)
|
15:12:16
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8913]: schedulerquartz: Javadoc comments added <http://dev.openmrs.org/changeset/8913>
|
15:24:16
|
<upul> openmrsservice onstartup onshutdown are not implemented yet. are they?
|
15:27:57
|
<bwolfe> upul: no, not yet
|
15:28:08
|
<bwolfe> upul: feel free to do it though. :-)
|
15:29:03
|
<upul> i hope it would be just taking the proxyfactory list and calling one by one
|
15:32:42
|
<bwolfe> yeah, thats probably it
|
15:32:55
|
<bwolfe> it will need to be done every time the spring context is refreshed
|
15:44:21
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: OpenMRS is unable to create a runtime properties file <http://forum.openmrs.org/viewtopic.php?f=9&t=475#p1725>
|
16:16:23
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8915]: schedulerquartz: Javadoc comments added <http://dev.openmrs.org/changeset/8915> || OpenMRS Changesets: Changeset [8914]: schedulerquartz: Javadoc comments added <http://dev.openmrs.org/changeset/8914>
|
16:16:44
|
*** sdefabbiakane has quit IRC
|
16:48:24
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8916]: Removed voided patients from results of ⦠<http://dev.openmrs.org/changeset/8916>
|
17:01:22
|
*** upul has quit IRC
|
17:01:34
|
*** Mkop has joined #openmrs
|
17:10:18
|
*** sdefabbiakane has joined #openmrs
|
17:20:26
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1533 (defect closed): PatientService.getPatientIdentifiers() returns voided patients <http://dev.openmrs.org/ticket/1533#comment:6> || OpenMRS Changesets: Changeset [8917]: 1.5.x: Removed voided patients from results of ⦠<http://dev.openmrs.org/changeset/8917>
|
17:32:45
|
<bwolfe> r0bby: looks like r0bby is getting a competitor "most commits in a single day"...
|
17:35:15
|
<Mkop> is this something new?
|
17:35:27
|
<Mkop> i.e. is he committing any more today than any other day?
|
17:36:08
|
<bwolfe> djmlog103 seems to be on a committing rampage todat
|
17:36:09
|
<bwolfe> *today
|
17:36:53
|
<Mkop> oh, he's getting a competitor
|
17:36:55
|
<Mkop> I didn't catch that
|
17:43:07
|
<Mkop> bwolfe: come on, the guy has 8 commits in 2 days. r0bby sometimes has that many commits in 15 minutes
|
17:43:33
|
<bwolfe> Mkop: very true...I guess it just feels like a lot
|
17:43:55
|
<Mkop> btw, I started doing some more stuff for you guys
|
17:44:08
|
<Mkop> doing some work on
|
17:44:10
|
<Mkop> !ticket 151
|
17:44:10
|
<OpenMRSBot> Mkop: Ticket #151: http://dev.openmrs.org/ticket/151
|
17:44:31
|
<bwolfe> Mkop: sweet!
|
17:44:48
|
<Mkop> the question is, how liberal should I be with editing?
|
17:44:49
|
<bwolfe> Mkop: can you claim the ticket so others don't step on your toes?
|
17:44:53
|
<Mkop> ok
|
17:45:37
|
<bwolfe> as in how many changes to messages?
|
17:46:27
|
<Mkop> as in, if a message is fine now, but imo it would be better if worded some other way
|
17:47:07
|
<bwolfe> go for it
|
17:47:45
|
<Mkop> ok
|
17:47:54
|
<Mkop> some other questions that I need to raise on the listserv:
|
17:48:03
|
<Mkop> 1) French stuff in messages.properties
|
17:48:28
|
<Mkop> justin says they use the french terms in en locale in PIH projects
|
17:48:50
|
<bwolfe> french terms? french messages you mean ?
|
17:48:53
|
<Mkop> 2) messages that no longer appear in core (i.e. they were removed to modules or otherwise deleted) - can we delete them?
|
17:48:58
|
<Mkop> Accompagnateur
|
17:49:01
|
<Mkop> (sp?)
|
17:50:46
|
<bwolfe> 1) thats fine...they use it in english, so its accurate
|
17:50:53
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8921]: schedulerquartz: -Quartz DB settings are loaded dynamically while module ⦠<http://dev.openmrs.org/changeset/8921> || OpenMRS Changesets: Changeset [8920]: schedulerquartz: JavaDoc deleted, assuming that the it will be generated ⦠<http://dev.openmrs.org/changeset/8920> || OpenMRS Changesets: Changeset [8919]: 1.5.x: Adding a call to refreshAuthenticatedUser in context tests to avoid ⦠<http://dev.openmrs.org/changeset/8919> || OpenMRS Changesets: Changeset [8918]: Adding a call to refreshAuthenticatedUser in context tests to avoid a lazy ⦠<http://dev.openmrs.org/changeset/8918>
|
17:52:29
|
<bwolfe> 2) I'm torn on this one
|
17:52:45
|
<bwolfe> 2) some modules might be depending on those messages...
|
17:53:00
|
<bwolfe> 2) but then again, a module doesn't "break" totally if the message isn't there...its just ugly
|
17:53:19
|
<bwolfe> Mkop: do you have a way to automatically find which messages aren't used anymore?
|
17:53:27
|
<Mkop> yes, it's called grep
|
17:54:00
|
<Mkop> i.e. I can write a script to grep trunk for each key
|
17:54:10
|
<bwolfe> I see...so you could write a script that iterates over the rows in that messages file and looks for that key in openmrs
|
17:54:14
|
<bwolfe> right
|
17:54:20
|
<bwolfe> good though ! ;-)
|
17:54:21
|
<Mkop> upul also gave me a link to this: http://www.guh-software.de/jinto_en.html
|
17:54:24
|
<bwolfe> though==thought
|
17:56:18
|
<bwolfe> Mkop: very cool. I looked a while back for an updated plugin like that...the only one I could find was 3 years old and had a few bugs
|
17:58:02
|
<Mkop> would we benefit at all by having a messages_il.properties file?
|
17:58:04
|
<Mkop> i.e. hebrew?
|
17:58:44
|
<Mkop> problem with hebrew is you kinda need right-to-left layout for it to work well
|
17:59:26
|
<bwolfe> not sure what you mean. what would it take to get right-to-left layout to work?
|
17:59:41
|
<bwolfe> horzontally reversing the page? :-)
|
17:59:58
|
<bwolfe> wonder if theres a jquery method for that... :-p
|
18:00:53
|
<Mkop> I don't know what's typically used by hebrew web developers
|
18:01:18
|
<Mkop> but look at, for example, http://www.google.co.il/
|
18:01:35
|
<Mkop> the text is all in hebrew, but things are also switched to the opposite sides
|
18:02:05
|
<bwolfe> yep, looks like its a horizontal switch
|
18:02:17
|
<bwolfe> even on the top bar...
|
18:02:21
|
<Mkop> yep
|
18:03:14
|
<Mkop> is there any motivation for openMRS to be translated to Hebrew? I mean, a country with standardized socialized medicine is probably unlikely to use us
|
18:04:13
|
<bwolfe> and how widely spoken is english?
|
18:04:54
|
<Mkop> pretty widely, but not universally
|
18:22:38
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8925]: more tests (primarily for voidRemark, one for unvoidRemark, perhaps a few ⦠<http://dev.openmrs.org/changeset/8925> || OpenMRS Forum: Re: How to detect when a module is being unloaded <http://forum.openmrs.org/viewtopic.php?f=8&t=470#p1728> || OpenMRS Forum: Re: How to detect when a module is being unloaded <http://forum.openmrs.org/viewtopic.php?f=8&t=470#p1727> || OpenMRS Tickets: Ticket #1523 (task closed): Upgrade XStream to the latest version <http://dev.openmrs.org/ticket/1523#comment:3> || OpenMRS Forum: Re: How to detect when a module is being unloaded <http://forum.openmrs.org/viewtopic.php?f=8&t=470#p1726> || OpenMRS Tickets: Ticket #1521 (task closed): Serialization fails for hibernate proxies <http://dev.openmrs.org/ticket/1521#comment:3> || OpenMRS Changesets: Changeset [8924]: 1.5.x: Followup fix to add cglib to the ant api compile classpath - #1521 <http://dev.openmrs.org/changeset/8924> || OpenMRS Changesets: Changeset [8923]: -- chica * changed weight processing rules on the PSF to read weight in ⦠<http://dev.openmrs.org/changeset/8923> || OpenMRS Changesets: Changeset [8922]: 1.5.x: Merged serialization changes to 1.5.x so that serialization of ⦠<http://dev.openmrs.org/changeset/8922>
|
18:54:41
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8926]: three more tests added for unvoidRemark service method Passes all tests ⦠<http://dev.openmrs.org/changeset/8926>
|
19:58:42
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8927]: subjectClass field refactored to subjectClassname (now stores String ⦠<http://dev.openmrs.org/changeset/8927>
|
20:01:31
|
*** Keelhaul has joined #openmrs
|
20:01:31
|
*** ChanServ sets mode: +v Keelhaul
|
20:30:44
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8928]: a couple more tests for getRemarkByObject, a small bugfix for the same <http://dev.openmrs.org/changeset/8928>
|
20:34:13
|
*** jacobb has quit IRC
|
20:36:38
|
*** jacobb has joined #openmrs
|
20:37:31
|
<Keelhaul> gah
|
20:37:33
|
<Keelhaul> those assholes
|
20:37:58
|
<Mkop> Keelhaul: what?
|
20:38:32
|
<Keelhaul> they changed the examination regulations in a way that my final grade is .2 points worse than expected
|
20:39:09
|
<Mkop> you're still taking coursework? I thought you'd be done by now
|
20:39:15
|
<Keelhaul> i am
|
20:39:22
|
<Keelhaul> my final thesis just got graded finally
|
20:39:31
|
<Keelhaul> so my final grade is known
|
20:39:44
|
<Mkop> oh, your thesis
|
20:39:47
|
<Keelhaul> but i expected a different calculation of it
|
20:40:07
|
<Keelhaul> basically, you used to require certain amounts of credit points in each block
|
20:40:10
|
<Keelhaul> usually around 30
|
20:40:20
|
<Keelhaul> with slightly over 50% of them being graded at least
|
20:40:37
|
<Keelhaul> those points comprise the block grade, and the blocks the final grade
|
20:40:55
|
<Keelhaul> they used to take the best graded CP you had and the rest went ungraded
|
20:41:08
|
<Keelhaul> now, whenever a class had a grade it goes into your block grade
|
20:41:22
|
<Keelhaul> unless you said you wanted to go ungraded prior to taking the exam
|
20:42:00
|
<Keelhaul> so i brought some leftover classes over from my bachelors which had shitty grades but lots of points to fill what i presumed to be ungraded mass
|
20:42:06
|
<Keelhaul> and now it's taking revenge on me
|
20:42:22
|
<Mkop> oh man
|
20:42:47
|
<Keelhaul> so now instaed of 1.9, i have a 2.1
|
20:42:51
|
<Keelhaul> with 1.0 being the best possible
|
20:43:12
|
<Mkop> oh
|
20:58:49
|
*** sdefabbiakane has quit IRC
|
21:02:49
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1618 (defect closed): PortletController Caches Parameters <http://dev.openmrs.org/ticket/1618#comment:1> || OpenMRS Changesets: Changeset [8930]: Added javadoc comment about the portletUUID <http://dev.openmrs.org/changeset/8930> || OpenMRS Changesets: Changeset [8929]: Removed the parameters from the cached model - #1618 <http://dev.openmrs.org/changeset/8929> || OpenMRS Tickets: Ticket #1618 (defect created): PortletController Caches Parameters <http://dev.openmrs.org/ticket/1618>
|
21:23:08
|
*** bwolfe has quit IRC
|
21:25:15
|
*** nribeka has quit IRC
|
22:06:49
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [8931]: reporting: Changes to build path properties * Removed extra openmrs jars ⦠<http://dev.openmrs.org/changeset/8931>
|
22:09:19
|
*** nribeka has joined #openmrs
|
22:09:19
|
*** ChanServ sets mode: +v nribeka
|
22:11:27
|
*** nribeka has quit IRC
|
22:11:50
|
*** nribeka has joined #openmrs
|
22:11:50
|
*** ChanServ sets mode: +v nribeka
|
22:11:56
|
*** nribeka has quit IRC
|
22:14:06
|
*** nribeka has joined #openmrs
|
22:14:06
|
*** ChanServ sets mode: +v nribeka
|
22:30:11
|
*** nribeka has quit IRC
|
22:58:57
|
*** nribeka has joined #openmrs
|
22:58:57
|
*** ChanServ sets mode: +v nribeka
|
23:14:46
|
*** Keelhaul has quit IRC
|