IRC Chat : 2009-05-18 - OpenMRS

00:35:47 *** bodobacs has quit IRC
00:44:39 *** nribeka has joined #openmrs
00:44:39 *** ChanServ sets mode: +v nribeka
00:47:05 *** nribeka1 has joined #openmrs
01:00:44 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7855]: groovy module: remove unused import <http://dev.openmrs.org/changeset/7855> || OpenMRS Changesets: Changeset [7854]: groovy module: this should satisfy #1500; additionally adding license … <http://dev.openmrs.org/changeset/7854>
01:04:30 <bwolfe> nribeka / Keelhaul : retired objects are supposed to be returned by default
01:04:44 <bwolfe> nribeka / Keelhaul : voided objects are not supposed to be returned by default
01:05:01 <Keelhaul> oh ic
01:05:04 <Keelhaul> then the test def is wrong
01:05:25 <Keelhaul> also
01:05:46 <Keelhaul> if retireReason is null or empty, something throws an IllegalArgumentException
01:05:50 <Keelhaul> some handler
01:05:57 <Keelhaul> so the test case cant be implemented
01:06:04 <Keelhaul> the test wants it to return null
01:06:13 *** nribeka has quit IRC
01:07:01 <Keelhaul> and finally, getLocationsHavingAllTags(new ArrayList<LocationTag>); returns all unretired locations
01:07:08 <Keelhaul> the test wants it to return an empty list though
01:07:12 <Keelhaul> which oen should it do
01:12:19 *** nribeka has joined #openmrs
01:12:19 *** ChanServ sets mode: +v nribeka
01:13:13 <nribeka> how about retired bwolfe?
01:13:26 <nribeka> should it be returned by default?
01:15:02 <bwolfe> Keelhaul: trust the code, not the @should at this point
01:15:11 <r0bby> i wonder if my mic is good
01:15:12 <r0bby> :)
01:15:24 <bwolfe> nribeka: what do you mean?
01:16:29 *** nribeka2 has joined #openmrs
01:16:40 <r0bby> OH NOES
01:17:28 <nribeka2> nvm bwolfe
01:17:39 *** ChanServ sets mode: +v nribeka2
01:17:50 *** nribeka has quit IRC
01:17:55 *** nribeka2 is now known as nribeka
01:25:28 <r0bby> ...why didn't the mail.jar problem bite me before this...
01:29:22 *** nribeka1 has quit IRC
01:32:49 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7856]: groovy module: this is needed for the groovyc task to succeed. <http://dev.openmrs.org/changeset/7856>
01:33:22 <bwolfe> because of the new spring annotation in applicationContext. it tries to load/loop over all classes referenced
01:36:00 <r0bby> was that to me
01:38:52 *** nribeka1 has joined #openmrs
01:40:51 <bwolfe> r0bby: yes
01:46:35 <r0bby> bwolfe: ah :)
01:46:43 <r0bby> this happened during compilation not runtime
01:46:48 <r0bby> the groovyc task
01:47:09 *** Mkop has joined #openmrs
01:47:21 <Mkop> Keelhaul: you here?
01:47:23 <r0bby> wtf
01:47:32 <r0bby> firefox crashed *TWICE*
01:47:53 <Keelhaul> sort of
01:47:53 <Keelhaul> why
01:48:19 <r0bby> perfect!!!
01:48:20 <r0bby> :D
01:48:22 <r0bby> YES!!!
01:49:29 <Mkop> Keelhaul: I saw your invitation on facebook
01:49:32 <Mkop> what are you thinking?
01:49:34 <Mkop> to a group
01:49:40 <Keelhaul> rofl
01:49:42 <Mkop> Good People of the World Against Religious Insanity
01:49:51 <Mkop> I have nothing wrong with you joining
01:49:56 <Mkop> you're entitled to your opinion
01:50:04 <Mkop> but did you _really_ think *I* would join?
01:50:30 <Keelhaul> well
01:50:35 <Keelhaul> would you call what oyu do "insanity"?
01:50:44 <Mkop> no
01:50:48 <Mkop> but the group clearly does
01:50:59 <Mkop> Positions: 1. Be a good person instead of religious. 2. Help religious people to see the light of reason and sanity. 3. Embrace the truth instead of deceit and lies of religions
01:51:36 <Keelhaul> it's a cause, not a group
01:51:39 <r0bby> GOD IT :d
01:51:47 <r0bby> this is neat :)
01:51:48 *** nribeka has quit IRC
01:52:01 <Mkop> oh, so I wouldn't join a group, but I should support a cause that's antithetical to what I believe?
01:52:35 <Keelhaul> i think i auto sent invitations to everyone on my list
01:52:43 <Mkop> oh
01:52:44 <Mkop> ok
01:52:47 <Mkop> find
01:52:48 <Mkop> fine*
01:52:54 <Mkop> so should I still be offended?
01:52:56 <Keelhaul> but you receiving it makes me giggle, actually
01:52:57 <Mkop> :-P
01:52:59 <Keelhaul> so maybe =P
01:53:15 <Mkop> fine
01:53:41 <Mkop> so I'll be offended, and then you can be offended that I rejected your invite, deal?
01:53:44 <r0bby> got it*
01:53:47 <Keelhaul> fine =P
01:53:59 <r0bby> Mkop: I kinda hate organized religion :)
01:54:31 *** nribeka has joined #openmrs
01:54:31 *** ChanServ sets mode: +v nribeka
01:54:45 <Mkop> r0bby: you think I don't know that?
01:59:27 *** jmiranda has joined #openmrs
01:59:27 *** ChanServ sets mode: +o jmiranda
01:59:35 <r0bby> yeh :)
01:59:48 <r0bby> feels nice being able to close ticket :)
02:00:00 *** nribeka2 has joined #openmrs
02:00:03 *** nribeka1 has quit IRC
02:00:27 *** ChanServ sets mode: +v nribeka2
02:00:38 *** nribeka has quit IRC
02:00:43 *** nribeka2 is now known as nribeka
02:01:12 <nribeka> bwolfe, are you there?
02:01:18 <nribeka> i don't think this is correct
02:01:19 <nribeka> http://pastebin.com/d44ca598d
02:01:23 <nribeka> should i fix it?
02:02:15 <Keelhaul> heh
02:02:21 <Keelhaul> the format criterion?
02:02:30 <Keelhaul> used instead of searchable
02:03:26 <bwolfe> yep, you can fix it
02:03:34 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7859]: groovy module: switch the name of the privilege for executing groovy … <http://dev.openmrs.org/changeset/7859> || OpenMRS Changesets: Changeset [7858]: groovy module: switch the name of the privilege for executing groovy … <http://dev.openmrs.org/changeset/7858> || OpenMRS Tickets: Ticket #1500 (defect closed): Groovy evaluation should require Run Groovy Scripts privilege <http://dev.openmrs.org/ticket/1500#comment:6> || OpenMRS Changesets: Changeset [7857]: groovy module: #1500 fix. <http://dev.openmrs.org/changeset/7857>
02:03:54 <nribeka> yes Keelhaul
02:15:29 *** Mkop has quit IRC
02:31:34 *** upul has joined #openmrs
02:31:34 *** ChanServ sets mode: +v upul
02:34:56 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7860]: testathon: LocationServiceTest implementation <http://dev.openmrs.org/changeset/7860>
03:01:44 *** bwolfe has quit IRC
03:06:58 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7861]: testathon: Added a few more implementations to UserServiceTest <http://dev.openmrs.org/changeset/7861>
03:10:35 <r0bby> it should show who commited what :)
03:10:48 <r0bby> I should get my labs login working
03:10:55 <r0bby> i'll do that tommorrow :/
03:23:05 *** vanmh has joined #openmrs
03:55:10 <Keelhaul> http://imgur.com/nb3e3.png
03:55:54 <nribeka> lol Keelhaul
03:55:57 <nribeka> jmiranda:
03:59:46 <jmiranda> nribeka,
04:00:58 <upul> Keelhaul: are there any more sequels?
04:01:35 <jmiranda> rocky iv?
04:01:51 <Keelhaul> no, there's a tv show called "scientology" which is horrible
04:02:07 <jmiranda> Keelhaul, you're joking?
04:02:15 <jmiranda> sorry
04:02:25 <Keelhaul> joking about what?
04:02:35 <jmiranda> Keelhaul, the joke went over my head
04:02:41 <Keelhaul> heh
04:02:44 <jmiranda> you switched media
04:02:44 <Keelhaul> didnt click on the link?
04:02:48 <jmiranda> i couldn't follow
04:02:49 <r0bby> :D
04:02:51 <Keelhaul> =P
04:03:08 * r0bby is glad he found groovywebconsole which is the inspiration HUGE
04:03:10 <r0bby> :)
04:03:36 <r0bby> I passed some of our mods back to the original author (Guillaume Laforge)
04:07:09 <nribeka> it seems that voiding person can't be performed jmiranda
04:07:15 <nribeka> my test is keep on failing
04:07:23 <nribeka> the person is attached to a patient
04:07:27 <jmiranda> yes
04:07:29 <r0bby> poor burke
04:07:30 <r0bby> :/
04:07:36 <jmiranda> nribeka, good find
04:07:51 <r0bby> I feel so guilty passing on our patch which is mostly burke (almost entirely)
04:07:55 <r0bby> I just manually applied it
04:08:09 <nribeka> last two test
04:08:20 <nribeka> failing miserably ...
04:08:22 <r0bby> jmiranda: does burke's freaky geniousness scare you...
04:08:26 <nribeka> any suggestions jmiranda?
04:08:40 <r0bby> although, i disagree w/ him on the design of the groovy module :x
04:08:50 <jmiranda> r0bby, hmmm ...
04:09:10 <jmiranda> not sure how to answer that question
04:09:15 <jmiranda> yes?
04:09:15 <r0bby> basically if we leave the form open an unauthenicated user was able to execute a script
04:09:20 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: OpenMRS Installation problem on windows 2003 <http://forum.openmrs.org/viewtopic.php?f=9&t=442#p1545> || OpenMRS Changesets: Changeset [7862]: groovy module: remove the Context.isAuthenticated() call from the DWR … <http://dev.openmrs.org/changeset/7862>
04:09:22 <jmiranda> nribeka, commit them
04:09:28 <nribeka> ok
04:09:35 <jmiranda> would like to see what's failing
04:09:37 <r0bby> he wants it done in the evaluagtion method
04:10:04 <r0bby> I feel i should shortcut it so the call isn't made and I don't think an exception is necessary (as he wants :X)
04:11:03 *** nimanthab has joined #openmrs
04:11:16 <jmiranda> r0bby, go with your heart
04:12:40 <nribeka> committed jmiranda
04:13:05 <Keelhaul> where?
04:14:09 <jmiranda> voidPerson_shouldReturnVoidedPersonWithGivenReason()?
04:15:06 <jmiranda> nribeka, what's the error you're receiving?
04:15:55 <nribeka> yes
04:16:02 <nribeka> the other one is unvoid
04:16:12 <nribeka> unvoidPerson_shouldUnvoidTheGivenPerson
04:16:23 <nribeka> any fixes jmiranda?
04:16:41 <nribeka> probably void / unvoid should go down to the child class?
04:17:27 <jmiranda> i'm getting a null pointer exception within the save handler
04:17:29 <nribeka> am i making mistake?
04:17:33 <jmiranda> is that what you're seeing?
04:17:54 <nribeka> yes
04:18:02 <nribeka> error
04:18:35 <nribeka> not failing ... but isn't supposed to be just getting the person and then call voidPerson(person)?
04:18:58 <jmiranda> yeah, this is probably a bug
04:19:06 <jmiranda> which is what we want
04:19:14 <nribeka> want to create ticket?
04:19:18 <nribeka> for it?
04:19:25 <jmiranda> so i wouldn't worry too much from the "is the test created correctly" perspective
04:19:42 <jmiranda> let me look at it a little more
04:19:46 <nribeka> jmiranda should create ticket then :P
04:19:53 <nribeka> which one should i go next?
04:19:54 <Keelhaul> upul: civil war is over, huh?
04:20:21 <jmiranda> nribeka, so is person #9 a patient as well?
04:20:52 <jmiranda> we should probably have separate tests for a person who is only a person
04:20:57 <jmiranda> and a person who is also a patient
04:21:09 <nribeka> i was thinking to create a datasets
04:21:13 <nribeka> for only person
04:21:17 <jmiranda> yeah
04:21:20 <nribeka> and void that one
04:21:23 <jmiranda> i think that would be a good start here
04:21:30 <nribeka> i didn't commit it
04:21:40 <nribeka> still copying from std dataset
04:22:11 <jmiranda> try that
04:22:11 <jmiranda> and then we can create a test that tries to void a person/patient
04:22:14 <jmiranda> and then create a bug report if that continues to fail
04:22:16 <jmiranda> as for what to do next ...
04:22:57 <nribeka> ok jmiranda
04:23:13 <jmiranda> (looking to see what test classes are still in need of help)
04:23:27 <jmiranda> PatientTestService
04:23:56 <upul> Keelhaul: cannot say yet, until the leader is found, but civilians are safe, there is a new so called leader calling from east asia called S Pathmanathan, arms smuggler wanted by interpol, fbi
04:24:04 <jmiranda> or if you want to work on something small, you can finish off AdministrationService
04:24:14 <Keelhaul> upul: they occupied a train station today and an autobahn
04:25:07 <upul> Keelhaul: they set fire to a temple this weekend in canada, embassy in hague
04:25:12 <Keelhaul> =o
04:25:32 <Keelhaul> amazing how many there are in the world
04:26:56 <upul> they went everywhere under 'asylum seeker' status and still do and get PR, there are MP in UK, Canada coming from their votes
04:27:53 <nribeka> jmiranda, i will add a few @should in the patient service
04:27:54 <upul> Even they supported hillary's campaign
04:27:55 <nribeka> is it ok?
04:30:30 <jmiranda> nribeka, go for it
04:31:31 <r0bby> jmiranda: i did put a useless call that'll never be reached since I do the same check in the dwr class...
04:31:53 <r0bby> I'd rather see a simple message like i did
04:34:29 *** nimanthab has quit IRC
04:35:19 <r0bby> what the...
04:36:21 <r0bby> firefox go down the hoooooooooooole
04:38:11 *** jmiranda_ has joined #openmrs
04:38:18 *** Mkop has joined #openmrs
04:38:28 <Mkop> hi, jmiranda
04:38:34 <Mkop> I'm not sure if we'll be coming to WI tomorrow
04:38:50 <Mkop> difficulties with availability of a car, etc.
04:39:00 <Mkop> I'll text you and let you know what's going on
04:39:10 * r0bby sighs
04:39:12 <r0bby> Oh
04:39:18 <r0bby> if any of you can make it to NYC
04:39:27 <Mkop> from Chicago?
04:39:29 <Mkop> I don't think so
04:39:35 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7864]: groovy module: add a safety check which throws an exception if the correct … <http://dev.openmrs.org/changeset/7864> || OpenMRS Changesets: Changeset [7863]: testathon: test cases implementation for PersonService <http://dev.openmrs.org/changeset/7863>
04:39:40 <r0bby> There's a meet a bunch of SOC students (past and present) are planning on Saturday May 23rd
04:39:47 <r0bby> we're planning 1ish i believe
04:40:01 <Mkop> I won't be on the east coast then
04:40:08 <Mkop> nor am I in GSoC
04:40:09 <r0bby> heh:)
04:40:15 <r0bby> Mkop: doesn't matter :P
04:40:19 <Mkop> nor would I be able to go someone on a saturday :-)
04:40:30 <r0bby> oh right
04:40:33 <r0bby> sabboth
04:40:33 <Mkop> somewhere*
04:40:39 <Mkop> yep
04:40:45 <r0bby> it's gonna be awesome :)
04:40:51 <r0bby> last year it fell through
04:41:06 <r0bby> once the google office visit wasn't accomplished
04:41:16 <r0bby> lh said maybe she'll do it this year :)
04:42:40 <r0bby> coffee: the life blood of r0bby's life
04:42:56 <Mkop> r0bby: aren't you done with finals?
04:43:01 <Mkop> why are you coffeeing?
04:43:38 <r0bby> Mkop: because it keeps me awake
04:43:41 <Keelhaul> oh Mkop, i foudn an interesting post on religion
04:43:50 <r0bby> and coffee actually made studying *WORSE*
04:43:50 <Mkop> oh no....
04:43:54 <Keelhaul> http://imgur.com/nb3e3.png
04:44:33 <r0bby> the smelling error makes me giggle
04:44:53 <r0bby> it was written by a 12 year old w/ no clue :)
04:45:16 <Mkop> what error?
04:45:16 <Mkop> hehe
04:45:33 <r0bby> "Moslems"
04:45:36 <Mkop> did you see that thing comparing religions to programming langugages?
04:45:42 <r0bby> yes :)
04:45:45 <r0bby> many times over
04:45:58 <r0bby> I think java programmers are athiests
04:46:07 <r0bby> j/k
04:46:09 * r0bby ducks
04:46:21 *** vanmh has quit IRC
04:46:25 <Keelhaul> gr00vy programmers are mormons =P
04:46:48 <r0bby> mmmm yes
04:47:00 <r0bby> what in god's name is going on
04:47:06 <r0bby> firefox is crashing left and right
04:47:19 <nribeka> jmiranda, still there?
04:47:27 <Mkop> clear your cookies
04:47:34 <Mkop> mmmm, speaking of cookies.....
04:48:08 <r0bby> wtf
04:48:13 <jmiranda_> nribeka, yes
04:48:19 <nribeka> i think i know why it's throwing exception
04:48:28 <upul> most probably a badly written plugin
04:48:29 <Mkop> oh hi jmiranda_
04:48:29 <r0bby> hmm
04:48:34 <Mkop> did you get what I said before?
04:48:36 <r0bby> which plugin :)
04:48:59 <nribeka> the void and unvoid is cascading, but ignoring the fact that person can be created without creating patient or user
04:49:14 <upul> i can't do miracles ;-)
04:49:30 <nribeka> well, i'm not sure if this is desired behavior or not
04:49:44 <jmiranda_> hey Mkop
04:49:50 <jmiranda_> saw your message
04:49:51 <jmiranda_> too bad
04:50:01 <Mkop> I might still make it up there
04:50:04 <nribeka> it's calling: Context.getPatientService().unvoidPatient(Context.getPatientService().getPatient(person.getPersonId()));
04:50:07 <jmiranda_> nribeka, ahh ok
04:50:15 <Mkop> jmiranda_: maybe tuesday - would that work for you?
04:50:18 <nribeka> and Context.getUserService().unvoidUser(Context.getUserService().getUser(person.getPersonId()));
04:50:19 <r0bby> Keelhaul: groovy is awesome
04:50:24 <jmiranda_> Mkop, yeah
04:50:32 <jmiranda_> how long are you staying out this way
04:50:41 <r0bby> I can't make cheap shots at the PIH folks since 1) jmiranda is one of them and 2) I gotta work w/ one this summer :)
04:50:51 <nribeka> so, when the person is not a patient or user, then the process will be trying to unvoid / void null object
04:51:09 <Mkop> jmiranda_: I'm in Chicago until Tuesday
04:51:36 <Mkop> r0bby: why are you making cheap shots against PIH again?
04:51:36 <r0bby> wth is going on
04:51:43 <r0bby> they hate groovy :)
04:51:46 <jmiranda_> r0bby, why would anyone take cheap shots at PIH folks?
04:51:48 <r0bby> well not _HATE_ :)
04:52:08 <r0bby> you dislike my religion!
04:52:28 <Mkop> mormonism?
04:52:36 <Keelhaul> lol
04:52:38 <jmiranda_> r0bby, i do?
04:52:43 <nribeka> and since it's called consecutively, the unvoid process will only succeed on person who is a user and patient. otherwise it will throw NPE
04:53:02 * r0bby is getting all his groovy tendencies out
04:53:05 <nribeka> the void checks only if user is null or not
04:53:13 <jmiranda_> nribeka, got it
04:53:40 <nribeka> so, need further discussions then? :P
04:53:42 <Mkop> r0bby is getting groovy wit' it
04:53:48 <jmiranda_> nribeka, do you have a fix in mind?
04:54:11 <jmiranda_> r0bby, we're using the groovy module on a daily basis
04:54:13 <r0bby> Mkop: damn jiggy :)
04:54:16 <r0bby> ahh :)
04:54:19 <jmiranda_> we love the groovy module
04:54:24 <r0bby> jmiranda_: Then expect some flashy changes
04:54:32 <r0bby> and you'll be happy to know it's now powered by groovy :)
04:54:35 <jmiranda_> no, darius probably expects that
04:54:35 <r0bby> literally.
04:54:39 <nribeka> well, i'm not sure the desired behavior. on the safe side: check if the person is a patient or user is null before cascading the void / unvoid
04:54:40 <nribeka> :P
04:54:55 <r0bby> jmiranda_: yeh I'm pushing out 2.0 before the weeks end
04:55:06 <r0bby> 1.2 -> 2.0
04:55:11 <jmiranda_> darius is what we call ... a genius
04:55:11 <r0bby> it's got some really drastic changes
04:55:20 *** jmiranda has quit IRC
04:55:20 <r0bby> jmiranda_: no duh
04:56:15 <jmiranda_> his ideas are so difficult to comprehend, your brain swells and you get headaches
04:57:20 <Mkop> where is darius based?
04:57:23 <jmiranda_> but he's also loves simplicity so if you can turn those "flashy" ideas into elegant beautiful simple code
04:57:25 <Mkop> he's not in Boston, is he?
04:57:28 <jmiranda_> then you can beat him
04:57:28 <Mkop> is he in Haiti?
04:57:36 <jmiranda_> he's in boston, yes
04:57:56 <Mkop> xkcd today is awesome, btw
04:58:18 <jmiranda_> but travels a lot as our tech liaison
04:58:22 <Mkop> did he travel to Haiti or something lately? I remember him complaining about bad download speeds where he was or something like that
05:01:11 <nribeka> darius is awesome :D
05:01:22 <jmiranda_> Mkop, probably rwanda or south africa
05:01:25 <nribeka> jmiranda, ben, burke, paul is awesome :D
05:01:30 <nribeka> everyone is awesome
05:01:44 <jmiranda_> nribeka, i accept your last statement
05:01:57 <nribeka> you should join the conference call sometime Mkop
05:02:17 <nribeka> and you will listen something "flashy - flashy" jmiranda mention early on
05:02:25 <Mkop> nribeka: yes, I should
05:02:32 <jmiranda_> nribeka, you weren't bored out of your mind after two hours of patient-person-user talk?
05:02:41 <Mkop> until now, Thursday mornings have been bad
05:02:52 <Mkop> what time is it? Thursday 11 Eastern or so?
05:02:58 <nribeka> hahaha ... jmiranda, it was a great discussion though ...
05:03:11 <nribeka> 2h and everyone forgot the next agenda :P
05:03:19 <jmiranda_> :)
05:03:34 <jmiranda_> ok all, i need to get some sleep
05:03:42 <nribeka> ok jmiranda
05:03:44 <jmiranda_> will see you all in the morning (my morning)
05:03:46 <jmiranda_> good night
05:03:46 <nribeka> cya tomorrow
05:03:47 <Mkop> in a system of 90,000 patients and only 14 who are also users, can't you just have a notation saying "This user is also patient #12345"?
05:03:50 <nribeka> nite
05:04:06 <nribeka> yeah, that was burke idea
05:04:12 <nribeka> and it will be added by darius
05:04:24 <nribeka> and it will be in 1.6 i think :P
05:04:35 <Mkop> what, notations?
05:04:36 <jmiranda_> nribeka, i think we all agree that the inheritance relationship between those three entities needs to go away
05:04:38 <nribeka> or late 1.5
05:04:42 <jmiranda_> the issue was how to do it
05:04:44 <nribeka> yeah
05:04:51 <jmiranda_> and how soon
05:04:54 <Mkop> I'm saying aside from whatever data model changes take place
05:05:05 <jmiranda_> darius was taking issue with the changes to hibernate.jar
05:05:06 <Mkop> for that number of cases, why not just a text notation
05:05:06 <nribeka> i agree with darius opinion about Java not supporting multiple inheritance
05:05:12 <jmiranda_> yeah
05:05:23 <Mkop> darius's thing made a lot of sense to me
05:05:49 <jmiranda_> Mkop, well in order to do that we'd need to make patientId != personId != userId
05:05:58 <jmiranda_> and that's what everyone wants
05:06:00 <nribeka> we removed the black magic behind hibernate lol
05:06:20 <nribeka> except Keelhaul jmiranda_ :P
05:06:25 <jmiranda_> a foreign key relationship
05:06:27 <nribeka> Keelhaul still need it
05:06:33 <jmiranda_> nribeka, :)
05:06:38 <nribeka> :P
05:06:48 <jmiranda_> oh, i thought you meant Keelhaul still had some black magic
05:07:10 <jmiranda_> i think Keelhaul could live without it, once we move to the new design
05:07:28 <jmiranda_> but we need to get that working ... probably not till 1.6 though
05:07:28 <Mkop> what is this black magic?
05:07:32 <Mkop> I didn't catch that part
05:07:41 <jmiranda_> Mkop, just leave it at that
05:07:49 <jmiranda_> it's just black magic
05:07:52 <jmiranda_> :)
05:07:54 <Mkop> lol
05:07:55 <nribeka> haha lol
05:07:56 <Keelhaul> nribeka: you removed it already?
05:08:03 <nribeka> no, Keelhaul
05:08:05 <nribeka> it still there
05:08:15 <Mkop> is it in the wiki or anything?
05:08:22 <jmiranda_> kidding ... nribeka if you wants to explain it to Mkop feel free
05:08:29 <jmiranda_> i'm really heading out
05:08:32 <jmiranda_> good night y'all
05:08:35 <Keelhaul> gn
05:08:37 <Mkop> good night justin
05:08:39 <nribeka> nite jmiranda_
05:08:44 <jmiranda_> later
05:08:45 *** jmiranda_ has quit IRC
05:09:10 <nribeka> the conference call conclusions: no hacks on core jar without in depth discussions
05:09:59 <Mkop> nribeka: do you feel like explaining to me what the black magic is/was?
05:10:34 <nribeka> ooo black magic was just the term used in the conference call
05:10:48 <nribeka> referring to how hibernate store / load object
05:11:02 <Mkop> what was the hack used?
05:11:11 <Keelhaul> and gn again
05:11:12 *** Keelhaul has quit IRC
05:11:27 <nribeka> the hack tried to trick the equals method in the entity key
05:11:55 <nribeka> by editing the entity key --> a user != a patient even though they have the same id
05:11:58 * r0bby dances.
05:12:08 <Mkop> oh
05:12:40 <nribeka> but the hack affect concept (basically it will affect all inheritance-type entity)
05:12:50 <Mkop> o\-<
05:12:57 <nribeka> :P
05:12:59 <Mkop> o-|-<
05:13:05 <Mkop> :-/-<
05:13:11 <nribeka> what is that Mkop?
05:13:11 <nribeka> :P
05:13:19 <Mkop> a guy dancing
05:13:44 <nribeka> hahaha
05:13:44 <r0bby> yeh groovy is 100% java and java is 100% groovy
05:14:32 <Mkop> right, and the book of Mormon is no different from the other gospels, right?
05:15:04 <nribeka> hahaha
05:15:32 <nribeka> argh ... i add only 2 should and the plugin generate lots of test cases
05:15:33 <nribeka> :(
05:15:51 <Mkop> huh? how'd that happen?
05:16:40 <nribeka> because there were already some @should (which is just a documentation, not for the test plugin to read)
05:16:53 <nribeka> but the test plugin blindly reads it and generate the test
05:16:54 <Mkop> oh, makes sens
05:16:54 <nribeka> :(
05:17:15 <Mkop> imo, @should should only be used as an annotation for the plugin
05:17:15 <r0bby> Mkop: you HAD to do it didnt you
05:17:29 <nribeka> yeah
05:17:45 <Mkop> you're more than welcome to add documentation without @s, but those @s are specific references for some plugin or another
05:18:19 <Mkop> whether it's @link or @see or @param etc. for javadoc, or @should for our little plugin
05:18:34 <Mkop> r0bby: you're talking about my making a mormonism reference?
05:20:01 *** scottyaz has left #openmrs
05:20:48 <nribeka> you can fix the javadoc again Mkop
05:20:49 <nribeka> :)
05:21:11 <Mkop> nribeka: I'm not a janitor.....
05:21:15 <Mkop> :-P
05:21:30 <nribeka> that's not a janitor job Mkop
05:21:35 <nribeka> :P
05:21:51 <Mkop> cleaning up other people's messes
05:21:52 <Mkop> ?
05:21:57 <r0bby> this javadoc needs to be updated
05:21:57 <Mkop> clean up your own freaking code
05:21:58 <r0bby> http://resources.openmrs.org/doc/org/openmrs/annotation/AuthorizedAnnotationAttributes.html
05:22:00 <OpenMRSBot> <http://ln-s.net/3CUQ> (at resources.openmrs.org)
05:22:08 <Mkop> and your own freaking docs
05:22:24 <nribeka> omg ... patient service test --> 101 test :(
05:22:40 <Mkop> r0bby: whoever updated the code should update the javadocs
05:22:55 <r0bby> Mkop: you liked doing it
05:22:59 <r0bby> I _HATE_ doing javadocs :)
05:23:18 <r0bby> I javadoc'd a class for this irclib i helped write
05:23:30 <r0bby> it's annoyingly tedious
05:23:47 <r0bby> I have deep deep respect for that :)
05:23:48 <Mkop> r0bby: it really isn't
05:23:53 <r0bby> it is :)
05:23:55 <Mkop> for each methods, it takes about 2 minutes
05:24:03 <r0bby> 2 minutes is a lot.
05:24:16 <Mkop> add a few @params, a @return, and a line or two of text if you so wish
05:25:07 <Mkop> IE8 + Gmail = Stack overflow at line 51
05:26:11 <Mkop> ok, good night all
05:26:14 <Mkop> I have to go to sleep
05:26:15 <Mkop> ttyl
05:26:19 *** Mkop has quit IRC
05:33:47 *** nribeka1 has joined #openmrs
05:34:44 *** ChanServ sets mode: +v nribeka1
05:34:53 *** nribeka has quit IRC
05:34:56 *** nribeka1 is now known as nribeka
05:39:33 *** ajitlodhi has joined #openmrs
05:39:47 <ajitlodhi> !trivialtickets
05:39:47 <OpenMRSBot> ajitlodhi: "trivialtickets" --- http://dev.openmrs.org/report/16
05:41:24 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7866]: testathon: fix for unvoid / void test. seems that the void / unvoid … <http://dev.openmrs.org/changeset/7866> || OpenMRS Changesets: Changeset [7865]: groovy module: localize the error message <http://dev.openmrs.org/changeset/7865>
05:41:57 *** ajitlodhi has quit IRC
05:48:32 *** nribeka1 has joined #openmrs
05:51:05 <r0bby> sigh
05:53:21 *** nribeka2 has joined #openmrs
05:54:04 *** nimanthab has joined #openmrs
05:54:57 <nimanthab> nimanthab: test
05:55:49 <r0bby> 123
05:56:00 <nimanthab> :)
05:57:44 <nribeka2> hungry time
06:02:10 *** nimanthab has quit IRC
06:05:50 *** nribeka3 has joined #openmrs
06:06:47 *** nribeka has quit IRC
06:11:23 *** nribeka1 has quit IRC
06:12:03 <r0bby> AGH
06:12:13 <r0bby> how the hell do you localization in DWR classes
06:15:23 <nribeka3> what kind of localization r0bby? message?
06:17:48 <r0bby> yes
06:17:59 <r0bby> i wish i lived alone sometimes
06:18:25 <r0bby> oh my god this is hacky as hell :(
06:19:10 *** scottyaz has joined #openmrs
06:21:06 *** nribeka2 has quit IRC
06:22:52 *** pascal` has joined #openmrs
06:29:32 <pascal`> hi
06:29:53 <upul> hi pascal`
06:29:59 <pascal`> hey upul
06:30:57 * r0bby stabs ff
06:31:26 <pascal`> o.O
06:31:32 <pascal`> er, hi r0bby
06:32:05 <pascal`> what are you stabbing?
06:32:13 <pascal`> (who?)
06:35:31 <r0bby> firefox
06:35:58 <r0bby> I'm tempted to investigate the leaky classloaders :(
06:38:38 <pascal`> while you're at it, you should investigate the bad use of the permgen space by tomcat
06:39:39 <r0bby> pascal`: tomcat has a classloader for each app :)
06:39:46 <r0bby> in a hierarchy
06:39:52 <r0bby> tree hierarchy*
06:40:49 <nribeka3> 81 failure to go
06:41:49 <r0bby> ... AWESOME
06:41:52 <r0bby> ant is corrupting a file!
06:43:55 <pascal`> odd
06:44:08 *** nribeka has joined #openmrs
06:44:08 *** ChanServ sets mode: +v nribeka
06:44:54 *** nribeka has quit IRC
06:52:13 *** nribeka has joined #openmrs
06:52:13 *** ChanServ sets mode: +v nribeka
06:57:35 <r0bby> w00t
07:01:38 *** nribeka3 has quit IRC
07:15:37 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7870]: groovy module: need to add this too. <http://dev.openmrs.org/changeset/7870> || OpenMRS Changesets: Changeset [7869]: groovy module: unused import <http://dev.openmrs.org/changeset/7869> || OpenMRS Changesets: Changeset [7868]: groovy module: a hacky way to localize, hey it works though! <http://dev.openmrs.org/changeset/7868> || OpenMRS Changesets: Changeset [7867]: testathon: added few implementation of PatientServiceTest <http://dev.openmrs.org/changeset/7867>
07:21:36 *** nribeka1 has joined #openmrs
07:37:35 *** nribeka has quit IRC
07:47:25 *** nribeka has joined #openmrs
07:47:25 *** ChanServ sets mode: +v nribeka
07:47:34 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7873]: testathon: added few implementation of PatientServiceTest <http://dev.openmrs.org/changeset/7873> || OpenMRS Changesets: Changeset [7872]: groovy module: comment add <http://dev.openmrs.org/changeset/7872> || OpenMRS Changesets: Changeset [7871]: groovy module: some javadoc'ing <http://dev.openmrs.org/changeset/7871>
08:05:20 *** nribeka1 has quit IRC
08:19:26 <upul> all finished
08:20:09 <upul> terrorist leader dead
08:24:02 <pascal`> =O
08:27:00 <pascal`> upul, do you think decades of fighting could really end this quickly?
08:28:19 <upul> yes, only needed a clear leadership and good people to fight the lies and deceit around the world
08:31:52 <upul> tomorrow could be holiday ;-)
08:33:21 *** bodobacs has joined #openmrs
08:33:59 *** bodobacs has left #openmrs
08:43:06 <r0bby> okay seriously
08:43:08 <r0bby> no more coffee
08:43:32 <r0bby> okay yeh -- we're not doing buttons inside the code editor
08:53:40 *** scottyaz_ has joined #openmrs
08:54:00 *** scottyaz has quit IRC
09:00:07 *** Pascal has joined #openmrs
09:05:48 *** Pascal is now known as pascal``
09:08:01 <r0bby> I think i'm being told by IDEA to go to bed...
09:09:35 *** pascal`` has joined #openmrs
09:13:23 *** pascal` has quit IRC
09:19:40 *** pascal`` is now known as pascal`
09:32:31 *** pascal` has quit IRC
09:51:10 *** kane77 has joined #openmrs
09:51:32 *** kane77 has quit IRC
11:00:57 *** nribeka has quit IRC
11:02:05 *** nribeka has joined #openmrs
11:02:05 *** ChanServ sets mode: +v nribeka
11:13:58 <upul> BBC world (radio) asked about the thoughts regarding the western calls for a ceasefire in Sri Lanka. Reply, these people are asking why western countries are not asking ceasefire in Afghanistan, that is the difference between their terrorism and LTTE terrorism ... ... <silence> BBC: there was a technical failure!
11:18:04 *** upul has quit IRC
11:25:09 *** james_regen has joined #openmrs
11:25:09 *** ChanServ sets mode: +v james_regen
11:39:03 *** pascal` has joined #openmrs
11:47:26 *** atomicturtle has joined #openmrs
11:48:06 *** atomicturtle has left #openmrs
12:13:33 <r0bby> AIIIIYEEEEEEEEEEEEEEEEEEEe
12:14:14 *** bwolfe has joined #openmrs
12:14:14 *** ChanServ sets mode: +o bwolfe
12:15:47 <r0bby> bwolfe!!!!!!!!!
12:15:51 <r0bby> I never went to bed
12:16:06 <r0bby> and guess what for some odd reasons the objects are persisting correctly!
12:16:16 <r0bby> and the spring form tags are the _SHIT_
12:17:00 <r0bby> I can do <form:errorscssClass="errors">
12:17:09 <r0bby> and it'll render if there are errors :D
12:17:19 <r0bby> it's one more import at the top of my jsp but damn :D
12:17:24 * r0bby dances
12:17:33 <r0bby> I think i'll catch mike now if possible
12:17:47 <r0bby> AGH
12:17:53 * r0bby makes more coffee
12:20:16 <r0bby> I decided to not do a jquery popup
12:26:23 <r0bby> want to see a demo bwolfe ?
12:26:48 <bwolfe> sure
12:39:19 <r0bby> what do ya think :)
12:39:48 <pascal`> hmmm
12:51:19 * r0bby screams like a school girl
12:54:18 *** Keelhaul has joined #openmrs
12:54:18 *** ChanServ sets mode: +v Keelhaul
12:58:21 <r0bby> this can't be good for my body...
12:58:28 <r0bby> staying up all night..
13:04:09 <r0bby> bwolfe: where is our server located?
13:05:26 <r0bby> whoa
13:05:45 <r0bby> guillaume mentioned heredocs (""" and ''') strings aren't highlighted properly
13:06:01 <bwolfe> which server r0bby ?
13:06:03 <r0bby> I *DO NOT* feel like writing a parser, i'll let him do it and borrow it :)
13:06:06 <bwolfe> we have three
13:06:10 <r0bby> dev
13:06:13 <r0bby> trac, svn etc
13:06:16 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7878]: groovy module: more eclipse .classpath file updates <http://dev.openmrs.org/changeset/7878> || OpenMRS Changesets: Changeset [7877]: groovy module: there was a local path referenced removed that now;. <http://dev.openmrs.org/changeset/7877> || OpenMRS Changesets: Changeset [7876]: groovy module: commit the .classpath for eclipse users <http://dev.openmrs.org/changeset/7876> || OpenMRS Changesets: Changeset [7875]: groovy module: remove an unused js file that I should have deleted before; … <http://dev.openmrs.org/changeset/7875> || OpenMRS Changesets: Changeset [7874]: groovy module: save/load functionality works perfectly :) <http://dev.openmrs.org/changeset/7874> || OpenMRS Forum: Re: Open MRS outside data queries <http://forum.openmrs.org/viewtopic.php?f=10&t=434#p1546>
13:06:18 <bwolfe> dev/svn.openmrs.org == oregon with OSUOSL
13:07:09 <pascal`> it isn't good... and not just for your body.
13:08:43 <r0bby> hh but they use UTC
13:08:50 <r0bby> which is what threw me off :)
13:08:52 <bwolfe> openmrs.org/wiki/forum/blog/ == florida with Volico.com
13:09:09 <bwolfe> modules.openmrs.org == texas with atomicturtle
13:09:18 <r0bby> pascal`: yeh not good fro the people around me
13:09:24 <r0bby> i'm a total and utter beeotch
13:09:45 <bwolfe> labs/demo.openmrs.org == florida (not 100% sure) with Verio.com
13:09:46 <r0bby> I'm not pleasant to be around when i'm sleep deprived :)
13:09:51 <r0bby> :)
13:09:56 <r0bby> jesus christ
13:10:03 <r0bby> couldn't you find one host...
13:10:09 <r0bby> how do you keep track!
13:10:22 <r0bby> my first shell host company was w/ a company i didnt like
13:10:24 <bwolfe> vm2.openmrs.org (old demo site) was with craptastic-server-company.com
13:10:29 <r0bby> then it was w/ some guy in shingletown,ca
13:10:41 <r0bby> (no joke on the name; server was hosted i forgot where, not shingoeton)
13:10:57 <bwolfe> we have a google doc that keeps all our notes, what server is where, what services are on them, etc
13:11:19 <r0bby> I lost touch w/ the guy; but when i stopped usinf trhem i kept in touch somewhat; i found one of the guys on #java on efnet one day
13:11:23 <r0bby> it was funny actually
13:11:41 <Keelhaul> shingletown D=
13:11:44 <r0bby> yeh
13:11:47 <Keelhaul> what a name
13:12:11 <r0bby> i once uhm told a user to rm -rf ~ and they did it!
13:12:24 <r0bby> luckily the guy liked me so I got off w/ a scolding!
13:12:48 <r0bby> ahh good times
13:12:51 <r0bby> oh well :)
13:14:10 <r0bby> I was bad :)
13:14:18 <r0bby> I blame immaturity!
13:16:44 *** jmiranda has joined #openmrs
13:16:44 *** ChanServ sets mode: +o jmiranda
13:17:24 <r0bby> jmiranda!!!!
13:17:30 <pascal`> one host = single point of failure
13:17:30 <pascal`> bwolfe, what's the svn backup strategy?
13:17:34 <r0bby> guess basic save/load has working :)
13:17:39 <r0bby> guess what*
13:17:48 <r0bby> excuse me i need coffee while i wait for mike
13:17:51 <r0bby> so i can sleep
13:20:43 <bwolfe> pascal`: I think OSU has nightly backups, but I haven't actually verified that
13:20:58 <bwolfe> basic` would be able to tell us. he'll be around in a few hours
13:22:02 <r0bby> bwolfe: it'll just be nice to actually show I can follow through when i release 2.0 :)
13:22:28 <r0bby> soc will surely be another fine example of that
13:22:32 <r0bby> but this will be pre-soc :D
13:33:32 <pascal`> well i hope they take the backups off site at least
13:33:49 <r0bby> I'm scared
13:33:56 <r0bby> I typo
13:34:05 <r0bby> 'd lucid when i was trying to say i was lucid!
13:36:45 <r0bby> feh
13:36:53 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7879]: groovy module: last .classpath modification i swear. <http://dev.openmrs.org/changeset/7879>
13:42:59 *** upul has joined #openmrs
13:42:59 *** ChanServ sets mode: +v upul
13:43:34 <pascal`> dude, r0bby, i think you need some sleep
13:43:34 <pascal`> (-:
13:46:54 <Keelhaul> yea
13:47:05 <Keelhaul> whatever you write up while dead tired might be worthless
13:49:09 <r0bby> it's not that bad
13:49:23 <r0bby> whatever I write lucid could be worthless :P
13:49:36 <r0bby> (Disclaimer: r0bby has zero confidence in anything he writes)
13:49:53 <r0bby> I can't sleep right now
13:50:04 <r0bby> all I'm writing right now is a spring controller lol
13:50:09 <r0bby> can't be that bad
13:50:53 <pascal`> 6 commits in a row
13:50:55 <pascal`> nice (=
13:51:25 <r0bby> pascal`: that was me forgetting little things
13:51:41 <r0bby> good news though: i have no things backlogged!
13:51:42 <r0bby> :D
13:51:48 <r0bby> ...for groovy module anyways
13:52:02 <r0bby> cept the jstl jar which is going away
13:53:39 <r0bby> I've done this twice last week.
13:53:54 <r0bby> Sunday night; then Thursday night
13:58:11 <upul> Keelhaul, it's finished
13:58:17 <Keelhaul> what is
13:58:49 <upul> When people ask, can we destroy the most dangerous and deadly extremists in the world? Sri Lanka say, yes we can.
14:00:48 <upul> When people ask can we face threats from US, UK, Norway, EU? Sri Lanka say, yes we can.
14:00:53 <bwolfe> r0bby: what have I told you about shotgun committing...
14:01:20 <bwolfe> upul: news link?
14:01:37 <r0bby> bwolfe: sorry
14:01:41 <Keelhaul> upul: lol tough talk
14:01:48 <r0bby> and that's machine gun
14:02:02 <r0bby> I'll try and clump my commits together :)
14:02:16 <upul> bwolfe, check out http://defence.lk/
14:02:27 <r0bby> I love the new spring 2.5 annotations
14:02:40 <r0bby> I'm still trying to learn them but by summers end i will be good w/ them i think :)
14:03:22 <r0bby> bwolfe: I
14:03:25 <r0bby> 'll behave
14:03:42 <r0bby> I'm gonna have to review this code before i commit it
14:04:12 <r0bby> groovy has ruined me i swear
14:04:23 <r0bby> semi-colons should have never been made optional!
14:04:40 <r0bby> I put them in groovy code, but forget them in java code, what gives?!?!?!
14:04:40 <bwolfe> r0bby: seriously. next time you commit use this process. 1) right click on the root of your project and say commit. 2) review EVERY FILE by double clicking on it to open a diff of the changes you've made 3) if you don't want to commit that file, uncheck the box 4) write up a nice commit comment in a text editor with spell checking 5) copy the comment into the commit message textbox 6) take 10 deep breathes 7) reread your commit com
14:04:40 <bwolfe> ment 8) commit
14:05:04 <r0bby> okies :)
14:05:08 <r0bby> I will
14:05:19 <r0bby> bwolfe: i usually do
14:05:35 <r0bby> I had some files sitting here uncommited :P
14:05:53 <r0bby> I tried to do the buttons on the code editor, they wound up looking like crap
14:05:56 *** atomicturtle has joined #openmrs
14:06:04 <r0bby> burke's suggestion
14:06:37 <bwolfe> upul: any top leaders of ltte left unaccounted for? any chance of a resurgence ?
14:06:51 *** atomicturtle has left #openmrs
14:06:58 <r0bby> bwolfe: I thought my days of machine gun commiting were over :(
14:07:15 <r0bby> Oh wait bwolfe I forgot a semi-coloN!
14:07:16 <r0bby> j/k
14:07:29 *** jmiranda has quit IRC
14:07:37 <r0bby> I really do love openmrs
14:08:44 <r0bby> this is hot :D
14:08:58 <r0bby> IDEA added some fun stuff
14:09:02 <r0bby> or a plugin i have added it
14:11:13 <upul> bwolfe, not a single one in the field, all top leaders are finished, there is this arms smuggler S Pathmanadan wanted by interpol now in malaysia http://www.interpol.int/public/Data/Wanted/Notices/Data/1998/43/1998_4743.asp
14:11:16 <OpenMRSBot> <http://ln-s.net/3CZi> (at www.interpol.int)
14:11:36 *** jmiranda has joined #openmrs
14:11:36 *** ChanServ sets mode: +o jmiranda
14:12:11 <upul> funny the news is UN envoy who sent here had called him from the airport toilet yesterday
14:14:06 <upul> may be LTTE scragglers will try to create a separate state in norway, uk or canada :-) won't have space here now
14:14:12 <upul> or germany :-D
14:14:51 * r0bby dances
14:15:52 <Keelhaul> upul: or they may have to retreat to guerilla tactics against your people
14:15:54 <Keelhaul> like suicide bombings
14:16:25 * r0bby sighs
14:16:31 <r0bby> I don't get all this crap :(
14:17:35 <Keelhaul> bwolfe: is there a way to automatically add the branck/module to the commit comment based on what you commit?
14:17:39 <Keelhaul> branch*
14:18:04 <bwolfe> Keelhaul: yeah, I think we could do that with svn hooks...I just don't have time to mess with it
14:18:17 <Keelhaul> ok
14:18:32 <upul> Keelhaul, nope, our army intelligence is super, we hardly had a bomb blowing in colombo in recent times, everything get caught
14:19:00 <Keelhaul> the russians thought they're safe after the chechnya wars
14:19:06 <upul> we even know what UN officials are doing in toilets ;-)
14:19:49 *** luzhuangwei has joined #openmrs
14:20:08 <Keelhaul> bush said "mission accomplished" after the regular iraqi army was defeated
14:20:36 <upul> china is our big friend, that's why us, uk didn't try to stop us
14:20:59 <r0bby> I always forget then i have to edit it :(
14:21:18 <r0bby> I wish i didn't work in such a constrainted in environment
14:21:18 <bwolfe> Keelhaul / nribeka : do you have any outstanding unit tests that you need to commit to the testathon branch?
14:21:29 <r0bby> then I could use @Service/@Repository w/o worr
14:21:31 <r0bby> y
14:21:32 <r0bby> :x
14:21:48 <Keelhaul> bwolfe: not that i know of
14:21:54 <Keelhaul> unless i take another test class
14:23:11 <pascal`> when i stay up all night it's usually not because i'm coding
14:23:54 <bwolfe> Keelhaul: do you want to do that ? because at this point I think we're going to need to delete all generated tests and merge to trunk
14:24:11 <Keelhaul> bwolfe: maybe tonight
14:24:20 <Keelhaul> but go ahead and merge
14:24:32 <Keelhaul> arent you going to take a look at all the commited tests first?
14:25:23 <bwolfe> Keelhaul: yeah, I think we'll look at the tests in the code review today
14:25:55 <Keelhaul> i noticed how the tests i wrote last night are shorter than the ones i wrote in the same class earlier
14:25:58 <Keelhaul> hope thats ok =P
14:26:02 <bwolfe> jmiranda: what do you think about that ? delete all generated tests that are failing in the testathon branch. code review unit tests today, merge to trunk today/tomorrow
14:26:15 <bwolfe> Keelhaul: yep, shorter is better for unit tests
14:26:25 <bwolfe> Keelhaul: the ideal test is one line. :-D
14:26:28 <Keelhaul> heh
14:26:29 <Keelhaul> well
14:26:34 <jmiranda> bwolfe: yeah, that sounds fine to me
14:26:35 <Keelhaul> depends on how thorough you want it
14:26:40 <jmiranda> we could also open this up for the next week
14:26:48 <jmiranda> and try to get all the tests completed
14:27:02 <jmiranda> then code review next week
14:27:15 <Keelhaul> old tests have things like "load list of unretired locations, retire one location, load list again, assert that the old list is 1 longer than the new"
14:27:49 <jmiranda> Keelhaul: we're going to clean up the older tests at some point
14:28:18 <Keelhaul> jmiranda: they aren't old old, they are plugin generated
14:28:27 <Keelhaul> just longer
14:29:04 <jmiranda> Keelhaul: by "old", i meant anything that doesn't comply to conventions
14:29:12 <jmiranda> before we had conventions
14:29:17 <r0bby> Oh my god it's 10:29am
14:30:21 <r0bby> I think im gonna see the beauty of groovy in the web layer \
14:30:46 <r0bby> and not just compiling to bytecode either like ive been doing
14:31:59 <jmiranda> bwolfe: we should at least get about 73 more tests done
14:32:00 <jmiranda> :)
14:32:07 <jmiranda> so we can hit our goal of 1000
14:33:10 <pascal`> 0) have at least 8hrs sleep in the last 48hrs
14:33:25 <Keelhaul> jmiranda: one of the tests i commited fails because i dont know how to trigger that particular exception
14:33:52 <bwolfe> jmiranda: knock yourself out. I need to move on to other things. :-/
14:33:52 <Keelhaul> so you might have to take it out or smt
14:34:16 <r0bby> I'm sorry for not participating i felt my efforts were better suited in improving something that gets a lot of use :)
14:34:18 <jmiranda> bwolfe: ok
14:34:20 <bwolfe> jmiranda: you should be able to find 50+ braindead easy tests to do
14:34:30 <r0bby> the ability to save scripts is a GREAt addition :)
14:34:37 <bwolfe> things like "should return null for invalid id" kind of things
14:34:45 <jmiranda> bwolfe: yeah
14:34:47 <bwolfe> those take 2 seconds to write. :-)
14:35:01 <r0bby> first braindead mistake: listForms()
14:35:10 <r0bby> from my days of writing groovy forms :x
14:38:24 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7881]: testathon: Implemented the last of the UserService tests <http://dev.openmrs.org/changeset/7881> || OpenMRS Changesets: Changeset [7880]: xforms module: localizing form designer text <http://dev.openmrs.org/changeset/7880>
14:50:04 <pascal`> bwolfe, users can be assigned role, but not individual privileges, is that correct?
14:50:04 <pascal`> *roles
14:50:42 <Keelhaul> for now, yes
14:59:36 <nribeka> i wrote some brain-dead test in last minute last night
14:59:37 <nribeka> lol
15:01:57 <nribeka> bwolfe + jmiranda: i hope the test i wrote is not wrong ...
15:02:04 <r0bby> ugh I hate constantly restarting tomcta
15:02:06 <r0bby> tomcat
15:02:33 <jmiranda> nribeka: don't worry about that
15:02:45 <jmiranda> you were a champ getting through as many tests as you did
15:02:53 <jmiranda> thank you for all your hard work this weekend
15:03:21 <r0bby> cute...
15:03:29 <r0bby> @Controller bites
15:03:52 <r0bby> you assign a variable in <c:forEach> and it thinks it's a model attribute!
15:04:10 <nribeka> thanks jmiranda
15:04:27 <r0bby> http://pastie.org/481599
15:04:29 <r0bby> example :)
15:04:46 <r0bby> OH DOH
15:04:55 <r0bby> i assigned it as a command object in the form tag
15:05:03 <nribeka> i put some comment about the void / unvoid in the commit message last night
15:05:31 <nribeka> which one is better r0bby: pastie, pastebin or rafb?
15:05:50 <r0bby> pastie
15:06:02 <r0bby> its color scheme doesn't make my eyes bleed.
15:06:10 <nribeka> btw i take the brain-dead test from patient service, jmiranda hehe ...
15:07:58 <jmiranda> was it one of mine?
15:08:37 <nribeka> i wrote most of the brain-dead test, so less brain-dead test there in patient service now :P
15:08:57 <nribeka> still around 80 test in there now
15:09:13 *** pascal` has quit IRC
15:11:47 <jmiranda> nribeka: yeah, there are some tricky ones still left to do
15:11:47 *** pascal` has joined #openmrs
15:11:52 <jmiranda> exitPatientFromCare
15:11:56 <jmiranda> mergePatient
15:12:40 <pascal`> meh internet
15:17:57 <nribeka> pascal`, you're in SA?
15:30:38 <nribeka> off
15:30:39 <nribeka> bbl
15:30:46 *** nribeka has quit IRC
15:37:42 <r0bby> why do things _ALWAYS_ look so much better in your head :(
15:38:54 *** scottyaz_ has quit IRC
15:39:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7882]: reporting: Removed dependency on reporting compatibility JAR. <http://dev.openmrs.org/changeset/7882>
15:40:15 *** catechu has joined #openmrs
15:42:42 *** jmiranda has quit IRC
15:43:13 *** jmiranda has joined #openmrs
15:43:14 *** ChanServ sets mode: +o jmiranda
15:54:50 <basic`> pascal`, bwolfe: yes, we do nightly backups with dirvish
16:00:02 *** vanmh has joined #openmrs
16:03:28 *** Keelhaul has quit IRC
16:03:34 *** Keelhaul has joined #openmrs
16:03:34 *** ChanServ sets mode: +v Keelhaul
16:06:38 <catechu> I'm trying to install the dev tools on Eclipse, but I'm getting an org.eclipse.ui requirement of 3.4.2.M20090204-0800 (I'm using M20090211-1700). Has this happened to anyone?
16:07:52 <bwolfe> hmm
16:09:00 <bwolfe> catechu: I'm using that version too and it works
16:09:17 <bwolfe> catechu: are you making your the other requirements are installed ?
16:09:27 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7883]: -- atd * added some atd_patient_state queries <http://dev.openmrs.org/changeset/7883>
16:10:16 <catechu> bwolfe: I got the error about mylyn extras, and installed those, so this failed requirement is all that's left.
16:10:53 <catechu> bwolfe: Are there any silent requirements that I'm missing?
16:10:59 <bwolfe> have you tried to upgrade all eclipse plugins? It might be another requirement
16:11:25 <catechu> bwolfe: I have not -- I will do so now and see what happens.
16:13:41 *** nribeka-mobile has joined #openmrs
16:18:31 <catechu> I am receiving the same error: "Cannot find a solution satisfying the following requirements org.eclipse.ui [3.4.2.M20090204-0800]."
16:20:53 <r0bby> agh
16:21:06 <r0bby> I will not sleep til i push this release out
16:21:20 <r0bby> hopefully quality doesn't suffer :X
16:28:41 *** upul has quit IRC
16:31:24 *** nribeka-mobile has quit IRC
16:35:23 *** nribeka has joined #openmrs
16:35:23 *** ChanServ sets mode: +v nribeka
16:40:40 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7884]: -- chica * Made checkout state configurable through a global property for … <http://dev.openmrs.org/changeset/7884>
16:41:17 <nribeka> bwolfe, jmiranda do the test branch is going to be merged? or code reviewed? or we can still commit later on?
16:41:32 <jmiranda> nribeka, keep committing
16:41:48 <jmiranda> i want to get about 70 - 100 more test cases done once i have some time on wednesday
16:42:04 <jmiranda> we won't merge until the end of the week
16:42:41 <nribeka> no more brain dead test lol
16:42:55 <jmiranda> you did them all?
16:42:59 <jmiranda> dang
16:43:05 <nribeka> ok jmiranda, i will try to add some ...
16:43:06 <jmiranda> i was hoping for a couple easy ones
16:43:17 * r0bby bangs his head on his desk
16:43:29 <jmiranda> r0bby, you don't need to do that
16:43:39 <nribeka> i'm my other laptop now. need to checkout again
16:43:45 <nribeka> what wrong r0bby?
16:44:29 <r0bby> but it feels good
16:47:13 *** bwolfe has quit IRC
16:53:04 *** luzhuangwei has quit IRC
16:55:03 *** omar has joined #openmrs
17:02:24 <nribeka> be back later tonight jmiranda
17:02:28 <nribeka> or this noon
17:02:31 <nribeka> cya ...
17:02:34 <Keelhaul> bye
17:02:37 <r0bby> Have fun
17:03:05 <r0bby> where the heck did the day go
17:03:12 <r0bby> it's already 1:02pm
17:03:14 <Keelhaul> this EKG precision cardio chest belt is nice
17:03:21 <nribeka> bye Keelhaul
17:03:21 <r0bby> you dying mr?
17:03:24 <nribeka> bye r0bby
17:03:27 *** nribeka has quit IRC
17:03:31 <Keelhaul> dying?
17:03:32 <Keelhaul> no
17:03:34 <Keelhaul> for my elliptical
17:03:45 <r0bby> heh
17:03:47 <Keelhaul> (at least not that i know of)
17:07:40 *** bwolfe has joined #openmrs
17:07:40 *** ChanServ sets mode: +o bwolfe
17:11:25 <r0bby> wb bwolfe
17:11:34 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7885]: global-property-types branch: Merging trunk into branch … <http://dev.openmrs.org/changeset/7885>
17:29:58 *** bwolfe_ has joined #openmrs
17:29:58 *** ChanServ sets mode: +o bwolfe_
17:30:49 <r0bby> hrm
17:30:53 <r0bby> two bwolfes
17:30:56 <r0bby> this can't be good
17:31:53 *** bwolfe has quit IRC
17:32:46 <r0bby> oh this is hot :)
18:04:06 *** catechu has quit IRC
18:12:18 *** Echidna_ has quit IRC
18:12:32 *** Echidna has joined #openmrs
18:14:50 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7886]: idcards: Fixed some incorrect messages Added option to print example cards … <http://dev.openmrs.org/changeset/7886>
18:44:04 <r0bby> nice!
18:44:05 <r0bby> :D
19:06:00 <r0bby> why in god's name is my sqldiff not being executed...
19:18:54 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7889]: reporting: Upgraded dbunit jar and classpath (need to remove old jar). <http://dev.openmrs.org/changeset/7889> || OpenMRS Changesets: Changeset [7888]: Only log error for standard authentication failure in … <http://dev.openmrs.org/changeset/7888> || OpenMRS Changesets: Changeset [7887]: reporting: Need to change location of dataset file. <http://dev.openmrs.org/changeset/7887>
19:24:18 <r0bby> awesome.. just got disconnected from mike
19:28:41 <r0bby> Round 2.
19:50:57 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7891]: ncd: Reorganized the imports on the ConditionDetectorService interface and … <http://dev.openmrs.org/changeset/7891> || OpenMRS Changesets: Changeset [7890]: ncd:more NLP Context refactoring. <http://dev.openmrs.org/changeset/7890> || OpenMRS Announcements List: OpenMRS Meeting in Boston May 26th <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind0905&L=openmrs-announce-l&P=73>
19:58:44 *** james_regen has quit IRC
20:09:56 <r0bby> bwolfe_, jmiranda ping
20:11:29 <bwolfe_> yes?
20:12:08 *** Keelhaul has quit IRC
20:14:36 <jmiranda> r0bby,
20:17:44 <r0bby> nevermind
20:18:09 <r0bby> Mike was right.. apparently sqldiffs are only processed under certain conditions despite the table's existence or lackthereof
20:20:23 <r0bby> okay, we're gonna try groovy!
20:20:42 <r0bby> i'm getting tired of re-deploying everytime i change a line in my controller
20:21:21 <r0bby> I'm gonna get groovy with spring
20:21:29 <r0bby> Was that a bad pun? Good!
20:21:30 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7895]: facilitydata: commit skeleton class. <http://dev.openmrs.org/changeset/7895> || OpenMRS Changesets: Changeset [7894]: reporting module: added an actual assert to the … <http://dev.openmrs.org/changeset/7894> || OpenMRS Changesets: Changeset [7893]: ncd:Fixes to NlpCriticContext[Type] mapping files. Fixes to ContextDAO. <http://dev.openmrs.org/changeset/7893> || OpenMRS Changesets: Changeset [7892]: ncd: partial progress on admin user interface for reportable results … <http://dev.openmrs.org/changeset/7892>
20:53:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7896]: mdrtb module, still for openmrs 1.3. 1/2 way done with adding … <http://dev.openmrs.org/changeset/7896>
21:01:02 <r0bby> bwolfe_: w00t w00t
21:01:03 <r0bby> :D
21:05:30 <r0bby> bwolfe_: check your emailllllllllllll
21:06:33 <bwolfe_> r0bby: no need to tell me that. evolution already tells me when I get an email
21:07:42 <r0bby> sorry, i worked all day on this :)
21:08:15 <r0bby> the version idea came to mind since i allowed for the same name to exist for a script
21:08:40 <r0bby> but you can also edit existing scripts so versions can easily be bumped up w/o creating a new one
21:08:45 <r0bby> one other change i wanna make
21:09:58 <r0bby> add a link to create a new script if say we're looking at an existing script
21:10:20 <r0bby> I like the color scheme :) it matches OpenMRS :D
21:10:42 <r0bby> hmm
21:11:00 <r0bby> the message for when there are no scripts needs a diff color
21:13:12 <r0bby> likey :)
21:13:30 <r0bby> I think im gonna hit the sack early tonight
21:14:44 * r0bby dances
21:25:07 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: OpenMRS Installation problem on windows 2003 <http://forum.openmrs.org/viewtopic.php?f=9&t=442#p1547> || OpenMRS Tickets: Ticket #1426 (enhancement closed): Groovy Module: Add ability to save script <http://dev.openmrs.org/ticket/1426#comment:4> || OpenMRS Changesets: Changeset [7897]: groovy module: CRUD abilities are now in place. per ticket #1426. <http://dev.openmrs.org/changeset/7897>
21:34:07 <r0bby> \/jj
21:34:09 <r0bby> er
21:53:02 <bwolfe_> r0bby: now you're shotgun-ticket-editing??
21:54:28 <r0bby> bwolfe_: sorry!
21:54:43 <r0bby> No I was opening it up again sorry
21:57:10 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7899]: ncd: Updated to set releaseDate = testrcvddatetime for existing reportable … <http://dev.openmrs.org/changeset/7899> || OpenMRS Changesets: Changeset [7898]: groovy module: change the color for the text if no scripts are saved. <http://dev.openmrs.org/changeset/7898>
21:57:13 <bwolfe_> r0bby: looking at your sqldiff: you should never modify an old diff. always add a new one with an "alter table add column..." syntax
21:58:40 <r0bby> ok I'm reverting it to an old version
21:58:46 <r0bby> Removing the version property
21:58:53 <r0bby> it was just an idea
21:59:05 <r0bby> a late idea that popped into my head
21:59:22 <r0bby> so to revert this change
21:59:29 *** bwolfe_ has quit IRC
21:59:30 <r0bby> do I add another diff?
22:29:12 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7901]: ncd: finished hibernate mapping class renaming and first-pass JavaDoc … <http://dev.openmrs.org/changeset/7901> || OpenMRS Tickets: Ticket #1426 (enhancement reopened): Groovy Module: Add ability to save script <http://dev.openmrs.org/ticket/1426#comment:5> || OpenMRS Changesets: Changeset [7900]: Reverted the hibernate.jar change for person/patient/user. #725 Changed … <http://dev.openmrs.org/changeset/7900>
23:01:14 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7904]: ncd: renamed tables to conform to OpenMRS module conventions. <http://dev.openmrs.org/changeset/7904> || OpenMRS Changesets: Changeset [7903]: groovy module: make it so the service/dao impls. compile for burke; as of … <http://dev.openmrs.org/changeset/7903> || OpenMRS Changesets: Changeset [7902]: ncd: removed deadwood entities, their mapping files, and references to … <http://dev.openmrs.org/changeset/7902>
23:33:15 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7905]: groovy module: rollback from the version property addition. <http://dev.openmrs.org/changeset/7905>