| 00:12:13 | <r0bby> Keelhaul: huh |
| 00:12:24 | <Keelhaul> [01:43:28] <@bwolfe> r0bby: since its that easy, I want to add it to trunk! |
| 00:12:43 | <r0bby> annotations on spring controllers |
| 00:12:50 | <r0bby> spring 2.5 added it. |
| 00:13:20 | <Keelhaul> oh |
| 00:13:26 | <Keelhaul> can you show an example? |
| 00:15:23 | <bwolfe> Keelhaul: see dariu's new module |
| 00:15:32 | <Keelhaul> htmlformentry? |
| 00:15:35 | <Keelhaul> or does he ahve a newer one |
| 00:15:37 | <bwolfe> http://dev.openmrs.org/changeset/7525 |
| 00:15:46 | <bwolfe> darius has all kinds of modules. :-p |
| 00:15:59 | <r0bby> darius is insane :) |
| 00:16:11 | <r0bby> I have the honor of indirectly working under him |
| 00:16:39 | <r0bby> it could be a curse in the other direction though |
| 00:17:00 | <r0bby> http://dev.openmrs.org/changeset/7520 |
| 00:17:02 | <r0bby> also that |
| 00:39:07 | *** catechu has joined #openmrs |
| 00:57:50 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7529]: rwandaprimarycarepilot module: added a couple more pages, and a standard ⦠<http://dev.openmrs.org/changeset/7529> || OpenMRS Forum: Re: Sending open MRS HL7 Messages <http://forum.openmrs.org/viewtopic.php?f=10&t=440#p1540> || OpenMRS Changesets: Changeset [7528]: Fixed postHl7Controller and jsp to show error message <http://dev.openmrs.org/changeset/7528> |
| 01:07:44 | <Keelhaul> try { |
| 01:07:45 | <Keelhaul> reason = reason.substring(start, end); |
| 01:07:45 | <Keelhaul> editedObs.add(Integer.valueOf(reason)); |
| 01:07:45 | <Keelhaul> } |
| 01:07:58 | <Keelhaul> hmm bwolfe, whats that for |
| 01:08:06 | <Keelhaul> it's in EncounterFormController, for example |
| 01:09:20 | <bwolfe> obs voidReason is in the formated "editedObs: #234" so an obs knows which obs it was related to before it was voided |
| 01:10:01 | <Keelhaul> bwolfe: i manually voided an obs and it gives me an exception when trying to get an intval |
| 01:11:02 | <Keelhaul> if there's a follow up obs, it doesnt throw it |
| 01:12:41 | <Keelhaul> i guess i should make the controller not try to add anythinh to that bean if getting an integer value wasnt succesful |
| 01:12:59 | <Keelhaul> thats in my ProblemFormController |
| 01:13:17 | <Keelhaul> but i could imagine it woudl also happen if somone manually voided an obs that's part of an encounter |
| 01:14:32 | <bwolfe> does your reason not have a space in it ? |
| 01:14:46 | <bwolfe> or a space at the end ? |
| 01:14:53 | <Keelhaul> none at the end |
| 01:14:58 | <Keelhaul> Context.getObsService().voidObs(o, "Automatically voided by ProblemService"); |
| 01:15:27 | <bwolfe> actually, you're right, if no space or with space it still tries to get an integer out of the reason |
| 01:16:09 | <Keelhaul> i guess that code was written assuming there's only one way obs can get voided |
| 01:16:55 | <bwolfe> yeah |
| 01:17:31 | <bwolfe> Keelhaul: will take a ticket/patch for trunk for it :-) |
| 01:17:50 | <Keelhaul> bwolfe: i can think of a way to fix it atm |
| 01:18:00 | <Keelhaul> i'm not a regex fiend |
| 01:18:12 | <bwolfe> can or cannot ? |
| 01:18:19 | <Keelhaul> can't* |
| 01:18:37 | <Keelhaul> if it gets to the integer conversion, it throws an exception |
| 01:18:42 | <Keelhaul> i could just ignore it maybe =) |
| 01:18:54 | <bwolfe> catch the exception and ignore it, yet |
| 01:18:56 | <bwolfe> *yes |
| 01:23:18 | *** atomicturtle1 has left #openmrs |
| 01:26:58 | *** catechu has quit IRC |
| 01:28:01 | *** Mkop has joined #openmrs |
| 01:28:07 | <Keelhaul> bwolfe: seems to work now, i'll write a patch tomorrow |
| 01:28:08 | *** Mkop1 has joined #openmrs |
| 01:28:21 | <Keelhaul> Mkop |
| 01:28:25 | <Keelhaul> it's still saturday! |
| 01:29:18 | <Mkop1> lol |
| 01:29:22 | <Mkop1> it's after sundown |
| 01:29:24 | <Mkop1> so it's OK |
| 01:29:48 | *** Mkop has quit IRC |
| 01:29:51 | *** Mkop1 is now known as Mkop |
| 01:30:02 | *** Mkop1 has joined #openmrs |
| 01:31:29 | <Mkop> huh? why's there Mkop and Mkop1? huh? |
| 01:31:49 | *** Mkop1 has quit IRC |
| 01:31:58 | <Mkop> two instances of xchat were open |
| 01:54:56 | *** nribeka1 has quit IRC |
| 01:58:56 | *** Mkop1 has joined #openmrs |
| 01:59:03 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7530]: uuids: Changed rest of the setRequiredData to save handlers <http://dev.openmrs.org/changeset/7530> |
| 02:14:09 | *** Mkop has quit IRC |
| 02:49:36 | * r0bby sighs |
| 02:49:46 | *** atomicturtle has joined #openmrs |
| 02:57:42 | *** atomicturtle has left #openmrs |
| 03:13:06 | *** bwolfe has quit IRC |
| 04:09:30 | *** ajitlodhi has joined #openmrs |
| 04:10:59 | <Keelhaul> http://www.studiooxmox.com/bilder/terminator_7xl.jpg |
| 04:11:03 | <OpenMRSBot> <http://ln-s.net/3:2_> (at www.studiooxmox.com) |
| 04:11:05 | * Keelhaul wants |
| 04:18:24 | <ajitlodhi> !trivialtickets |
| 04:18:24 | <OpenMRSBot> ajitlodhi: "trivialtickets" --- http://dev.openmrs.org/report/16 |
| 04:29:29 | *** rryan has joined #openmrs |
| 05:14:16 | *** Mkop2 has joined #openmrs |
| 05:19:23 | *** Mkop1 has quit IRC |
| 05:28:27 | <ajitlodhi> can i help solving tickets owned by some body...? |
| 05:37:21 | <r0bby> ajitlodhi: i would talk to the person who owns it |
| 05:37:28 | <r0bby> as to not step on their toes |
| 05:37:33 | <r0bby> see what they did, etc |
| 05:37:37 | <r0bby> who owns it? |
| 05:38:32 | <ajitlodhi> jmiranda |
| 05:38:50 | <r0bby> speak to justin |
| 05:38:55 | <ajitlodhi> how they own the tickets?? |
| 05:39:05 | <r0bby> because he's doing work on it |
| 05:39:19 | <r0bby> http://openmrs.org/wiki/User:jmiranda |
| 05:39:25 | <r0bby> his contact info is there |
| 05:39:25 | <ajitlodhi> so jmiranda is justin.... |
| 05:39:29 | <r0bby> yes :) |
| 05:39:34 | <r0bby> Justin Miranda |
| 05:39:36 | <ajitlodhi> k |
| 05:39:49 | <Keelhaul> yes, miranda is his LAST name =P |
| 05:41:58 | <Keelhaul> gn |
| 05:41:59 | *** Keelhaul has quit IRC |
| 05:42:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7531]: rwandaprimarycarepilot module: Adding login and initial version of the ⦠<http://dev.openmrs.org/changeset/7531> |
| 05:50:21 | *** atomicturtle has joined #openmrs |
| 05:53:26 | <ajitlodhi> Gn |
| 06:08:02 | *** ajitlodhi has quit IRC |
| 08:00:54 | *** Mkop has joined #openmrs |
| 08:17:13 | *** Mkop2 has quit IRC |
| 08:49:42 | *** atomicturtle1 has joined #openmrs |
| 08:49:42 | *** atomicturtle has quit IRC |
| 09:54:17 | *** Mkop has quit IRC |
| 10:27:08 | *** pakon has joined #openmrs |
| 11:04:31 | *** pakon has quit IRC |
| 11:50:07 | *** atomicturtle has joined #openmrs |
| 11:50:07 | *** atomicturtle1 has quit IRC |
| 12:25:01 | *** harshini has joined #openmrs |
| 12:29:47 | *** harshini has quit IRC |
| 13:08:32 | *** atomicturtle has left #openmrs |
| 14:12:09 | *** Keelhaul has joined #openmrs |
| 14:12:09 | *** ChanServ sets mode: +v Keelhaul |
| 14:49:30 | *** atomicturtle1 has joined #openmrs |
| 16:09:27 | *** Mkop has joined #openmrs |
| 16:26:24 | *** Keelhaul has quit IRC |
| 17:22:43 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7532]: rwandaprimarycarepilot module: making things look prettier with buttons <http://dev.openmrs.org/changeset/7532> |
| 17:50:31 | *** atomicturtle1 has quit IRC |
| 17:50:32 | *** atomicturtle has joined #openmrs |
| 17:53:02 | *** atomicturtle has left #openmrs |
| 17:53:09 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7533]: rwandaprimarycarepilot module: made .tag files for button and textInput <http://dev.openmrs.org/changeset/7533> |
| 18:05:28 | *** pakon has joined #openmrs |
| 18:24:47 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7534]: rwandaprimarycarepilot module: cleaned up controllers a bit to pull less ⦠<http://dev.openmrs.org/changeset/7534> |
| 18:42:53 | *** Mkop has quit IRC |
| 19:02:56 | *** bwolfe has joined #openmrs |
| 19:02:56 | *** ChanServ sets mode: +o bwolfe |
| 19:26:56 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7535]: rwandaprimarycarepilot module: Adding login/logout to the header; fixing ⦠<http://dev.openmrs.org/changeset/7535> |
| 19:43:22 | *** andrewaclt has joined #openmrs |
| 19:43:26 | <andrewaclt> Hello. |
| 19:49:21 | <bwolfe> hey andrewaclt |
| 20:06:25 | *** nribeka has joined #openmrs |
| 20:06:28 | *** ChanServ sets mode: +v nribeka |
| 20:12:12 | *** Keelhaul has joined #openmrs |
| 20:12:12 | *** ChanServ sets mode: +v Keelhaul |
| 20:50:24 | *** atomicturtle1 has joined #openmrs |
| 20:58:41 | *** atomicturtle1 has left #openmrs |
| 21:00:23 | *** pakon has quit IRC |
| 21:03:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7536]: Reorganized ShowGraphServlet so that it can be more easily unit ⦠<http://dev.openmrs.org/changeset/7536> |
| 21:35:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7539]: rwandaprimarycarepilot module: fixed logout link. <http://dev.openmrs.org/changeset/7539> || OpenMRS Changesets: Changeset [7538]: global-property-types: Fix a mistake with bad modules <http://dev.openmrs.org/changeset/7538> || OpenMRS Changesets: Changeset [7537]: global-property-types: Some cosmetic improvements of settings.jsp <http://dev.openmrs.org/changeset/7537> |
| 22:39:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7540]: rwandaprimarycarepilot module: added enter-vitals page, and ⦠<http://dev.openmrs.org/changeset/7540> |
| 22:58:28 | <r0bby> bwolfe: does darius ever relax |
| 22:59:15 | <r0bby> he's been coding all weekend |
| 23:00:00 | <r0bby> bwolfe: so yeh from the looks of it, using the annotation driven controllers |
| 23:05:28 | <bwolfe> r0bby: I'm playing with it in trunk now...I can't get it to work |
| 23:05:47 | <r0bby> hrm |
| 23:06:07 | <r0bby> what's the problem w/ it ? |
| 23:13:53 | <bwolfe> its not picking up the mapping |
| 23:14:06 | <bwolfe> I'm just doing it on the databaseChanges jsp page |
| 23:14:13 | <bwolfe> a very simple one |
| 23:17:12 | <r0bby> hrm |
| 23:17:22 | <r0bby> do you have it scanning the right package? |
| 23:17:37 | <r0bby> <context:component-scanbase-package="@MODULE_PACKAGE@.web.controller"/> |
| 23:17:38 | <r0bby> what I have |
| 23:17:54 | <r0bby> I like keeping controllers seperate from service classes |
| 23:18:05 | <r0bby> DWR Service classes; seperate from servlets etc |
| 23:34:55 | *** andrewaclt has quit IRC |
| 23:42:13 | <Keelhaul> heh |
| 23:42:28 | <Keelhaul> can someone explain me in a nutshell what those controller annotations are for? |
| 23:46:04 | <r0bby> Keelhaul: eliminates the need for the XML |
| 23:46:16 | <Keelhaul> moduleApplicationContext? |
| 23:46:24 | <r0bby> well eliminates the need to define each bean |
| 23:46:26 | <r0bby> rather |
| 23:46:30 | <Keelhaul> hmm |
| 23:46:43 | <Keelhaul> what if multiple jsp files want to use the same controller |
| 23:46:44 | <r0bby> you define all spring metadata in the bean itself |
| 23:47:08 | <r0bby> why in god's name would you do that? |
| 23:47:34 | <Keelhaul> one of my modules overrides the jsp page of another module |
| 23:47:41 | <Keelhaul> but uses the same controller |
| 23:47:57 | <Keelhaul> also, PortletController is meant to work with multiple portlets |
| 23:51:03 | <r0bby> heh yeh |
| 23:51:14 | <r0bby> i havent fully learned em yet |
| 23:51:20 | <r0bby> i plan on learing as i go |
