IRC Chat : 2009-04-13 - OpenMRS

00:01:12 *** flyankur has quit IRC
00:20:37 <r0bby> yay i finally grok htmlformentry module's design :)
00:20:42 <r0bby> the piece i need :D
00:59:32 *** sdefabbiakane has quit IRC
01:39:32 *** atomicturtle has joined #openmrs
01:39:57 *** atomicturtle has left #openmrs
01:40:17 *** Keelhaul has quit IRC
01:46:02 *** diegoalvarez has joined #openmrs
01:47:13 *** diegoalvarez has left #openmrs
01:53:30 *** flyankur has joined #openmrs
02:01:13 *** puchuu has quit IRC
02:09:48 *** k_nishant has joined #openmrs
02:30:09 *** bwolfe has quit IRC
02:33:43 *** flyankur has quit IRC
02:39:50 *** isurundt has joined #openmrs
02:52:57 *** jaffoneh has joined #OpenMRS
02:53:05 <jaffoneh> Hello
02:53:22 <jaffoneh> I have applied for a position that was removed from the wanted decision at OpenMRS
02:53:27 <jaffoneh> I changed the application
02:53:36 <jaffoneh> and updated it to apply to a new poisition
02:53:46 <jaffoneh> and just wanted to make sure that OpenMRS are aware of that update
02:55:31 *** vindyani has joined #openmrs
02:58:07 *** vindyani has quit IRC
03:10:04 <r0bby> jaffoneh: it should show in the google soc app
03:46:36 *** djmlog103_ has joined #openmrs
03:47:34 *** isurundt has quit IRC
03:55:42 *** jaffoneh has left #OpenMRS
04:01:27 *** Mkop2 has joined #openmrs
04:25:25 *** Mkop2 has quit IRC
04:25:44 *** Mkop has joined #openmrs
04:35:37 *** greendots has quit IRC
04:43:59 *** djmlog103_ has quit IRC
04:49:10 *** jmiranda has joined #openmrs
04:49:10 *** ChanServ sets mode: +o jmiranda
05:03:57 *** diegoalvarez has joined #openmrs
05:06:06 *** diegoalvarez has quit IRC
05:06:12 *** diegoalvarez has joined #openmrs
05:07:38 <Mkop> hey, jmiranda!
05:07:41 <Mkop> wazzup
05:09:19 *** sunbiz has joined #openmrs
05:09:31 *** ChanServ sets mode: +v sunbiz
05:12:14 <jmiranda> hey Mkop
05:12:25 <jmiranda> not much
05:12:35 <jmiranda> how was your weekend?
05:14:08 <Mkop> good
05:14:18 <Mkop> lots of fun
05:14:52 <Mkop> Monday night: all nighter
05:14:58 <Mkop> Tuesday night: all nighter
05:15:33 <Mkop> Wednesday night: up till about 2:00 at a Passover seder (http://en.wikipedia.org/wiki/Passover_Seder)
05:15:45 <Mkop> Thursday night: up till 3:00 at a Passover seder
05:16:24 <Mkop> Friday nght: prob went to bed around 12 or so after having a Shabbat dinner with 15 people or so
05:16:36 <Mkop> Saturday lunch: had Shabbat lunch with another 12 people or so
05:16:43 <Mkop> today: travel
05:16:50 <Mkop> tomorrow: meeting at 9 frieking am
05:19:00 <jmiranda> Mkop: wow, sounds like a long week
05:19:05 <Mkop> yep
05:19:37 <Mkop> and I was at synagogue every morning
05:19:45 <Mkop> not necessarily on time, but there
05:19:56 <Mkop> I generally have major issues waking up
05:20:25 <jmiranda> in college, who doesn't :)
05:20:32 <sunbiz> :D
05:21:10 <Mkop> some people are worse than others
05:21:18 <r0bby> I hate waking up
05:21:22 <r0bby> this semester i am sooo lucky
05:21:26 <r0bby> I can get up early ifi want
05:21:28 <jmiranda> i think i pulled an all nighter at least 3 times a week
05:21:29 <r0bby> but mostly i dont
05:21:35 <r0bby> I can get up @ 5am or 7am
05:21:39 <jmiranda> and then slept until noon the rest of the days
05:21:41 <Mkop> have you ever had to drop a class required by your major because it was at the wrong time of day?
05:21:48 <r0bby> Mkop: no!
05:21:50 <sunbiz> jmiranda: when do we have the student finalizing meeting ??
05:21:55 <r0bby> you dont drop shit like that
05:21:55 <Mkop> actual all nighters 3 times a week? wow
05:22:00 <r0bby> The course im in right now
05:22:13 <r0bby> If i fail it i have to wait until NEXT spring!
05:22:15 <jmiranda> that's a bit of an exaggeration :)
05:22:20 <jmiranda> i just remember doing it a lot
05:22:49 <Mkop> I had a class in the fall that I was not doing very well in as of the drop date, largely due to the fact that it was at 9am, and i decided I'd rather take it next year than get a bad grade
05:22:51 <r0bby> jmiranda: you went to columbia, have you ever explored the tunnels underneath the CS building (i believe that's where the enterance was)
05:23:19 <jmiranda> r0bby: shhhh!
05:23:29 <r0bby> Everybody knows about those!
05:23:32 <jmiranda> apparently, there were parties there all the time
05:23:44 <r0bby> I had a friend of mine take me down there
05:23:46 <r0bby> it was amazing :)
05:23:54 <jmiranda> i was against "partying" in college, so no i've never been down there
05:23:56 <r0bby> Rapid changes in temperature
05:24:14 <r0bby> jmiranda: ohh you missed out it's amazing down there :)
05:24:22 <Mkop> I'm not much of a partier myself
05:24:32 <r0bby> I didn't party down there; i just walked around :)
05:24:33 <Mkop> I don't do stupid stuff like get drunk and miss class because I'm hung over
05:24:54 <Mkop> instead I do stupid stuff like stay up till 4 am watching stupid stuff on youtube and miss class because I'm asleep
05:24:57 <Mkop> :-)
05:25:03 <r0bby> i believe there is a room where the manhattan project was conceived down there as well :)
05:25:04 <jmiranda> Mkop: i realized my mistake late
05:25:16 <jmiranda> you should party a little
05:25:18 <Mkop> meaning now you are a partier?
05:25:36 <r0bby> Mkop: all work and no play makes r0bby a dull boy!
05:25:36 <Mkop> I'll have a beer occasionally in my room, but not really party
05:25:38 <jmiranda> it's a bit unhealthy what i did :)
05:25:40 <r0bby> it will make michael one too!
05:26:03 <Mkop> to quote bwolfe, "all work and no play gets **** done"
05:26:06 <Mkop> :-)
05:26:17 <r0bby> LOL
05:26:19 *** k_nishant1 has joined #openmrs
05:26:22 <r0bby> That is true
05:26:28 <r0bby> but you need a balance
05:26:58 *** sunbiz has quit IRC
05:27:00 <r0bby> hmm i wonder if i could hit my friend up again and go back down to the tunnels :x
05:27:14 <r0bby> I'll be in the city on saturday for Open Everything
05:27:25 <r0bby> I'll get to meet lh :)
05:27:32 <Mkop> do you need columbia ID to get into the building?
05:27:36 <jmiranda> tell her i said hello
05:27:42 <r0bby> will do :)
05:27:54 <r0bby> I dun remember
05:27:56 <jmiranda> Mkop: nah, columbia is super liberal
05:28:05 <jmiranda> just kidding
05:28:09 <r0bby> I would not go down in the tunnels ALONE
05:28:18 <jmiranda> most libraries and dorms require an ID
05:28:19 <r0bby> the fact it's so easy to get down there is kinda scary...
05:28:37 <jmiranda> everything else is pretty open
05:28:49 <Mkop> in Penn you need ID to get into the dorms or library, or other buildings after hours
05:28:49 <jmiranda> the tunnels are all over campus
05:28:53 <r0bby> this was all like 4 years ago
05:29:12 <r0bby> almost 5 i think
05:29:33 <Mkop> jmiranda: I saw a picture of you on docpaul's blog today
05:29:35 <jmiranda> you could probably go down through the grates over by the physics building
05:29:43 <jmiranda> Mkop: weird
05:29:45 <Mkop> i.e. an old picture that i just noticed today
05:29:55 <r0bby> jmiranda: CS building is easiest
05:29:57 <Mkop> does he have 2 blogs?
05:30:00 <r0bby> I don't think i remember
05:30:01 <jmiranda> oh, the google pic
05:30:13 <jmiranda> with the dinosaur
05:30:18 <r0bby> how to get down there and I wouldn't go alone
05:30:21 <Mkop> http://docpaul.wordpress.com/2007/11/20/gsoc-mentor-summit/
05:30:29 <OpenMRSBot> <http://ln-s.net/3860> (at docpaul.wordpress.com)
05:30:36 <Mkop> dinosaur?
05:30:56 <jmiranda> there's a dinosaur just to our right or left (out of the picture)
05:31:03 <jmiranda> i thought we had one in front of it too
05:31:05 <Mkop> oh
05:31:33 <r0bby> heh
05:31:51 <r0bby> jmiranda: have you guys done any reviews?
05:32:00 <jmiranda> http://maps.google.com/maps/ms?hl=en&ie=UTF8&msa=0&msid=103763259662194171141.00000111b083b28bf007c&ll=37.422747,-122.083318&spn=0.0057,0.011094&z=17
05:32:06 <OpenMRSBot> <http://ln-s.net/3861> (at maps.google.com)
05:32:26 <r0bby> if so, can you say anything about my proposal or do i need to speak to Mike Seaton :x
05:32:30 <jmiranda> click on the "Giant dinosaur skeleton" link
05:32:53 <jmiranda> r0bby: actually we've decided to boycott GSoC this year
05:33:07 <jmiranda> burke just made the call around 8pm tonight
05:33:15 <jmiranda> we'll make an announcement tomorrow
05:33:21 <jmiranda> i'm sorry
05:33:24 <jmiranda> that was not funny
05:33:25 <r0bby> LOL
05:33:29 <r0bby> no it wasn't!
05:33:30 <r0bby> LOL
05:33:36 <Mkop> why? you've gotta come up with a good reason
05:33:54 <r0bby> I believe it's to avoid having a student like me
05:33:57 <jmiranda> all: in case it is not clear (i know how sensitive you all are) ... I WAS JUST KIDDING
05:34:05 <r0bby> I know :)
05:34:18 <r0bby> hmm
05:34:21 <jmiranda> r0bby: that was for anyone else reading the irclogs
05:34:21 <r0bby> you bastard
05:34:34 <r0bby> my friend has been having a hell of a time getting a hold of darius
05:34:43 <r0bby> he took the project i basically gave up
05:34:46 <jmiranda> r0bby: i would discuss with mike
05:35:01 <r0bby> (I was gonna do wysiwyg editor for the html form entry module
05:35:10 <r0bby> then realized, i didn't care too much :(
05:35:28 <r0bby> I'm gutting that module anyways :)
05:35:39 <jmiranda> r0bby: i can only speak for myself ... but this last week was a bad one for me personally, so i haven't reviewed all of my applications yet
05:35:41 <r0bby> so I'll get really intimmate w/ it :)
05:35:55 <jmiranda> darius has about 14 applications, so i assume he's making his way through
05:36:01 <jmiranda> and it was his birthday this weekend
05:36:13 <r0bby> How many apps for the aggregate form entry tool?
05:36:22 <r0bby> :x
05:36:25 <jmiranda> good question
05:36:30 <jmiranda> i haven't looked at that one
05:36:38 <jmiranda> just saw that darius topped the list
05:36:49 <r0bby> I've been working on groovyforms on and off
05:37:32 <r0bby> I've also been trying to grok the htmlformentry module
05:38:28 <Mkop> jmiranda: can you tell me how many apps were there for the ones I applied for, or is that confidential?
05:38:35 <Mkop> active lists and frontlinesms
05:38:45 <r0bby> how many slots did we get also
05:38:45 <r0bby> :x
05:39:15 <r0bby> ok i got dishes to do then bed time so i can function in the am :0)
05:43:54 *** k_nishant has quit IRC
06:22:08 <jmiranda> good night
06:24:05 *** pv78 has joined #openmrs
06:26:54 *** djmlog103_ has joined #openmrs
06:28:00 <r0bby> nini
06:39:38 <Mkop> good night
06:40:24 *** pv78 has quit IRC
06:43:33 *** djmlog103_ has quit IRC
06:49:57 *** Mkop2 has joined #openmrs
07:14:48 *** diegoalvarez has quit IRC
07:19:52 *** k_nishant has joined #openmrs
07:31:28 *** k_nishant1 has quit IRC
07:36:15 *** nathanael has joined #openmrs
07:46:39 *** nathanael has quit IRC
07:47:06 *** pascal` has joined #openmrs
07:48:11 *** nathanael has joined #openmrs
07:52:26 *** pascalmrs has joined #openmrs
07:52:56 *** pascal` has quit IRC
07:53:04 *** pascalmrs is now known as pascal`
08:09:34 *** k_nishant1 has joined #openmrs
08:11:33 *** Mkop2 has quit IRC
08:19:35 *** k_nishant has quit IRC
08:31:58 <Mkop> pascal`: you around?
08:32:16 <pascal`> yup
08:32:44 <Mkop> do you know anything about using DrugUtil?
08:32:56 <Mkop> do you know if I need a call to context or anything like that?
08:33:37 <Mkop> it seems from the javadocs that I replace, for example,
08:34:01 <Mkop> I mean orderutil, not drug util
08:34:10 <pascal`> hmm
08:34:20 <pascal`> unfortunately i have no idea =\
08:34:27 <Mkop> it seems that I replace Context.getOrderService().voidDrugSet(p, drugSetId, voidReason, OrderService.SHOW_CURRENT); with OrderUtil.voidDrugSet(p, drugSetId, voidReason, OrderService.ORDER_STATUS.CURRENT);
08:34:29 <pascal`> i've been working with omrs for a total of 4 days =)
08:34:33 <Mkop> oh, ok
08:34:40 <Mkop> I thought you were around longer than that
08:34:42 <Mkop> sorry
08:34:59 <pascal`> no problem... i'll sure you'll figure it out tho (=
08:35:15 <pascal`> what i would recommend is trying to find a similar customization and seeing what they did there
08:36:00 <Mkop> this isn't really a customization per se
08:36:06 <Mkop> I'm making some changes to the API
08:36:16 <Mkop> I guess I'll check with bwolfe in the morning
08:37:13 <pascal`> that'll work too
08:40:40 <Mkop> thanks for your help anyway
08:42:26 <pascal`> lol
08:42:32 <pascal`> anytime :P
09:36:31 *** k_nishant has joined #openmrs
09:37:33 *** k_nishant1 has quit IRC
10:17:13 *** k_nishant has quit IRC
10:38:07 *** Agnor has joined #openmrs
11:16:26 *** Mkop has left #openmrs
11:31:36 *** james_regen has joined #openmrs
11:31:36 *** ChanServ sets mode: +v james_regen
12:04:55 *** pascal` has quit IRC
12:29:22 *** bwolfe has joined #openmrs
12:29:23 *** ChanServ sets mode: +o bwolfe
13:16:33 *** nathanael has left #openmrs
13:16:38 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #175 (enhancement closed): Firefox Plugin for XSN Download <http://dev.openmrs.org/ticket/175#comment:6>
13:27:50 *** atomicturtle has joined #openmrs
13:30:46 *** atomicturtle has left #openmrs
13:35:56 *** pascal` has joined #openmrs
13:36:45 <pascal`> hi jmiranda
13:39:24 *** upul has joined #openmrs
13:39:24 *** ChanServ sets mode: +v upul
13:40:51 <pascal`> anyone?
13:41:54 *** vindyani has joined #openmrs
13:42:07 <bwolfe> pascal`: jmiranda likes to ignore people :-)
13:42:20 <pascal`> heh, ok
13:42:26 <bwolfe> either that or he just went to get coffee
13:42:53 <pascal`> it's cool, i'm not sure my question for him has an answer
13:43:07 <pascal`> well, i'm pretty sure i'm just missing something, so i'll keep digging
13:44:15 *** isurundt has joined #openmrs
13:47:12 <jmiranda> hey pascal`
13:47:17 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7309]: Added css classes to findObservation portlet to facilitate customization - … <http://dev.openmrs.org/changeset/7309> || OpenMRS Tickets: Ticket #152 (enhancement closed): Firefox: Don't Ask to Change a Password <http://dev.openmrs.org/ticket/152#comment:4>
13:47:27 <jmiranda> just going through my morning routine
13:47:52 <jmiranda> but bwolfe is right, i do like to ignore people
13:48:12 <jmiranda> it gives me a rush
13:48:31 *** ajitlodhi has joined #openmrs
13:53:27 <ajitlodhi> hi jmiranda
13:55:10 *** upul_ has joined #openmrs
13:55:10 *** ChanServ sets mode: +v upul_
13:55:24 <jmiranda> hey ajitlodhi
13:57:08 <isurundt> hi ben
13:57:24 <bwolfe> hey isuru
13:57:36 <isurundt> bwolfe:saw that the ticket #1240 has been closed. :)
13:57:53 <isurundt> bwolfe:thanx for your support in doing that
13:58:21 <bwolfe> thank you for doing it :-)
13:59:37 <isurundt> bwolfe: now i can make a much higher focus on completing the encounter type hierarchy asap. may need your guidance for that too.
14:05:17 *** shyamheartbreakk has joined #openmrs
14:07:59 <pascal`> ok, so i think i have a question...
14:08:30 <pascal`> is it possible to create a data export that will output all the encounters from a certain form for all patients?
14:08:51 <pascal`> i see you can specify first and last encounters, but i don't see how you can get all encounters. is this possible?
14:10:08 <pascal`> this one is actually for jmiranda, since i'm working on a birt report, but if anyone know i'd appreciate some help/advice (=
14:13:26 <bwolfe> pascal`: there is a formdataexport module that might do it. but I think jmiranda wrote that one too
14:13:37 <bwolfe> pascal`: but right now its get last N encounters
14:14:26 <pascal`> well, i need to basically make a report which displays the number of <CONCEPT FROM MY FORM>'s done per provider over a given time period
14:14:54 *** upul has quit IRC
14:15:00 *** upul_ is now known as upul
14:15:11 <pascal`> so, my thinking is extract all the lasts months encounters from the form, along with the concept, and manipulate the data in the report
14:15:48 <pascal`> also, i don't see how to get the last N encounters
14:17:05 <bwolfe> ah, maybe not last N encounters, but last N observations
14:17:44 <pascal`> hmm
14:17:48 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1240 (task closed): Liquibase demo dataset has bad data in program table <http://dev.openmrs.org/ticket/1240#comment:9> || OpenMRS Changesets: Changeset [7310]: Fixing programs/workflows/states in demo data - #1240 Author: isurundt <http://dev.openmrs.org/changeset/7310>
14:19:34 <jmiranda> pascal`: yeah, we're working on an actual visit dataset (within openmrs)
14:19:51 <pascal`> is it not a common thing to want to know how many X encounters were done by a certain provider over a given time?
14:20:04 <pascal`> i.e. Dr X did 55 aids tests last month?
14:20:19 <jmiranda> pascal`: not sure
14:20:29 <bwolfe> pascal`: there is a separate way to get that
14:20:29 <jmiranda> we did a BIRT report like that a few years ago
14:20:39 <bwolfe> look at Data Entry Statistics on the admin page
14:20:44 *** k_nishant has joined #openmrs
14:21:33 <jmiranda> now that I think of it, the form data export won't really help you answer that question
14:21:57 <pascal`> yeah, i've come to that conclusion (=
14:22:04 <jmiranda> actually, i guess it could (i'm just not sure if there's a provider ID in there)
14:22:58 <pascal`> the problem is, you don't seem to be able to get multiple encounters in your resultset
14:22:59 *** nribeka has joined #openmrs
14:22:59 *** ChanServ sets mode: +v nribeka
14:23:23 <jmiranda> take a look at this
14:23:23 <jmiranda> http://svn.openmrs.org/openmrs-contrib/reports/PIH%20-%20Provider%20Summary%20Report/
14:23:25 <OpenMRSBot> <http://ln-s.net/38$H> (at svn.openmrs.org)
14:23:26 <r0bby> bwolfe: how many apps are there for the aggregate form entry tool?
14:23:36 <bwolfe> r0bby: 99.3
14:23:48 <bwolfe> give or take
14:23:48 <jmiranda> WFTY
14:24:34 <r0bby> lol
14:24:36 <jmiranda> sorry, that sounded like you were talking about a radio station
14:24:43 <r0bby> can't get an accurate #
14:24:51 <r0bby> I have a feeling you're bloating your numbers a tad
14:24:53 <jmiranda> i'm sure it's <5
14:25:03 <r0bby> It's a cool project
14:25:19 <jmiranda> but to be safe, definitely <100
14:27:53 * r0bby places his head on the chopping block
14:29:19 <nribeka> chop chop
14:31:16 <pascal`> jmiranda, i see that there is some explicit SQL in the xml souce of the provider summary report you showed me
14:31:36 <pascal`> is this normal? or does this indicate that a data export was possibly NOT used?
14:32:39 <pascal`> ok nvm
14:32:42 <pascal`> seems normal
14:33:32 *** k_nishant has quit IRC
14:33:48 *** shyamheartbreakk has quit IRC
14:35:01 <jmiranda> pascal`: yes we used SQL for that one
14:35:16 <jmiranda> we're currently working on new visit, obs, patient datasets
14:35:33 <jmiranda> encounter should be done in the next month or so
14:35:38 *** k_nishant has joined #openmrs
14:37:48 <jmiranda> pascal`: we won't be doing aggregates on the first pass
14:38:06 <jmiranda> like number of encounters per provider, but you'll easily be able to do that inside BIRT
14:40:10 *** k_nishant has quit IRC
14:43:18 <pascal`> yeah
14:43:37 <pascal`> the logic is actually more complex than that, so quite a bit will have to be done in birt
14:44:00 <pascal`> but i should still be able to design the report to query the database directly without using a predefined data export?
14:44:10 <pascal`> is that acceptable?
14:48:09 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7312]: cohort-definition-refactoring: Add a CohortUtil filter method which takes … <http://dev.openmrs.org/changeset/7312> || OpenMRS Changesets: Changeset [7311]: cohort-definition-refactoring: Fixing todo in unimplemented method to call … <http://dev.openmrs.org/changeset/7311>
14:53:43 <jmiranda> pascal`: sorry for the delay
14:53:46 <jmiranda> yes that is correct
14:53:52 <jmiranda> it will actually be a lot easier
14:53:54 <jmiranda> using SQL
14:54:06 <pascal`> mhm
14:54:20 <jmiranda> what are some other questions you need to answer
14:54:43 <pascal`> that's pretty much it for now
14:54:56 <jmiranda> if you have a bunch, i would just output a big dump of data and do aggregation within BIRT
14:54:58 <pascal`> ... i've just been wasting a lot of time trying to construct the correct data export =\
14:55:12 <pascal`> oh, you mean in terms of reporting.
14:55:18 *** luzhuangwei has joined #openmrs
14:55:29 <jmiranda> if there's only a few, then you can just do each query as a dataset (i.e. select provider_id, count(*) from encounter group by provider_id)
14:55:33 <jmiranda> something like that
14:55:50 <jmiranda> pascal`: sorry bout that :)
14:55:51 <pascal`> yeah, it's all simple enough, now that i know i just need to write the SQL
14:56:14 <jmiranda> pascal`: i'd like you to be a beta user for the new reporting stuff
14:56:17 <jmiranda> you interested?
14:56:28 <jmiranda> that way you can tailor the tools to your needs
14:56:42 <pascal`> i'll have to talk to Carl about that
14:57:10 <pascal`> i'm on two implementations at the moment, so I think the idea is to work with stable releases
14:57:21 <pascal`> i am interested, but i'll have to let you know
14:58:16 <jmiranda> pascal`: sounds good
14:58:58 <bwolfe> that carl, he's always getting in the way :-)
14:59:34 <pascal`> (=
14:59:45 <jmiranda> carl is the best boss ever, right pascal`?
15:00:05 <pascal`> i know this chat room is logged ;P
15:00:09 <jmiranda> :)
15:02:12 <jmiranda> pascal`: are you on skype?
15:02:27 <pascal`> i use google talk
15:02:32 <jmiranda> ok
15:02:44 *** k_nishant has joined #openmrs
15:02:45 <jmiranda> well, feel free to ping me at any time if you have questions about BIRT
15:02:49 <jmiranda> or reporting
15:03:25 <pascal`> thanks, will do
15:03:25 <jmiranda> (1) that will keep you from wasting time on stuff like the encounter dataset
15:03:34 <jmiranda> (2) will help me figure out what it is you guys need over there
15:03:34 <bwolfe> boo on google talk
15:04:04 <pascal`> hmm
15:04:28 <pascal`> i choose not to be an unwilling p2p node, i choose google talk (=
15:04:48 <pascal`> i guess you don't have to think about bandwidth concerns in the states
15:04:54 <bwolfe> boo on your unwillingness to leach and be leached on :-p
15:05:02 <bwolfe> very true
15:05:17 <bwolfe> I don't think about it when I'm in SA either...Chris is there for that :-D
15:06:07 <pascal`> hey, well i'd gladly come work over there and use skype no problem =D
15:06:49 <pascal`> i take it that it isn't a public holiday for you guys today?
15:07:09 <bwolfe> no
15:07:13 <pascal`> it is here, _Family Day_ (=
15:07:15 <bwolfe> it is for you ?
15:07:24 <bwolfe> day after easter is always family day ?
15:07:33 *** vindyani has quit IRC
15:07:35 <pascal`> i think so, yeah
15:07:48 <bwolfe> so is your family working with you...or are you just not celebrating correctly? :-p
15:08:30 <pascal`> my wife is working on her own stuff
15:08:39 <pascal`> it's after 5 tho, so i think i'm gonna call it quits
15:09:42 <pascal`> cya l8rs guys, and thanks for your help
15:09:44 <pascal`> chat tomorrow
15:09:52 *** pascal` has quit IRC
15:12:27 *** isurundt has quit IRC
15:13:28 *** upul_ has joined #openmrs
15:13:28 *** ChanServ sets mode: +v upul_
15:14:40 *** upul has quit IRC
15:14:48 *** upul_ is now known as upul
15:18:14 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1403 (task closed): Javascript messages don't work after initialization filter <http://dev.openmrs.org/ticket/1403#comment:1> || OpenMRS Changesets: Changeset [7314]: Fixing messages in javascript files immediately after initialization … <http://dev.openmrs.org/changeset/7314> || OpenMRS Changesets: Changeset [7313]: indicator branch: Creating initial branch off of … <http://dev.openmrs.org/changeset/7313> || OpenMRS Tickets: Ticket #1403 (task created): Javascript messages don't work after initialization filter <http://dev.openmrs.org/ticket/1403>
15:22:00 *** Mkop has joined #openmrs
15:22:02 *** upul_ has joined #openmrs
15:22:02 *** ChanServ sets mode: +v upul_
15:22:07 *** upul has quit IRC
15:22:13 *** upul_ is now known as upul
15:22:20 *** djazayeri has joined #openmrs
15:22:20 *** ChanServ sets mode: +o djazayeri
15:25:57 <Mkop> bwolfe: another question on what I did last night
15:26:22 <Mkop> in a few places I replaced Context.getOrderService().voidDrugSet(...) with OrderUtil.voidDrugSet(...)
15:26:48 <Mkop> that's what the javadocs said, but it just seems strange that I'm removing a Context call
15:26:49 <bwolfe> ok
15:27:21 <bwolfe> a voidDrugSet call maybe
15:27:40 <bwolfe> but some other ones with Drugs should never have been in the service
15:27:50 *** isurundt has joined #openmrs
15:27:51 *** upul_ has joined #openmrs
15:27:51 *** ChanServ sets mode: +v upul_
15:27:55 *** upul has quit IRC
15:28:08 *** upul_ is now known as upul
15:28:19 <bwolfe> upul: for as cool as wimax is, you should do get disconnected a lot...
15:28:50 <Mkop> bwolfe: huh?
15:28:56 <bwolfe> Mkop: a method called voidDrugSet sounds like it should be modifying the database...I hope OrderUtil isn't calling Context.something
15:29:08 <upul> bwolfe, it's the neighbour's wireless :-)
15:30:18 <Mkop> why shouldn't it be calling Context.something?
15:31:16 <bwolfe> Mkop: I dunno, just seems odd that a util would be doing that...especially if that util method used to be in the service
15:33:55 <Mkop> yes, orderutil is doing stuff from the context
15:34:05 <Mkop> it gets an OrderService, and then uses that to void the orders
15:35:20 <bwolfe> odd
15:35:21 <bwolfe> ok
15:36:05 <Mkop> also, about that private method that I deprecated instead of deleting - I can't delete it, because it is called by the deprecated public methods, and I have no way of converting from an int to an ORDER_STATUS
15:41:42 *** kane77 has joined #openmrs
15:42:48 <Mkop> how do i get a List<Patient> from a Cohort?
15:45:01 <Mkop> bwolfe: ^^
15:46:33 <Mkop> ok, got to run, I'll ttyl
15:46:34 *** Mkop has left #openmrs
15:48:20 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7315]: indicator branch: Initial commit of classes to support Indicator, … <http://dev.openmrs.org/changeset/7315>
16:02:42 *** k_nishant has quit IRC
16:14:36 *** upul has left #openmrs
16:22:24 *** isurundt has quit IRC
16:35:23 <ajitlodhi> ajitlodhi
16:35:58 *** k_nishant has joined #openmrs
16:39:24 *** nribeka is now known as nribeka-home
16:40:16 *** k_nishant has quit IRC
16:42:56 *** k_nishant has joined #openmrs
16:58:42 *** luzhuangwei has quit IRC
17:12:43 *** luzhuangwei has joined #openmrs
17:12:46 *** nribeka-mobile has joined #openmrs
17:15:12 *** nribeka has joined #openmrs
17:15:12 *** ChanServ sets mode: +v nribeka
17:16:13 *** ChanServ sets mode: +v nribeka-mobile
17:16:36 <nribeka> nribeka attack
17:17:05 *** ajitlodhi has quit IRC
17:18:13 *** nribeka-mobile has quit IRC
17:32:56 *** meonkeys_ has joined #openmrs
17:37:04 *** jmiranda has quit IRC
17:38:38 *** meonkeys has quit IRC
17:54:48 *** luzhuangwei has quit IRC
18:00:31 *** bwolfe has quit IRC
18:10:13 *** Mkop has joined #openmrs
18:15:35 *** Mkop has left #openmrs
18:20:34 *** meonkeys_ is now known as meonkeys
18:50:59 *** nribeka1 has joined #openmrs
19:03:47 *** Mkop has joined #openmrs
19:04:21 *** nribeka has quit IRC
19:33:35 *** bwolfe has joined #openmrs
19:33:35 *** ChanServ sets mode: +o bwolfe
19:33:38 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7317]: Fixing compilation errors introduced in [7316]. TODO: make sure the fix I … <http://dev.openmrs.org/changeset/7317> || OpenMRS Changesets: Changeset [7316]: Added BaseOpenmrsData and BaseOpenmrsMetadata markers to some … <http://dev.openmrs.org/changeset/7316> || OpenMRS Tickets: Ticket #1404 (defect created): Infopath Form Entry creates observations with precise concept-names, but these are incorrect <http://dev.openmrs.org/ticket/1404>
19:39:16 <Mkop> hey bwolfe
19:39:21 <Mkop> couple questions
19:39:47 <Mkop> first of all, based on your first comment at http://dev.openmrs.org/ticket/1142#comment:5
19:40:22 <Mkop> do you mean I should add something like: if (includeRetired == true) throw new APIException("You should not include voideds in the search.");
19:41:53 <Mkop> next question: I'm getting a bunch of deprecated warnings from Session.connection() (a hibernate thing)
19:42:05 <Mkop> in the hibernate javadocs it's not marked as deprecated
19:47:46 <Mkop> third question: (this one's not a biggy, I'm just wondering)
19:48:15 <Mkop> why in a bunch of places do we have "some string".equals(somevariable) instead of somevariable.equals("some string")?
19:52:21 <Mkop> bwolfe: ^^
19:56:33 <bwolfe> I'll answer you in reverse order
19:56:34 <bwolfe> :-)
19:56:39 <bwolfe> (just to be difficult)
19:57:16 <bwolfe> "some string".equals(somevariable) protects you against somevariable being null as well. that way you don't have to say (somevariable != null && somevariable.equals("some strnig"))
19:58:16 <bwolfe> pretty sure it should be marked as deprected in hibernate either in the javadoc or with an annotation. I don't know how to do it their new way. if you figure it out, go ahead and create a ticket/patch for it
19:58:21 <bwolfe> yes
19:59:23 <Mkop> ok, thanks
19:59:27 <Mkop> now another one:
19:59:37 <Mkop> what's the relationship between Patients and persons?
20:01:58 <Mkop> bwolfe: in circumstances like this, should i ping you in general?
20:02:26 <bwolfe> probably
20:02:39 <Mkop> I never know whether pinging is helpful or annoying
20:02:42 <bwolfe> because djazayeri would never answer a general question. :-p
20:03:01 <djazayeri> huh? what?
20:03:01 <djazayeri> who?
20:03:18 <bwolfe> james_regen, nribeka-home, and jacobb would also know the answer to your questions, but not sure they watch the room closely for non-pinged questions
20:03:33 <Mkop> "circumstances like this" = where I was just talking to you and you've probably switched to another window but you know there's a possibility I'm gonna respond to what you said
20:03:40 <bwolfe> a Patient is a Person
20:03:58 <bwolfe> ah
20:04:09 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7319]: Fixing failing unit test. Thanks ci.openmrs.org! (Incidentally this passed … <http://dev.openmrs.org/changeset/7319> || OpenMRS Changesets: Changeset [7318]: Adding unit test to ensure fix to TaskDefinition.hbm.xml in [7317] was … <http://dev.openmrs.org/changeset/7318>
20:04:24 <bwolfe> well, there might be that possibility, but there is a good chance I won't look back at the window for 20 mins. :-) so yes, ping me unless I ask a question
20:04:29 <Mkop> ok
20:04:30 <bwolfe> ...or be prepared to wait 20 mins :-)
20:05:24 <Mkop> bwolfe: so how do I convert a List<Patient> to a List<Person>?
20:08:05 <bwolfe> a List<Patient> IS a List<Person>
20:08:14 <bwolfe> (but not vice versa)
20:10:33 <Mkop> so a straight cast should work
20:10:38 <Mkop> it doesn't work without the cast
20:12:01 <Mkop> bwolfe: how do I check for current PatientPrograms using the (... startDate, endDate,...) parameters? set both of those to be today?
20:12:26 <bwolfe> where is it not working without the cast ?
20:12:38 <bwolfe> not sure on the patient programs
20:13:22 <djazayeri> Technically the correct thing to do is: List<? extends Person> personList = patientList;
20:13:27 <djazayeri> that works with no cast.
20:15:32 <djazayeri> Mkop: if you want to see who's in a program today, then yes, it should be (in 1.3 or 1.4) PatientSetService.getPatientsInProgram or getPatientsByProgramAndState with the same date for fromDate and toDate
20:16:23 <djazayeri> alternately you can do something like:
20:16:58 <djazayeri> ProgramStatePatientFilter pf = new ProgramStatePatientFilter();
20:17:02 <djazayeri> pf.setProgram(...);
20:17:10 <djazayeri> pf.setWithinLastDays(1);
20:17:22 <djazayeri> Cohort c = pf.filter(); ...
20:17:59 <Mkop> about the casting thing - in DefaultArdenDataSource.java I have: return Context.getObsService().getObservations(Collections.singletonList((Person)patient), null, Collections.singletonList(concept), null, null, null, null, new Integer(howMany), null, null, null, false);
20:18:02 <djazayeri> actually the last line would be Cohort c = pf.filter(null, new EvaluationContext())
20:19:00 *** greendots has joined #openmrs
20:19:31 <Mkop> djazayeri: I'm trying to find an easy way to work around the deprecated method public Collection<PatientProgram> getCurrentPrograms(Patient patient, Date onDate) throws APIException;
20:19:56 <greendots> hi djazayeri
20:19:58 <Mkop> the javadocs say I should use getPatientPrograms(Patient, Program, Date, Date, Date, Date, boolean) instead
20:20:41 <djazayeri> Mkop: a bit of background...are you working on a logic data source or something?
20:20:53 <djazayeri> And are you talking about the ProgramWorkflowService?
20:20:58 <djazayeri> Hi greendots
20:21:06 <Mkop> I'm working on ticket 1142 which is to get rid of calls to deprecated methods
20:21:19 <Mkop> from the api and webapp
20:21:22 <djazayeri> Gotcha.
20:22:26 <djazayeri> What class/method are you in that's making the deprecated call?
20:23:43 *** Keelhaul has joined #openmrs
20:23:43 *** ChanServ sets mode: +v Keelhaul
20:23:44 <greendots> djazayeri: did you get my email on WYSIWYG html form entry designer?
20:24:01 *** james_regen has quit IRC
20:25:11 <Mkop> djazayeri: this particular call is in PortletController.java
20:28:04 <djazayeri> Mkop: for the call that gets all programs you should be able to just switch to making that call with null for all the extra arguments.
20:28:20 <djazayeri> For the one that gets current programs, you want to do a "new Date()" and pass that to the two.
20:28:25 <djazayeri> to the two date arguments.
20:29:08 <Mkop> ok, that works
20:29:09 <Mkop> thanks
20:29:13 <djazayeri> Although I disagree: I don't think that getCurrentPrograms should be deprecated.
20:29:46 <djazayeri> FYI, while you're in that file, can you please add to the javadoc at the top a comment saying that "patientPrograms" and "patientCurrentPrograms" are added to the model?
20:32:00 <Mkop> in terms of whether it should or shouldn't be deprecated, I'm not one to have an opinion. I'm just following instructions to remove references to the ones that are deprecated. are you gonna take this up with the dev list or something, or should I just continue?
20:32:35 <Mkop> current means that maxEnrollmentDate = today, and minCompletionDate = today, right?
20:34:48 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7320]: Added Handler annotation and spring component scan to read it - #1386 Also … <http://dev.openmrs.org/changeset/7320>
20:35:18 *** ChanServ sets mode: +v nribeka1
20:35:27 *** nribeka1 is now known as nribeka-school
20:35:37 <djazayeri> Yeah, I'll take that up with the list
20:36:32 <Keelhaul> Mkop, djazayeri: what are you up to?
20:37:54 <Mkop> !ticket 1142
20:37:54 <OpenMRSBot> Mkop: Ticket #1142: http://dev.openmrs.org/ticket/1142
20:38:08 <Keelhaul> ah
20:38:55 <Mkop> Keelhaul: how do I convert a Cohort to a List<Patient>
20:39:26 <Keelhaul> uh
20:39:29 <Keelhaul> never looked at cohort
20:39:36 <Keelhaul> doesnt it contain a set of patient ids?
20:40:40 <Mkop> a set of patient ids still isn't the same as a set of patients
20:40:52 <Mkop> :-( I have to add a whole extra line of code. boo hoo
20:40:54 <Keelhaul> nope
20:41:53 <Keelhaul> for(Integer id : cohort.getMemberIds()) patientList.add(patientService.getPatient(id));
20:41:54 <Keelhaul> =P
20:42:39 * Mkop needs a nap
20:42:54 <Mkop> actually, I need to go to sleep for a night
20:43:02 <Mkop> didn't do that last night
20:43:05 <Keelhaul> =o
20:43:05 <Keelhaul> how come
20:43:08 <Mkop> I just kinda forgot
20:43:11 <Keelhaul> lol
20:43:16 <Mkop> oops, is it 6 am?
20:49:40 *** jmiranda has joined #openmrs
20:49:40 *** ChanServ sets mode: +o jmiranda
20:54:55 <Mkop> bwolfe: should I also be fixing the references throughout test, or only in web and api?
21:19:42 *** dfuterman has joined #openmrs
21:21:06 <djazayeri> Mkop: there's a method in PatientSetService like getPatients(Collection<Integer>) or something like that.
21:40:41 *** dfuterman has quit IRC
21:45:59 <bwolfe> Mkop: might as well fix in tests too
21:46:12 <bwolfe> Mkop: because the tests will eventually have to be changed when we delete the deprecated methods
21:46:38 <Keelhaul> does anyone use Checkclipse?
21:48:25 <bwolfe> whats it do?
21:48:36 <Keelhaul> pedantically checks your code for style
21:49:03 <Keelhaul> gives a warning on any missing javadoc tags etc
21:49:18 <Keelhaul> too long method names and bodies
21:49:23 <Keelhaul> but you can customize it
21:49:42 <Keelhaul> which i should do because it doesnt like some things i'd rather keep doing
21:50:20 <Keelhaul> like not using parentheses for one-instruction conditions etc
21:51:02 <Keelhaul> http://www.mvmsoft.de/content/plugins/checkclipse/checkclipse.htm
21:51:06 <OpenMRSBot> <http://ln-s.net/38E4> (at www.mvmsoft.de)
21:54:06 *** k_nishant1 has joined #openmrs
21:54:40 *** k_nishant1 has quit IRC
21:55:00 <Keelhaul> here's another one: http://eclipse-cs.sourceforge.net/
21:57:22 *** Mkop has quit IRC
22:11:38 *** k_nishant has quit IRC
22:23:39 <nribeka-school> checkstyle Keelhaul
22:24:05 <Keelhaul> yea
22:24:14 <Keelhaul> these are eclipse plugins for checkstyle
22:24:29 <nribeka-school> ah ic ic
22:24:36 <nribeka-school> how about jalopy?
22:24:38 <nribeka-school> anyway
22:24:44 <nribeka-school> i'm off home
22:28:04 *** bwolfe has quit IRC
22:28:10 *** nribeka-school has left #openmrs
22:31:01 *** vanmh has joined #openmrs
22:36:31 *** nribeka has joined #openmrs
22:36:31 *** ChanServ sets mode: +v nribeka
22:49:05 *** nribeka-home has quit IRC
22:50:33 *** nribeka has quit IRC
23:14:14 *** Agnor has quit IRC
23:29:05 *** kane77 has quit IRC
23:30:53 *** djazayeri has quit IRC
23:46:59 *** bwolfe has joined #openmrs
23:46:59 *** ChanServ sets mode: +o bwolfe