00:57:04
|
*** Mkop21 has joined #openmrs
|
00:57:04
|
*** Mkop2 has quit IRC
|
00:57:09
|
*** Mkop21 is now known as Mkop2
|
01:00:22
|
*** kane77 has quit IRC
|
02:01:04
|
*** flyankur has joined #openmrs
|
02:20:45
|
*** Keelhaul has quit IRC
|
02:22:14
|
*** ajitlodhi has joined #openmrs
|
02:26:25
|
*** upul has joined #openmrs
|
02:26:25
|
*** ChanServ sets mode: +v upul
|
02:31:14
|
*** sdefabbiakane has joined #openmrs
|
02:37:28
|
*** ajitlodhi has quit IRC
|
02:51:48
|
*** isurundt has joined #openmrs
|
03:09:43
|
*** flyankur has quit IRC
|
03:35:49
|
*** sdefabbiakane has quit IRC
|
03:56:15
|
*** ajitlodhi has joined #openmrs
|
03:58:18
|
*** ajitlodhi has quit IRC
|
04:00:50
|
*** ajitlodhi has joined #openmrs
|
04:01:49
|
*** ajitlodhi has quit IRC
|
04:02:07
|
*** ajitlodhi has joined #openmrs
|
04:07:30
|
*** atomicturtle1 has joined #openmrs
|
04:11:11
|
*** greendots has quit IRC
|
04:58:55
|
<Mkop2> it's too quiet in here
|
05:06:39
|
<upul> Boom! Bang!
|
05:07:07
|
<upul> Sorry I dropped a needle
|
05:10:54
|
<Mkop2> !boom
|
05:10:54
|
<OpenMRSBot> Mkop2: "boom" --- BOOOOOOOMMMMMMMMM!!!!!!!!!!!!
|
05:11:06
|
<Mkop2> this is nuts
|
05:11:25
|
<Mkop2> hmmm
|
05:11:36
|
<Mkop2> I thought I had an inordinate amount of spam this months
|
05:11:38
|
<Mkop2> month*
|
05:11:48
|
<Mkop2> but no, gmail just isn't deleting my old spam, for some reason
|
05:12:02
|
<Mkop2> it's April 7, and my spam from March 3 is still sitting there
|
05:12:04
|
<Mkop2> strange
|
05:12:50
|
*** ajay_chhatwal has joined #openmrs
|
05:14:46
|
*** ajay_chhatwal has quit IRC
|
05:48:24
|
*** atomicturtle1 has quit IRC
|
05:48:27
|
*** atomicturtle has joined #openmrs
|
06:12:20
|
*** isurundt has quit IRC
|
06:19:21
|
*** ajitlodhi has quit IRC
|
06:21:11
|
*** pascal321 has joined #openmrs
|
06:21:41
|
*** pascal321 is now known as pascal`
|
06:21:44
|
<pascal`> hi
|
06:22:40
|
<upul> hi
|
06:34:41
|
<Mkop2> hi
|
06:34:58
|
<Mkop2> pascal`, you from south africa I take it?
|
06:36:14
|
<pascal`> yup
|
06:40:22
|
<Mkop2> I was born there
|
06:40:28
|
<Mkop2> lived there for the first 4 years of my life
|
06:42:12
|
<pascal`> ok cool
|
06:42:16
|
<pascal`> where do you live now?
|
06:42:51
|
<ajuonline> o.O
|
06:44:04
|
<Mkop2> I go to school in Philadelphia
|
06:44:10
|
<Mkop2> where in SA do you live?
|
06:44:19
|
<Mkop2> my family lives in Denver
|
06:44:25
|
*** openmrs_2531 has joined #openmrs
|
06:44:45
|
*** openmrs_2531 has quit IRC
|
06:47:58
|
<pascal`> i'm from cape town
|
06:51:49
|
<Mkop2> oh, cool
|
06:51:52
|
*** atomicturtle has quit IRC
|
06:51:53
|
<Mkop2> I'm from joburg
|
06:53:08
|
*** atomicturtle has joined #openmrs
|
06:57:01
|
<pascal`> ok
|
06:57:35
|
<pascal`> does everyone get 640 warning building the latest trunk?
|
06:57:45
|
<pascal`> *warning_s_
|
06:58:49
|
<r0bby> yes
|
06:59:11
|
<pascal`> cool, thanks
|
07:30:01
|
<pascal`> hmm
|
07:31:24
|
<pascal`> anyone else seen a permgen space out of memory error?
|
07:31:42
|
<pascal`> bad class loading memory management?
|
07:38:16
|
<upul> pascal`: restart tomcat
|
07:38:27
|
<pascal`> yes
|
07:38:36
|
<upul> pascal`: still you get it?
|
07:38:43
|
<pascal`> was just wondering where it was a known openmrs leak
|
07:38:55
|
<pascal`> but it seems there is a lot of debate about who is to blame
|
07:38:56
|
<upul> it's a tomcat issue
|
07:39:17
|
<pascal`> well, it seems at least that it isn't an openmrs issue
|
07:39:28
|
<pascal`> restarting fixed it tho, as expected
|
07:40:07
|
<upul> !oom
|
07:40:07
|
<OpenMRSBot> upul: "oom" --- (#1) Tomcat's memory management sucks. Increase your memory available to tomcat. See http://openmrs.org/wiki/Out_Of_Memory_Errors, or (#2) moo backwards
|
07:40:48
|
<pascal`> cool =)
|
07:41:31
|
<pascal`> anyone on a debian/ubuntu distro should try: apt-get moo
|
07:42:16
|
<Mkop2> lol
|
07:42:36
|
<Mkop2> geeks are so strange
|
07:42:55
|
<pascal`> you try it?
|
07:43:27
|
<Mkop2> yep
|
07:43:48
|
<pascal`> try: aptitude -v
|
07:43:50
|
<upul> yep
|
07:46:23
|
<pascal`> actually: aptitude -v moo
|
07:46:34
|
<pascal`> then: aptitude -v -v moo
|
07:46:38
|
<pascal`> and so on
|
07:46:38
|
<Mkop2> they also have a minesweeper game in aptitude
|
07:47:15
|
<upul> minesweeper doesn't work for me, it dies
|
07:47:37
|
<Mkop2> really? oh well
|
07:48:55
|
<upul> nice one pascal`
|
07:49:07
|
<pascal`> (=
|
07:52:53
|
<Mkop2> minesweeper didn't really work for me either
|
07:52:55
|
<Mkop2> I kept losing
|
07:53:06
|
<Mkop2> on the easy level
|
07:53:09
|
<Mkop2> because it's 4 am
|
07:54:10
|
<upul> how many hours do you usually sleep Mkop2 ?
|
07:54:25
|
<Mkop2> I sleep a fair amount
|
07:54:29
|
<Mkop2> prob 7 hours
|
07:54:39
|
<Mkop2> I'm on a flight tomorrow morning at 7am
|
07:54:51
|
<Mkop2> 7:30am*
|
08:01:29
|
<pascal`> is the lastest database update script somewhere in the trunk?
|
08:01:59
|
<upul> if you are using the trunk version, then database update happens when you deploy the build
|
08:02:21
|
<upul> no need to run any sql scripts
|
08:03:02
|
<upul> implementors page has instructions for the released version which do need scripts
|
08:05:53
|
*** ajitlodhi has joined #openmrs
|
08:07:22
|
*** gowri has joined #openmrs
|
08:08:53
|
*** ajitlodhi has quit IRC
|
08:15:31
|
*** gowri has left #openmrs
|
08:17:06
|
<pascal`> hmm
|
08:17:19
|
<pascal`> i used ant install, but i dont think that updated the db
|
08:19:18
|
<upul> no when the war file gets deployed it does that
|
08:19:43
|
<pascal`> well, then something isn't right
|
08:20:18
|
<pascal`> my database version property is 1.3.3.0
|
08:20:47
|
<upul> are you following this guide http://openmrs.org/wiki/Step-by-Step_Installation_for_Developers
|
08:20:48
|
<OpenMRSBot> <http://ln-s.net/1iOR> (at openmrs.org)
|
08:20:50
|
*** pakon has joined #openmrs
|
08:24:03
|
<pascal`> yeah
|
08:25:33
|
<upul> you can let the openmrs.war do the database building by not creating a openmrs runtime properties file
|
08:25:50
|
<pascal`> oic
|
08:25:54
|
<upul> i think you already created the database and properties file before starting openmrs
|
08:26:05
|
<pascal`> so the default runtime properties are to mod the DB?
|
08:26:24
|
<pascal`> surely i can just uncomment that setting in my current runtime file?
|
08:26:53
|
<upul> i mean, when you don't have a runtime properties file, it will think it is a fresh install, and show a wizard which will create everything
|
08:27:34
|
<upul> this inline database update works only if the databse is already upgraded to a specific verions, i think 1.4 something
|
08:28:01
|
<upul> ones older than that you have to manually upgrade using the install scripts before, new auto update can work
|
08:29:42
|
<upul> if you are just trying out openmrs trunk, just remove the runtime properties file in the .OpenMRS and start
|
08:30:23
|
<pascal`> ok, i'll try. thanks!
|
08:30:35
|
<upul> if you have created the database and database user if would be simpler to remove them and let the wizard creat it for you
|
08:31:01
|
<pascal`> well
|
08:31:05
|
<pascal`> its see what happens
|
08:31:09
|
<pascal`> *lets
|
08:35:21
|
*** konnikov has joined #openmrs
|
08:39:52
|
<pascal`> cool
|
08:40:03
|
<pascal`> looks like just renaming the runtime properties file worked
|
08:40:21
|
<pascal`> now i get the install wizard =)
|
08:44:07
|
*** pakon has quit IRC
|
08:49:13
|
*** k_nishant has joined #openmrs
|
09:04:53
|
*** konnikov has quit IRC
|
09:45:16
|
*** isurundt has joined #openmrs
|
09:53:21
|
*** atomicturtle1 has joined #openmrs
|
09:53:21
|
*** atomicturtle has quit IRC
|
09:54:24
|
*** Mkop2 has quit IRC
|
10:02:52
|
*** flyankur has joined #openmrs
|
10:13:29
|
*** isurundt has quit IRC
|
10:37:11
|
*** k_nishant1 has joined #openmrs
|
10:39:33
|
*** k_nishant1 has quit IRC
|
10:40:07
|
*** k_nishant1 has joined #openmrs
|
10:43:24
|
*** puchuu has joined #openmrs
|
10:46:25
|
*** kane77 has joined #openmrs
|
10:47:17
|
*** k_nishant1 has quit IRC
|
10:52:14
|
*** k_nishant has quit IRC
|
10:53:18
|
*** flyankur has quit IRC
|
11:15:56
|
*** puchuu has quit IRC
|
11:26:58
|
<pascal`> o.O
|
11:29:15
|
*** upul has quit IRC
|
11:40:03
|
*** james_regen has joined #openmrs
|
11:40:04
|
*** ChanServ sets mode: +v james_regen
|
11:45:18
|
*** atomicturtle1 has left #openmrs
|
11:51:39
|
*** k_nishant has joined #openmrs
|
11:56:45
|
*** dan_w has joined #openmrs
|
12:10:47
|
*** bwolfe has joined #openmrs
|
12:10:47
|
*** ChanServ sets mode: +o bwolfe
|
12:12:26
|
*** k_nishant1 has joined #openmrs
|
12:13:25
|
*** ajitlodhi has joined #openmrs
|
12:30:09
|
*** scottyaz has joined #openmrs
|
12:30:12
|
*** pakon has joined #openmrs
|
12:32:31
|
*** k_nishant has quit IRC
|
12:38:44
|
*** platypnoea has joined #openmrs
|
12:39:10
|
*** scottyaz has quit IRC
|
12:40:56
|
*** scottyaz has joined #openmrs
|
12:41:23
|
*** platypnoea has left #openmrs
|
12:52:56
|
*** atomicturtle has joined #openmrs
|
12:53:03
|
*** atomicturtle has left #openmrs
|
13:08:01
|
*** Keelhaul has joined #openmrs
|
13:08:01
|
*** ChanServ sets mode: +v Keelhaul
|
13:14:42
|
*** greendots has joined #openmrs
|
13:18:50
|
<Keelhaul> bwolfe: what's the desired behavir of someone calls SomethingService.saveSomething(null)?
|
13:18:53
|
<Keelhaul> return null or exception
|
13:20:52
|
<bwolfe> Keelhaul: hmm, I would expect an exception..because thats just a dumb call to make
|
13:21:09
|
<bwolfe> Keelhaul: getSomething(null) is probably the opposite
|
13:21:32
|
<Keelhaul> bwolfe: custom exception or whatever hibernate or whatever hibernate has to say about that call?
|
13:21:41
|
<Keelhaul> err -or whatever hibernate
|
13:22:05
|
<bwolfe> I'm guessing we usually let the error fall through to some sort of NPE
|
13:22:18
|
<bwolfe> but you can throw an APIException or IllegalArgumentException
|
13:22:42
|
*** danielkayiwa has joined #openmrs
|
13:23:04
|
<Keelhaul> ok thx
|
13:28:38
|
*** danielkayiwa has quit IRC
|
13:58:33
|
*** pascal` has quit IRC
|
14:02:47
|
*** greendots has quit IRC
|
14:07:24
|
*** sdefabbiakane has joined #openmrs
|
14:09:29
|
*** scottyaz has quit IRC
|
14:17:53
|
*** Agnor has joined #openmrs
|
14:18:04
|
*** pakon has quit IRC
|
14:22:43
|
*** scottyaz has joined #openmrs
|
14:26:21
|
<Agnor> hi
|
14:26:29
|
<Agnor> bwolfe, are you there?
|
14:27:24
|
<bwolfe> yep
|
14:27:54
|
<Agnor> still about #151, "Fix Messages on User Interface"
|
14:28:04
|
<Agnor> I've thought about creating a new css class
|
14:28:09
|
<Agnor> named required
|
14:28:48
|
<Agnor> and probably adding a new "required" message on message.properties (could be a simple (*) or (required) )
|
14:29:17
|
<Agnor> the new css class could be changing font color to red (although it would probably look ugly)
|
14:29:24
|
<Agnor> or just underline and bold the text
|
14:29:44
|
<Agnor> all this to signal non-null fields
|
14:30:11
|
<Agnor> what do you think about this approach=
|
14:30:12
|
<Agnor> ?
|
14:30:25
|
<bwolfe> sounds like a good plan
|
14:30:34
|
<bwolfe> I agree that red text would be ugly
|
14:30:37
|
<Keelhaul> red heh
|
14:30:39
|
<bwolfe> perhaps just a red star ?
|
14:30:44
|
<Keelhaul> that's what i've been doing
|
14:30:48
|
<Keelhaul> doesnt look too bad imo
|
14:31:41
|
<Agnor> Keelhaul, are you talking about the required messages after submitting null values?
|
14:31:53
|
<Keelhaul> nah
|
14:31:58
|
<Keelhaul> just coloring the required ones red
|
14:32:06
|
<Keelhaul> but not based on the data model
|
14:33:18
|
<Agnor> are you working on it, or there are already some of that on the svn trunk?
|
14:33:44
|
<Keelhaul> nah
|
14:33:49
|
<Keelhaul> not thati know off
|
14:34:18
|
<Keelhaul> in fact, i'm not sure how to find out whether a member is required or not in the data model =/
|
14:34:57
|
<Agnor> I was using the hibernate xmls to check on that
|
14:35:25
|
<Keelhaul> are you checking the xmls manually or are there hibernate methods for that?
|
14:35:31
|
<Agnor> but it's somewhat confusing
|
14:35:36
|
<Agnor> manually :)
|
14:35:47
|
<Agnor> I don't
|
14:35:55
|
<Agnor> know hibernate...
|
14:36:18
|
<Agnor> but the xml files are understandable
|
14:36:54
|
<Keelhaul> i like the css class idea
|
14:37:19
|
<Agnor> it would add more flexibility
|
14:37:24
|
<Keelhaul> yea
|
14:38:10
|
<Agnor> i think something like <span class = "required"><spring:message="Required"/></span> would be good
|
14:38:18
|
<Keelhaul> so oyu could so something like <td <c:if test="${something that identifies this field as required}">class="required"</c:if><input...
|
14:38:36
|
<Keelhaul> +>
|
14:38:51
|
<Agnor> I'll try to find something about it
|
14:39:42
|
<Keelhaul> i wouldnt add a message to every field
|
14:39:49
|
<Keelhaul> just mark them somehow
|
14:39:51
|
<Keelhaul> like red
|
14:40:10
|
<Keelhaul> and at the end of the form you could say something like "red = required"
|
14:40:22
|
<Agnor> yes I was thinking about that
|
14:40:34
|
<Agnor> but I don't remember much interfaces that do that
|
14:40:40
|
<Agnor> they mostly use *
|
14:40:43
|
<Keelhaul> yea
|
14:40:47
|
<Keelhaul> well maybe
|
14:40:55
|
<Agnor> and the required message could be a *
|
14:40:57
|
<Keelhaul> i'm using * for other purposes sometimes
|
14:41:01
|
<Keelhaul> so i'd have to change that =P
|
14:42:02
|
<Keelhaul> http://keelhaul.homeip.net/misc/red.png
|
14:42:42
|
<bwolfe> Keelhaul: yeah, you should use a + or something
|
14:42:48
|
<bwolfe> I don't like the red
|
14:42:55
|
<bwolfe> and just bold won't work
|
14:43:12
|
<bwolfe> perhaps underline as Agnor suggested is the one to do first
|
14:43:16
|
<Keelhaul> all <th> text is bold already, isnt it
|
14:43:30
|
<bwolfe> right, thats why it won't work
|
14:43:57
|
<bwolfe> if a dev can just add <td class="required">Patient</td><td><input...</td>...
|
14:44:20
|
<bwolfe> it would be better than them having to put in the spring:message code="required" stuff
|
14:44:29
|
<Keelhaul> yea
|
14:44:37
|
<Agnor> ok
|
14:44:42
|
<Agnor> makes sense :)
|
14:45:44
|
<Keelhaul> bwolfe: what should i use a + for?
|
14:46:14
|
<bwolfe> Keelhaul: instead of a *
|
14:46:20
|
<Keelhaul> ok
|
14:46:33
|
<Agnor> btw, when I use ant update, should I first stop the tomcat server?
|
14:46:46
|
<bwolfe> no
|
14:46:59
|
<Agnor> I've had some problems while using update and had to manually restart the tomcat server...
|
14:47:05
|
<Keelhaul> hmm
|
14:47:09
|
<Keelhaul> i never tried ant auto deployment
|
14:47:10
|
<bwolfe> Agnor: if you're just changing jsp/css stuff you should use "deploy-web" instead of "update"....MUCH faster
|
14:47:19
|
<Agnor> thanks
|
14:50:34
|
*** scottyaz has quit IRC
|
14:54:29
|
<Agnor> another build error...
|
14:54:37
|
<Agnor> apparently it cannot copy the test files
|
14:54:48
|
<Agnor> /home/joao/workspace/openmrs-trunk/build.xml:288: Failed to copy /home/joao/workspace/openmrs-trunk/web/test/dojo_test.jsp to /var/lib/tomcat6/webapps/openmrs/test/dojo_test.jsp due to java.io.FileNotFoundException /var/lib/tomcat6/webapps/openmrs/test/dojo_test.jsp (No such file or directory)
|
14:58:50
|
<Keelhaul> bwolfe: if there's a method that returns required fields as strings, maybe it could be used in validators too
|
14:59:38
|
<bwolfe> Agnor: you need write access to the tomcat folders, apprently you do not have that
|
15:00:12
|
<bwolfe> Keelhaul: is there such a method ?
|
15:00:21
|
<Keelhaul> bwolfe: that's what Agnor is working on
|
15:00:32
|
<Agnor> ok bwolfe
|
15:00:38
|
<bwolfe> Keelhaul: he was just going to add the "required" class to every element
|
15:00:46
|
<bwolfe> Keelhaul: I don't think it was any more complicated than that
|
15:00:47
|
<Agnor> probably forgot some chmod on the ubuntu guide
|
15:01:03
|
<Keelhaul> oh =/
|
15:01:03
|
<Keelhaul> heh
|
15:01:10
|
<Keelhaul> thats what you meant by "checking" heh
|
15:01:17
|
<Agnor> yes
|
15:01:18
|
<Keelhaul> i thought you xml-parse them in code
|
15:01:32
|
<Agnor> it probably would take more time to do that
|
15:01:36
|
<Keelhaul> yep
|
15:02:22
|
<Keelhaul> but if someone implemented that, all you'd need to do if the data model changes is change the hbm files
|
15:02:30
|
<Keelhaul> and the forms will adapt
|
15:02:32
|
<Keelhaul> in theory at least
|
15:03:37
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1098 (defect closed): Cannot create a patient with 4 names <http://dev.openmrs.org/ticket/1098#comment:1>
|
15:17:00
|
<sdefabbiakane> bwolfe, for location 946 (location retiring), you said you wanted me to use an interface similar to obsForm--do you want me to keep the text 'retired', or make it 'voided' as it is on ObsForm?
|
15:17:54
|
<bwolfe> sdefabbiakane: keep it as 'retired'.
|
15:18:12
|
<sdefabbiakane> bwolfe: that's what I thought, thanks
|
15:18:38
|
<Keelhaul> sdefabbiakane: data gets voided, metadata retired
|
15:19:04
|
<Keelhaul> 20°C outside
|
15:19:05
|
<sdefabbiakane> yeah, that's what I assumed, but I wanted to double check so I don't have to go make changes again
|
15:19:28
|
*** upul has joined #openmrs
|
15:19:29
|
*** ChanServ sets mode: +v upul
|
15:19:39
|
*** flyankur has joined #openmrs
|
15:26:51
|
<Keelhaul> i hear bomb sirens D=
|
15:26:58
|
<Keelhaul> the allies are coming
|
15:28:47
|
<bwolfe> Keelhaul: thats a very sad joke :-/
|
15:29:06
|
<bwolfe> Keelhaul: are they bomb sirens or weather related ?
|
15:29:55
|
<Keelhaul> why would someone turn on sirens when it's sunny and warm
|
15:30:20
|
<Keelhaul> it's the siren of the local voluntary firefighters i think
|
15:30:28
|
<Keelhaul> but it sounds just like bomb sirens of ye olde
|
15:30:29
|
<bwolfe> those fools
|
15:31:00
|
<bwolfe> probably just gave some old people some bad memories
|
15:31:17
|
<Keelhaul> well this is a village-like suburb
|
15:31:22
|
<Keelhaul> it was never bombed
|
15:31:59
|
<Keelhaul> well the entire town wasnt
|
15:32:18
|
<Keelhaul> i think there was some agreement where the allies wouldnt touch göttingen and the germans wouldnt touch oxford or smt
|
15:33:57
|
<Keelhaul> Nearly untouched by Allied bombing in World War II (the informal understanding during the war was that Germany wouldn't bomb Cambridge and Oxford and the Allies wouldn't bomb Heidelberg and Göttingen), the inner city of Göttingen is now an attractive place to live with many shops, cafes and bars.
|
15:53:52
|
*** atomicturtle has joined #openmrs
|
15:54:58
|
*** atomicturtle has left #openmrs
|
15:59:19
|
<Keelhaul> bwolfe: could it be that the 125 character per line limit doesnt apply to unit test classes?
|
15:59:57
|
<bwolfe> Keelhaul: depends whats in the line
|
16:00:19
|
<Keelhaul> java code
|
16:02:02
|
<bwolfe> heh
|
16:02:06
|
<bwolfe> figured that, thanks :-p
|
16:02:21
|
<bwolfe> could be that its one line string
|
16:02:27
|
<bwolfe> in which case the formatter can't break it up
|
16:03:20
|
<Keelhaul> EncounterService es = (EncounterService) Context
|
16:03:21
|
<Keelhaul> .getService(EncounterService.class);
|
16:03:28
|
<Keelhaul> this would fit on one line in my other classes
|
16:03:58
|
<Keelhaul> none of the code in this class exceeds 80 characters
|
16:06:20
|
*** upul has quit IRC
|
16:06:27
|
*** upul_ has joined #openmrs
|
16:06:27
|
*** ChanServ sets mode: +v upul_
|
16:06:33
|
*** upul_ is now known as upul
|
16:10:53
|
*** ajitlodhi has quit IRC
|
16:11:37
|
<bwolfe> Keelhaul: it was probably formatted before the 125 character formatter was put in
|
16:11:47
|
<bwolfe> you can put it all on one line and try the formatter again
|
16:12:12
|
<Keelhaul> bwolfe: i wrote the code longer than 80 characters, then hit ctrl+f and it made it short
|
16:12:16
|
<Keelhaul> err ctrl-shift-f
|
16:12:41
|
*** danielkayiwa has joined #openmrs
|
16:18:18
|
*** k_nishant1 has quit IRC
|
16:22:12
|
*** flyankur has quit IRC
|
16:23:52
|
*** upul has quit IRC
|
16:24:56
|
*** k_nishant has joined #openmrs
|
16:27:14
|
*** vindyani has joined #openmrs
|
16:35:01
|
*** luzhuangwei has joined #openmrs
|
16:35:08
|
<luzhuangwei> hi,all
|
16:50:01
|
<Keelhaul> hi
|
16:50:25
|
<Keelhaul> bwolfe: it seems like validators wont reject empty boolean fields at all
|
16:50:27
|
<Keelhaul> like voided
|
16:52:47
|
*** vindyani_ has joined #openmrs
|
16:53:49
|
*** ajitlodhi has joined #openmrs
|
16:54:20
|
*** ajitlodhi has quit IRC
|
16:59:55
|
<bwolfe> Keelhaul: is it possible to make them empty ?
|
17:00:11
|
<Keelhaul> bwolfe: the validators checks for value == null
|
17:02:21
|
*** ajitlodhi has joined #openmrs
|
17:02:22
|
<bwolfe> Keelhaul: right, but doesn't "false" get filled in automatically
|
17:02:29
|
<Keelhaul> bwolfe: apparently
|
17:02:40
|
<Keelhaul> i have to set it to null explicitly for the validator to catch it
|
17:06:27
|
<bwolfe> luzhuangwei: I simply moved your code into the openmrs.js file so that we didn't have the duplicated code
|
17:06:30
|
*** vindyani has quit IRC
|
17:06:51
|
<luzhuangwei> yeah, i see just now
|
17:06:55
|
<bwolfe> luzhuangwei: although it doesn't look like the editPersonInfo.jsp file was actually using the stuff
|
17:07:24
|
<luzhuangwei> thanks,I think your modification is very brief,well
|
17:09:40
|
<Keelhaul> bwolfe: ok, test class for OrderValidator is finished
|
17:09:53
|
<Keelhaul> although the check it does in the beginning, whether the entire order object is null
|
17:09:56
|
<Keelhaul> i dont think i can test it
|
17:10:04
|
<Keelhaul> it throws an exception and never gets to do that check
|
17:11:19
|
*** vindyani_ is now known as vindyani
|
17:14:07
|
<bwolfe> Keelhaul: ok, then no worries testing that one
|
17:15:47
|
<luzhuangwei> Ben,do you mean in editPersonInfo.jsp maybe not need to modify birthdate?
|
17:16:29
|
<bwolfe> luzhuangwei: meaning there is no "age" html element that is being updated after the age is calculated
|
17:17:56
|
<luzhuangwei> oh,I know,thank for your comment :-)
|
17:20:41
|
<luzhuangwei> oh,I will off line,bye Ben,bye everyone
|
17:21:23
|
<bwolfe> cya
|
17:22:05
|
*** luzhuangwei has left #openmrs
|
17:23:56
|
*** ajitlodhi has quit IRC
|
17:31:08
|
<Keelhaul> bwolfe: http://rafb.net/p/gRAZXS73.html
|
17:31:26
|
<Keelhaul> it rejects the same field in both cases
|
17:31:32
|
<Keelhaul> should i leave it like that?
|
17:32:21
|
<bwolfe> Keelhaul: if retireReason is null you should say so. so I say "no, don't leave it like that"
|
17:33:44
|
<Keelhaul> that's someone else's code so i thought maybe there's a purpose behind this
|
17:35:56
|
<bwolfe> Keelhaul: if there is a reason, its the wrong reason :-p
|
17:36:01
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: GSoC 09 - Widgets for WYSIWYG HTML form <http://forum.openmrs.org/viewtopic.php?f=11&t=433#p1512>
|
17:58:48
|
<Keelhaul> bwolfe: ok, i wrote unit tests for all existing validators, i think
|
17:58:59
|
<Keelhaul> which arent many
|
17:59:10
|
<bwolfe> Keelhaul: heh, yeah, well, we need more.
|
17:59:15
|
<bwolfe> but tests for the current ones is awesome
|
17:59:22
|
<Keelhaul> there's no ticket for validator tests
|
17:59:41
|
<bwolfe> Keelhaul: there are some validators that are spread out in the /src/web folders and need to be consolidated into /src/api
|
18:02:04
|
<Keelhaul> woah
|
18:02:08
|
<Keelhaul> and those arent few
|
18:06:20
|
*** ankush has joined #openmrs
|
18:06:22
|
<Keelhaul> http://dev.openmrs.org/ticket/1393
|
18:06:31
|
*** ankush has left #openmrs
|
18:06:47
|
<bwolfe> thanks Keelhaul :-)
|
18:07:38
|
<Keelhaul> it is an intro ticket, right?
|
18:07:48
|
<Keelhaul> just need to move them and change their mapping
|
18:09:27
|
<bwolfe> Keelhaul: yep, I agree
|
18:16:28
|
*** danielkayiwa has quit IRC
|
18:19:09
|
*** vindyani has quit IRC
|
18:36:47
|
<sdefabbiakane> bwolfe: I just uploaded a new patch for ticket 946, can you take a look if you have a moment?
|
18:36:52
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7272]: Added versions 1.1 and 1.2 to the valid config file versions -#1193 <http://dev.openmrs.org/changeset/7272> || OpenMRS Tickets: Ticket #1394 (task created): Add unit tests for validators <http://dev.openmrs.org/ticket/1394> || OpenMRS Tickets: Ticket #1393 (task created): Move all validators into the API <http://dev.openmrs.org/ticket/1393>
|
18:37:13
|
<Keelhaul> bwolfe: could you review/add my obs validator patch so i can clean up my trunk a bit? =)
|
18:37:49
|
<bwolfe> man, all these demands and no bribes to help me decide how to prioritize!
|
18:37:59
|
<bwolfe> I guess I'll just go take a walk ;-)
|
18:38:08
|
<sdefabbiakane> :(
|
18:39:37
|
<sdefabbiakane> although a walk does sound nice..it's beautiful out
|
18:39:39
|
<bwolfe> tell you what: I'm pretty easy so I'll give you a hint. Since my name is Benjamin...just drop a Benjamin onto my desk and things will magically happen...
|
18:39:59
|
<Keelhaul> hah
|
18:40:01
|
<Keelhaul> that's a 100, rite?
|
18:40:42
|
<bwolfe> it is
|
18:40:58
|
<bwolfe> 100 dollars is what, 2 euros Keelhaul ? :-p
|
18:41:02
|
<Keelhaul> lol
|
18:41:11
|
<Keelhaul> i wish
|
18:41:26
|
<sdefabbiakane> 75.34 according to google
|
18:43:35
|
*** k_nishant has quit IRC
|
18:53:49
|
*** atomicturtle1 has joined #openmrs
|
18:55:45
|
*** atomicturtle1 has left #openmrs
|
18:59:34
|
*** k_nishant has joined #openmrs
|
19:18:09
|
<sdefabbiakane> bwolfe: figured out why my messages.properties file had so many changes. My eclipse is stripping whitespace when it saves, and all of those places are where there are spaces at the end of the line
|
19:19:11
|
<bwolfe> sdefabbiakane: odd that it is stripping whitespace in yours and not others'
|
19:20:03
|
<sdefabbiakane> bwolfe: yeah. you want me to have it stop doing that or apply the patch/remove all of the extra whitespace?
|
19:21:20
|
<bwolfe> I'd rather leave the properties as they are in svn right now
|
19:21:42
|
<sdefabbiakane> alright. I'll have the new patch up in a moment or three
|
19:28:03
|
<sdefabbiakane> bwolfe: it's up there. I fixed everything you mentioned.
|
19:28:24
|
*** ajitlodhi has joined #openmrs
|
19:28:25
|
<bwolfe> sweet. although that was more like "a moment or four"
|
19:28:30
|
<bwolfe> :-)
|
19:28:33
|
<sdefabbiakane> :)
|
19:30:13
|
*** james_regen has quit IRC
|
19:32:52
|
*** ajitlodhi has quit IRC
|
20:01:24
|
<k_nishant> bwolfe: Are the evaluation completed
|
20:02:05
|
<bwolfe> not that I know of
|
20:02:19
|
<bwolfe> we're planning on discussing things late this week
|
20:02:34
|
<bwolfe> each mentor is tasked with revewing the apps for their project before then
|
20:02:48
|
<Keelhaul> planning on setting up an appointment for discussions =P
|
20:02:48
|
<k_nishant> ok that's fine
|
20:07:32
|
*** kane77 has quit IRC
|
20:44:21
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1395 (defect created): Error on 404 "missing.jsp" page <http://dev.openmrs.org/ticket/1395>
|
20:47:18
|
*** Agnor has quit IRC
|
20:57:15
|
*** greendots has joined #openmrs
|
21:08:31
|
<r0bby> http://www.searchme.com/#/&q=Robert%20O%27Connor%20javaπ=15
|
21:08:33
|
<r0bby> whoa
|
21:08:35
|
<OpenMRSBot> <http://ln-s.net/36qa> (at www.searchme.com)
|
21:22:06
|
*** Keelhaul has quit IRC
|
21:30:14
|
*** openmrs_9586 has joined #openmrs
|
21:30:30
|
<openmrs_9586> does openMRS provide any support for 'infobuttons'?
|
21:38:26
|
*** openmrs_9586 has quit IRC
|
21:48:26
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1395 (defect closed): Error on 404 "missing.jsp" page <http://dev.openmrs.org/ticket/1395#comment:1> || OpenMRS Changesets: Changeset [7273]: Fixed missing.jsp/404 error page to work after changing the api to require ⦠<http://dev.openmrs.org/changeset/7273>
|
22:10:13
|
<bwolfe> whats an infobutton ?
|
22:19:14
|
*** sdefabbiakane has quit IRC
|
22:32:01
|
*** flyankur has joined #openmrs
|
22:47:36
|
<r0bby> ben
|
22:47:55
|
<r0bby> chica defines a JSP (greaseboard.jsp)... what exactly is a greaseboard?
|
22:48:39
|
*** atomicturtle has joined #openmrs
|
22:48:55
|
<r0bby> :x
|
22:48:59
|
<r0bby> been curious
|
22:49:28
|
<bwolfe> its a current patient list
|
22:49:45
|
<r0bby> ah
|
22:49:47
|
<bwolfe> its meant to be displayed on an lcd screen on a wall in a doc's office
|
22:49:55
|
<bwolfe> so that docs can walk by and see important stuff
|
22:50:19
|
<r0bby> i just found a paper on it
|
22:50:20
|
<r0bby> :X
|
22:50:54
|
<r0bby> ugh adobe just hung firefox
|
22:52:31
|
<r0bby> just found a paper on chica
|
22:52:34
|
<r0bby> looks like a cool system
|
22:53:17
|
<r0bby> you even have some papers published holding your name
|
22:53:24
|
<r0bby> as does Justin, Darius, etc
|
22:53:53
|
<bwolfe> yep
|
22:54:03
|
<r0bby> OHH
|
22:54:34
|
<r0bby> it's like tablet LCD
|
22:54:41
|
<r0bby> docs cna just write direct onit
|
22:54:49
|
<r0bby> er crap
|
22:54:55
|
<r0bby> this is what i get for eading fast
|
22:55:24
|
<r0bby> what in god's name is so special about this pdf...it's hanging firefox
|
22:57:04
|
*** atomicturtle has left #openmrs
|
23:02:10
|
*** k_nishant1 has joined #openmrs
|
23:05:25
|
<r0bby> interesting system
|
23:12:02
|
* ajuonline whacks r0bby
|
23:20:08
|
*** k_nishant has quit IRC
|
23:20:13
|
*** dan_w has quit IRC
|
23:21:00
|
*** flyankur has quit IRC
|
23:21:23
|
*** flyankur has joined #openmrs
|
23:23:57
|
*** k_nishant has joined #openmrs
|
23:35:39
|
<r0bby> ajuonline: now now, let's be social!
|
23:36:53
|
<ajuonline> r0bby: :P stop talking to yourself on the channel ;)
|
23:37:55
|
<r0bby> I like talking to myself
|
23:38:02
|
<r0bby> I have the best conversations
|
23:38:09
|
<ajuonline> of course - you are nuts :P
|
23:39:36
|
*** k_nishant1 has quit IRC
|
23:41:53
|
<r0bby> HOT DAM!N
|
23:42:27
|
<r0bby> def sb = new StringBuilder(); if(sb) { println "hai"; } sb << "hai"; if(sb) { println sb }
|
23:42:47
|
<r0bby> first one never enters (groovy truth (it's an empty String)
|
23:42:51
|
<r0bby> second one does :)
|
23:43:20
|
<r0bby> :D
|
23:44:15
|
<r0bby> (This Groovy lesson brought to you by r0bby and the letters G,r,o,o,v and y!
|
23:44:24
|
<greendots> lol
|
23:46:06
|
* r0bby sighs
|