01:38:35
|
*** burke has joined #openmrs
|
01:38:35
|
*** ChanServ sets mode: +o burke
|
01:43:31
|
<r0bby> burke: o/
|
01:43:48
|
<burke> r0bby: o\
|
01:43:50
|
<r0bby> I pulled out all xstream stuff last night :)
|
01:44:24
|
<burke> where'd you put it?
|
01:44:30
|
<r0bby> I got rid of it
|
01:44:33
|
<burke> :)
|
01:44:38
|
<r0bby> I'm storing everything in the db
|
01:44:50
|
<r0bby> including the model, view and controller
|
01:48:33
|
<r0bby> what was my rationale behind doing it the way i was again?
|
01:49:00
|
* r0bby can't even remember
|
01:55:26
|
<burke> one of the goals was to be able to import/export forms easily (as ZIPs or similar) so they could be shared between servers/implementations ... but that doesn't depend on OS vs. DB storage.
|
01:56:46
|
<r0bby> yeh
|
01:59:52
|
<r0bby> Actually, that's still possible.
|
02:00:39
|
* r0bby trying to figure out a dataset :x
|
02:01:46
|
<Echidna> how can you expect to import/export anything as long as concepts arent synced =/
|
02:02:03
|
<r0bby> Echidna: because this doesn't depend on concepts
|
02:02:08
|
<r0bby> the way groovyforms works anyways
|
02:02:50
|
<r0bby> with the current way of having each form hold a reference to a Form object this makes it harder for that goal
|
02:03:39
|
<Echidna> well
|
02:03:48
|
<Echidna> i think that's needed for obs/field pairing
|
02:03:58
|
<r0bby> well
|
02:03:58
|
<Echidna> and encounter/form
|
02:04:03
|
<r0bby> again
|
02:04:23
|
<r0bby> class FooForm { Patient p; Concept weight; }
|
02:04:46
|
<r0bby> That would generate a template and a controller
|
02:05:06
|
<r0bby> the actual form will be nothingf more than a JSP or HTML (can't decide yet)
|
02:05:42
|
<r0bby> originally it was going to be JSP, but i don't feel too comfortable w/ it; HTML forms gave a design idea that i may pull out
|
02:06:20
|
<Echidna> how do you get the corrent concepts then
|
02:06:42
|
<r0bby> that would be implementation specific i see your point
|
02:07:12
|
<Echidna> form fields have a concept mapping
|
02:07:33
|
<Echidna> w/o a form reference, you'd have to map the ids manually
|
02:07:39
|
<Echidna> or via global props etc
|
02:07:51
|
<r0bby> yeh
|
02:08:25
|
<Echidna> btw
|
02:08:28
|
<Echidna> i'm having a problem
|
02:08:33
|
<Echidna> one of my modules adds a form
|
02:08:40
|
<Echidna> another module wants to overwrite the jsp of that form
|
02:08:44
|
<Echidna> but it doesnt work, anymore
|
02:09:00
|
<Echidna> i set the order attribute lower on the overwriting module
|
02:10:38
|
<r0bby> burke: if I associated a Form object with a GroovyForm, does that form have to have mirrored FormFields?
|
02:10:51
|
<r0bby> :x
|
02:12:36
|
<burke> form_field is used to place fields on forms. a field can be used on more than one form.
|
02:13:50
|
<burke> the initial goal of groovy forms was to make a quick-n-dirty way to throw a web-based form together and then script against the API with the data (model) submitted from a form
|
02:14:25
|
<burke> if you want to use form/form_field/field tables, then it gets a little more involved.
|
02:15:20
|
<Echidna> having a form mapped to an encounter helps identify it
|
02:15:25
|
<r0bby> I was hoping it wouldn't have been that much more involved
|
02:16:32
|
* r0bby removes it
|
02:17:09
|
*** Mkop2 has joined #openmrs
|
02:17:24
|
<Mkop2> hi, burke!
|
02:17:36
|
<burke> Mkop2: hey
|
02:17:52
|
<Mkop2> I was thinking a bit more about active lists
|
02:18:16
|
<Mkop2> what if we make listentry a container for obs's, as an alternative to Encounter?
|
02:18:24
|
<Mkop2> I think that's not a good idea
|
02:18:41
|
<Mkop2> because the allergy/diagnosis etc. should still show up in reported Encounter data
|
02:19:22
|
<burke> i think the choice will be b/w (1) do it with obs vs. (2) do it separately
|
02:19:39
|
<Mkop2> oh, we would do it separately entirely?!
|
02:19:43
|
<Mkop2> I hadn't even considered that
|
02:20:09
|
<burke> using obs is nice, 'cause that's what most have been doing thus far and these kinda things should be obs anyway
|
02:20:13
|
<Mkop2> it seems more logical to do obs, and just have certain type of obs persist
|
02:20:55
|
<Echidna> why do not just have a list that contains maps to certain obs, depending on their concept
|
02:21:31
|
<Mkop2> yeah, that's what I mean
|
02:21:46
|
<Echidna> active_list_item_id
|
02:22:00
|
<Mkop2> oh, hmm
|
02:22:06
|
<Echidna> maybe not an item type field
|
02:22:10
|
<Echidna> er
|
02:22:13
|
<Echidna> not = also
|
02:22:14
|
<Mkop2> I was thinking active_list_item_id
|
02:22:25
|
<Echidna> well
|
02:22:30
|
<Echidna> start and end would be two different obs
|
02:23:01
|
<Echidna> actually
|
02:23:07
|
<Echidna> you also need a patient field
|
02:23:08
|
<Echidna> heh
|
02:23:32
|
<Mkop2> obs points to patient
|
02:23:36
|
<Mkop2> doesn't it?
|
02:23:52
|
<Echidna> active_list_item
|
02:23:53
|
<Echidna> well
|
02:23:55
|
<Echidna> yes but
|
02:24:07
|
<Echidna> that would make searching more complex
|
02:24:10
|
<Mkop2> ok, so we'd want that redundancy for efficienty sake
|
02:24:41
|
<Mkop2> item_type = {allergy, diagnosis}?
|
02:24:47
|
<Echidna> yea
|
02:25:01
|
<Echidna> could be a concept
|
02:25:06
|
<Echidna> or another table
|
02:25:09
|
<Echidna> like encounter_type
|
02:26:09
|
*** ajitlodhi has joined #openmrs
|
02:27:17
|
<Mkop2> what graphical tool is there for diagramming this kind of stuff?
|
02:29:16
|
<Echidna> heh dunno
|
02:29:34
|
<Echidna> whatever they used to create that big data model image =)
|
02:30:18
|
<Mkop2> you know what's probably good? MSAccess
|
02:30:36
|
<Mkop2> or any decent db software
|
02:32:14
|
*** upul has joined #openmrs
|
02:32:21
|
*** ChanServ sets mode: +v upul
|
02:32:26
|
<burke> MySQL Workbench
|
02:32:42
|
<burke> ok, kiddies. I gotta go.
|
02:33:05
|
<burke> i'll try to check in tomorrow pm.
|
02:33:32
|
<Mkop2> good night, burke
|
02:33:42
|
*** burke has quit IRC
|
02:43:20
|
*** atomicturtle1 has joined #openmrs
|
02:43:31
|
<r0bby> burke can't leave us!
|
02:52:07
|
*** andrewaclt has quit IRC
|
02:55:21
|
*** puchuu has joined #openmrs
|
02:55:59
|
*** isurundt has joined #openmrs
|
03:14:52
|
*** flyankur has quit IRC
|
03:43:42
|
* Mkop2 is bored
|
03:44:08
|
* Mkop2 is trying to segment heart valves
|
03:56:32
|
* Mkop2 is not succeeding at getting a comment out of anyone, apparently
|
04:00:50
|
*** ajay_chhatwal has joined #openmrs
|
04:06:47
|
<ajay_chhatwal> any GSoC mentors around
|
04:06:49
|
<ajay_chhatwal> ?
|
04:07:12
|
<Mkop2> nope
|
04:07:30
|
<Mkop2> burke was here a bit ago, but he's not here now
|
04:07:37
|
<Mkop2> it's past midnight for him
|
04:07:49
|
<upul> anybody got heart valves?
|
04:07:56
|
<ajay_chhatwal> when are they generally available on IRC?
|
04:10:44
|
<Mkop2> ajay_chhatwal: it depends. It seems like last week they were around more. bwolfe is usually around during the day
|
04:10:52
|
<Mkop2> I assume he'll be around tomorrow
|
04:11:12
|
<upul> most are in indianapolis, http://www.timeanddate.com/worldclock/city.html?n=105
|
04:11:15
|
<OpenMRSBot> <http://ln-s.net/36Nw> (at www.timeanddate.com)
|
04:11:18
|
<Mkop2> upul: yes, I got heart valves. segmented heart valves, though I'm not sure if they're segmented correctly
|
04:11:19
|
<ajay_chhatwal> specifically sunbiz and docpaul
|
04:11:37
|
<Mkop2> sunbiz isn't around much, and docpaul isn't really that much either
|
04:11:52
|
<Mkop2> try email, would be my suggestion
|
04:12:01
|
<ajay_chhatwal> ok...thanks
|
04:12:16
|
<Mkop2> or if you want, email them and ask them when they'll be on IRC or how you can get them on IM
|
04:12:28
|
<ajay_chhatwal> ok
|
04:13:52
|
<Mkop2> upul: if you're wondering, I'm in a class called biomedical image analysis
|
04:14:22
|
<Mkop2> we have a picture of a heart valve, and I'm using an algorithm called Level Sets to separate out the heart valve from the rest of the image
|
04:14:43
|
<upul> did you try photoshop, magic wand :-)
|
04:15:24
|
<Mkop2> magic wand won't work for this kinda thing
|
04:15:38
|
<Mkop2> I think magic wand works only based on intensity
|
04:17:21
|
<upul> what is your major in?
|
04:17:28
|
<Mkop2> bioengineering
|
04:17:38
|
<Mkop2> this class is cross-listed between bioengineering and computer science
|
04:18:05
|
<upul> hmm, field high in demand I've heard
|
04:18:15
|
<Mkop2> that's my hope, at least
|
04:33:57
|
<r0bby> Some mentors are in boston.
|
04:34:38
|
<Mkop2> and one is in WI
|
04:34:49
|
<Mkop2> what's your point?
|
04:35:06
|
<Mkop2> and one is in Kenya
|
04:35:50
|
<upul> i meant most are in indianapolis
|
04:35:56
|
*** greendots has quit IRC
|
04:36:30
|
<Mkop2> that's what you said
|
04:36:45
|
<Mkop2> I'm picking on r0bby, not you :-)
|
04:36:45
|
<upul> sunbiz is in india i think
|
04:36:50
|
<Mkop2> oh he is?
|
04:36:51
|
<Mkop2> ok
|
04:37:32
|
<r0bby> Justin is in WI; Mike Seaton, Darius, and a few others that work for PIH
|
04:37:35
|
<r0bby> in boston
|
04:41:44
|
<upul> i was wrong then, they are in indianapolis and boston
|
04:42:30
|
<upul> same timezone
|
04:42:35
|
<Mkop2> who's in Indianapolis? Ben, Paul, burke, Brian, who else?
|
04:42:57
|
<Mkop2> OpenMRSBot
|
04:43:04
|
<Mkop2> well, actually he's in Oregon
|
04:45:54
|
*** sdefabbiakane has joined #openmrs
|
04:48:27
|
<Mkop2> wazzup sam
|
04:48:43
|
<sdefabbiakane> lots and lots of homework at the moment =/
|
04:48:48
|
<Mkop2> me too
|
04:48:51
|
<Mkop2> I'm in the computer lab right nwo
|
04:48:53
|
<Mkop2> now*
|
04:50:04
|
<upul> Mkop2: are the computer labs open 24 hours?
|
04:50:08
|
<Mkop2> working on biomedical image analysis homework
|
04:50:11
|
<Mkop2> I guess this one is
|
04:50:22
|
<Mkop2> the chemical engineering seniors have a big deadline tomorrow
|
04:50:27
|
<Mkop2> there are 23 people in this computer lab
|
04:53:24
|
<sdefabbiakane> yeah, the 24 hour labs at my school are always pretty well occupied
|
04:54:19
|
<sdefabbiakane> where do you go, Mkop2?
|
04:54:28
|
<Mkop2> Upenn
|
04:54:41
|
<sdefabbiakane> ahh
|
04:54:44
|
<sdefabbiakane> big school
|
04:55:12
|
<Mkop2> where do you go again?
|
04:55:20
|
<sdefabbiakane> wesleyan university
|
04:55:46
|
<Mkop2> how big is wesleyan?
|
04:55:56
|
<sdefabbiakane> 2800 undergrads, about 100 grads
|
04:57:00
|
<Mkop2> and you're undergrad?
|
04:57:30
|
<sdefabbiakane> ya, a sophomore
|
04:58:04
|
<Mkop2> you look young in your facebook pic
|
04:58:20
|
<Mkop2> you look about 15
|
04:58:52
|
<sdefabbiakane> well, I am young, and that picture is like three years old, too
|
04:59:12
|
<sdefabbiakane> actually, I think I was 15 when that was taken. I really need to get a new one
|
04:59:17
|
<Mkop2> lol
|
04:59:20
|
<Mkop2> good guess on my part
|
04:59:41
|
<sdefabbiakane> ya
|
05:02:41
|
<Mkop2> ok, I need to go to sleep!
|
05:02:44
|
<Mkop2> good night!
|
05:02:46
|
*** Mkop2 has quit IRC
|
05:19:19
|
*** sdefabbiakane has quit IRC
|
05:25:55
|
*** ajay_chhatwal has left #openmrs
|
05:27:19
|
*** ajay_chhatwal has joined #openmrs
|
05:31:15
|
<r0bby> heh
|
05:43:45
|
*** ajay_chhatwal has quit IRC
|
05:57:27
|
*** ajay_chhatwal has joined #openmrs
|
06:00:50
|
*** ajay_chhatwal has quit IRC
|
06:06:06
|
*** aargre has joined #openmrs
|
06:10:12
|
*** ajay_chhatwal has joined #openmrs
|
06:39:34
|
*** puchuu has quit IRC
|
07:04:49
|
*** dan_w has joined #openmrs
|
07:06:33
|
*** ajay_chhatwal has quit IRC
|
07:30:29
|
*** scottyaz has joined #openmrs
|
07:38:53
|
*** aargre has quit IRC
|
07:53:05
|
*** ajay_chhatwal has joined #openmrs
|
07:53:20
|
*** ajay_chhatwal has quit IRC
|
07:56:28
|
*** ajay_chhatwal has joined #openmrs
|
08:27:33
|
*** ajay_chhatwal has quit IRC
|
08:41:04
|
*** upul has quit IRC
|
08:41:45
|
*** upul has joined #openmrs
|
08:41:45
|
*** ChanServ sets mode: +v upul
|
10:35:44
|
*** isurundt has left #openmrs
|
10:36:00
|
*** isurundt has joined #openmrs
|
10:54:32
|
*** alaukik has joined #openmrs
|
11:15:09
|
*** alaukik has quit IRC
|
11:18:24
|
*** luzhuangwei has joined #openmrs
|
11:35:05
|
*** upul has quit IRC
|
11:47:27
|
*** james_regen has joined #openmrs
|
11:47:27
|
*** ChanServ sets mode: +v james_regen
|
11:48:43
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: GSoC 09 - Widgets for WYSIWYG HTML form <http://forum.openmrs.org/viewtopic.php?f=11&t=433#p1509>
|
12:14:11
|
*** pascal123 has joined #openmrs
|
12:14:54
|
<pascal123> hi
|
12:16:46
|
*** pascal123 is now known as pascal`
|
12:33:03
|
*** upul has joined #openmrs
|
12:33:03
|
*** ChanServ sets mode: +v upul
|
12:40:30
|
*** flyankur has joined #openmrs
|
12:47:55
|
*** bwolfe has joined #openmrs
|
12:47:55
|
*** ChanServ sets mode: +o bwolfe
|
12:55:37
|
*** k_nishant has joined #openmrs
|
13:04:26
|
<pascal`> hi
|
13:08:41
|
*** sdefabbiakane has joined #openmrs
|
13:10:02
|
*** ajuonline has joined #openmrs
|
13:10:11
|
* ajuonline whacks r0bby
|
13:12:30
|
<pascal`> hah
|
13:13:01
|
*** shyamheartbreakk has joined #openmrs
|
13:30:49
|
<luzhuangwei> hi,bwolfe
|
13:31:25
|
*** vindyani has joined #openmrs
|
13:37:07
|
*** scottyaz has quit IRC
|
13:38:30
|
*** upul has quit IRC
|
13:39:03
|
<bwolfe> hi luzhuangwei
|
13:39:21
|
<pascal`> hey ben
|
13:39:36
|
<bwolfe> hey pascal`
|
13:39:38
|
<pascal`> i made a change to wiki... the step by step for implementers had a bit of a problem
|
13:39:43
|
<bwolfe> first day of work ?
|
13:39:59
|
<pascal`> it linked to an old database creation script which wasn't compatible with the latest .war
|
13:40:04
|
<pascal`> yeah, first day (=
|
13:41:23
|
<luzhuangwei> Can you give a review for my proposal when you are free?thx:-)
|
13:42:11
|
<luzhuangwei> And I have modified my patch for ticket #1346,thanks for your comment
|
13:45:08
|
*** Keelhaul has joined #openmrs
|
13:45:08
|
*** ChanServ sets mode: +v Keelhaul
|
13:45:16
|
<Keelhaul> hi
|
13:45:54
|
*** sdefabbiakane has left #openmrs
|
13:45:56
|
<luzhuangwei> hi
|
13:47:49
|
*** shyamheartbreakk has left #openmrs
|
14:02:07
|
*** atomicturtle1 has left #openmrs
|
14:06:55
|
<bwolfe> luzhuangwei: ok, I added a comment
|
14:07:14
|
<bwolfe> FYI to all applicatants: it appears that you are not automatically notified of any comments we add
|
14:07:20
|
<luzhuangwei> thank you,Ben
|
14:07:27
|
<bwolfe> I would suggest going and looking at your app to make sure a mentor hasn't commented on it
|
14:07:58
|
<luzhuangwei> ok,thanks
|
14:08:17
|
<r0bby> i'm sick :(
|
14:11:12
|
<ajuonline> r0bby: yo! ;)
|
14:11:40
|
<ajuonline> bwolfe: no comments - dont automatically notify studentss. Unless they manually subscribe to updates to their application.
|
14:11:57
|
<bwolfe> ajitlodhi: yeah, I think thats dumb
|
14:12:10
|
<bwolfe> I'm reading through the gsoc mentors list thread about it
|
14:12:23
|
<bwolfe> apparently its been a feature request in the melange bug tracker for a year
|
14:13:05
|
<ajuonline> umm ok. but thats OK. since the "Subscribe to updates" thing is quite visible, when the student tries to see their application.
|
14:19:27
|
<r0bby> ajuonline: yo
|
14:19:30
|
<r0bby> i'm dying
|
14:19:56
|
<r0bby> my next semester is gonna be annoying
|
14:19:59
|
<r0bby> but good :)
|
14:20:12
|
<r0bby> two classes (albeit physics is one of them)
|
14:20:24
|
<r0bby> 8am then 9am :)
|
14:25:23
|
<Keelhaul> classes at 8am is good? =o
|
14:30:23
|
*** pascal` has quit IRC
|
14:31:58
|
<r0bby> i dun mind
|
14:32:07
|
<r0bby> im more awake in the morning than i am mid day
|
14:34:16
|
<Keelhaul> heh
|
14:34:19
|
<Keelhaul> guess i could say the same
|
14:34:24
|
<Keelhaul> i went to bed at 7am today
|
14:34:29
|
<Keelhaul> and got up at 15
|
14:34:38
|
<ajuonline> r0bby: my college ends on april 22, so you know how the situation is with me right now ;)
|
14:35:35
|
<ajuonline> r0bby: so you finally applied?
|
14:37:26
|
<r0bby> ajuonline: Aggregate Data Entry tool :)
|
14:38:29
|
<bwolfe> Keelhaul: you keep the strangest hours. I hope you don't have any roommates
|
14:38:33
|
<r0bby> I figured it's foolish to let last year stop me
|
14:38:34
|
<r0bby> :)
|
14:38:43
|
<r0bby> bwolfe: I had strange hours this weekend
|
14:39:01
|
<r0bby> I went to bed @ 730something on Saturday morning and 830something on Sunday morning :)
|
14:39:56
|
*** flyankur has quit IRC
|
14:41:26
|
<Keelhaul> bwolfe: nah, i live alone
|
14:41:45
|
<Keelhaul> and not having to be somewhere every morning makes my day shift forward all the time
|
14:42:08
|
<Keelhaul> well tbqh, i'm not a morning person anyway
|
14:43:08
|
<Keelhaul> bwolfe: you never answered my question about unit testing validators
|
14:43:27
|
<bwolfe> Keelhaul: I thought I did
|
14:43:45
|
<Keelhaul> bwolfe: nope, you went to bed w/o saying anything =P
|
14:43:47
|
<bwolfe> wasn't your question "do I really have to unit test a one line change?" ?
|
14:43:51
|
<Keelhaul> oh
|
14:43:55
|
<Keelhaul> i asked something afterwards
|
14:44:10
|
<bwolfe> oh, I was probably gone
|
14:44:12
|
<Keelhaul> i cant seem to test the validator via the controller, it goes straight to an api exception
|
14:44:21
|
<Keelhaul> so i'm not sure how to test it
|
14:44:42
|
<bwolfe> Keelhaul: there should be other validator tests already for that obsvalidator
|
14:46:50
|
<r0bby> hah
|
14:46:59
|
<r0bby> Just caught a lovely logic error in my service class
|
14:47:02
|
<r0bby> oooops
|
14:47:12
|
<r0bby> Guess that's what i get for copying it :x
|
14:47:59
|
<Keelhaul> bwolfe: i only see one validator test, for patient identifiers
|
14:51:58
|
<Keelhaul> and that one doesnt seem to be a real validator in the spring sense
|
14:52:23
|
<bwolfe> Keelhaul: sure it is...it implements the spring validator
|
14:52:42
|
<bwolfe> Keelhaul: run your tests against the validate(Object obj, Errors errors) method. don't go through the api
|
14:52:51
|
<Keelhaul> ok
|
14:54:06
|
<Keelhaul> bwolfe: nope, each of them (luhn, verhoeff) implement BaseHyphenatedIdentifierValidator, which implements the IdentifierValidator interface
|
14:54:34
|
<Keelhaul> -implement +extend
|
14:54:50
|
<bwolfe> I was looking at org.openmrs.validator.PatientIdentifierValidator
|
14:59:07
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: GSoC 09 - Widgets for WYSIWYG HTML form <http://forum.openmrs.org/viewtopic.php?f=11&t=433#p1510>
|
15:00:47
|
<Keelhaul> bwolfe: ah ok thx
|
15:05:00
|
<Keelhaul> um lol
|
15:05:01
|
<Keelhaul> if (obs.getPersonId() == null && obs.getPersonId() == null)
|
15:05:45
|
<Keelhaul> obssessive compulsive coding
|
15:05:45
|
<bwolfe> its just an extra precautionary check :-p
|
15:06:02
|
<bwolfe> they forgot the check for "if null == obs.getPersonId()"
|
15:06:13
|
<Keelhaul> did you write that validator?
|
15:07:09
|
<bwolfe> I don't think so
|
15:08:20
|
<Keelhaul> last night i spent an hour trying to find out why one of my modules wouldnt override the url of another module
|
15:08:40
|
<Keelhaul> then i found out i was editing the application context files in Echidna's backup dir instead of my workspace...
|
15:09:09
|
<Keelhaul> the VS2008 xml editor doesnt show the path =/
|
15:11:38
|
*** Mkop2 has joined #openmrs
|
15:16:59
|
*** Mkop21 has joined #openmrs
|
15:16:59
|
*** Mkop2 has quit IRC
|
15:17:04
|
*** Mkop21 is now known as Mkop2
|
15:17:51
|
<Keelhaul> !should
|
15:17:51
|
<OpenMRSBot> Keelhaul: Error: "should" is not a valid command.
|
15:17:56
|
<Keelhaul> !junit
|
15:17:56
|
<OpenMRSBot> Keelhaul: "junit" --- OpenMRS uses unit testing. See http://openmrs.org/wiki/Unit_Testing and http://openmrs.org/wiki/Module_Unit_Testing
|
15:18:08
|
<Mkop2> Keelhaul: http://openmrs.org/wiki/Unit_Testing_with_@should
|
15:18:09
|
<OpenMRSBot> <http://ln-s.net/2UyD> (at openmrs.org)
|
15:18:15
|
<Mkop2> !@should
|
15:18:15
|
<OpenMRSBot> Mkop2: "@should" --- http://openmrs.org/wiki/Unit_Testing_with_%40should
|
15:18:44
|
<Keelhaul> o
|
15:19:00
|
<Mkop2> the wiki needs a table of contents
|
15:20:04
|
<Keelhaul> i think there's a documentation portal
|
15:22:04
|
<Mkop2> yeah, but I don't think it's comprehensive enough
|
15:22:44
|
<Keelhaul> feel free to make it more comprehensive =)
|
15:24:08
|
<Mkop2> yeah, that's the problem with FOSS projects
|
15:24:17
|
<Mkop2> you can never complain about anything :-)
|
15:30:16
|
<Keelhaul> sure you can
|
15:30:37
|
<Keelhaul> someone is usually the "most responsible" person for a particular part
|
15:30:58
|
<Keelhaul> if you can touch their ego by your complaint, they might do something =)
|
15:31:05
|
<Mkop2> lol
|
15:43:33
|
*** vindyani has quit IRC
|
15:54:06
|
*** Mkop2 has quit IRC
|
15:56:20
|
<k_nishant> well the evaluation has started
|
15:58:16
|
<Keelhaul> =)
|
15:58:26
|
<Keelhaul> bwolfe: is there a reason why obs has person and personId?
|
15:59:02
|
<bwolfe> because nonpatient+nonusers can have an obs
|
15:59:16
|
<Keelhaul> oh is
|
15:59:17
|
<Keelhaul> ic*
|
15:59:21
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Open MRS outside data queries <http://forum.openmrs.org/viewtopic.php?f=10&t=434#p1511> || OpenMRS Changesets: Changeset [7264]: uuids: added HibernateSynchronizationInterceptor in order to assign uuids ⦠<http://dev.openmrs.org/changeset/7264>
|
16:07:52
|
<k_nishant> bwolfe: are all evaluations done yet? :-/
|
16:08:04
|
<bwolfe> no
|
16:08:29
|
<k_nishant> hmmm
|
16:08:36
|
* k_nishant waits
|
16:12:35
|
<Keelhaul> bwolfe: um, i need instances of Validator and Errors
|
16:12:43
|
<Keelhaul> i can get the validators from a controller instance, i guess
|
16:12:56
|
<Keelhaul> not sure about Errors
|
16:12:59
|
<bwolfe> new ObsValidator()
|
16:13:08
|
<bwolfe> new BindException(obs, "obs")
|
16:13:38
|
<Keelhaul> ok
|
16:13:53
|
<Keelhaul> where does that constructor come frome?
|
16:13:54
|
<Keelhaul> -e
|
16:14:38
|
<bwolfe> which one ?
|
16:14:45
|
<Keelhaul> validator
|
16:15:13
|
<bwolfe> new ObsValidator() ? its implied
|
16:15:18
|
*** k_nishant has quit IRC
|
16:15:27
|
<bwolfe> if you have no other constructors in the object, then there is a no-arg constructor that you can use
|
16:16:11
|
<Keelhaul> thx
|
16:26:38
|
*** k_nishant has joined #openmrs
|
16:33:01
|
<Keelhaul> bwolfe: well, unfortunately i can only test the valueNumeric datatype error because that's all the xml datafile contains =P
|
16:33:51
|
<bwolfe> Keelhaul: you can just create the obs object manually using setters
|
16:34:01
|
<Keelhaul> i know =/
|
16:34:04
|
<Keelhaul> but that'd look ugly
|
16:34:09
|
<Keelhaul> concepts are huge
|
16:34:10
|
<Keelhaul> =P
|
16:34:27
|
<Keelhaul> would that be better than adding more data to the xml?
|
16:34:36
|
<bwolfe> Keelhaul: ah, you meant concept numerics
|
16:34:41
|
<Keelhaul> yea
|
16:34:44
|
<bwolfe> there should be at least one concept of each data type
|
16:34:48
|
<Keelhaul> there's only one datatype defined in the xml
|
16:34:51
|
<bwolfe> are you looking at the standardDataSet.xml file ?
|
16:34:55
|
<Keelhaul> initial yea
|
16:35:00
|
<Keelhaul> theres also a complex
|
16:35:28
|
<bwolfe> see include/standardTestDataset.xml
|
16:35:33
|
<Keelhaul> bwolfe: no, the obs dataset
|
16:35:38
|
<Keelhaul> is the standard more complete?
|
16:35:41
|
<bwolfe> yes
|
16:35:42
|
*** Mkop2 has joined #openmrs
|
16:35:43
|
<Keelhaul> ah ok
|
16:41:22
|
*** vindyani has joined #openmrs
|
16:41:23
|
*** ajay_chhatwal has joined #openmrs
|
16:42:17
|
<Keelhaul> so
|
16:42:40
|
<Keelhaul> i heard you guys almost have snow in the midwest/east coast
|
16:43:11
|
<bwolfe> yeah, its very sad
|
16:43:21
|
<bwolfe> there were snow flurries. no accumulation though
|
16:44:02
|
<vindyani> hi
|
16:44:04
|
<vindyani> how can we subscribe to interns@openmrs.org mailing list
|
16:44:32
|
<Keelhaul> i hope that doesnt come here
|
16:44:38
|
<Keelhaul> i already put summer wheels on
|
16:44:43
|
<Keelhaul> 17°C atm here
|
16:45:09
|
<ajuonline> r0bby: were you aware of hfoss.org internships?
|
16:45:17
|
<ajuonline> s/were/are
|
16:47:50
|
<bwolfe> vindyani: we enroll interns/students once they are accepted in gsoc/oip
|
16:48:32
|
<vindyani> ok, thanks, I thought we need to get subscribe to it
|
16:51:36
|
*** k_nishant has quit IRC
|
16:58:53
|
<Mkop2> here in Philly we only have light rain
|
16:59:08
|
<Mkop2> didn't realize other places had snow
|
17:01:30
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7265]: uuids: Small updates to the liquibase conversion of the sql update - #1379 <http://dev.openmrs.org/changeset/7265>
|
17:08:32
|
<luzhuangwei> I will go to sleep,Bye,All:-)
|
17:08:41
|
*** luzhuangwei has left #openmrs
|
17:16:55
|
*** andrewaclt has joined #openmrs
|
17:16:59
|
*** isurundt has quit IRC
|
17:17:11
|
*** vindyani has quit IRC
|
17:24:23
|
*** Mkop2 has quit IRC
|
17:27:56
|
<Keelhaul> bwolfe: need your help =(
|
17:27:57
|
<Keelhaul> http://rafb.net/p/Hpc6p995.html
|
17:28:00
|
<Keelhaul> lines 7-9
|
17:28:19
|
<Keelhaul> for some reason the field rejection doesnt get added to errors, at least the test says it's null
|
17:28:34
|
<Keelhaul> Assert.assertFalse(errors.hasFieldErrors("obsDatetime"));
|
17:29:02
|
<bwolfe> don't you want assertTrue ?
|
17:29:04
|
<Keelhaul> err
|
17:29:05
|
<Keelhaul> yes
|
17:29:12
|
<Keelhaul> i pasted from the wrong test lol
|
17:29:20
|
<Keelhaul> Assert.assertTrue(errors.hasFieldErrors("obsDatetime"));
|
17:29:31
|
<bwolfe> maybe you're getting the wrong field ?
|
17:29:33
|
<bwolfe> not sure
|
17:29:44
|
<Keelhaul> the field name is obsDatetime
|
17:29:45
|
<bwolfe> debug it and see what values are filled in in the errors obejct
|
17:33:31
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1346 (task closed): Request: Display actual cause of death if Other Non Coded selected <http://dev.openmrs.org/ticket/1346#comment:5> || OpenMRS Changesets: Changeset [7267]: Adding Cause of Death Other text to dashboard header - #1346 Author: ⦠<http://dev.openmrs.org/changeset/7267> || OpenMRS Changesets: Changeset [7266]: Cleaned up some unit tests and added corresponding @should annotations <http://dev.openmrs.org/changeset/7266>
|
17:47:52
|
*** andrewaclt has quit IRC
|
18:02:57
|
<Keelhaul> bwolfe: found it lol
|
18:03:18
|
<Keelhaul> in my paste, see how the if-block for concept encompasses the date check?
|
18:03:43
|
<bwolfe> Keelhaul: nice
|
18:03:52
|
<bwolfe> Keelhaul: see, unit tests are helpful! ;-)
|
18:03:56
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7268]: Fixed the javascript logic for getting the current age from a date - ⦠<http://dev.openmrs.org/changeset/7268>
|
18:03:56
|
<Keelhaul> lol
|
18:04:02
|
<bwolfe> even if those tests are on one line of code changed
|
18:04:15
|
<Keelhaul> http://rafb.net/p/pYFx9s58.html
|
18:04:16
|
<Keelhaul> there
|
18:04:23
|
<Keelhaul> if that's how you imagined it, i'll make a new patch
|
18:05:32
|
<bwolfe> Keelhaul: yeah, looks good
|
18:06:41
|
<Keelhaul> bwolfe: btw, the old patch didnt contain this error =P
|
18:06:51
|
<Keelhaul> i must have made it when writing tests
|
18:06:55
|
<bwolfe> odd
|
18:07:54
|
<Keelhaul> http://rafb.net/p/aoUFYZ69.html
|
18:07:56
|
<Keelhaul> i know why
|
18:08:16
|
<Keelhaul> i accidently slipped the date check in between the concept checking code
|
18:08:23
|
<Keelhaul> then i saw that today and moved it further down..
|
18:08:35
|
<Keelhaul> which happened to be within the brackets
|
18:15:52
|
*** ankush has joined #openmrs
|
18:16:07
|
*** ankush has left #openmrs
|
18:40:39
|
*** aargre has joined #openmrs
|
18:40:46
|
*** aargre has quit IRC
|
18:41:16
|
*** aargre has joined #openmrs
|
18:46:06
|
<aargre> hello bwolfe burke told me to get in contact with you about trivial or intro tickets
|
18:46:23
|
<bwolfe> to get in contact with me?
|
18:46:37
|
<bwolfe> why did he say it that way ?
|
18:46:42
|
<bwolfe> !trivialtickets
|
18:46:42
|
<OpenMRSBot> bwolfe: "trivialtickets" --- http://dev.openmrs.org/report/16
|
18:46:44
|
<bwolfe> !introtickets
|
18:46:44
|
<OpenMRSBot> bwolfe: "introtickets" --- http://dev.openmrs.org/report/20
|
18:46:58
|
<bwolfe> you can simply pick a ticket a do it. :-)
|
18:48:52
|
<aargre> ok he said you could help me pick one or two not that i need it ...but i figured you might have one more of a priority then others
|
18:49:58
|
<Keelhaul> lol
|
18:53:36
|
<aargre> so i would like to work on #382 how do i make sure no on else is?
|
18:54:03
|
<bwolfe> aargre: you assign yourself to it
|
18:54:15
|
<bwolfe> aargre: but you can't assign yourself to it until we give your username more privileges
|
18:54:20
|
<bwolfe> !ticket 382
|
18:54:20
|
<OpenMRSBot> bwolfe: Ticket #382: http://dev.openmrs.org/ticket/382
|
18:55:18
|
<aargre> ok so I will create a username
|
18:55:25
|
<bwolfe> aargre: so once you register on dev, give me your username and I can do that
|
18:55:45
|
<aargre> ok give me a second then :D
|
18:55:49
|
<bwolfe> aargre: and back to your original question: No, there aren't any that are more of a priority.
|
18:56:05
|
<bwolfe> aargre: and tell burke he's a knucklehead
|
18:56:07
|
<bwolfe> :-p
|
18:56:28
|
<bwolfe> the point of the trivial/intro tickets is for people to just take them and do that...burke should have known that :-)
|
18:57:01
|
<aargre> I think he was just trying to point me in the direction of a friendly face to get the ball rolling
|
18:57:41
|
<Keelhaul> bwolfe: have you seen my location management ticket from a while ago
|
18:57:56
|
<Keelhaul> saying that "manage locations" should get its own group on the admin panel
|
18:58:03
|
<Keelhaul> would that be an intro ticket?
|
18:58:42
|
<Keelhaul> !ticket 1331
|
18:58:42
|
<OpenMRSBot> Keelhaul: Ticket #1331: http://dev.openmrs.org/ticket/1331
|
18:59:34
|
<aargre> ok i have setup my username and it is aargre
|
19:04:39
|
*** ajay_chhatwal has left #openmrs
|
19:07:39
|
<bwolfe> Keelhaul: yeah,
|
19:08:16
|
<bwolfe> aargre: ok, you should have TICKET EDIT privileges now
|
19:08:29
|
<bwolfe> so you can assign a ticket to yourself if you want to work on it
|
19:09:07
|
<aargre> bwolfe: thank you
|
19:09:17
|
<r0bby> ajuonline: no
|
19:11:30
|
<aargre> bwolfe: am i to assume any ticket already assigned to you or somebody is just a placer
|
19:12:27
|
<bwolfe> aargre: if its a trivial/intro ticket, yes
|
19:14:07
|
<aargre> bwolfe: ok can i also assume that you would rather have me talk with you before committing changes
|
19:14:23
|
<bwolfe> aargre: trac uses "Somebody" if owner==null I think
|
19:14:40
|
<bwolfe> aargre: well, you can try to commit changes, but you don't have rights to yet :-p
|
19:14:50
|
<bwolfe> aargre: attach a patch to the ticket and it will be reviewed/applied
|
19:14:52
|
<bwolfe> !patches
|
19:14:52
|
<OpenMRSBot> bwolfe: "patches" --- http://openmrs.org/wiki/Patches
|
19:16:28
|
<aargre> bwolfe: ok thank you very much i have a lot of work ahead of me my build didn't work last night so i have to start over but i am excited to get a start on things
|
19:19:00
|
*** aargre has left #openmrs
|
19:20:05
|
*** kane77 has joined #openmrs
|
19:31:30
|
*** ajitlodhi has quit IRC
|
20:04:00
|
*** greendots has joined #openmrs
|
20:09:53
|
*** Zakaria has joined #openmrs
|
20:17:25
|
*** Agnor has joined #openmrs
|
20:19:34
|
<Agnor> hi
|
20:21:47
|
<bwolfe> hey
|
20:23:22
|
<Agnor> I have a doubt about ticket #151
|
20:23:32
|
<Agnor> "Fix Messages on User Interfaces"
|
20:23:42
|
<bwolfe> !ticket 151
|
20:23:42
|
<OpenMRSBot> bwolfe: Ticket #151: http://dev.openmrs.org/ticket/151
|
20:23:58
|
*** james_regen has quit IRC
|
20:24:07
|
<bwolfe> Agnor: what kind of doubt ?
|
20:24:10
|
<Agnor> essentially would it be a simple replace?
|
20:24:20
|
<Agnor> "Instead of "discription can't be empty", say "A description is mandatory" before they submit as well. "
|
20:25:37
|
<Agnor> However, I can't find that string, I've searched on message.properties, user/alert jsp on view and even on the core API
|
20:26:03
|
<Keelhaul> well you'd have to add it =)
|
20:26:47
|
*** Zakaria has quit IRC
|
20:26:54
|
<bwolfe> Agnor: yeah, that ticket is two-fold. 1) make some of the user interface messages in messages.properties more user-friendly and less technical. 2) Look at the database for different objects to see which are "non-null". then put a note on the edit page for those entries saying "required" or a red dot or something to tell the user that its required
|
20:27:00
|
<Keelhaul> also, to mark items as mandatory before submit, you'd need add a few checks/vars in the controller or so
|
20:27:34
|
<Agnor> thanks
|
20:27:37
|
<Keelhaul> bbl
|
20:27:41
|
*** Keelhaul has quit IRC
|
20:40:22
|
*** Zakaria has joined #openmrs
|
20:40:27
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7269]: uuids: removed Synchronization interfaces <http://dev.openmrs.org/changeset/7269>
|
20:41:25
|
<Zakaria> Hi
|
20:41:38
|
<Zakaria> hi am a student participation in GSoC
|
20:42:05
|
<bwolfe> hi Zakaria
|
20:42:19
|
<Zakaria> Hi bwolfe
|
20:42:46
|
<Zakaria> I sent an application concerning the Longitudinal Data Review module
|
20:45:08
|
<Zakaria> I would like to know if I can discuss this project here ?
|
20:45:28
|
*** Zakaria has quit IRC
|
20:45:31
|
*** Mkop2 has joined #openmrs
|
20:56:24
|
*** Agnor has quit IRC
|
20:56:33
|
<bwolfe> you certainly can discuss it here...but I guess we won't now. :-/
|
20:56:42
|
*** Mkop2 has quit IRC
|
21:02:45
|
*** pakon has joined #openmrs
|
21:04:38
|
*** Mkop2 has joined #openmrs
|
21:11:54
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7271]: --chica * update jsp to address failure to redirect in FireFox * Check if ⦠<http://dev.openmrs.org/changeset/7271> || OpenMRS Changesets: Changeset [7270]: uuids: removed libraries commons-codec and commons-httpclient <http://dev.openmrs.org/changeset/7270>
|
21:23:49
|
<pakon> bwolfe: cool link http://google-opensource.blogspot.com/2009/04/student-applications-for-google-summer.html :)
|
21:23:51
|
<OpenMRSBot> <http://ln-s.net/36_Q> (at google-opensource.blogspot.com)
|
21:24:57
|
<pakon> how can i contact with Dave Thomas? i can't find his email.
|
21:25:40
|
*** bwolfe has quit IRC
|
21:27:10
|
<pakon> bwolfe: respond me when you will be online
|
21:27:14
|
*** pakon has quit IRC
|
21:28:31
|
<greendots> hey mkop
|
21:36:11
|
<Mkop2> hi, greendots
|
21:36:27
|
<Mkop2> if you spell my username right I'll respond quicker generally
|
21:37:49
|
* r0bby spells M-k-o-p-2
|
21:37:53
|
<r0bby> Did it work?
|
21:37:54
|
<r0bby> :)
|
21:38:06
|
<r0bby> did I mention i'm sarcastic?
|
21:53:07
|
* ajuonline whacks r0bby
|
22:00:02
|
* Mkop2 whacks r 0 b b y
|
22:22:56
|
<r0bby> ajuonline: what
|
22:24:34
|
<r0bby> ajuonline: i do think I like doing hfoss coding :)
|
22:24:48
|
*** Mkop2 has quit IRC
|
22:25:02
|
<r0bby> I was attracted to openmrs because it's cause just :)
|
23:08:11
|
*** Keelhaul has joined #openmrs
|
23:08:11
|
*** ChanServ sets mode: +v Keelhaul
|
23:41:01
|
*** Mkop2 has joined #openmrs
|
23:53:32
|
*** dan_w has quit IRC
|