00:08:46
|
*** Keelhaul has joined #openmrs
|
00:08:46
|
*** ChanServ sets mode: +v Keelhaul
|
00:13:56
|
*** bwolfe_away is now known as bwolfe
|
00:15:45
|
<r0bby> bwolfe: welcome back :)
|
00:15:46
|
<bwolfe> r0bby: can you at least do something v1.0 worthy that at least works and gets it into the hands of users ? :-)
|
00:15:48
|
<bwolfe> thanks
|
00:16:01
|
<r0bby> bwolfe: I'll see what I can bang out
|
00:16:09
|
<r0bby> no promises
|
00:16:23
|
<r0bby> I have an exam to prepare for right now though
|
00:17:47
|
<bwolfe> good times
|
00:18:01
|
<r0bby> oh yes
|
00:18:04
|
<r0bby> FUN!
|
00:18:23
|
<r0bby> Oh bwolfe I'm not gonna make it out there
|
00:19:04
|
<bwolfe> :-/
|
00:19:09
|
<Keelhaul> out where
|
00:19:13
|
<r0bby> to indy
|
00:19:22
|
<r0bby> it's gonna wind up costing me more than it's worth
|
00:19:41
|
<Keelhaul> why, where do you live
|
00:19:41
|
* r0bby has ZERO income
|
00:20:25
|
<r0bby> and the whole them paying to get me out there is like yeh that's gonna happen..
|
00:25:18
|
<Keelhaul> heh
|
00:25:31
|
<Keelhaul> bwolfe: you play soccer?
|
00:25:51
|
<bwolfe> indeed
|
00:26:15
|
<Keelhaul> heh nice
|
00:26:27
|
<Keelhaul> i thought people who like football are always like "ew soccer isnt a guy sport!"
|
00:27:05
|
<bwolfe> haha
|
00:27:16
|
<bwolfe> I've played soccer since I was probably 10
|
00:29:04
|
<bwolfe> do you play ?
|
00:29:22
|
<Keelhaul> nah heh
|
00:29:28
|
<Keelhaul> i watch it sometimes..
|
00:29:41
|
<Keelhaul> i've always been rather useless when it comes to ball games
|
00:39:07
|
<Keelhaul> bwolfe: do you have an idea why i hit many lazyinitexceptions when i'm logged in as a non-admin?
|
00:39:33
|
<Keelhaul> especially in my advices
|
00:39:38
|
<Keelhaul> http://rafb.net/p/jRmCQv82.html
|
00:39:49
|
<bwolfe> Keelhaul: but it doesn't happen when you're admin ??
|
00:39:54
|
<Keelhaul> no
|
00:40:09
|
<bwolfe> permissions issue ?
|
00:40:17
|
<bwolfe> is there anything further in your tomcat logs ?
|
00:40:40
|
<Keelhaul> nope
|
00:40:53
|
<Keelhaul> it says line 23 in my advice method
|
00:40:57
|
<Keelhaul> which is
|
00:40:58
|
<Keelhaul> if (Context.getAuthenticatedUser().getAttribute("Location-Restricted") != null
|
00:41:21
|
<bwolfe> or maybe some of it is being loaded by a controller because the admin has more privs ?
|
00:42:01
|
<Keelhaul> well prolly not that line
|
00:42:09
|
<Keelhaul> and the check should happen for every user
|
00:42:23
|
<Keelhaul> unless theres some hidden setting that makes admins bypass all advice
|
00:42:27
|
<Keelhaul> but that wouldnt make sense
|
00:43:46
|
<bwolfe> Keelhaul: no, advice doesn't work that way
|
00:43:57
|
*** nribeka has joined #openmrs
|
00:44:19
|
<bwolfe> Keelhaul: but, for example, the PortletController loads up all kinds of data based on privileges
|
00:44:36
|
<Keelhaul> yea
|
00:44:46
|
<Keelhaul> the page i'm on right now is encounter management
|
00:44:59
|
<Keelhaul> from what i see, it completely ignores the encounterservice advice
|
00:45:08
|
<Keelhaul> and throws an exception when entering the patientserviceadvice
|
00:45:20
|
<Keelhaul> so it displays the encounter but leaves the patient blank in the end
|
00:45:24
|
<Keelhaul> that's not what i had in mind lol
|
00:45:53
|
<Keelhaul> ah
|
00:46:15
|
<Keelhaul> remember how you told me to test whether extended services and handled by advices for base services
|
00:46:20
|
<Keelhaul> apparently they arent
|
00:46:26
|
<Keelhaul> and = are
|
00:47:27
|
<bwolfe> example Keelhaul ?
|
00:47:42
|
<Keelhaul> <advice>
|
00:47:42
|
<Keelhaul> <point>org.openmrs.api.EncounterService</point>
|
00:47:42
|
<Keelhaul> <class>org.openmrs.module.inpatientcare.advice.EncounterServiceAroundAdvice</class>
|
00:47:42
|
<Keelhaul> </advice>
|
00:48:31
|
<Keelhaul> that one doesnt intercept calls to EncounterService extends org.openmrs.EncounterService
|
00:48:34
|
<Keelhaul> it seems
|
00:49:17
|
<bwolfe> hhhhmm
|
00:49:44
|
<Keelhaul> lets see if i can use the same advice class for both
|
00:53:44
|
<Keelhaul> oh great, www doesnt work again
|
00:53:52
|
<Keelhaul> either my router or my isp have been worthless lately
|
00:54:04
|
<Keelhaul> no www = no compiling
|
00:54:14
|
<Keelhaul> unless i remove the dtd uri
|
00:58:24
|
<Keelhaul> ok the advice "works" now
|
00:58:32
|
<Keelhaul> as in fails with the same exception
|
00:59:27
|
*** nribeka1 has quit IRC
|
01:17:04
|
*** Echidna has joined #openmrs
|
01:41:27
|
*** jacobb has quit IRC
|
01:42:21
|
<r0bby> /soc/jo
|
01:42:22
|
<r0bby> er
|
02:03:42
|
<Keelhaul> bwolfe
|
02:03:42
|
<Keelhaul> User me = Context.getUserService().getUser(Context.getAuthenticatedUser().getUserId());
|
02:03:42
|
<Keelhaul> if (me.getAttribute("Location-Restricted") != null && me.getAttribute("Location-Restricted").getValue().equals("1")) {
|
02:03:56
|
<Keelhaul> i have to do this crap all the time now for non-admins =/
|
02:04:08
|
<Keelhaul> you sure nothing changed in hibernate recently besides nribeka's fix?
|
02:04:15
|
<Keelhaul> i'm using a pre-fix jar
|
02:04:48
|
<bwolfe> as opposed to just using the getAuthenticatedUser() object ?
|
02:05:05
|
<bwolfe> thats because that stored object isn't fetching the attributes
|
02:05:10
|
<bwolfe> so its trying to do a lazy load
|
02:05:21
|
<bwolfe> there might have been a change in the mappings that caused it
|
02:05:40
|
<Keelhaul> if you set it to lazy=false, will it still do the magic?
|
02:05:52
|
<bwolfe> perhaps
|
02:06:41
|
<bwolfe> I'm off. gnight
|
02:06:50
|
<Keelhaul> gn
|
02:26:17
|
*** bwolfe has quit IRC
|
02:57:24
|
*** flyankur has quit IRC
|
03:06:20
|
* r0bby => bed();
|
03:08:34
|
<Keelhaul> gn
|
04:25:49
|
*** isurundt has joined #openmrs
|
05:19:31
|
<jmiranda> hey isurundt
|
05:19:45
|
<jmiranda> sorry i missed you earlier
|
05:34:23
|
<Keelhaul> http://vimeo.com/3250732?pg=embed&sec=3250732
|
06:20:17
|
*** Keelhaul has quit IRC
|
06:26:21
|
<isurundt> hi jmiranda
|
06:27:31
|
<jmiranda> hey
|
06:28:20
|
<isurundt> had some problems regarding submitting patches...
|
06:29:21
|
<isurundt> finally was able to sort out them by myself
|
06:29:28
|
<isurundt> :)
|
06:41:28
|
<jmiranda> cool
|
06:41:32
|
<jmiranda> thanks for doing that
|
06:41:32
|
<isurundt> thanx for asking
|
06:44:20
|
<isurundt> btw, have you finalized your GSOC projects list.Im currently working on Encounter Type HIerachy project. Hope to do that as my GSOC project as well
|
07:08:19
|
*** isurundt has quit IRC
|
07:10:24
|
*** isurundt has joined #openmrs
|
07:21:18
|
<jmiranda> isurundt, i don't think we've finalized the list, no
|
07:22:15
|
<jmiranda> we'll probably be ramping up on our coordination for GSoC once we get our application in at the end of this week (i think it's this week?)
|
09:41:01
|
<isurundt> jmiranda: ok .thanks
|
11:03:33
|
*** flyankur has joined #openmrs
|
11:22:54
|
*** james_regen has joined #openmrs
|
11:22:54
|
*** ChanServ sets mode: +v james_regen
|
11:26:15
|
*** Ankur_ has joined #openmrs
|
11:29:42
|
*** Echidna has quit IRC
|
11:36:45
|
*** flyankur has quit IRC
|
11:37:35
|
*** Echidna has joined #openmrs
|
11:48:45
|
*** Ankur_ is now known as flyankur
|
11:50:36
|
*** isurundt has quit IRC
|
12:38:01
|
*** flyankur has quit IRC
|
12:40:46
|
*** flyankur has joined #openmrs
|
12:47:03
|
*** Ankur_ has joined #openmrs
|
12:47:31
|
*** bwolfe has joined #openmrs
|
12:47:31
|
*** ChanServ sets mode: +o bwolfe
|
12:47:46
|
*** flyankur has quit IRC
|
12:50:03
|
*** Ankur_ has quit IRC
|
13:05:45
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Is online demo working? <http://forum.openmrs.org/viewtopic.php?f=11&t=423#p1483>
|
14:19:04
|
*** Keelhaul has joined #openmrs
|
14:19:04
|
*** ChanServ sets mode: +v Keelhaul
|
14:32:11
|
*** flyankur has joined #openmrs
|
14:41:50
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1323 (defect created): Edit this Patient gives error when changing the tribe <http://dev.openmrs.org/ticket/1323> || OpenMRS Forum: Re: Is online demo working? <http://forum.openmrs.org/viewtopic.php?f=11&t=423#p1484> || OpenMRS Tickets: Ticket #1322 (defect created): Found Similar People yields excessive results when adding a new person <http://dev.openmrs.org/ticket/1322>
|
15:07:59
|
<bwolfe> Keelhaul: I really like the new graphing widget
|
15:08:14
|
<Keelhaul> bwolfe: what widget
|
15:08:29
|
<bwolfe> Keelhaul: but fyi: I had to fix the coloring a little bit. ...and I added a darker red for absolute (error) values
|
15:08:41
|
<Keelhaul> oh
|
15:08:48
|
<Keelhaul> i had to play around with the colors a bit
|
15:09:05
|
<Keelhaul> because on my laptop where i wrote it, the colors looked completely different from normal lcd monitors
|
15:09:19
|
<Keelhaul> what was wrong with the coloring
|
15:09:19
|
<bwolfe> the colors were fine, you just had the ranges wrong a bit
|
15:09:26
|
<Keelhaul> really
|
15:09:29
|
<bwolfe> it was overlapping colors
|
15:09:30
|
<Keelhaul> tell me where
|
15:09:33
|
<Keelhaul> oh yea
|
15:09:35
|
<bwolfe> so normal was showing up pink
|
15:09:38
|
<Keelhaul> well yea, i knew that
|
15:09:41
|
<bwolfe> I changed it so normal was white
|
15:09:45
|
<bwolfe> critical was yellow
|
15:09:53
|
<bwolfe> and out of that was orange
|
15:09:56
|
<Keelhaul> but if you define the ranges properly in the concept, they shouldnt overlap
|
15:10:07
|
<bwolfe> right
|
15:10:22
|
<bwolfe> I had the ranges proper, but it was still a little off
|
15:11:03
|
<bwolfe> you had critical = new IntervalMarker(criticalLow, maxRange, COLOR_CRITICAL);
|
15:11:08
|
<bwolfe> I simply made it critical = new IntervalMarker(criticalHigh, maxRange, COLOR_CRITICAL);
|
15:11:23
|
<Keelhaul> hmm
|
15:11:37
|
<Keelhaul> no, you cant do that
|
15:11:49
|
<Keelhaul> look at HDL cholesterol for example
|
15:11:54
|
<Keelhaul> the critical range is on the bottom
|
15:13:12
|
<bwolfe> that doesn't make sense though
|
15:13:18
|
<bwolfe> because for weight/height/cd4, etc
|
15:15:43
|
<bwolfe> Keelhaul: this is what it looks like now: http://dev.openmrs.org/attachment/ticket/1319/patientGraphs.png
|
15:15:45
|
<OpenMRSBot> <http://ln-s.net/2z1D> (at dev.openmrs.org)
|
15:16:12
|
<Keelhaul> bwolfe: that's what happens if you have overlapping ranges in the concept
|
15:16:26
|
<Keelhaul> they only have 2 colors + white if you dont overlap
|
15:17:37
|
<bwolfe> my values for cd4 (totally made up): Absolute 50.0 1000.0, Critical 100.0 900.25, Normal 300.0 850.0
|
15:17:41
|
<bwolfe> is that what you mean by overlapping?
|
15:20:29
|
<Keelhaul> yea
|
15:20:50
|
<Keelhaul> critical_low should be above normal_hi in that case
|
15:22:08
|
<Keelhaul> http://keelhaul.homeip.net/misc/hdl.png
|
15:22:10
|
<Keelhaul> check this out
|
15:22:16
|
<Keelhaul> this should still be possible with the same servlet
|
15:22:27
|
*** Echidna has quit IRC
|
15:23:55
|
<bwolfe> agreed
|
15:24:06
|
<bwolfe> and it still seems to work fine with trunk
|
15:24:30
|
<Keelhaul> what you need is a few mroe checks
|
15:24:53
|
<Keelhaul> either that, or the people should only define one range limit for each
|
15:25:02
|
<Keelhaul> e.g. only critical_low if the critical area is on top
|
15:25:39
|
<Keelhaul> if cricital_hi (= absolute_hi in this case) it also defined, it will assume that the critical area lies at the bottom
|
15:25:41
|
<Keelhaul> and overlap
|
15:25:48
|
<bwolfe> I don't think you need that
|
15:25:59
|
<bwolfe> if critical area is only on top, only define a cricital high :-)
|
15:26:10
|
<bwolfe> (and don't define a normal low)
|
15:27:15
|
<bwolfe> looking at your screenshot again: normal low > critical high. why ?
|
15:27:17
|
<Keelhaul> you dont need a critical high if it's on top
|
15:27:41
|
<Keelhaul> bwolfe: becuase HDL cholesterol is "good"
|
15:27:43
|
<Keelhaul> more is better
|
15:28:32
|
<bwolfe> absolute == "there should never be values beyond this" critcal == "there might be a problem if values are above/below this" normal == "most people are in this range"
|
15:28:39
|
<bwolfe> is that how you're seeing those ranges ?
|
15:28:48
|
<Keelhaul> yes
|
15:28:58
|
<Keelhaul> and yellow is the area between normal and critical
|
15:29:27
|
<bwolfe> correct
|
15:29:54
|
<Keelhaul> so if your critical area is above normal, you only need to define a critical_low
|
15:30:08
|
<Keelhaul> because critical high is the absolute high in this case
|
15:30:32
|
<Keelhaul> those checks are a bit dumb, they assume if critical_high is defined, then the critical area must lie at the bottom
|
15:31:09
|
<Keelhaul> so either you have to only define the relevant limits in your concept (e.g. only critical low) or add more checks to the servlet
|
15:31:32
|
<Keelhaul> e.g. if the user has both critical low and high defined, check where the normal area lies
|
15:32:47
|
<Keelhaul> and oh yea, i see now, i made it so it colors everything thats out of normal yellow
|
15:32:59
|
<Keelhaul> and the draws red over the areas where critical is defined, if it is
|
15:33:08
|
<Keelhaul> then*
|
15:33:32
|
<Keelhaul> otherwise you'd need many more checks
|
15:33:42
|
<Keelhaul> that's why it'S orange
|
15:40:18
|
<bwolfe> Keelhaul: if critical is above normal, you only need a critical HIGH, because its above
|
15:40:48
|
<bwolfe> you should always have absolute low < critical low < normal low < normal high < critical high < absolute high
|
15:41:45
|
*** Keelhaul|afk has joined #openmrs
|
15:42:12
|
<Keelhaul|afk> dammit
|
15:42:17
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1319 (enhancement closed): Improve observation graph servlet <http://dev.openmrs.org/ticket/1319#comment:1> || OpenMRS Changesets: Changeset [7078]: A much improved patient graph servlet (used on patient dashboard). This ⦠<http://dev.openmrs.org/changeset/7078>
|
15:42:22
|
<Keelhaul|afk> my router tends to block www connections lately from time to time
|
15:42:30
|
<Keelhaul|afk> bwolfe: check this out
|
15:42:32
|
<Keelhaul|afk> http://rafb.net/p/PzDxjj20.html
|
15:42:58
|
<Keelhaul|afk> with these extra checks it should know whether the critical area is on top or on bottom
|
15:43:09
|
<Keelhaul|afk> so if the user defines both limits for critical, it wont make everything red
|
15:43:13
|
<bwolfe> <bwolfe> Keelhaul: if critical is above normal, you only need a critical HIGH, because its above
|
15:43:13
|
<bwolfe> <bwolfe> you should always have absolute low < critical low < normal low < normal high < critical high < absolute high
|
15:43:39
|
<Keelhaul|afk> bwolfe: no
|
15:43:46
|
<Keelhaul|afk> because between critical and normal there is also yellow
|
15:43:52
|
<bwolfe> right
|
15:43:56
|
<bwolfe> that is allowed
|
15:43:58
|
<Keelhaul|afk> if something is out of normal range, its not automatically critical
|
15:43:59
|
<bwolfe> and is in there now
|
15:44:01
|
<Keelhaul|afk> theres a buffer
|
15:44:12
|
<bwolfe> totally agreed
|
15:44:17
|
<Keelhaul|afk> and you need a critical LOW if critical is above normal
|
15:44:19
|
<Keelhaul|afk> not high
|
15:44:36
|
<bwolfe> nope, because low is lower :-)
|
15:44:37
|
<Keelhaul|afk> critical high is usually absolute high in that case
|
15:44:52
|
<Keelhaul|afk> yes but you dont need to know where critical ends (= critical high)
|
15:44:55
|
<Keelhaul|afk> you need to know where it sstarts
|
15:45:06
|
<bwolfe> it starts at critical high
|
15:45:25
|
<Keelhaul|afk> it ends there
|
15:45:26
|
<bwolfe> and between normal high and critical high you have abnormal high (yellow0
|
15:45:41
|
<Keelhaul|afk> critical high is the top end of critical
|
15:45:43
|
<Keelhaul|afk> not bottom
|
15:46:13
|
<bwolfe> no, critical goes until absolute
|
15:46:26
|
<bwolfe> because obviously you're critical until its not possible anymore
|
15:46:32
|
<Keelhaul|afk> yes
|
15:46:41
|
<Keelhaul|afk> and that makes critical high == absolute high
|
15:46:48
|
<Keelhaul|afk> you dont need to worry about that value
|
15:47:08
|
<Keelhaul|afk> but you need to know where the red area starts above the normal
|
15:47:25
|
<Keelhaul|afk> that's defined in critical low
|
15:51:02
|
<Keelhaul|afk> brb
|
15:51:41
|
*** Echidna has joined #openmrs
|
15:54:21
|
<bwolfe> Echidna / Keelhaul / Keelhaul|afk : http://dev.openmrs.org/attachment/ticket/1319/patientGraphs2.png
|
15:54:23
|
<OpenMRSBot> <http://ln-s.net/2z1r> (at dev.openmrs.org)
|
15:54:45
|
<bwolfe> normally you'll only see orange and yellow
|
15:55:04
|
<bwolfe> if you don't want the orange + yellow at the bottom, don't put values in for any lows
|
15:55:11
|
<bwolfe> (except absolute low)
|
15:55:21
|
*** Keelhaul2 has joined #openmrs
|
15:55:33
|
<Keelhaul2> bwolfe: http://keelhaul.homeip.net/misc/graph.png
|
15:56:42
|
<bwolfe> Keelhaul2: you get the same effect if you use the proper range values of critical low == null/0, critical high == 10, absolute high = 30
|
15:57:18
|
<Keelhaul2> bwolfe: then the critical range will be at the bottom
|
15:57:31
|
<bwolfe> there are two critical ranges
|
15:57:54
|
<Keelhaul2> rly
|
15:58:14
|
<Keelhaul2> i thought it's one with two limits
|
15:58:21
|
*** Keelhaul has quit IRC
|
15:58:24
|
*** Keelhaul2 is now known as Keelhaul
|
15:58:25
|
<bwolfe> heh
|
15:58:32
|
<bwolfe> you're all over the place :-p
|
15:58:44
|
<Keelhaul> yea, this network takes ages to timeout
|
15:58:47
|
<bwolfe> you're a quarter of the people in here right now :-)
|
15:58:52
|
<Keelhaul> not manymore
|
15:58:59
|
<Keelhaul> oh yea
|
15:59:01
|
<Keelhaul> i still am
|
15:59:04
|
<bwolfe> Keelhaul: did you know you can kill off your own nicknames ?
|
15:59:09
|
<Keelhaul> not on freenode
|
15:59:14
|
<Keelhaul> dunno how
|
15:59:19
|
<bwolfe> yeah, register the nickname with a password
|
15:59:32
|
<bwolfe> then do /ghost nickname password after you get disconnected at some point
|
15:59:53
|
*** ChanServ sets mode: +v Keelhaul
|
15:59:57
|
*** Echidna_ has joined #openmrs
|
16:00:13
|
<Keelhaul> ah ok /ghost
|
16:00:22
|
<Keelhaul> the syntax seems to vary on different networks
|
16:00:28
|
<bwolfe> thats unfortunate
|
16:01:05
|
<bwolfe> there are 7 possible places a value can be:
|
16:01:16
|
<bwolfe> 1) below absolute low (shouldn't happen)
|
16:01:22
|
<Keelhaul> that's how it works on gamesurge
|
16:01:24
|
<bwolfe> 2) above absolute high (shouldn't happen)
|
16:01:35
|
*** Echidna has quit IRC
|
16:01:38
|
<bwolfe> 3) normal: between normal low and normal high
|
16:01:39
|
<Keelhaul> /msg authserv@services.gamesurge.net ghost Keelhaul
|
16:02:07
|
<bwolfe> 4) critical low : between absolute low and critical low
|
16:02:20
|
<bwolfe> 5) abnormal low: between critical low and normal low
|
16:02:23
|
<Keelhaul> ic
|
16:02:32
|
<Keelhaul> maybe you should list the boxes for critical separately then
|
16:02:32
|
<bwolfe> 6) abnormal high : between normal high and critical high
|
16:02:44
|
<bwolfe> 7) critical high : between crticial high and absolute high
|
16:03:11
|
<Keelhaul> because the boxes for critical low and critical high are laid out the same way as normal low/high
|
16:03:20
|
<Keelhaul> so you might think it's the same range
|
16:03:37
|
*** isurundt has joined #openmrs
|
16:03:51
|
<bwolfe> or maybe it should just be 6 rows instead of 3 rows by 3 columns
|
16:04:47
|
<Keelhaul> you should somehow understand the meaning based on the layout
|
16:05:04
|
<bwolfe> right, and I agree that its confusing as it is
|
16:05:04
|
<Keelhaul> i'm the perfect example of how the critical boxes can be misinterpreted =P
|
16:05:09
|
<bwolfe> :-)
|
16:05:22
|
<bwolfe> you even had me questioning it at one point
|
16:05:26
|
<Keelhaul> http://rafb.net/p/Qm10sm34.html
|
16:05:35
|
<Keelhaul> this is the proper code then
|
16:06:05
|
<bwolfe> Keelhaul: yep, and I think that might be what I changed it to
|
16:09:13
|
<bwolfe> Keelhaul: I would welcome a patch that shifts around the concept editor for that :-)
|
16:09:24
|
<Keelhaul> lol
|
16:09:44
|
*** Keelhaul|afk has quit IRC
|
16:13:11
|
<isurundt> ben: its nice to see you there. :) i need to have some clarifications in the encounterserviceimpl and encounterdao classes..
|
16:14:33
|
<bwolfe> isurundt: ok
|
16:14:44
|
<bwolfe> isurundt: what needs clarifying ?
|
16:14:51
|
<isurundt> when retiring the particular encounter type, I think that i should retire the child encounter types of that as well. am i correct??
|
16:17:15
|
<Keelhaul> can the types have only one parent?
|
16:18:07
|
<bwolfe> isurundt: the user should say whether they want it to cascade. I don't think we want to do that in all situations
|
16:18:16
|
<bwolfe> Keelhaul: yes, that is how he is designing it
|
16:18:25
|
<Keelhaul> well
|
16:18:34
|
<Keelhaul> if the types cant be accessed when the parents are retured
|
16:18:37
|
<Keelhaul> maybe yes
|
16:18:44
|
<isurundt> think that is logical
|
16:20:21
|
<Keelhaul> hmm
|
16:20:31
|
<Keelhaul> are encounter types anything more than tags atm?
|
16:21:07
|
<bwolfe> thats just about all they do Keelhaul, yes
|
16:21:28
|
<bwolfe> they mark an encounter as a certain "type" so encounters can be grouped / reviewed easier
|
16:22:05
|
<isurundt> yes. that is the advantage of grouping them hierachically as i understood
|
16:24:20
|
<isurundt> ben: also i had a look at how location hierachy has been implemented as you mentioned. In the case of encounter type hierachy it may not be much complex as the locaion hierachy right?
|
16:24:43
|
<bwolfe> right
|
16:24:45
|
*** Echidna_ is now known as Echidna
|
16:24:57
|
<bwolfe> Keelhaul: added location tags at the same time
|
16:25:20
|
<bwolfe> isurundt, you will only add patrent type
|
16:25:42
|
<isurundt> yes.
|
16:28:54
|
<isurundt> ben: in the presetation(web) what you have suggested is to list all the encounter types in the manage encounter types page rather then putting a link to view the child encounte type of a particular encounter type. In this case i should add another column to list the parent encounter type of a particular encounter type. isn't it?
|
16:31:45
|
<bwolfe> isurundt: hmm
|
16:31:57
|
<bwolfe> isurundt: I think I read your comment wrong before
|
16:32:30
|
<bwolfe> isurundt: perhaps the Manage Encounter Types page should list all of them...but the child encounter types should be listed underneath the parent ones...only tabbed over a small bit
|
16:33:03
|
<bwolfe> isurundt: the Manage Encounter Type page should list all child encounter types for that parent. and it should allow the user to choose/change the parent type
|
16:33:08
|
<bwolfe> does that make sense ?
|
16:33:33
|
<Keelhaul> dynamic would be nice, like via ajax
|
16:33:43
|
<Keelhaul> i wish i knew ajax =/
|
16:33:47
|
<isurundt> yes. i think that would be much user frendly.
|
16:33:51
|
<Keelhaul> that would help me select locations better
|
16:34:00
|
<isurundt> :)
|
16:34:30
|
<isurundt> keelhaul: think i can do that. :)
|
16:34:34
|
<Keelhaul> bwolfe: why did you change my parent_location_id col to parent_location
|
16:34:46
|
<Keelhaul> it's not consistent with the usual keying
|
16:37:34
|
<bwolfe> Keelhaul: I think we've used both
|
16:38:14
|
<bwolfe> isurundt: ajax isn't need as a first pass. just a normal listing with some spacing changes is all that is needed
|
16:38:20
|
<bwolfe> we can make it fancier later on
|
16:38:33
|
<bwolfe> encounter.encounter_type
|
16:38:37
|
<bwolfe> obs.obs_group_id
|
16:38:46
|
<isurundt> ben:ok
|
16:39:06
|
<Keelhaul> you can list the parent type in bold or sometihng
|
16:39:10
|
<Keelhaul> and reduce the child font size
|
16:39:11
|
<Keelhaul> etc
|
16:39:37
|
<Keelhaul> isurundt: hf figuring out the webapp, it's not documented at all =P
|
16:40:20
|
<bwolfe> Keelhaul: yeah, sorry about that
|
16:40:31
|
<bwolfe> its, um, intuitive ;-)
|
16:40:35
|
<Keelhaul> lol
|
16:40:45
|
<Keelhaul> bwolfe: i guess it's no problem if you've used springbefore
|
16:40:47
|
<Keelhaul> but i hadnt
|
16:40:48
|
<isurundt> :)
|
16:40:50
|
<Keelhaul> so it took a while
|
16:44:11
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7079]: exceldataimport: Added functionality for importing lab results. <http://dev.openmrs.org/changeset/7079>
|
16:45:00
|
<bwolfe> nribeka: any progress on that hibernate bug ? :-)
|
16:53:04
|
<isurundt> ben: think i clarified almost all of the doubts had regarding the implementation. Hope to give a patch for "EncounterDAO", "HibernateEncounterDAO", "EncounterService" and "EncounterServiceImpl" soon. :)
|
16:54:47
|
<bwolfe> great
|
16:54:52
|
<bwolfe> looking forward to it :-)
|
16:55:02
|
<isurundt> ben: any other suggestions ?
|
16:55:36
|
<bwolfe> perhaps
|
16:55:40
|
<bwolfe> but none that I can think of
|
16:55:41
|
<isurundt> which you think that will be important.
|
16:56:21
|
<isurundt> ok then.i will give a patch soon. thanks a lot.
|
16:59:24
|
*** isurundt has quit IRC
|
17:04:20
|
<nribeka> hi bwolfe :)
|
17:04:31
|
<nribeka> just got back from foraging some food lol
|
17:04:42
|
<nribeka> still searching around :P
|
17:04:48
|
<nribeka> for the hibernate
|
17:05:09
|
<nribeka> for the password, will code that one first. seems simpler and easier to do :P
|
17:13:51
|
<Keelhaul> bbl
|
17:13:52
|
*** Keelhaul has quit IRC
|
17:15:22
|
*** bwolfe has quit IRC
|
17:15:27
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1324 (defect created): Cohort Builder Returns Incomplete Results <http://dev.openmrs.org/ticket/1324>
|
17:17:37
|
*** bwolfe has joined #openmrs
|
17:17:37
|
*** ChanServ sets mode: +o bwolfe
|
18:18:21
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7080]: openmrs-logic:Merging trunk into branch [6968]:[7078] <http://dev.openmrs.org/changeset/7080>
|
18:25:34
|
<bwolfe> basic`: hows that dev2 upgrade going ? :-p
|
18:40:32
|
<flyankur> hey bwolfe
|
18:42:08
|
*** bwolfe_ has joined #openmrs
|
18:42:08
|
*** ChanServ sets mode: +o bwolfe_
|
18:42:49
|
<flyankur> I have a query related the projects listeted google summer of code project !
|
18:43:03
|
<bwolfe_> sure
|
18:43:12
|
*** bwolfe has quit IRC
|
18:43:14
|
*** bwolfe_ is now known as bwolfe
|
18:45:56
|
<flyankur> first . I added the logo of summer of code logo on the wiki page . Is it fine
|
18:46:06
|
<bwolfe> !gsoc
|
18:46:06
|
<OpenMRSBot> bwolfe: Error: "gsoc" is not a valid command.
|
18:46:09
|
<bwolfe> !soc
|
18:46:09
|
<OpenMRSBot> bwolfe: "soc" --- http://code.google.com/soc
|
18:46:17
|
<bwolfe> !gsoc2008
|
18:46:17
|
<OpenMRSBot> bwolfe: Error: "gsoc2008" is not a valid command.
|
18:46:48
|
<bwolfe> !learn gsoc2009 as http://openmrs.org/wiki/Summer_Of_Code_2009
|
18:46:48
|
<OpenMRSBot> bwolfe: The operation succeeded.
|
18:46:56
|
<bwolfe> !gsoc2009
|
18:46:56
|
<OpenMRSBot> bwolfe: "gsoc2009" --- http://openmrs.org/wiki/Summer_Of_Code_2009
|
18:47:08
|
<bwolfe> well done
|
18:47:15
|
<flyankur> And i was going through openmrs code and the projects .i want to apply for a project
|
18:48:14
|
<flyankur> I have intrest in 3 projects , as they are very near to my working domain ! But i would like your advice , as which one is important for openmrs , as in priority .
|
18:48:36
|
<flyankur> 1. WYSIWYG Form Designer for Html Form Entry Module
|
18:48:50
|
<flyankur> 2.Ldap module
|
18:49:44
|
<flyankur> 3.New OpenMRS Website Template
|
18:50:20
|
<bwolfe> flyankur: that would actually be the "importance" ranking order :-)
|
18:50:50
|
<bwolfe> flyankur: these are SOC type of projects (~2 months in length for a new developer)
|
18:51:09
|
<bwolfe> flyankur: I would suggest you work on a "introductory ticket" here before soc starts
|
18:51:20
|
<bwolfe> those are meant to be < 1 week for a new developer
|
18:51:43
|
<bwolfe> that would prove your abilities with openmrs and make you a better gsoc candidate
|
18:52:00
|
<bwolfe> (remember, we're not sure we're goign to be in gsoc yet...applications are still being submitted!)
|
18:52:39
|
<bwolfe> !introtickets
|
18:52:39
|
<OpenMRSBot> bwolfe: Error: "introtickets" is not a valid command.
|
18:52:45
|
<bwolfe> !gettingstarted
|
18:52:45
|
<OpenMRSBot> bwolfe: "gettingstarted" --- You might want to look at !overview, !techtalk, and !projects
|
18:52:50
|
<bwolfe> !gettingstartedtickets
|
18:52:50
|
<OpenMRSBot> bwolfe: Error: "gettingstartedtickets" is not a valid command.
|
18:53:07
|
<flyankur> !trivialtickets
|
18:53:07
|
<OpenMRSBot> flyankur: Error: "trivialtickets" is not a valid command.
|
18:53:14
|
<bwolfe> !learn introtickets as http://dev.openmrs.org/report/20
|
18:53:14
|
<OpenMRSBot> bwolfe: The operation succeeded.
|
18:53:34
|
<bwolfe> !learn gettingstartedtickets as http://dev.openmrs.org/report/16
|
18:53:34
|
<OpenMRSBot> bwolfe: The operation succeeded.
|
18:53:51
|
<bwolfe> !learn trivialtickets as http://dev.openmrs.org/report/16
|
18:53:51
|
<OpenMRSBot> bwolfe: The operation succeeded.
|
18:53:53
|
<bwolfe> there :-)
|
19:20:26
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1305 (defect closed): Manage Obs page should not show Void This Obs button if the obs has not been created yet <http://dev.openmrs.org/ticket/1305#comment:1> || OpenMRS Tickets: Ticket #1304 (task closed): Unvoid obs button on Manage Obs page is in the wrong place <http://dev.openmrs.org/ticket/1304#comment:3> || OpenMRS Changesets: Changeset [7081]: Fixing #1304 (Unvoid obs button on Manage Obs page is in the wrong place) ⦠<http://dev.openmrs.org/changeset/7081>
|
20:09:30
|
*** james_regen has quit IRC
|
20:40:22
|
*** flyankur has quit IRC
|
20:49:24
|
<basic`> bwolfe: well it's taken me a little longer than expected.. forgot about the theme issue and i haven't even gotten there yet, our trac 11 rpm was out of date so i needed to get that updated first... and then i realized that i can't test 0.10/0.11 on the same vm, so im in the process of getting our centos testvm to mirror the openmrs vm for testing 0.11
|
20:49:55
|
<bwolfe> :-/
|
20:50:05
|
<bwolfe> so much for your grand claims of a push button update! :-p
|
20:50:25
|
<bwolfe> I understand you want to do it right and make it easier for the next one though
|
21:09:08
|
*** Echidna_ has joined #openmrs
|
21:12:20
|
*** Echidna has quit IRC
|
21:40:54
|
*** Keelhaul has joined #openmrs
|
21:40:54
|
*** ChanServ sets mode: +v Keelhaul
|
21:42:42
|
* r0bby put himself out there as a potential mentor
|
21:43:35
|
<Keelhaul> r0bby puts out =o
|
21:46:19
|
<r0bby> that sounded wrong didn't it?
|
21:46:46
|
<Keelhaul> =P
|
21:54:05
|
*** bwolfe has quit IRC
|
21:56:42
|
*** Echidna_ is now known as Echidna
|
22:00:43
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7082]: eclipse tools: switching between the tabs of the config.xml editor always ⦠<http://dev.openmrs.org/changeset/7082>
|
22:00:55
|
*** jmiranda has quit IRC
|
22:32:38
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1325 (task created): Prepare the DevStudio 0.3.2 release <http://dev.openmrs.org/ticket/1325> || OpenMRS Tickets: Ticket #1230 (task closed): Release the new version of the behavior test plugin on the update site. <http://dev.openmrs.org/ticket/1230> || OpenMRS Tickets: Ticket #1180 (defect closed): Servlets page in config.xml editor does not react properly on Undo <http://dev.openmrs.org/ticket/1180> || OpenMRS Changesets: Changeset [7083]: eclipse tools: Servlets page in config.xml editor does not react properly ⦠<http://dev.openmrs.org/changeset/7083> || OpenMRS Tickets: Ticket #1181 (defect closed): Switching between the tabs of the config.xml editor always asks to save <http://dev.openmrs.org/ticket/1181>
|
23:04:40
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7084]: eclipse tools: fix version numbers in features - #1325 <http://dev.openmrs.org/changeset/7084>
|
23:13:07
|
*** Echidna has quit IRC
|
23:25:24
|
*** Echidna has joined #openmrs
|
23:36:42
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7085]: eclipse tools: UI glitch in the config.xml editor's text fields - #1326 <http://dev.openmrs.org/changeset/7085> || OpenMRS Tickets: Ticket #1326 (defect created): UI glitch in the config.xml editor's text fields <http://dev.openmrs.org/ticket/1326>
|