00:03:54
|
*** [mharrison] has quit IRC
|
00:31:55
|
*** bwolfe has joined #openmrs
|
00:31:55
|
*** ChanServ sets mode: +o bwolfe
|
00:40:55
|
*** atomicturtle has joined #openmrs
|
00:42:33
|
*** nribeka has joined #openmrs
|
00:43:49
|
*** atomicturtle has left #openmrs
|
00:48:26
|
*** nribeka1 has joined #openmrs
|
00:53:20
|
*** nribeka has quit IRC
|
00:55:35
|
*** [mharrison] has joined #openmrs
|
01:05:52
|
*** [mharrison] has quit IRC
|
01:05:59
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6752]: Added attributes to build target to suppress errors <http://dev.openmrs.org/changeset/6752>
|
01:07:56
|
*** [mharrison] has joined #openmrs
|
01:10:28
|
*** [mharrison] has quit IRC
|
01:35:44
|
*** [mharrison] has joined #openmrs
|
01:37:09
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6753]: Fixing attributes on build target to suppress errors <http://dev.openmrs.org/changeset/6753>
|
02:37:26
|
*** [mharrison] has quit IRC
|
03:30:34
|
*** bwolfe has quit IRC
|
03:34:05
|
*** bwolfe has joined #openmrs
|
03:34:05
|
*** ChanServ sets mode: +o bwolfe
|
03:45:44
|
*** bwolfe_ has joined #openmrs
|
03:45:44
|
*** ChanServ sets mode: +o bwolfe_
|
03:46:26
|
*** bwolfe has quit IRC
|
03:46:29
|
*** bwolfe_ is now known as bwolfe
|
03:47:08
|
*** bwolfe has joined #openmrs
|
03:47:08
|
*** ChanServ sets mode: +o bwolfe
|
03:53:07
|
*** [mharrison] has joined #openmrs
|
04:36:26
|
*** bwolfe has quit IRC
|
08:32:05
|
*** nribeka has joined #openmrs
|
08:41:02
|
*** nribeka1 has quit IRC
|
09:11:14
|
*** nribeka has quit IRC
|
11:27:35
|
*** bmckown has joined #openmrs
|
11:27:35
|
*** ChanServ sets mode: +o bmckown
|
11:44:57
|
*** nribeka has joined #openmrs
|
11:55:08
|
*** nribeka1 has joined #openmrs
|
12:13:39
|
*** nribeka has quit IRC
|
12:48:42
|
*** bmckown has quit IRC
|
13:21:25
|
*** bwolfe has joined #openmrs
|
13:21:25
|
*** ChanServ sets mode: +o bwolfe
|
14:52:35
|
<Echidna> bwolfe: my module's service unit test cant find the dataset xml file anymore, any idea what could be the problem?
|
14:52:40
|
<Echidna> the url seems fight
|
14:52:52
|
<Echidna> protected static final String PROBLEM_INITIAL_DATA_XML = "org/openmrs/module/medicalproblem/test/include/MedicalProblemTest-initialData.xml";
|
14:53:12
|
<bwolfe> Echidna: did you just do a clean ?
|
14:53:22
|
<bwolfe> perhaps ant isnt copying the file(s) correctly
|
14:53:23
|
<Echidna> no
|
14:53:31
|
<bwolfe> open that xml and make a minor change, then save it
|
14:53:34
|
<bwolfe> then run your test again
|
14:54:29
|
<Echidna> D:\Users\Keelhaul\Documents\Workspace\medicalproblem\test\include\MedicalProblemTest-initialData.xml
|
14:54:33
|
<Echidna> nope, saving didnt help
|
14:54:38
|
<Echidna> trying to clean and compile agian now
|
15:09:03
|
<Echidna> bwolfe: does the xml file get read from the normal dir or from the .omod?
|
15:09:13
|
<bwolfe> normal dir
|
15:10:13
|
<Echidna> strange
|
15:10:19
|
<Echidna> the problemservicetests cant find its file
|
15:10:33
|
<Echidna> and tests from another module complain about a db value being null
|
15:10:40
|
<Echidna> even though there is no entry with it being null
|
15:10:45
|
<Echidna> and one of the tests doesnt even use a db
|
15:12:07
|
<Echidna> http://rafb.net/p/ECOMGm67.html
|
15:12:12
|
<Echidna> that tests doesnt load a db
|
15:12:14
|
<Echidna> -s
|
15:13:07
|
<Echidna> maybe my hbm file has to declare a default value
|
15:13:12
|
<Echidna> but that wasnt required before
|
15:13:51
|
<Echidna> nope, didnt help
|
15:17:25
|
<bwolfe> Echidna: if you don't put a column into the xml file, it is not put into the insert statement. therefore, when you try to insert, it will try to put a null value in
|
15:19:14
|
<Echidna> i know
|
15:19:29
|
<Echidna> the module's xml dataset has that col in all rows
|
15:19:30
|
<Echidna> but
|
15:19:36
|
<Echidna> this particular test loads no xml
|
15:19:41
|
<Echidna> but still complains
|
15:22:51
|
<bwolfe> Echidna: are you doing it in an @before annotated methdo ?
|
15:23:05
|
<Echidna> yes
|
15:23:11
|
<Echidna> @Before
|
15:23:17
|
<Echidna> but as i said
|
15:23:24
|
<Echidna> this test class loads no xml
|
15:23:30
|
<Echidna> others do have the @Before
|
15:26:04
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6756]: 1.4.x: Fixed build file to ignore firefox load errors for unit tests. ⦠<http://dev.openmrs.org/changeset/6756> || OpenMRS Changesets: Changeset [6755]: 1.4.x: Added web compile target for tests <http://dev.openmrs.org/changeset/6755> || OpenMRS Changesets: Changeset [6754]: 1.4.x: Fixing concept service so unit tests pass. Added default login ⦠<http://dev.openmrs.org/changeset/6754>
|
15:30:28
|
<bwolfe> Echidna: you mean the whole test class doesn't have an @before ? or just this method within it ?
|
15:34:00
|
*** atomicturtle has joined #openmrs
|
15:34:22
|
<Echidna> @Before
|
15:34:22
|
<Echidna> public void runBeforeEachTest() throws Exception {
|
15:34:22
|
<Echidna> executeDataSet(MEDICALPROBLEM_INITIAL_DATA_XML);
|
15:34:22
|
<Echidna> }
|
15:34:27
|
*** atomicturtle has left #openmrs
|
15:34:33
|
<Echidna> thats the class that does use the xml
|
15:34:37
|
<Echidna> another class does not
|
15:35:02
|
<Echidna> and the the classes themselves have no @tags
|
15:35:05
|
<Echidna> just the methods
|
15:35:23
|
<Echidna> runBeforeEachTest() has @Before, test classes have @test
|
15:35:26
|
<Echidna> @Test*
|
15:37:07
|
<bwolfe> Echidna: hmm
|
15:37:11
|
<bwolfe> very interesting
|
15:37:58
|
<Echidna> the test class in the third module still works
|
15:38:04
|
<bwolfe> Echidna: from the stack trace, it looks like its the baseSetupWithStandardDataAndAuthentication method on the BaseContextSensitive class
|
15:38:08
|
<Echidna> but that one doesnt add anything to the data model
|
15:38:13
|
<Echidna> and it's not a service test either
|
15:38:20
|
<bwolfe> that base class runs some default xml
|
15:38:24
|
<Echidna> oh
|
15:38:38
|
<bwolfe> to disable that, you can add an @SkipBaseSetup annotation to your class or to your method
|
15:40:52
|
<Echidna> bwolfe: that fixed the test class that doesnt use an xml
|
15:41:07
|
<Echidna> but now the other class that does shows the same file no found error as the other module
|
15:41:34
|
<Echidna> is my classpath maybe missing something
|
15:42:04
|
<bwolfe> stack trace ?
|
15:42:15
|
<bwolfe> it wouldn't be classpath
|
15:42:24
|
<bwolfe> because it should be in the /build folder
|
15:42:37
|
<bwolfe> refresh/check the /build folder to see if its in there
|
15:42:41
|
<Echidna> http://rafb.net/p/ChCD9l32.html
|
15:43:17
|
<Echidna> bwolfe: the build folder has no /test
|
15:43:47
|
<bwolfe> it wouldn't be /test, it would be just /org
|
15:44:38
|
<Echidna> org/openmrs/module/moduleid
|
15:44:47
|
<Echidna> according to the path in the test class
|
15:44:51
|
<Echidna> but no /test in there
|
15:44:56
|
<Echidna> and no said xml fail
|
15:44:58
|
<Echidna> file*
|
16:35:38
|
<Echidna> bbl
|
17:01:40
|
*** r0bby has quit IRC
|
17:01:49
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6757]: mdrtb module. DST widget update <http://dev.openmrs.org/changeset/6757>
|
17:01:58
|
*** r0bby has joined #openmrs
|
17:01:58
|
*** ChanServ sets mode: +v r0bby
|
17:10:12
|
<bwolfe> Echidna: you can try just copying that file in :-p
|
17:10:25
|
<bwolfe> Echidna: but the correct solution is to update the build.xml so that it copies it over there
|
17:12:57
|
*** bmckown has joined #openmrs
|
17:12:57
|
*** ChanServ sets mode: +o bmckown
|
17:32:14
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6758]: 1.3.x: Fixing unit tests so they run via junit-report Fixed ⦠<http://dev.openmrs.org/changeset/6758>
|
17:47:15
|
*** nribeka1 has quit IRC
|
18:37:21
|
*** Echidna_ has joined #openmrs
|
18:41:27
|
*** Echidna has quit IRC
|
19:40:23
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1056 (task reopened): Upgrade scheduler to handle long-running tasks <http://dev.openmrs.org/ticket/1056#comment:2>
|
19:40:24
|
<Echidna_> bwolfe: aww thx for the kind words =P
|
19:41:10
|
<bwolfe> :-)
|
19:41:27
|
<bwolfe> sharing the love... :-D
|
19:42:04
|
<Echidna_> bwolfe: i'll try to finish updating the locations patch this weekend
|
19:44:16
|
<bwolfe> ok, cool. I'll be travelling starting Sunday, so if you don't get to it by Saturday night, you've given yourself another week or so. :-p
|
19:45:09
|
<Echidna_> lol
|
19:45:12
|
<Echidna_> travelling where
|
19:48:44
|
<Echidna_> well it's just the "transient" thing to take care of
|
19:48:52
|
<Echidna_> the rest was done the day of the review
|
20:02:03
|
<bwolfe> Echidna_: going to kenya and rwanda for about 12 days
|
20:04:36
|
<Echidna_> bwolfe: how are the hotels there
|
20:05:10
|
<bwolfe> Nairobi has some great hotels! ...but we're not staying at my favorite this time. :-/
|
20:05:17
|
<bwolfe> I've never been to rwanda though
|
20:05:38
|
<bwolfe> Its nothing like "hotel rwanda" though...which is what you were referring to, I'm sure
|
20:08:14
|
<Echidna_> lol no, never heard of it heh
|
20:08:20
|
<Echidna_> is it something horrible?
|
20:12:26
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6759]: Fixing javadoc comment on the portlet controller to match the return type ⦠<http://dev.openmrs.org/changeset/6759>
|
20:13:07
|
<bmckown> hey, can I change subjects for a second for a /should be very quick/ question, bwolfe ?
|
20:13:36
|
<bwolfe> bmckown: I didn't know irc ever was restricted to a single topic ! :-)
|
20:13:37
|
<bmckown> If you have a concept. and the concept is a set. if you want the set members, you call getConceptSets() correct?
|
20:13:47
|
<bmckown> :-)
|
20:13:56
|
<bwolfe> Echidna_: yes, its bad. the movie is about the genocide that happened there about 10 years ago
|
20:14:15
|
<bwolfe> bmckown: I think so
|
20:14:27
|
<bwolfe> bmckown: we should probably rename that to getSetMembers or something...
|
20:15:06
|
<bmckown> But if you have a Concept that is IN a set, you gotta make a service call. Okay. Just your quick answer could save me a bit of time testing this after I code what I think is correct.
|
20:20:27
|
<bwolfe> bmckown: correct, to get the parent set you have to call ConceptService.getConceptSetByConcept or something
|
20:21:15
|
<bmckown> Okay. That's what I thought from browsing the source but wanted to be sure. Thanks. :-)
|
21:11:27
|
*** james_regen has quit IRC
|
21:42:17
|
*** nribeka has joined #openmrs
|
21:48:38
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6762]: -- atd * fixed initialization of Task <http://dev.openmrs.org/changeset/6762> || OpenMRS Changesets: Changeset [6761]: -- chica * changed KiteMessageHandler to read one byte at a time to debug ⦠<http://dev.openmrs.org/changeset/6761> || OpenMRS Changesets: Changeset [6760]: -- dss * added authentication and error handling to ClassLoaderTask <http://dev.openmrs.org/changeset/6760>
|
22:20:39
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1242 (task created): Allowing creating a patient record without filling in DOB when the patient was a user <http://dev.openmrs.org/ticket/1242>
|
22:50:10
|
*** bwolfe has quit IRC
|
22:51:13
|
*** Echidna has joined #openmrs
|
22:51:19
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1242 (defect created): Patient can be created from user or person without required fields (eg, DOB, names, etc.) <http://dev.openmrs.org/ticket/1242>
|
22:56:23
|
*** Echidna_ has quit IRC
|
23:00:30
|
*** bmckown has quit IRC
|
23:46:03
|
*** nribeka has quit IRC
|