| 00:36:22 | *** nribeka has joined #openmrs |
| 02:10:21 | *** nribeka has quit IRC |
| 02:10:39 | *** nribeka has joined #openmrs |
| 02:32:53 | <nribeka> bwolfe, are you there? |
| 02:44:47 | *** upul has joined #openmrs |
| 02:44:51 | *** Echidna has quit IRC |
| 02:44:52 | *** Echidna_ has joined #openmrs |
| 03:51:02 | <r0bby> bwolfe: 18:18 basic` bwolfe: 0.10->0.11 really depends on the complexity of the trac install (plugins, config, etc). An unmodified trac 0.10 only takes about 10-15 minutes of downtime |
| 04:18:47 | *** [mharrison] has quit IRC |
| 04:19:47 | *** [mharrison] has joined #openmrs |
| 04:25:15 | *** [mharrison] has quit IRC |
| 04:25:51 | *** [mharrison] has joined #openmrs |
| 04:27:44 | <r0bby> bwolfe: so wanna go to NC On US Airways :) |
| 04:49:25 | <bwolfe> r0bby: why do you ask? |
| 04:49:46 | <bwolfe> r0bby: thanks for the repeat on trac. I had missed that! |
| 04:51:49 | *** bwolfe has quit IRC |
| 07:18:47 | *** upul has quit IRC |
| 07:19:13 | *** upul has joined #openmrs |
| 10:54:25 | *** nribeka1 has joined #openmrs |
| 10:54:29 | *** nribeka1 has left #openmrs |
| 11:06:35 | *** upul has quit IRC |
| 11:10:04 | *** nribeka has quit IRC |
| 12:25:48 | *** james_regen has joined #openmrs |
| 12:25:48 | *** ChanServ sets mode: +v james_regen |
| 12:55:42 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6634]: reporting-sprint: Change build.xml to refer to this branch name. <http://dev.openmrs.org/changeset/6634> |
| 13:25:02 | *** nribeka has joined #openmrs |
| 13:31:51 | *** bwolfe has joined #openmrs |
| 13:31:51 | *** ChanServ sets mode: +o bwolfe |
| 14:16:25 | *** bmckown has joined #openmrs |
| 14:16:25 | *** ChanServ sets mode: +o bmckown |
| 14:31:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6636]: Fixed links to admin drug orders on patient dashboard - #1210 <http://dev.openmrs.org/changeset/6636> || OpenMRS Changesets: Changeset [6635]: -- chica * fixed an error with a test case <http://dev.openmrs.org/changeset/6635> |
| 14:34:21 | *** nribeka has quit IRC |
| 15:03:18 | <Echidna_> bwolfe: are unit tests for Location good enough now? |
| 15:03:26 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6637]: Added escapeHtml option to several dwr calls <http://dev.openmrs.org/changeset/6637> |
| 15:04:16 | *** atomicturtle has quit IRC |
| 15:10:22 | <bwolfe> Echidna_: yeah, they look better |
| 15:10:28 | <bwolfe> and thanks for touching on some of the other location methods |
| 15:10:32 | <bwolfe> those need some cleaning too |
| 15:15:21 | <bwolfe> Echidna_: random feedback: 1) something like this can be two tests: http://paste2.org/p/130847 2) we use a slightly different format for the unit test names. its focused around the @should annotation (and eclipse plugin) http://openmrs.org/wiki/Unit_Testing_with_@should |
| 15:15:22 | <OpenMRSBot> <http://ln-s.net/2UyD> (at openmrs.org) |
| 15:15:43 | <bwolfe> (looking for that @should url on the wiki made me realize the testing doc needs a lot of work) |
| 15:18:38 | <Echidna_> oh man |
| 15:20:54 | <Echidna_> bwolfe: why cant locationtags have an additional value field?= |
| 15:21:09 | <bwolfe> what do you mean ? |
| 15:21:29 | <Echidna_> to replace my Room class |
| 15:21:45 | <Echidna_> it has attributes like capacity |
| 15:21:55 | <Echidna_> wouldnt want to have to extend Location |
| 15:23:21 | <bwolfe> tags aren't meant to store data though |
| 15:23:32 | <bwolfe> they just label the location as something |
| 15:23:38 | <Echidna_> if LocationTag would have a value field, i could use tag.name="capacity", tag.value="10" |
| 15:23:49 | <Echidna_> damn |
| 15:24:04 | <Echidna_> theoretically i dont have to use the extended Location class |
| 15:24:22 | <Echidna_> question is how the acceptance would be then |
| 15:24:38 | <Echidna_> i could add a LocationAttribute class =/ |
| 15:30:05 | *** Echidna_ is now known as Echidna |
| 15:30:32 | <bwolfe> hehe |
| 15:31:01 | <bwolfe> you could just have your own object that stores location_id, capacity |
| 15:31:13 | <bwolfe> and refer to that on the pages where you want to display room size |
| 15:35:13 | *** atomicturtle has joined #openmrs |
| 15:36:37 | <Echidna> bwolfe: are there any plans for user access restriction |
| 15:36:53 | <bwolfe> restriction on what ? |
| 15:36:56 | <Echidna> like only having access to resources/patients from your own department |
| 15:39:17 | <bwolfe> people have asked about that |
| 15:39:24 | <bwolfe> but that is extremely difficult to implement |
| 15:39:27 | <bwolfe> because it touches everything |
| 15:39:31 | <Echidna> yea |
| 15:39:39 | <Echidna> i was thinking of a new set of privs |
| 15:39:42 | <Echidna> and new controllers |
| 15:39:50 | <Echidna> which use the old search functions, but then filter |
| 15:39:54 | <Echidna> slower but less work |
| 15:39:55 | <Echidna> i guess |
| 15:41:34 | <bwolfe> yeah, the other option is to use AOP around any method that returns patients |
| 15:41:44 | <bwolfe> also potentially very slow though |
| 15:41:49 | <bwolfe> (but could be done in a module) |
| 15:42:42 | <Echidna> yea |
| 15:42:44 | <Echidna> gotta try |
| 15:42:52 | <Echidna> nver used aop |
| 15:43:12 | <Echidna> btw |
| 15:43:26 | <Echidna> there still needs to be a new table to map a doctor to a location |
| 15:43:32 | <Echidna> or is there something there already |
| 15:44:52 | <bwolfe> I don't know that we have something |
| 15:45:03 | <bwolfe> unless you put it in a PersonAttribute for that doctor |
| 15:45:16 | <bwolfe> that would give you multiple doctors per location |
| 15:45:26 | <bwolfe> if its one to one, then there'll have to be a diff solution |
| 15:45:39 | <Echidna> should be many to many |
| 15:45:49 | <Echidna> or should it hmm |
| 15:45:56 | <Echidna> can doctors belong to multiple locations? |
| 15:45:58 | <Echidna> irl |
| 15:49:00 | <bwolfe> sure |
| 15:49:07 | <bwolfe> Burke works at 5 different clinics |
| 15:49:13 | <bwolfe> Paul is only at one though |
| 15:49:35 | <Echidna> lol |
| 15:49:53 | <Echidna> so hm |
| 15:50:11 | <Echidna> personattribute locationMember or smt |
| 15:50:15 | <Echidna> and locationId |
| 15:53:56 | <Echidna> er |
| 15:54:07 | <Echidna> PersonAttributeType named locationMember |
| 15:59:57 | <Echidna> oh wait |
| 16:00:03 | <Echidna> what about the Health Center attribute |
| 16:00:08 | <Echidna> is it for patients? |
| 16:00:10 | <bwolfe> could use that one |
| 16:00:12 | <Echidna> maybe it could be abused |
| 16:00:13 | <Echidna> yea |
| 16:00:26 | <bwolfe> I think its meant as patient's health center though |
| 16:02:27 | <Echidna> i know =) |
| 16:02:47 | *** nribeka has joined #openmrs |
| 16:03:36 | <Echidna> if the entire hierarchy is composed of Location, i could theoretically confine a provider to a room |
| 16:03:36 | <Echidna> lol |
| 16:04:41 | <bwolfe> heh |
| 16:04:42 | <bwolfe> true |
| 16:04:48 | <bwolfe> and some places might want that |
| 16:04:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6639]: Merging trunk into branch logic [6605]:[6638] <http://dev.openmrs.org/changeset/6639> || OpenMRS Changesets: Changeset [6638]: Added default location option to patient identifier - #978 (also from ⦠<http://dev.openmrs.org/changeset/6638> |
| 16:05:00 | <bwolfe> say a provider stays in one place and patients come in and out for check ups |
| 16:05:21 | <nribeka> ah online finally |
| 16:08:35 | <Echidna> well damn |
| 16:08:51 | <Echidna> i'd need one attribute per location for people like burke, though |
| 16:11:38 | <bwolfe> yeah, it'd be best to store it on the person |
| 16:11:49 | <bwolfe> then loop over users looking for that attribute |
| 16:11:54 | <bwolfe> or store it in your own table |
| 16:13:35 | <Echidna> user_location_map |
| 16:13:42 | <Echidna> doesnt need to be person then |
| 16:19:26 | <nribeka> bwolfe, i attach the hibernate jar |
| 16:19:50 | <nribeka> the test fail on shouldSaveConceptNumeric |
| 16:20:03 | <nribeka> brb |
| 16:33:02 | <atomicturtle> I'll put adding Extension:SimpleFeed to the TODO list |
| 16:33:24 | <atomicturtle> that looks pretty cool |
| 16:36:12 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #971 (task closed): FormEntry Processing Error <http://dev.openmrs.org/ticket/971#comment:1> |
| 16:40:52 | <atomicturtle> :w |
| 16:53:24 | <bwolfe> thanks atomicturtle ! |
| 17:08:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6640]: Added a change to the database update script to remove the ⦠<http://dev.openmrs.org/changeset/6640> |
| 17:12:08 | <nribeka> bwolfe, i hope we're not going for the "if it's a Person related use entityName else use rootEntityName" hehe :D |
| 17:12:29 | <nribeka> bmckown, thank you for the book suggestion. knock em dead is really interesting :) |
| 17:12:37 | <bwolfe> nribeka: no, thats not an option |
| 17:12:49 | <bwolfe> nribeka: haven't looked at the problem with the names yet |
| 17:12:57 | <bwolfe> did you do any more digging on it? |
| 17:13:02 | <bwolfe> if not, can you ? |
| 17:13:05 | <bwolfe> brb |
| 17:13:23 | <nribeka> all the data seems to be going to the database correctly |
| 17:14:05 | <nribeka> the problem occur when we get the ConceptNumeric |
| 17:16:35 | *** mkulumadzi has joined #openmrs |
| 17:17:10 | <mkulumadzi> hey all, this is evan in malawi |
| 17:17:25 | <nribeka> http://pastebin.com/m21a6b905 --> output from the test using original hibernate |
| 17:17:38 | <mkulumadzi> we started having an error in formentry today and i was wondering if someone could help me identify the cause |
| 17:18:15 | <mkulumadzi> pasting the error message here: |
| 17:18:20 | <mkulumadzi> http://www.pastie.org/362552 |
| 17:18:20 | <nribeka> http://pastebin.com/m1f393e72 --> output from the test using patched hibernate |
| 17:19:41 | <nribeka> mkulumadzi, is it the same with ticket 1165 |
| 17:19:43 | <nribeka> http://dev.openmrs.org/ticket/1165 |
| 17:21:03 | <mkulumadzi> yeah, looks identical |
| 17:21:45 | <mkulumadzi> we are on 1.4.0.20 build 6591, using formentry 3.3.4 |
| 17:21:55 | <mkulumadzi> it had been working fine |
| 17:22:29 | <nribeka> mkulumadzi, i think everyone is on lunch break right now |
| 17:22:39 | <mkulumadzi> makes sense |
| 17:22:45 | <nribeka> yes, the ticket says it's happening in 1.4.x |
| 17:22:58 | <mkulumadzi> yeah, saw that |
| 17:23:09 | <nribeka> and if you could stay here for a while you might get answer from bmckown or bwolfe :D |
| 17:23:22 | <mkulumadzi> it's getting late here |
| 17:23:32 | <mkulumadzi> but i'll hang around for a bit |
| 17:34:43 | <nribeka> off now. ttyl mkulumadzi, bwolfe + bmckown |
| 17:34:54 | <mkulumadzi> later nribeka |
| 17:38:17 | *** nribeka has quit IRC |
| 17:43:09 | <mkulumadzi> ok, lame on my part |
| 17:43:25 | <mkulumadzi> wasn't at the latest version of the module... 3.3.5 seems to fix the problem |
| 17:49:35 | <mkulumadzi> followup question: my 'check for updates' feature is broken... seems that the module repository moved? |
| 17:51:24 | <mkulumadzi> error here: http://www.pastie.org/362599 |
| 18:04:07 | *** nribeka has joined #openmrs |
| 18:11:31 | <bmckown> mkulumadzi, (Evan), are you running linux? |
| 18:11:43 | <bwolfe> good find mkulumadzi |
| 18:11:45 | <mkulumadzi> yes |
| 18:11:51 | <bmckown> It's permissions |
| 18:11:54 | <bmckown> I think |
| 18:12:04 | <bwolfe> mkulumadzi: can you paste that mod repo error to a ticket ? |
| 18:12:11 | <bmckown> the velocity log gets dumped out in the tomcat bin directory |
| 18:12:11 | <mkulumadzi> sure |
| 18:12:37 | <mkulumadzi> bmckown, the formentry error was fixed when i upgraded to the latest version of the module |
| 18:12:53 | <bmckown> oh, so the velocity error is not a problem now? |
| 18:13:26 | <bmckown> BTW, Hi! Hope you're doing well. :-) |
| 18:14:36 | <bmckown> I see. guess it's fixed. :-) |
| 18:14:53 | <mkulumadzi> hi back |
| 18:14:55 | <mkulumadzi> doing well here |
| 18:15:07 | <mkulumadzi> seems to be fixed |
| 18:15:15 | <bmckown> that's good. |
| 18:15:19 | <mkulumadzi> i'll let you know if i see it again |
| 18:15:30 | <bmckown> okay |
| 18:16:09 | <nribeka> the ticket is 1165 i think bmckown |
| 18:23:20 | <bmckown> yes, was looking at the ticket. i had originally thought it might be a permission error w/ linux machines |
| 18:24:59 | <bwolfe> nribeka: it makes sense that Concept-->ConceptNumeric would be effected, but ConceptName ?? |
| 18:25:32 | <mkulumadzi> just created the ticket for the module repository error |
| 18:25:33 | <mkulumadzi> http://dev.openmrs.org/ticket/1220 |
| 18:26:39 | <mkulumadzi> i'm out |
| 18:26:41 | <mkulumadzi> thanks guys |
| 18:26:44 | *** mkulumadzi has quit IRC |
| 18:28:17 | <nribeka> bwolfe, if not sure why but for the first assert, the concept numeric is returned with two concept name when using hibernate with new patch |
| 18:28:34 | <nribeka> but when using old hibernate, it only return one concept name |
| 18:28:44 | <nribeka> only the latest concept name |
| 18:32:39 | <bwolfe> very interesting |
| 18:33:28 | <bwolfe> nribeka: is it lines 32 to 34 in http://pastebin.com/m1f393e72 ? |
| 18:34:21 | <nribeka> the first assert will return line 32 and 34 |
| 18:35:16 | <bwolfe> but that seems right |
| 18:35:22 | <bwolfe> because both are attached to the concept :-p |
| 18:35:46 | *** nribeka1 has joined #openmrs |
| 18:37:14 | <bwolfe> nribeka: which line in the test is the assert on ? |
| 18:38:53 | <nribeka1> wait bwolfe |
| 18:38:55 | <nribeka1> :D |
| 18:40:48 | <nribeka1> line 129 bwolfe |
| 18:40:53 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1220 (task created): Error accessing module repository from 'Check For Updates' <http://dev.openmrs.org/ticket/1220> |
| 18:40:55 | <nribeka1> ConceptServiceTest |
| 18:50:12 | <bwolfe> nribeka: switch lines 130 and 129 |
| 18:50:21 | <bwolfe> you might not be getting the right object |
| 18:53:01 | *** nribeka has quit IRC |
| 19:07:59 | <nribeka1> still the same bwolfe |
| 19:08:13 | <nribeka1> the object is concept numeric |
| 19:08:16 | <bwolfe> it fails at the switched line, or not until the name assert ? |
| 19:08:19 | <bwolfe> oh ok, good |
| 19:10:28 | <nribeka1> is it good thing bwolfe? |
| 19:10:44 | <bwolfe> nribeka1: its good that its a concept numeric |
| 19:11:08 | <bwolfe> can you debug and see if line 586 in Concept.java is the one getting hit by the getName() call ? |
| 19:11:23 | <bwolfe> if so, its a simple hashing problem |
| 19:11:54 | <r0bby> bwolfe: reason i asked the NC US Airways question was b/c of the plane that made a landing in the hudson |
| 19:11:57 | <r0bby> :P |
| 19:12:00 | <r0bby> it was headed for NC :P |
| 19:12:08 | <bwolfe> I see |
| 19:12:20 | <nribeka1> i saw it too r0bby |
| 19:12:26 | <bwolfe> you have a dark sense of humor r0bby |
| 19:12:41 | <bwolfe> and by dark I mean questionable |
| 19:12:41 | <r0bby> Direct Flight to Manhattan |
| 19:13:02 | <r0bby> I also have questionable morals, but sure don't mention those |
| 19:19:21 | <nribeka1> bwolfe, it returns the best match |
| 19:19:44 | <nribeka1> because the first concept name has a preferred tag on it |
| 19:19:55 | <bwolfe> oh |
| 19:19:58 | <nribeka1> the new concept name doesn't have tag on it |
| 19:20:08 | <bwolfe> so why does that pass with the old jar ?? |
| 19:20:10 | <bwolfe> heh |
| 19:20:12 | <nribeka1> it's because they're returning both of them |
| 19:20:21 | <nribeka1> the old one only found one concept name |
| 19:21:33 | <r0bby> nribeka1: what ya working on? |
| 19:22:04 | <nribeka1> hibernate patch to enable Person become a User and Patient at the same time |
| 19:24:07 | *** mo has joined #openmrs |
| 19:24:47 | <bwolfe> nribeka1: I still don't know why it would do that. |
| 19:25:01 | <bwolfe> perhaps hibernate isn't caching it with yours ? |
| 19:29:43 | *** mo has quit IRC |
| 19:30:49 | <nribeka1> caching bwolfe? |
| 19:31:05 | <nribeka1> [a new conceptnumeric] --> the original hibernate jar |
| 19:33:08 | <nribeka1> [Some non numeric concept name, a new conceptnumeric] --> hibernate with new patch |
| 19:33:36 | *** Echidna_ has joined #openmrs |
| 19:34:24 | *** Echidna has quit IRC |
| 19:37:26 | <nribeka1> ttyl bwolfe |
| 19:38:44 | <bwolfe> cya nribeka1 |
| 19:42:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6642]: -- chica * changed schedulable task to start on startup <http://dev.openmrs.org/changeset/6642> || OpenMRS Changesets: Changeset [6641]: -- atd * changed schedulable task to start on startup <http://dev.openmrs.org/changeset/6641> || OpenMRS Tickets: Ticket #1188 (enhancement closed): Implement global property to turn on/off auto updates <http://dev.openmrs.org/ticket/1188#comment:1> || OpenMRS Tickets: Ticket #1221 (enhancement created): Database upgrades should become an explicit and manual process for admins <http://dev.openmrs.org/ticket/1221> |
| 19:46:29 | <Echidna_> http://apina.biz/11996.jpg |
| 19:47:55 | <r0bby> Echidna_: whats this |
| 19:47:56 | <r0bby> :X |
| 19:48:33 | <Echidna_> WoW lol |
| 19:51:41 | <r0bby> why |
| 19:54:05 | <bwolfe> Echidna_: is that supposed to be a progression of the same guy ?? |
| 20:16:40 | <Echidna_> bwolfe: yea lol |
| 20:16:51 | <Echidna_> since he started playing wow |
| 20:16:56 | <bwolfe> geez |
| 20:19:07 | <r0bby> now this is adorable |
| 20:19:37 | <r0bby> wow from decent looking to ooogly in ... |
| 21:05:11 | <nribeka1> back |
| 21:05:13 | <nribeka1> lol :D |
| 21:16:08 | *** james_regen has quit IRC |
| 21:41:51 | <bwolfe> Echidna_: digg is claiming your photo is a fake |
| 21:42:20 | <bwolfe> Echidna_: someone reversed the true order of the pics and put "wow" in front of it |
| 21:42:28 | <bwolfe> Echidna_: look at the ear holes... |
| 21:50:54 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6643]: --chica * modifications to grease board patient checkin <http://dev.openmrs.org/changeset/6643> |
| 22:22:55 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1222 (enhancement created): Allow openmrs-require to check more than one privilege <http://dev.openmrs.org/ticket/1222> |
| 22:47:05 | *** bwolfe has quit IRC |
| 22:54:59 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1165 (defect closed): can't download form because of velocity error <http://dev.openmrs.org/ticket/1165#comment:12> || OpenMRS Changesets: Changeset [6644]: 1.4.x branch: Added sql to update the concept_word table to work with the ⦠<http://dev.openmrs.org/changeset/6644> |
| 23:27:02 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6646]: Removing unnecessary warning message in logs from graphs servlet on the ⦠<http://dev.openmrs.org/changeset/6646> || OpenMRS Changesets: Changeset [6645]: Fixed error message on Concept description objects <http://dev.openmrs.org/changeset/6645> |
| 23:37:06 | *** bmckown has quit IRC |
| 23:54:42 | *** nribeka1 has quit IRC |
