00:04:28
|
*** jacobb has joined #openmrs
|
00:09:27
|
*** jacobb has quit IRC
|
00:12:33
|
*** jacobb has joined #openmrs
|
00:24:35
|
*** nribeka has quit IRC
|
00:30:30
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6622]: registration module: Replaced references to /openmrs with the contextPath. ⦠<http://dev.openmrs.org/changeset/6622>
|
00:31:14
|
*** bwolfe has joined #openmrs
|
00:31:14
|
*** ChanServ sets mode: +o bwolfe
|
01:14:13
|
*** nribeka has joined #openmrs
|
01:15:28
|
<nribeka> bwolfe, did you see my comment?
|
01:19:24
|
<bwolfe> nribeka: here, or on the ticket ?
|
01:20:14
|
<nribeka> on the ticket
|
01:20:36
|
<nribeka> i got the proxy ( i think )
|
01:20:39
|
<bwolfe> yeah, but I don't understand. which line gave you that ?
|
01:21:00
|
<nribeka> the last assert
|
01:21:08
|
<bwolfe> ah.
|
01:21:15
|
<bwolfe> then yes, that means it is working
|
01:21:16
|
<nribeka> assertTrue("When getting a user, it should be of the class user, not: " + user2.getClass(), user2.getClass().equals(User.class));
|
01:21:32
|
<nribeka> it's ok?
|
01:21:44
|
<bwolfe> the assert should probably be using method that checks for any subclass
|
01:22:28
|
<nribeka> yayyy ... it's not illegal argument anymore
|
01:22:40
|
<nribeka> checking subclass?
|
01:22:53
|
<bwolfe> yeah, I forget the method
|
01:23:00
|
<bwolfe> is on the Class object
|
01:23:02
|
<r0bby> this.getClass().isAssignableFrom(User.class);
|
01:23:04
|
<r0bby> or something
|
01:23:13
|
<r0bby> or whatever
|
01:23:14
|
<bwolfe> yeah, that sounds right r0bby
|
01:23:22
|
<nribeka> r0bby, is here :)
|
01:28:24
|
<r0bby> no
|
01:28:25
|
<r0bby> no
|
01:28:27
|
<r0bby> im not here
|
01:37:38
|
*** atomicturtle has joined #openmrs
|
01:44:56
|
<bwolfe> nribeka: but the problem with that patch is that module owners are not able to override objects, services, etc
|
01:45:24
|
<bwolfe> nribeka: there might be a unit test in the module section that tests it
|
01:45:45
|
<nribeka> which module bwolfe?
|
01:46:02
|
<bwolfe> nribeka: I know tammy's does it
|
01:46:16
|
<bwolfe> the dss, chica, or atd module
|
01:46:50
|
<nribeka> i don't get it bwolfe. why do they need to overide the objects, services, etc?
|
01:46:58
|
<nribeka> you mean to avoid the exception?
|
01:47:19
|
<nribeka> to avoid this: org.openmrs.User$$EnhancerByCGLIB$$dee26ed?
|
01:52:50
|
<nribeka> i try:
|
01:52:52
|
<nribeka> System.out.println(user2.getGivenName());
|
01:52:52
|
<nribeka> System.out.println(user2.getFamilyName());
|
01:53:05
|
<nribeka> it gives me:
|
01:53:05
|
<nribeka> John
|
01:53:05
|
<nribeka> Doe
|
01:59:00
|
*** pearlbear has joined #openmrs
|
01:59:00
|
*** ChanServ sets mode: +v pearlbear
|
02:39:28
|
*** upul has joined #openmrs
|
02:57:03
|
<nribeka> bwolfe, it works
|
02:57:06
|
<nribeka> woohooo
|
02:57:07
|
<nribeka> :D
|
02:57:32
|
<nribeka> user2.getClass().getSuperclass().equals(User.class)
|
02:58:19
|
<nribeka> dinner surely help you think much clearer lolz
|
03:31:48
|
*** nribeka1 has joined #openmrs
|
03:34:09
|
*** nribeka1 has left #openmrs
|
03:49:51
|
*** nribeka1 has joined #openmrs
|
03:49:52
|
*** nribeka has quit IRC
|
04:11:40
|
<bwolfe> nribeka1: thats not really the 'proper' way to test it
|
04:11:48
|
<bwolfe> use the method that r0bby pointed out
|
04:14:48
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1211 (task created): Expand Merge Patient to Merge Person <http://dev.openmrs.org/ticket/1211>
|
04:15:31
|
*** nribeka has joined #openmrs
|
04:36:02
|
<bwolfe> atomicturtle: can you put http://www.mediawiki.org/wiki/Extension:SimpleFeed into our mediawiki ?
|
04:36:04
|
<OpenMRSBot> <http://ln-s.net/2ila> (at www.mediawiki.org)
|
04:36:20
|
<bwolfe> atomicturtle: I've been told its supposed to be better than our current feed extension
|
04:37:15
|
*** nribeka1 has quit IRC
|
04:46:36
|
*** bwolfe has quit IRC
|
05:15:13
|
*** nribeka1 has joined #openmrs
|
05:31:40
|
*** nribeka has quit IRC
|
05:48:10
|
*** nribeka1 has quit IRC
|
05:48:33
|
*** nribeka has joined #openmrs
|
06:24:55
|
*** Echidna has joined #openmrs
|
06:58:19
|
*** nribeka1 has joined #openmrs
|
07:16:29
|
*** nribeka has quit IRC
|
07:31:53
|
*** nribeka1 has quit IRC
|
08:31:27
|
*** upul has quit IRC
|
08:31:48
|
*** upul has joined #openmrs
|
11:39:22
|
*** upul has quit IRC
|
12:42:58
|
*** james_regen has joined #openmrs
|
12:42:58
|
*** ChanServ sets mode: +v james_regen
|
13:31:12
|
*** bwolfe has joined #openmrs
|
13:31:12
|
*** ChanServ sets mode: +o bwolfe
|
13:43:55
|
*** bmckown has joined #openmrs
|
13:43:55
|
*** ChanServ sets mode: +o bmckown
|
13:57:27
|
*** nribeka has joined #openmrs
|
14:12:57
|
<nribeka> hi bwolfe
|
14:13:06
|
<bwolfe> hey nribeka
|
14:14:41
|
<nribeka> what do you think about the hibernate changes?
|
14:14:45
|
<nribeka> it pass the test
|
14:14:52
|
<nribeka> but you need to call the superclass
|
14:17:20
|
<bwolfe> nribeka: thats fine. hibernate sometimes returns a proxy like that.
|
14:17:33
|
<bwolfe> nribeka: why did you choose to use getSuperClass() instead of the isAssignableFrom ?
|
14:18:14
|
<nribeka> is assignable from return false
|
14:18:22
|
<nribeka> let me try it one more time
|
14:20:30
|
<nribeka> this works bwolfe:
|
14:20:32
|
<nribeka> User.class.isAssignableFrom(user2.getClass())
|
14:21:22
|
<bwolfe> ok. thats more correct than just using the getSuperClass
|
14:21:35
|
<bwolfe> nribeka: I need you to test object overriding though
|
14:21:53
|
<nribeka> object overriding?
|
14:22:53
|
<bwolfe> yeah, like if a module wants to create a "new" encounter object
|
14:23:59
|
<nribeka> is there a junit test for it or i need to write the test?
|
14:24:47
|
<bwolfe> nribeka: http://openmrs.org/wiki/Extending_an_OpenMRS_Table_Through_a_Module
|
14:24:50
|
<OpenMRSBot> <http://ln-s.net/2ipx> (at openmrs.org)
|
14:25:02
|
<bwolfe> nribeka: there might be one in the module test package now, but I'm not sure
|
14:25:20
|
<bwolfe> nribeka: tammy says the custom encounter stuff is in the chica module
|
14:25:41
|
<bwolfe> so download that one, (and the required dss module) and see if it works
|
14:26:21
|
<nribeka> do i need to apply darius patch as well to test tammy's module?
|
14:27:00
|
<bwolfe> nribeka: eventually you will need to, but I don't think it will apply to this. darius's patch deals with concepts and native conceptid generation
|
14:30:33
|
<bwolfe> nribeka: she claims there is a test in the chica module called TestEncounterService that might work for you
|
14:30:49
|
<bwolfe> nribeka: be sure to replace the hibernate.jar thats in the chica module with the one you patched
|
14:31:46
|
<nribeka> checkout-ing chica
|
14:31:48
|
<nribeka> ok bwolfe
|
14:33:03
|
<bwolfe> nribeka: I think the module tests even depend on the other modules being present, so fetch dss and maybe atd
|
14:34:20
|
<nribeka> on a side note, it's -21F there right bwolfe :)
|
14:34:28
|
<nribeka> wow ...
|
14:34:35
|
<bwolfe> yes, /very/ cold
|
14:34:45
|
<nribeka> checkout-ing dss and atd
|
14:53:13
|
*** [mharrison] has quit IRC
|
14:53:22
|
<nribeka> tammy's module require java 6 bwolfe
|
14:53:28
|
<nribeka> need to reinstall java 6 first
|
14:53:46
|
<bwolfe> ha
|
14:53:49
|
<bwolfe> thats unfortunate
|
15:21:38
|
*** bwolfe has quit IRC
|
15:21:44
|
*** bwolfe_ has joined #openmrs
|
15:21:44
|
*** ChanServ sets mode: +o bwolfe_
|
15:31:22
|
<bmckown> jacobb, did you say at one point that Mirth was dependent upon Java 1.5?
|
15:32:13
|
<bmckown> that is to say, if OpenMRS used java 1.6 would it affect integration with Mirth?
|
16:32:22
|
<nribeka> bwolfe_, the TestEncounterService run successfully
|
16:32:36
|
<nribeka> does this means the patch won't break tammy's module?
|
16:32:44
|
<bwolfe_> nribeka: with your new modified hibernate jar in the module ?
|
16:32:49
|
<nribeka> yes
|
16:33:06
|
<bwolfe_> hmm
|
16:33:23
|
<bwolfe_> can you attach your modified jar to the ticket, cc tmdugan, and ask her to try it out ?
|
16:33:48
|
<bwolfe_> nribeka: and do all other tests still pass ?
|
16:34:54
|
<nribeka> i run the PatientServiceTest and UserServiceTest and Tammy's test
|
16:34:58
|
<nribeka> all pass
|
16:35:04
|
<nribeka> do i need to run other test?
|
16:35:05
|
<bwolfe_> nribeka: run 'em all :-)
|
16:35:16
|
<bwolfe_> right click on /test/api and choose run as --> junit tests
|
16:35:43
|
<nribeka> *finger crossed*
|
16:35:48
|
<bwolfe_> hehe
|
16:37:14
|
<nribeka> some failed :(
|
16:37:23
|
<nribeka> privilege required: view concept
|
16:39:09
|
<nribeka> bwolfe_, 29 test failed miserably
|
16:39:10
|
<nribeka> :(
|
16:39:28
|
<bwolfe_> thats probably the login issue
|
16:39:33
|
<bwolfe_> do you have an updated trunk ?
|
16:39:47
|
<nribeka> i update the trunk yesterday
|
16:40:04
|
<bwolfe_> hmm
|
16:40:21
|
<nribeka> most are privileges
|
16:40:33
|
<nribeka> there are OpenmrsTestTest
|
16:41:19
|
<bwolfe_> whats in your base unit test for the password/salt ?
|
16:41:59
|
<nribeka> password="4a1750c8607d0fa237de36c6305715c223415189" salt="c788c6ad82a157b712392ca695dfcf2eed193d7f"
|
16:43:11
|
<bwolfe_> does that match this? password="4a1750c8607d0fa237de36c6305715c223415189" salt="c788c6ad82a157b712392ca695dfcf2eed193d7f"
|
16:43:57
|
<bwolfe_> and does your org.openmrs.util.Security.java class have incorrectlyEncodeString in it ?
|
16:44:36
|
<nribeka> private static String incorrectlyEncodeString(String strToEncode) throws APIException {
|
16:45:45
|
<nribeka> updating my other openmrs
|
16:45:49
|
<nribeka> i have two copy of them
|
16:53:24
|
<nribeka> bwolfe_, i get more errror on the other copy :)
|
16:54:03
|
<nribeka> 82 errror
|
16:54:21
|
<bwolfe_> and you're using admin/test ?
|
16:54:27
|
<bwolfe_> is that whats in your runtime properties ?
|
16:55:09
|
<nribeka> junit.username=admin
|
16:55:09
|
<nribeka> junit.password=test
|
16:55:19
|
<nribeka> i'm off for a moment bwolfe
|
16:55:20
|
<nribeka> ttyl
|
16:55:22
|
<bwolfe_> no spaces after that ?
|
16:55:22
|
<bwolfe_> ok
|
16:55:29
|
<nribeka> need to go to career service :)
|
16:55:41
|
<nribeka> no spaces
|
16:55:54
|
<nribeka> is it because windows?
|
16:55:57
|
<nribeka> CR LF?
|
16:55:58
|
<bwolfe_> hmm
|
16:56:03
|
<bwolfe_> hopefully not
|
16:56:29
|
<bwolfe_> r0bby: can you run the unit tests on the latest trunk ?
|
16:57:25
|
<nribeka> off
|
16:57:26
|
*** nribeka has quit IRC
|
17:12:23
|
*** bwolfe_ has quit IRC
|
17:17:32
|
*** Echidna_ has joined #openmrs
|
17:21:53
|
*** Echidna has quit IRC
|
17:23:57
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1213 (task created): Add startDate and stopDate to Relationships <http://dev.openmrs.org/ticket/1213> || OpenMRS Tickets: Ticket #1212 (task created): Investigate use of Joda time for calendar and date operations <http://dev.openmrs.org/ticket/1212>
|
17:24:34
|
*** bwolfe_ has joined #openmrs
|
17:24:34
|
*** ChanServ sets mode: +o bwolfe_
|
17:26:05
|
*** bmckown has quit IRC
|
17:38:31
|
*** atomicturtle has quit IRC
|
18:46:36
|
*** nribeka has joined #openmrs
|
18:58:00
|
<nribeka> bwolfe_, do the error occur on yours?
|
18:58:01
|
<nribeka> or no?
|
19:25:10
|
*** nribeka has quit IRC
|
19:25:28
|
*** nribeka has joined #openmrs
|
19:29:24
|
*** [mharrison] has joined #openmrs
|
19:30:58
|
*** bwolfe_ is now known as bwolfe
|
19:31:02
|
<bwolfe> nribeka: testing now
|
19:35:05
|
<nribeka> ok bwolfe
|
19:35:07
|
<nribeka> :D
|
19:42:34
|
*** atomicturtle has joined #openmrs
|
19:58:57
|
<bwolfe> nribeka: some are failing...investigating now
|
19:59:17
|
<nribeka> how many bwolfe?
|
19:59:24
|
<nribeka> how can i help?
|
19:59:30
|
<nribeka> or i can just wait :P
|
19:59:32
|
<nribeka> lol
|
19:59:35
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6623]: -- sockethl7listener * made insert statements in sqldiff that affect core ⦠<http://dev.openmrs.org/changeset/6623> || OpenMRS Tickets: Ticket #1214 (task created): Add UserService method to update secret question and answer <http://dev.openmrs.org/ticket/1214>
|
20:00:43
|
<bwolfe> 27
|
20:02:05
|
<bwolfe> nribeka: everything after the userservice fails...I'm guessing its not trying to reauthenticate for some reason
|
20:02:26
|
<nribeka> hang on bwolfe
|
20:02:27
|
<nribeka> :D
|
20:02:34
|
<nribeka> i need to get something first brb
|
20:02:35
|
<nribeka> :D
|
20:05:09
|
*** pearlbear has left #openmrs
|
20:25:52
|
<bwolfe> nribeka: ok, fixed in the latest
|
20:26:00
|
<nribeka> ok
|
20:26:06
|
<nribeka> lemme update it then
|
20:26:06
|
<nribeka> :D
|
20:26:11
|
<bwolfe> the problem was only coming up in batch tests
|
20:27:31
|
<bwolfe> and anything after the UserServiceTest would fail. this happened because the UserServiceTest authenticated as a user other than "System Developer". the other tests never reauthenticated because it saw that some user was already authenticated
|
20:28:02
|
<bwolfe> nribeka: sorry I'm so thick-headed and didn't believe you the first time! :-/
|
20:29:18
|
<nribeka> hehe ... it's ok :D
|
20:30:14
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #436 (defect closed): Regimen tab not working <http://dev.openmrs.org/ticket/436#comment:2> || OpenMRS Changesets: Changeset [6627]: Fix for java 6 method usage. <http://dev.openmrs.org/changeset/6627> || OpenMRS Changesets: Changeset [6626]: -- chica * made insert statements in sqldiff that affect core openmrs ⦠<http://dev.openmrs.org/changeset/6626> || OpenMRS Changesets: Changeset [6625]: -- atd * made insert statements in sqldiff that affect core openmrs ⦠<http://dev.openmrs.org/changeset/6625> || OpenMRS Changesets: Changeset [6624]: -- dss * made insert statements in sqldiff that affect core openmrs ⦠<http://dev.openmrs.org/changeset/6624>
|
20:37:29
|
<bwolfe> nribeka: ok, so all tests pass for you now ?
|
20:39:32
|
<nribeka> fail on this one bwolfe
|
20:39:33
|
<nribeka> OpenmrsTestsTest
|
20:41:30
|
<bwolfe> nribeka: I'm better you haven't actually read the error message yet
|
20:41:36
|
<bwolfe> because it tells you why it fails
|
20:42:15
|
<nribeka> array index out of bound
|
20:42:32
|
<nribeka> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
|
20:44:09
|
<bwolfe> ah, so it was an error, not a failure :-)
|
20:44:39
|
<nribeka> ooo :D
|
20:44:41
|
<bwolfe> nribeka: can you fix that test so that it fails instead of errors with your current setup ?
|
20:44:43
|
<nribeka> sorry :P
|
20:44:49
|
<nribeka> ok ok
|
20:44:58
|
<nribeka> i'm searching where it fails now
|
20:46:50
|
<bwolfe> you should be able to double click in the junit window in eclipse
|
20:47:00
|
<bwolfe> double click on the test with the red "x"
|
20:47:33
|
<r0bby> bwolfe: which unit test?
|
20:48:07
|
<bwolfe> r0bby: I was referring to the whole suite of them. I was asking you because you are on windows
|
20:48:29
|
<bwolfe> r0bby: but we have since figured out the problem. it wasn't windows specific
|
20:51:49
|
<r0bby> not only am I on windows -- i'm on vista
|
20:56:02
|
<nribeka> // switch to dot separation
|
20:56:02
|
<nribeka> className = className.replace("/", ".");
|
20:56:02
|
<nribeka> // strip out the beginning up to org.openmrs.
|
20:56:02
|
<nribeka> className = className.substring(className.indexOf("org.openmrs."));
|
20:56:12
|
<nribeka> that four line bwolfe
|
20:57:00
|
<bwolfe> r0bby: yeah, so is nribeka, which is why I asked you :-)
|
20:57:15
|
<bwolfe> nribeka: which line ? the " className = className.substring(className.indexOf("org.openmrs."));" line ?
|
20:57:23
|
<nribeka> yes
|
20:58:00
|
<nribeka> the class name = C:\Users\Winardi\Desktop\Work\PatientMatching\openmrs-trunk-ori\build\org\openmrs\test\BaseContextSensitiveTest$1
|
20:58:16
|
<r0bby> DO NOT hard-code paths or i'll have to beat somebody :)
|
20:58:17
|
<nribeka> indexOf --> -1
|
20:58:22
|
<r0bby> not in the mood to fight failing tests
|
20:58:36
|
<nribeka> it's not hard coded
|
20:58:47
|
<nribeka> it's a result of currentFile.getAbsolutePath()
|
21:00:25
|
<r0bby> IM HUNGRY
|
21:00:27
|
<r0bby> damn it
|
21:00:29
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6629]: Added the default credentials to the base junit test authenticate method ⦠<http://dev.openmrs.org/changeset/6629> || OpenMRS Changesets: Changeset [6628]: Fixing authentication error when tests are run as a batch <http://dev.openmrs.org/changeset/6628>
|
21:01:09
|
<nribeka> r0bby: lol
|
21:01:55
|
<bwolfe> nribeka: line number ?
|
21:02:07
|
<nribeka> 156
|
21:02:15
|
<bwolfe> nribeka: or do you see how to fix it ?
|
21:03:09
|
<nribeka> i think it's better to use System.getProperty("file.separator");
|
21:03:19
|
<nribeka> instead of replace("/","."
|
21:03:35
|
<nribeka> because "/" is for Unix, right?
|
21:04:12
|
<nribeka> ups ... or is it path.separator
|
21:04:15
|
<nribeka> :P
|
21:06:15
|
<r0bby> I did that
|
21:06:48
|
<r0bby> i have one giant GString for moving the view JSP into the contact path for openmrs so I can use RequestDispatcher
|
21:07:34
|
<r0bby> sb << realPath << "${File.separator}WEB-INF${File.separator}view${File.separator}module${File.separator}groovyforms${File.separator}forms${File.separator}$id"
|
21:07:57
|
<nribeka> it's file.separator right r0bby?
|
21:08:01
|
<nribeka> not path.separator?
|
21:08:14
|
<r0bby> it's a static field on File.
|
21:08:25
|
<nribeka> File?
|
21:08:30
|
<nribeka> ooo you mean in Groovy?
|
21:09:04
|
<r0bby> nope
|
21:09:06
|
<r0bby> in java
|
21:09:13
|
<r0bby> nribeka: groovy enhances java
|
21:09:27
|
<r0bby> http://java.sun.com/javase/6/docs/api/java/io/File.html#separator
|
21:09:31
|
<OpenMRSBot> <http://ln-s.net/2iws> (at java.sun.com)
|
21:10:17
|
<bwolfe> nribeka: well, whichever one it is, it should use that instead of "/", you are right
|
21:10:29
|
<bwolfe> if you make that change does it pass or fail (at least not error)
|
21:11:38
|
<nribeka> it pass bwolfe
|
21:11:44
|
<nribeka> green all the way
|
21:12:44
|
<bwolfe> nribeka: cool
|
21:13:04
|
<bwolfe> nribeka: make a ticket for that an attach the patch, will you ?
|
21:13:28
|
<nribeka> one liner patch
|
21:13:29
|
<nribeka> ok
|
21:15:06
|
<bwolfe> nribeka: I'll have you commit it, someone just needs to approve it via a ticket so that people don't think you're committing code to trunk willy-nilly :-)
|
21:15:24
|
<nribeka> hahaha ok ok :)
|
21:18:40
|
<nribeka> http://dev.openmrs.org/ticket/1217
|
21:18:42
|
<nribeka> :D
|
21:24:47
|
*** james_regen has quit IRC
|
21:25:20
|
<bwolfe> basic`: how did the trac .10 --> .11 migrations go. How long does something like that take for you?
|
21:27:50
|
<nribeka> two test throwing exception on my other openmrs bwolfe
|
21:28:11
|
<nribeka> *i'm hoping this because we haven't apply darius patch
|
21:28:32
|
<nribeka> java.sql.SQLException: Attempt to insert null into a non-nullable column: column: CONCEPT_ID table: CONCEPT in statement [insert into concept (concept_id, retired, date_created, version, date_changed, is_set, datatype_id, class_id, changed_by, creator) values (null, ?, ?, ?, ?, ?, ?, ?, ?, ?)]
|
21:29:56
|
<bwolfe> yes
|
21:30:01
|
<bwolfe> that is darius's thing
|
21:30:47
|
<nribeka> do you want me to attach the hibernate jar or you to apply darius patch first?
|
21:30:53
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6631]: Added ability to load images in the initial setup wizard <http://dev.openmrs.org/changeset/6631> || OpenMRS Tickets: Ticket #1217 (task created): JUnit Test Failed on Windows <http://dev.openmrs.org/ticket/1217> || OpenMRS Tickets: Ticket #1216 (enhancement created): Change dwr error handler to use a global exception div <http://dev.openmrs.org/ticket/1216> || OpenMRS Tickets: Ticket #1215 (defect closed): Module Advice is Loaded Twice at Startup <http://dev.openmrs.org/ticket/1215#comment:1> || OpenMRS Changesets: Changeset [6630]: Fixing duplicate module advice being loaded - #1215 <http://dev.openmrs.org/changeset/6630> || OpenMRS Tickets: Ticket #1215 (defect created): Module Advice is Loaded Twice at Startup <http://dev.openmrs.org/ticket/1215>
|
21:30:58
|
<nribeka> omg i need to use java 5 again
|
21:31:08
|
<nribeka> :(
|
21:31:17
|
<bwolfe> nribeka: why ??
|
21:31:49
|
<nribeka> to compile hibernate if we apply darius patch
|
21:31:51
|
<nribeka> lol
|
21:31:58
|
<bwolfe> nribeka: apply darius's patch to your jar and attach that one
|
21:32:00
|
<bwolfe> nribeka: oh
|
21:32:07
|
<bwolfe> why does hibernate require 1.5 ??
|
21:32:18
|
<bwolfe> and how does it ??
|
21:33:10
|
<nribeka> because there are methods added to classes under java.sql that is extended by hibernate classes
|
21:34:20
|
<nribeka> so, if you compile it using java 6, it will throw exception saying some method not overridden by the hibernate
|
21:35:12
|
<bwolfe> I see
|
21:35:25
|
<bwolfe> why don't you just have both installed?
|
21:35:36
|
<bwolfe> then you can switch back and forth in eclipse settings
|
21:36:02
|
<nribeka> i have another program that will confuse if i install two :P
|
21:40:24
|
<bwolfe> I see
|
21:40:37
|
<bwolfe> you should have applied Darius' patch back when you had 1.5 ;-)
|
21:40:54
|
<bwolfe> nribeka: trunk should be good on 1.5 for a while now. mike found the problem you had earlier today
|
21:40:59
|
<nribeka> Modified the "/" which cause JUnit to fail on Windows - #1217
|
21:40:59
|
<bwolfe> (and fixed it)
|
21:41:16
|
<nribeka> is it ok for the comment like that bwolfe?
|
21:41:56
|
<bwolfe> you probably want "causes" instead of "cause"
|
21:42:04
|
<bwolfe> but otherwise yes, that looks perfect
|
21:42:16
|
<bwolfe> nribeka: if you ever find that you can't compile trunk with 1.5, let the dev list know about it
|
21:42:55
|
<nribeka> ok ok :D
|
21:45:36
|
<nribeka> you can close the ticket bwolfe
|
21:45:46
|
<bwolfe> nribeka: nah, you can :-)
|
21:45:57
|
<nribeka> ok :D
|
21:53:00
|
<nribeka> installing java 5
|
22:02:33
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1217 (task closed): JUnit Test Failed on Windows <http://dev.openmrs.org/ticket/1217#comment:2> || OpenMRS Tickets: Ticket #1218 (enhancement created): Switch Security to use SHA-2 <http://dev.openmrs.org/ticket/1218> || OpenMRS Changesets: Changeset [6632]: Modified the "/" which causes JUnit to fail on Windows - #1217 <http://dev.openmrs.org/changeset/6632>
|
22:06:50
|
<r0bby> wait openmrs uses a wizard set up now?
|
22:07:01
|
<nribeka> yes
|
22:09:27
|
<r0bby> why is spring throwing a fit on me?
|
22:09:34
|
<r0bby> org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'messageSourceServiceTarget' is defined
|
22:09:48
|
<r0bby> ever since DWR starting crapping on me, spring followed suit
|
22:12:38
|
<bwolfe> r0bby: where/how are you getting that error? I don't think I've seen it.
|
22:14:01
|
<r0bby> when i try and access it
|
22:14:08
|
<r0bby> the main webapp
|
22:14:28
|
<r0bby> let me try re-deploying.
|
22:16:39
|
<r0bby> bwolfe: nope still getting it
|
22:17:06
|
*** Echidna has joined #openmrs
|
22:17:27
|
<bwolfe> r0bby: stacktrace
|
22:18:00
|
<r0bby> hold
|
22:20:19
|
<nribeka> bwolfe, this is the patch right?
|
22:20:20
|
<nribeka> http://opensource.atlassian.com/projects/hibernate/secure/attachment/13705/hibernate-native-or-assigned-patch.diff
|
22:20:23
|
<OpenMRSBot> <http://ln-s.net/2iyG> (at opensource.atlassian.com)
|
22:20:28
|
<nribeka> from ticket http://dev.openmrs.org/ticket/1131
|
22:21:02
|
*** Echidna_ has quit IRC
|
22:21:56
|
<bwolfe> nribeka: no, the hibernate patch is in the lib/hibernate/readme.txt file, right ?
|
22:22:13
|
<nribeka> ooo ok ok
|
22:22:15
|
<nribeka> lemme check
|
22:23:14
|
<nribeka> hehehe the readme says refer to the ticket :p
|
22:23:50
|
<r0bby> http://pastie.org/361910
|
22:24:36
|
<r0bby> bwolfe: ^
|
22:25:38
|
<bwolfe> r0bby: when did this last work for you ?
|
22:25:46
|
<bwolfe> any mods to openmrs-servlet.xml ?
|
22:25:53
|
<bwolfe> application-contextServices.xml ?
|
22:27:39
|
<r0bby> hrm no
|
22:27:47
|
<r0bby> I dun remember the last time i touched it :x
|
22:28:31
|
<nribeka> run for me few days ago
|
22:29:02
|
<nribeka> January 12
|
22:30:38
|
<bwolfe> nribeka: looks like you have to do like Darius describes in http://forum.hibernate.org/viewtopic.php?p=2400324
|
22:32:41
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1219 (task created): Separate Appropriate messages.properties Files into the API Layer <http://dev.openmrs.org/ticket/1219>
|
22:40:12
|
<r0bby> ben no changes
|
22:40:48
|
<r0bby> bwolfe: would it be a problem if I re-enrolled for soc to finish my project? :x
|
22:40:58
|
<bwolfe> r0bby: ha
|
22:41:09
|
<r0bby> I'm guessing no
|
22:41:14
|
<r0bby> :(
|
22:41:27
|
<r0bby> well finish my project and add the enhancements!
|
22:41:31
|
<bwolfe> I think a good way of getting back into soc would be to finish your 08 project
|
22:41:45
|
<r0bby> argh :(
|
22:41:50
|
<r0bby> and mentoring would be out :(
|
22:44:48
|
<r0bby> bwolfe: =((
|
22:44:50
|
<r0bby> meh
|
22:45:05
|
<bwolfe> r0bby: you can do it. I believe in you!
|
22:48:13
|
<nribeka> can i be a mentor bwolfe
|
22:48:14
|
<nribeka> lol
|
22:48:16
|
<nribeka> :D
|
22:48:21
|
<nribeka> just kidding :P
|
22:49:37
|
<bwolfe> we'll take "mentor apps" from any past student or current developer/user (basically, from anyone). That doesn't mean we'll pick you as a possible mentor, and it doesn't mean you'll get a student, but it doesn't hurt to ask!
|
22:49:58
|
<bwolfe> so if its something you think you can do (and you want to do it), let us know before gsoc starts and we'll have a go at it! :-)
|
22:50:07
|
<nribeka> ah that's sounds cool :D
|
22:50:21
|
<nribeka> i will become a student again i guess :P
|
22:50:57
|
<nribeka> or no. i need to find a job or else i will have to go out of US :)
|
22:51:49
|
<bwolfe> you could be a student outside the US :-p
|
22:52:35
|
<nribeka> internet is really bad in Indonesia
|
22:52:37
|
<nribeka> :(
|
22:55:21
|
<bwolfe> perhaps australia ?
|
22:55:31
|
<bwolfe> or canada ?
|
22:55:36
|
<bwolfe> (but its very cold up there...)
|
22:55:43
|
<r0bby> bwolfe: I wonder if I could hook openmrs into a grails app :)
|
22:55:54
|
<r0bby> which would basically mean re-writing the app :)
|
22:55:56
|
<bwolfe> probably
|
22:56:09
|
<nribeka> well, i can only go home to indonesia
|
22:56:10
|
<nribeka> :D
|
22:56:22
|
<r0bby> since Spring MVC is basically gonna battle it out :(
|
22:56:39
|
<r0bby> OpenMRS is _WAY_ too coupled to the UI :(
|
22:56:54
|
<bwolfe> nah
|
22:56:56
|
<r0bby> if it wasn't then we could do a grails app :)
|
22:57:16
|
<bwolfe> you can use the api alone
|
22:57:19
|
<bwolfe> or should be able to
|
22:57:23
|
<r0bby> yeh true
|
22:57:38
|
<bwolfe> I know people have used it in a cold fusion app, so I know its possible! :-)
|
22:57:52
|
<r0bby> ah :)
|
22:57:54
|
<r0bby> right
|
22:57:59
|
<r0bby> damn i forgot about that :X
|
22:58:20
|
* bwolfe heads to dinner
|
22:58:25
|
<nribeka> cya bwolfe
|
22:58:29
|
<nribeka> ttyl
|
23:04:44
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6633]: reporting-sprint: Create initial branch. <http://dev.openmrs.org/changeset/6633>
|
23:06:05
|
<nribeka> off
|
23:06:06
|
<nribeka> :D
|
23:06:09
|
<nribeka> home time
|
23:06:10
|
*** nribeka has left #openmrs
|
23:18:29
|
*** bwolfe has quit IRC
|
23:18:31
|
<basic`> bwolfe: 0.10->0.11 really depends on the complexity of the trac install (plugins, config, etc). An unmodified trac 0.10 only takes about 10-15 minutes of downtime
|
23:19:14
|
<r0bby> basic`: he's gone
|
23:19:28
|
<basic`> oh shoot, left before i could finish typing
|
23:19:46
|
<basic`> r0bby: no problem, i'll catch him tomorrow
|
23:35:18
|
*** bwolfe has joined #openmrs
|
23:35:18
|
*** ChanServ sets mode: +o bwolfe
|