| 00:26:16 | *** nribeka has joined #openmrs |
| 01:21:22 | *** pearlbear has quit IRC |
| 02:36:07 | *** upul has joined #openmrs |
| 04:33:05 | *** upul has quit IRC |
| 08:24:51 | *** upul has joined #openmrs |
| 09:06:31 | *** Keelhaul has joined #openmrs |
| 09:06:31 | *** ChanServ sets mode: +v Keelhaul |
| 09:06:38 | <Keelhaul> hey |
| 09:06:55 | <Keelhaul> where i can i find loaded modules in an ubuntu environment |
| 09:06:59 | <Keelhaul> openmrs modules that is |
| 09:11:28 | <Keelhaul> ah found em |
| 09:11:39 | <Keelhaul> /usr/share/.Openmrs |
| 09:42:20 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6569]: groovyforms: typo/groovy-fication. <http://dev.openmrs.org/changeset/6569> |
| 10:21:09 | *** nribeka has quit IRC |
| 10:21:24 | *** nribeka has joined #openmrs |
| 11:38:59 | *** upul has quit IRC |
| 12:45:31 | *** james_regen has joined #openmrs |
| 12:45:31 | *** ChanServ sets mode: +v james_regen |
| 12:51:34 | *** upul has joined #openmrs |
| 13:09:21 | *** bwolfe has joined #openmrs |
| 13:09:21 | *** ChanServ sets mode: +o bwolfe |
| 13:11:57 | *** upul has quit IRC |
| 13:11:59 | *** upul_ has joined #openmrs |
| 13:14:28 | *** upul_ is now known as upul |
| 13:35:53 | *** upul has quit IRC |
| 13:41:50 | <Keelhaul> java decompilers are such a great thing |
| 13:42:01 | <Keelhaul> i lost my thumbdrive with a month of work on it |
| 13:42:05 | <Keelhaul> (forgot to backup for some reason) |
| 13:42:11 | <Keelhaul> but i still had the omods |
| 13:44:30 | <Keelhaul> bwolfe: why are conceptnametags voided rather than retired? |
| 13:46:53 | <bwolfe> hmm, thats a good question |
| 13:50:33 | <bwolfe> I think it is because ConceptNameTag is |
| 13:50:40 | <bwolfe> err because ConceptName is |
| 13:51:33 | <Keelhaul> that's like saying EncounterType should be voided because Encounter is |
| 13:52:34 | <bwolfe> yeah...I think its wrong |
| 13:52:42 | <bwolfe> I think ConceptName should be retired as well |
| 13:53:13 | <bwolfe> (looking at http://openmrs.org/wiki/OpenMRS_API_Service_Template#Retired_vs_Voided and http://openmrs.org/wiki/Deleting_Data_in_OpenMRS:_Void_vs._Retire_vs._Purge) |
| 13:53:18 | <OpenMRSBot> <http://ln-s.net/2h31> (at openmrs.org) |
| 13:53:29 | <Keelhaul> still not quite sure what you mean by making LocationTag more like ConceptNameTag |
| 13:53:41 | <Keelhaul> besides the "preferred" etc methods, i dont see a difference |
| 13:53:53 | <Keelhaul> i renamed "name" to "tag" lol |
| 13:55:16 | <bwolfe> hmm, not sure either |
| 13:55:28 | <bwolfe> for some reason they looked a lot different when I was looking earlier |
| 13:55:32 | <bwolfe> maybe it was the voided/retired thing |
| 13:55:55 | <Keelhaul> hmm |
| 13:56:03 | <Keelhaul> should it be LocationTag.tag or .name? |
| 13:56:34 | <bwolfe> probably tag |
| 13:56:41 | <Keelhaul> ok |
| 14:00:54 | *** atomicturtle has joined #openmrs |
| 14:06:56 | <bwolfe> Keelhaul: are the service methods the same? Are the methods on location and conceptname for the tags the same ? |
| 14:07:13 | <Keelhaul> havent cheecked yet |
| 14:14:15 | <Keelhaul> bwolfe: is Collection better than Set? |
| 14:14:40 | <bwolfe> at one time I thought it was...but now I don't think so |
| 14:14:51 | <bwolfe> if you're returning a set, call it a set. :-) |
| 14:15:11 | <bwolfe> that way the user has a few extra methods to work with instead of just the very generic Collection methods |
| 14:15:21 | <Keelhaul> i use Set for tags |
| 14:15:26 | <Keelhaul> ConceptName uses Collection |
| 14:29:44 | <bwolfe> yeah, thats probably fine |
| 14:31:03 | <Keelhaul> do the implementations of all methods have to be the same or just the naming/parameter patterns? |
| 14:31:17 | <Keelhaul> i tend to check for passed null references to avoid exceptions |
| 14:32:01 | <bwolfe> naming patterns |
| 14:33:34 | <Keelhaul> some service methods for ConceptNameTag seems to be.. missing |
| 14:33:37 | <Keelhaul> like retire/unretire |
| 14:33:38 | <Keelhaul> purge |
| 14:33:47 | <Keelhaul> getBy<anythingbutname> |
| 14:40:27 | *** bmckown has joined #openmrs |
| 14:40:27 | *** ChanServ sets mode: +o bmckown |
| 14:41:04 | <bwolfe> Keelhaul: conceptnametag seems to have been a bad example to pick |
| 14:49:42 | *** atomicturtle1 has joined #openmrs |
| 15:00:41 | <Keelhaul> bwolfe: i'd liek LocationTag more if it had an additional value field |
| 15:06:25 | *** atomicturtle has quit IRC |
| 15:08:59 | *** bwolfe has quit IRC |
| 15:18:21 | *** bwolfe has joined #openmrs |
| 15:18:21 | *** ChanServ sets mode: +o bwolfe |
| 15:28:15 | <Keelhaul> bwolfe: i can no longer run the unit tests |
| 15:28:19 | <Keelhaul> it says the new stuff cant be found |
| 15:28:27 | <Keelhaul> parent_location_id etc |
| 15:29:13 | <bwolfe> is it in the mapping file ? |
| 15:29:48 | <Keelhaul> yes |
| 15:30:04 | <Keelhaul> and hibernate.config.xml or whatever its called |
| 15:30:39 | <bwolfe> perhaps a clean, etc ? |
| 15:31:08 | <bwolfe> Keelhaul: the other thing to check is to make usre junit is using the new file. do this by putting nonsense into the hbm.xml file and running the tests...they should fail then |
| 15:32:18 | <Keelhaul> ah ok |
| 15:32:21 | <Keelhaul> did an eclipse clean |
| 15:32:26 | <Keelhaul> now they pass.. |
| 15:32:39 | <Keelhaul> why isnt an ant clean sufficient? |
| 15:40:53 | *** atomicturtle1 has quit IRC |
| 15:43:20 | *** atomicturtle has joined #openmrs |
| 15:59:27 | *** bwolfe has quit IRC |
| 16:01:07 | *** bwolfe has joined #openmrs |
| 16:01:07 | *** ChanServ sets mode: +o bwolfe |
| 16:22:26 | <Keelhaul> bwolfe: i removed a few asserts from LocationServiceTest, but not many |
| 16:22:39 | <Keelhaul> just those that tested objects fresh out of initialData.xml |
| 16:23:06 | <bwolfe> Keelhaul: ideally there are only asserts at the very end of hte unit test |
| 16:23:15 | <bwolfe> if you have other asserts, those should be other tests |
| 16:23:22 | <Keelhaul> =/ |
| 16:23:29 | <Keelhaul> that's a lot of code then |
| 16:23:41 | <bwolfe> having a lot of tests is much better than less longer tests |
| 16:23:48 | <bwolfe> its just a lot harder to debug when one breaks |
| 16:23:52 | <bwolfe> thats the only reason |
| 16:25:29 | <Keelhaul> TestUtil.printOutTableContents(getConnection(), "location"); |
| 16:25:30 | <Keelhaul> whats that |
| 16:25:31 | <bwolfe> Keelhaul: besides, its a lot of copy/paste...or just making more @shoulds on the method and using the eclipse plugin to generate the tests |
| 16:25:43 | <bwolfe> it prints into the console during a test |
| 16:25:49 | <bwolfe> its for debugging...you can take that back out |
| 16:25:49 | <Keelhaul> can i remove it? |
| 16:25:52 | <Keelhaul> ojk |
| 16:25:53 | <Keelhaul> ij |
| 16:25:54 | <Keelhaul> ok* |
| 17:01:15 | <Keelhaul> bwolfe: can you make trac not log you out every day? |
| 17:02:40 | <bwolfe> I'd love to |
| 17:03:07 | <Keelhaul> there should be some setting for the duration of cookie life |
| 17:03:12 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6570]: -- chica * added a rule to fill in the pws id on the maternal depression ⦠<http://dev.openmrs.org/changeset/6570> |
| 17:03:43 | <bwolfe> is that set to 24 hours right now ? |
| 17:06:04 | <Keelhaul> dunno |
| 17:06:19 | <Keelhaul> but when i use it every other day or so, i have to log in every time |
| 17:14:33 | <nribeka> bwolfe, benchmark of three inheritance style :) |
| 17:14:35 | <nribeka> http://www.xcalia.com/xdn/resources/articles/InheritanceStrategy/PickingTheRightInheritanceStrategy.jsp |
| 17:14:39 | <OpenMRSBot> <http://ln-s.net/2h72> (at www.xcalia.com) |
| 17:14:45 | <nribeka> what do you think bwolfe? |
| 17:27:26 | <bwolfe> nribeka: per concrete isn't really an option |
| 17:27:43 | <bwolfe> we rejected per hierarchy from the beginning |
| 17:27:58 | <bwolfe> but perhaps it should be revisited... |
| 17:28:22 | <nribeka> which one bwolfe? |
| 17:28:29 | <nribeka> per hierarchy? |
| 17:28:33 | <bwolfe> yeah |
| 17:30:27 | <bwolfe> nribeka: but that would mean we only have a "person" table |
| 17:30:32 | <bwolfe> which just sounds wrong when we're all about the patients... :-p |
| 17:31:41 | *** nribeka1 has joined #openmrs |
| 17:32:23 | <nribeka1> they perform better? |
| 17:32:50 | <bwolfe> what do you mean ? |
| 17:37:14 | <nribeka1> the per hierarchy perform better |
| 17:37:28 | <nribeka1> but the space needed is the worst |
| 17:43:42 | *** nribeka2 has joined #openmrs |
| 17:44:31 | <bwolfe> nribeka: thats fine...we don't have very many columns in the patient table and the user table |
| 17:51:26 | *** nribeka has quit IRC |
| 17:53:21 | <nribeka2> off to school bwolfe. ttyl |
| 17:53:26 | *** nribeka2 has quit IRC |
| 18:01:47 | *** nribeka1 has quit IRC |
| 18:07:15 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1198 (defect closed): Remote Form Entry privileges not working <http://dev.openmrs.org/ticket/1198#comment:1> || OpenMRS Changesets: Changeset [6571]: Remote Form Entry: Fixing ticket #1198 Privileges not working. <http://dev.openmrs.org/changeset/6571> || OpenMRS Tickets: Ticket #1198 (defect created): Remote Form Entry privileges not working <http://dev.openmrs.org/ticket/1198> |
| 18:37:11 | *** bwolfe has quit IRC |
| 18:40:19 | *** nribeka has joined #openmrs |
| 18:50:22 | *** bwolfe has joined #openmrs |
| 18:50:27 | *** ChanServ sets mode: +o bwolfe |
| 18:55:38 | *** atomicturtle has quit IRC |
| 18:57:08 | *** bwolfe has quit IRC |
| 19:43:32 | *** atomicturtle has joined #openmrs |
| 20:15:23 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6572]: --chica *fix incorrect error logging <http://dev.openmrs.org/changeset/6572> |
| 21:31:28 | *** james_regen has quit IRC |
| 21:52:44 | *** Keelhaul has quit IRC |
| 22:43:00 | *** bmckown has quit IRC |
| 23:02:52 | *** Echidna has joined #openmrs |
| 23:04:31 | *** nribeka has quit IRC |