IRC Chat : 2009-01-07 - OpenMRS

00:21:09 *** r0bby_ has joined #openmrs
00:21:19 *** jacobb has quit IRC
00:22:01 *** r0bby has quit IRC
00:35:16 *** jacobb has joined #openmrs
00:39:02 *** bwolfe has quit IRC
00:53:51 *** bwolfe has joined #openmrs
00:53:51 *** ChanServ sets mode: +o bwolfe
01:02:02 *** r0bby_ has quit IRC
01:02:04 *** r0bby has joined #openmrs
01:02:26 *** ChanServ sets mode: +v r0bby
01:07:16 *** r0bby has quit IRC
01:07:32 *** r0bby has joined #openmrs
01:07:32 *** ChanServ sets mode: +v r0bby
02:29:48 *** upul has joined #openmrs
03:24:58 *** nribeka has quit IRC
03:25:22 *** bwolfe has quit IRC
03:25:33 *** nribeka has joined #openmrs
03:36:34 *** bmckown has quit IRC
04:02:08 *** atomicturtle has joined #openmrs
04:15:03 *** nribeka has quit IRC
04:27:51 *** nribeka has joined #openmrs
06:55:56 *** nribeka has quit IRC
07:00:18 *** nribeka has joined #openmrs
07:25:16 *** nribeka has quit IRC
07:27:54 *** nribeka has joined #openmrs
07:51:13 *** nribeka has quit IRC
11:28:01 *** upul has quit IRC
11:28:01 *** jacobb has quit IRC
11:29:22 *** upul has joined #openmrs
11:29:22 *** jacobb has joined #openmrs
11:40:50 *** upul has quit IRC
12:29:24 *** upul has joined #openmrs
12:47:14 *** upul_ has joined #openmrs
12:47:15 *** upul has quit IRC
12:55:20 *** upul_ is now known as upul
13:01:21 *** james_regen has joined #openmrs
13:01:21 *** ChanServ sets mode: +v james_regen
13:03:26 *** bwolfe has joined #openmrs
13:03:26 *** ChanServ sets mode: +o bwolfe
14:21:08 *** nribeka has joined #openmrs
14:31:56 *** Keelhaul has joined #openmrs
14:32:00 <Keelhaul> hi
14:36:31 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1196 (task created): FormEntry: NullPointerException when trying to load a form in OpenMRS 1.5 <http://dev.openmrs.org/ticket/1196> || OpenMRS Changesets: Changeset [6551]: openmrs-logic: Check if a variable has a value due to earlier Call or Data … <http://dev.openmrs.org/changeset/6551> || OpenMRS Changesets: Changeset [6550]: chica_module: BP rules that lookup a table for percentiles <http://dev.openmrs.org/changeset/6550> || OpenMRS Changesets: Changeset [6549]: --chica *Created a task that constructs an hl7 message with information … <http://dev.openmrs.org/changeset/6549>
14:40:45 <Keelhaul> bwolfe: are you good with spring?
14:41:42 <Keelhaul> i cant seem to persist an object after sending the form
14:41:57 <Keelhaul> onSubmit gets called, but then formBackingObject gets called again
14:41:58 <Keelhaul> and resets it
14:42:05 <Keelhaul> even though sessionForm=true
14:44:52 *** bmckown has joined #openmrs
14:44:52 *** ChanServ sets mode: +o bmckown
14:51:15 <nribeka> bwolfe
15:02:05 <bwolfe> Keelhaul: what are you doing in formBackingObject? Are you saving something ?
15:02:14 <bwolfe> formBackingObject is called right before the page is rendered
15:02:25 <bwolfe> and right before onSubmit, if sessionForm=false
15:02:34 <bwolfe> are you redirecting back to the same form after saving ?
15:02:47 <Keelhaul> bwolfe: no, just creating a new object
15:02:54 <Keelhaul> filling it with some data if a patientId was passed
15:03:00 <Keelhaul> which doesnt happen in my test anyway
15:03:14 <Keelhaul> setting some default values
15:03:26 <Keelhaul> those default values get overwritten in onSubmit
15:03:37 <Keelhaul> then it creates a new object, which is then displayed in the form
15:04:01 <Keelhaul> it actually calls successview
15:04:07 <Keelhaul> but with a new object
15:04:31 *** atomicturtle has quit IRC
15:04:56 <Keelhaul> http://forum.springsource.org/showthread.php?p=72067
15:04:59 <OpenMRSBot> <http://ln-s.net/2gj:> (at forum.springsource.org)
15:05:02 <Keelhaul> this guy seems to have had the same problem
15:05:09 <Keelhaul> but how do i know if theres a validation error
15:05:35 <bwolfe> Keelhaul: there will probably be things in the log
15:05:47 <bwolfe> and if you have a validator attached to the controller
15:06:09 <Keelhaul> don think i have
15:06:13 <Keelhaul> at least not on purpose lol
15:06:15 <bwolfe> I think you can do bindException.hasErrors() or somethign with one of the parameters passed to getFormBackingObject
15:06:34 <bwolfe> in your formBackingObject, you can also check to see if its a page load of a page submit
15:06:39 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6552]: chica_module: BP rules that lookup a table for percentiles <http://dev.openmrs.org/changeset/6552>
15:06:42 <bwolfe> I can't remember how to do that offhand though
15:10:30 <Keelhaul> bwolfe: any idea about ticket 1196?
15:10:39 <Keelhaul> whos handling formentry nowadays
15:12:37 <bwolfe> I dunno, probably me
15:17:50 <nribeka> bwolfe, how to create new ddl after i add the person_id column?
15:17:57 <nribeka> is there any ant target for it?
15:19:01 <bwolfe> nribeka: what sql file do you want to use this in ?
15:20:23 <nribeka> i don't get it bwolfe
15:20:51 <nribeka> if i remember it correctly there's a way to hbm --> sql right?
15:21:14 <nribeka> so, because i add the new column i need to generate the new ddl right?
15:21:15 <bwolfe> nribeka: yes, but why do you need to do tha t?
15:21:38 <bwolfe> (that was "yes, there is a way")
15:21:49 <bwolfe> no, you don't need to generate any ddl
15:22:31 <bwolfe> you just have to put the sql that does the "alter table person add column...". that /used/ to be in the update-to-latest-mysqldiff.sql file. now it is in xml format in the liquibase-update-to-latest.xml file
15:24:04 <nribeka> ups, i thought we need to re-create the ddl :P
15:25:41 <bwolfe> nope, no need to
15:26:04 <bwolfe> you didn't have to before, but now you /really/ don't have to. mainly because now the "ddl" is in liquibase xml format.
15:30:23 <Keelhaul> bwolfe: could YOU add the liquibasediff to my patch?
15:30:32 <Keelhaul> i dont really have time to read about it now =/
15:30:43 <bwolfe> potentially
15:32:20 <Keelhaul> hmm
15:34:55 <Keelhaul> bwolfe: did you ask me to attach the form template or burke?
15:35:20 <bwolfe> I did
15:35:33 <Keelhaul> ok i attached it
15:35:35 <bwolfe> thats why it says "bwolfe" as the person that added the comment. :-)
15:35:41 <Keelhaul> oh it does?
15:35:41 <Keelhaul> ok
15:35:43 <Keelhaul> lol
15:45:29 <nribeka> bwolfe, i get org.dbunit.dataset.NoSuchColumnException: users.PERSON_ID :(
15:46:07 <bwolfe> you added person_id to the users.hbm mapping file ?
15:46:14 <nribeka> yes
15:46:29 <nribeka> <key column="person_id" not-null="true" on-delete="cascade" />
15:46:29 <nribeka>
15:46:29 <nribeka> <property name="personId" type="java.lang.Integer" not-null="true"
15:46:29 <nribeka> column="person_id" insert="false" update="false" />
15:48:18 <bwolfe> hmm
15:48:19 <bwolfe> not sure
15:48:48 <bwolfe> you can use TestUtil.printOutTableContents(getConncetion(), "users"); before any dbunit xml files are run to see what columns hibernate knows about
15:49:12 *** atomicturtle has joined #openmrs
15:49:28 <bwolfe> you should also make sure junit is picking up the right mapping file. add some nonsense to the file so that it shouldn't work, then try to run the test again
16:13:01 <Keelhaul> bwolfe: i rebuilt the xsn, no cigar =(
16:13:52 <bwolfe> does the form.template column still have that same tribe string that I put in the comment ?
16:15:28 <Keelhaul> <patient.tribe openmrs_attribute="tribe" openmrs_table="patient">$!{patient.attributeMap.Tribe.hydratedObject.tribeId}^$!{patient.attributeMap.Tribe.hydratedObject.name}</patient.tribe>
16:15:33 <Keelhaul> thats what it has now
16:16:08 <bwolfe> ok, thats right
16:16:09 <Keelhaul> maybe the 1.4.x branch version will work agian now?
16:16:10 <Keelhaul> havent tried
16:16:19 <Keelhaul> but 3.5 still throws a nullpointerexception
16:16:32 <bwolfe> any other errors in your tomcat log ?
16:16:42 <Keelhaul> unfortunately, no
16:16:45 <Keelhaul> theres no stdout log
16:17:00 <Keelhaul> thats where all the errors usually go, at least from my experience
16:17:09 <Keelhaul> catalina.log only contains irrelevant data
16:17:37 <Keelhaul> 07.01.2009 15:25:20 liquibase.lock.LockHandler releaseLock INFO: Successfully released change log lock 07.01.2009 15:25:29 org.apache.coyote.http11.Http11BaseProtocol start INFO: Starting Coyote HTTP/1.1 on http-8180
16:17:39 <Keelhaul> stuff like that
16:18:07 <Keelhaul> unless there are other logs besides in /var/log/tomcat
16:18:38 <Keelhaul> i'd access my home windows installation
16:18:43 <Keelhaul> but as you can see, echidna aint online =/
16:18:48 <Keelhaul> because my isp fails
16:19:36 <bwolfe> Keelhaul: any velocity logs in your logs folder ?
16:20:03 <bwolfe> ok, let me know when you can check
16:20:14 <Keelhaul> no
16:20:23 <Keelhaul> whats velocity anyway
16:20:29 <Keelhaul> i first heard it today
16:20:54 <Keelhaul> hmm
16:21:03 <Keelhaul> i could set localhost to use a different db, not the one at home
16:24:32 <bwolfe> its not the db though, its tomcat
16:24:38 <bwolfe> velocity is a templating engine
16:25:13 <bwolfe> it converts the default values of $!{patientObject.tribe.name} into values by calling patientObject.getTribe().getName()
16:25:28 <bwolfe> err "into values" == "into strings"
16:25:45 <Keelhaul> ic
16:26:02 <Keelhaul> ah crap
16:26:16 <Keelhaul> i cant connect to that db from here
16:26:21 <Keelhaul> it only accepts connections from localhost
16:28:17 <Keelhaul> bwolfe: ok, the formentry module from the 1.4.x branch seems to work with trunk
16:28:22 <Keelhaul> all others give the null exception
16:29:04 <Keelhaul> btw, the "Add new problem" on the demo form, does it work?
16:29:07 <Keelhaul> doesnt seem for me
16:31:55 *** Keelhaul has quit IRC
16:32:06 *** Keelhaul has joined #openmrs
16:42:50 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6554]: -- chica * removed ruleLibrary/test from the classpath <http://dev.openmrs.org/changeset/6554> || OpenMRS Changesets: Changeset [6553]: Changed to the ReplacementDataSet in the junit framework so we can have … <http://dev.openmrs.org/changeset/6553>
16:44:15 <nribeka> bwolfe, do i need to add the alter table to liquibase before i run the test?
16:45:51 *** nribeka has left #openmrs
16:46:20 *** nribeka has joined #openmrs
16:47:42 *** nribeka1 has joined #openmrs
16:59:45 *** upul has quit IRC
17:08:00 *** nribeka has quit IRC
17:12:35 <Keelhaul> bwolfe: btw, even if i had access to proper tomcat logs, all that would be in there is the same stack trace of the nullpointerexception
17:15:02 <Keelhaul> time to go home
17:15:05 *** Keelhaul has quit IRC
17:15:44 *** james_regen has quit IRC
17:30:28 *** james_regen has joined #openmrs
17:30:29 *** ChanServ sets mode: +v james_regen
17:53:07 *** nribeka1 has quit IRC
17:55:46 <bwolfe> man, I missed both keehaul and nribeka. :-/
18:51:01 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6555]: Changed most references of GregorianCalendar to Calendar.getInstance() <http://dev.openmrs.org/changeset/6555>
19:11:54 *** nribeka has joined #openmrs
19:23:01 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6559]: -- chica * recreated the sqldiff from scratch in preparation for … <http://dev.openmrs.org/changeset/6559> || OpenMRS Changesets: Changeset [6558]: -- atd * recreated the sqldiff from scratch in preparation for production … <http://dev.openmrs.org/changeset/6558> || OpenMRS Changesets: Changeset [6557]: -- dss * restarted the sqldiff from scratch in preparation for production … <http://dev.openmrs.org/changeset/6557> || OpenMRS Changesets: Changeset [6556]: -- sockethl7listener * updated sqldiff to include person_attribute_types <http://dev.openmrs.org/changeset/6556> || OpenMRS Tickets: Ticket #1197 ( created): Prepare the DevStudio 0.3 release <http://dev.openmrs.org/ticket/1197>
19:38:28 <nribeka> bwolfe :D
19:38:51 <bwolfe> nribeka:
19:39:06 <bwolfe> answer to your question from earlier:
19:39:29 <nribeka> why am i getting this error: BaseContextSensitiveTest cannot be resolved to a type
19:39:55 <bwolfe> no, you don't have to touch liquibase before you run the tests. liquibase is for your and users' mysql database. the tests use an in-memory database that is built on the fly out of the hibernate mapping files
19:40:08 <bwolfe> do you need to clean your project ?
19:40:17 <nribeka> but only happen to PatientServiceTest not on others
19:40:33 <nribeka> yes, it happen after i run clean from the build
19:42:09 <bwolfe> nribeka: is it up in the import section ?
19:43:10 <nribeka> yes
19:46:07 <nribeka> i try to clean, delete --> update, close the project --> open it again but not good
19:46:12 <nribeka> any suggestion bwolfe?
19:46:44 <bwolfe> try just changing the PatientServiceTest file
19:46:49 <bwolfe> and then saving it
19:47:03 <bwolfe> do you get the red line, or is this happening when you're running it ?
19:47:24 <nribeka> red line
19:47:49 <nribeka> it says: the import org.openmrs.test is unresolved
19:50:52 <bwolfe> hmm
19:50:53 <bwolfe> not sure
19:51:08 <bwolfe> it doesn't go away if you modify the file ?
19:52:54 <nribeka> nope bwolfe
19:53:08 <bwolfe> hmm
19:53:08 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6560]: eclipse tools: increase version number for changed features and plugins - … <http://dev.openmrs.org/changeset/6560>
19:53:14 <bwolfe> when did this start ?
19:53:33 <nribeka> this noon when i want to run the test
19:53:41 <nribeka> after i run the ant clean
19:56:08 <bwolfe> hmm
19:56:15 <bwolfe> did you run compile-api-tests
19:56:19 <bwolfe> or anythign else ?
19:56:25 <bwolfe> sometimes eclipse is just a little picky
19:56:29 <bwolfe> and I don't know why
19:56:31 <nribeka> ok ok i got it running bwolfe
19:56:31 <nribeka> :D
19:56:34 <nribeka> sorry :P
19:57:37 <bwolfe> what was the problem ?
19:57:42 <bwolfe> or what did you do to fix it ?
19:58:30 <nribeka> hahaha i use the eclipse clean instead of ant clean target
19:59:08 <nribeka> ERROR - BasicPropertyAccessor$BasicSetter.set(94) |2009-01-07 14:58:33,519| IllegalArgumentException in class: org.openmrs.Person, setter method of property: personCreator
19:59:08 <nribeka> ERROR - BasicPropertyAccessor$BasicSetter.set(98) |2009-01-07 14:58:33,524| expected type: org.openmrs.User, actual value: org.openmrs.Patient
19:59:10 <nribeka> :(
20:01:44 <bmckown> this bug keeps popping up.
20:01:53 <bmckown> that is ticket number....
20:01:59 <nribeka> which bug bmckown?
20:01:59 <nribeka> :D
20:02:10 <bmckown> let me find it again...
20:02:23 <nribeka> #725?
20:02:34 <nribeka> http://dev.openmrs.org/ticket/725
20:03:01 <bmckown> ah. you win. yes 725
20:03:04 <nribeka> bmckown, i'm testing those bug right now :)
20:03:14 <nribeka> assigned to --> nribeka
20:03:23 <bmckown> really (duh, sorry)
20:03:43 <nribeka> happy new year bmckown
20:03:47 <nribeka> how was the party?
20:03:48 <nribeka> :D
20:03:53 <nribeka> bwolfe too
20:03:57 <nribeka> james_regen too
20:03:58 <bmckown> happy new year, nribeka
20:04:05 <nribeka> everyone in the irc :D
20:25:13 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6562]: eclipse tools: increase version number for changed features and plugins - … <http://dev.openmrs.org/changeset/6562> || OpenMRS Changesets: Changeset [6561]: eclipse tools: update the site.xml descriptor of the update site - #1197 <http://dev.openmrs.org/changeset/6561>
20:41:45 *** nribeka has quit IRC
20:51:56 *** nribeka has joined #openmrs
21:02:54 <basic`> bwolfe: are the commit emails still not sending out?
21:03:21 <bwolfe> basic`: I haven't gotten any for 3 weeks
21:03:29 <basic`> that's very odd
21:03:48 <bwolfe> any errors on your end ?
21:03:57 <basic`> well, let me see if i can get the color emails working, i remember they weren't happy the last time i tried switching
21:04:13 <basic`> you should have access to the hooks directory if you want to tweak those too
21:05:03 <bwolfe> basic`: ok, I feel fine tweaking...but not doing the setup really
21:05:33 <basic`> sure, i just wanted to let you know (in case you're waiting on me/OSL) for something you know how to do
21:09:51 <basic`> bwolfe: can you try commiting something to test?
21:10:07 <bwolfe> hmm
21:10:21 <bwolfe> if only you had told me 10 mins ago :-p
21:10:40 <basic`> haha, epic fail
21:14:05 <bwolfe> eh, not quite "epic". I can always find /something/ to edit and commit. :-)
21:14:08 <bwolfe> done
21:14:56 <bwolfe> now we wait the requisite 10 minutes :-p
21:15:11 <basic`> hmm, i dont even see an email being queued up
21:18:08 <basic`> ahhh i think i see the problem
21:19:18 <nribeka> bwolfe, i don't understand how adding person_id to both users and patient table will solve the user / patient / person problem
21:21:30 <bwolfe> nribeka: it won't fix it by itself. but it will make it so that user_id does not have to match person_id (and patient_id does not have to match person_id)
21:22:05 <bwolfe> nribeka: this will let you use a different kind of mapping in hibernate. something other than the current "subclass" technique
21:24:24 <nribeka> bwolfe, changing the mapping would change the pojo then? no?
21:28:15 <basic`> bwolfe: okay i think i got it to send a message, depending on how long the mail takes to get to you
21:28:20 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6563]: Fixed the hashing algorithm to generated a correct SHA-1 algorithm - … <http://dev.openmrs.org/changeset/6563>
21:30:19 *** james_regen has quit IRC
21:36:23 <bwolfe> basic`: do you need me to commit something again? or did you push the last one through ?
21:36:32 <basic`> i just manually ran it
21:36:37 <basic`> it says it sent an email
21:40:00 <basic`> bwolfe: anything coming through?
21:40:32 <bwolfe> nothing yet, but I wasn't exaggerating, it does take almost 10 mins
21:40:39 <basic`> oof
21:40:57 <basic`> it's definitely sending the html color emails now, but they may be hung up somewhere else
21:41:25 <basic`> openmrs.osuosl.org postfix/smtp[4700]: CB3D9346C0A: to=<svn@openmrs.org>, relay=smtp4.osuosl.org[140.211.166.137]:25, delay=0.4, delays=0.36/0.02/0.01/0.01, dsn=2.0.0, status=sent (250 2.0.0 Ok: queued as 0549B3EEA0)
21:43:45 <bwolfe> basic`: is the "from" still "svn@openmrs.org" ?
21:43:51 <basic`> yes
21:44:03 <bwolfe> ok, so our mail server should be letting them through
21:44:10 <basic`> wouldn't hurt to check that though
21:44:30 <basic`> the post commit is running: /usr/bin/svnnotify --repos-path "$1" --revision "$2" --from svn@openmrs.org --to svn@openmrs.org -C -d --handler HTML::ColorDiff
21:46:21 <bwolfe> basic`: just committed something else
21:59:29 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6565]: Cleaned up some of the scheduler java files <http://dev.openmrs.org/changeset/6565> || OpenMRS Tickets: Ticket #1178 (defect closed): hexString in src/api/org/openmrs/util/Security.java does not properly hexify string <http://dev.openmrs.org/ticket/1178#comment:3> || OpenMRS Changesets: Changeset [6564]: mdrtb module. minor change to add/edit dst controllers. <http://dev.openmrs.org/changeset/6564>
22:21:36 <basic`> bwolfe: anything? that's odd, they should be sending
22:21:46 <bwolfe> nothing :-/
22:22:01 <bwolfe> I'll send you an email if they come through tonight
22:22:15 <bwolfe> and have burke check the listserv logs
22:22:18 <nribeka> bwolfe, are u going to be online tonight?
22:22:27 <bwolfe> probably not
22:22:37 <nribeka> :(
22:22:53 <bwolfe> nribeka: I'll be on email though
22:23:02 <nribeka> ooo ok ok
22:23:06 <nribeka> i will send some pm
22:23:07 <bwolfe> nribeka: send me an email with any questions you have and I'll get back to you
22:23:09 <nribeka> hahaha lolz
22:23:45 <bwolfe> now that I have my phone checking my email I don't always turn my laptop on at night :-)
22:23:54 <nribeka> bwolfe, so the idea is user will have: person_id and user_id
22:23:59 <bwolfe> yeah
22:24:07 <nribeka> and patient will have: person_id and patient_id
22:24:11 <bwolfe> yep
22:24:12 <bwolfe> you got it
22:24:39 <nribeka> person_id in each of them (patient and users) will have the same value with the person table, right?
22:24:41 <bwolfe> the patient table will, anyway
22:24:52 <bwolfe> the person table won't know about user and patient
22:25:11 <nribeka> but the patient_id and user_id won't be the same value as the person_id?
22:25:17 <bwolfe> correct
22:25:33 <bwolfe> and thats all for now, I have to run!
22:25:39 <nribeka> ok ok :)
22:25:39 <bwolfe> send me an email... :-0
22:25:41 <bwolfe> :-)
22:25:44 <nribeka> i will ask more later :D
22:31:29 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6568]: Changed some api calls in the web layer to match the new post-refactoring … <http://dev.openmrs.org/changeset/6568> || OpenMRS Changesets: Changeset [6567]: eclipse tools: update in the distrobuilder script - #1197 <http://dev.openmrs.org/changeset/6567> || OpenMRS Changesets: Changeset [6566]: Cleaned up some warnings in report service and DataExportFunctions <http://dev.openmrs.org/changeset/6566>
22:33:45 <nribeka> off for now
22:33:46 <nribeka> :D
22:33:46 *** nribeka has left #openmrs
22:34:47 *** nribeka has joined #openmrs
22:36:17 *** nribeka has quit IRC
22:45:05 *** bwolfe has quit IRC
22:52:10 *** atomicturtle has quit IRC
23:20:12 *** bmckown has quit IRC