| 00:24:09 | *** nribeka1 has quit IRC |
| 00:54:39 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6256]: visitregister. replacing build.xml with Mike's original version. <http://dev.openmrs.org/changeset/6256> || OpenMRS Changesets: Changeset [6255]: visitregister module added the navigation and controls for the two ⦠<http://dev.openmrs.org/changeset/6255> |
| 02:01:35 | *** atomicturtle has joined #openmrs |
| 02:01:49 | *** atomicturtle has left #openmrs |
| 02:12:50 | *** pygi has quit IRC |
| 02:30:48 | *** pygi has joined #openmrs |
| 02:34:07 | *** pygi has quit IRC |
| 02:34:35 | *** pygi has joined #openmrs |
| 02:36:43 | *** nribeka has joined #openmrs |
| 02:37:11 | *** pygi has quit IRC |
| 02:37:29 | *** pygi has joined #openmrs |
| 02:58:03 | *** pygi has quit IRC |
| 03:36:43 | *** nribeka has quit IRC |
| 05:24:29 | *** atomicturtle1 has joined #openmrs |
| 05:34:29 | *** [m_harrison] has quit IRC |
| 05:44:45 | *** nribeka has joined #openmrs |
| 06:10:56 | *** pygi has joined #openmrs |
| 06:14:59 | *** pygi has quit IRC |
| 06:29:22 | *** r0bby has quit IRC |
| 06:33:38 | *** njero has quit IRC |
| 07:36:53 | *** nribeka1 has joined #openmrs |
| 07:36:59 | *** nribeka1 has left #openmrs |
| 07:58:20 | *** nribeka has quit IRC |
| 10:01:19 | *** pygi has joined #openmrs |
| 10:46:09 | *** pygi has quit IRC |
| 12:19:41 | *** pygi has joined #openmrs |
| 12:22:51 | *** james_regen has joined #openmrs |
| 12:22:51 | *** ChanServ sets mode: +v james_regen |
| 12:29:49 | *** nribeka has joined #openmrs |
| 13:03:54 | *** kapten_yuba has joined #openmrs |
| 13:04:02 | *** kapten_yuba has left #openmrs |
| 13:17:11 | *** bwolfe_ has joined #openmrs |
| 13:17:11 | *** ChanServ sets mode: +o bwolfe_ |
| 13:51:33 | *** bwolfe_ is now known as bwolfe |
| 14:27:36 | *** Keelhaul has joined #openmrs |
| 14:28:52 | <Keelhaul> hi |
| 14:31:54 | <bwolfe> hey |
| 14:33:52 | *** bmckown has joined #openmrs |
| 14:33:52 | *** ChanServ sets mode: +o bmckown |
| 14:40:15 | <Keelhaul> bwolfe: i've run into some java out of mem errors yesterday trying to add a report template, and the measures show on the wiki dont help =/ |
| 14:40:46 | <bwolfe> Keelhaul: heap space ? |
| 14:41:06 | <Keelhaul> yea |
| 14:41:27 | <Keelhaul> in fact, a fraction of that template will cause it too |
| 14:41:35 | <bwolfe> interesting |
| 14:41:41 | <bwolfe> which page ? |
| 14:41:48 | <bwolfe> is this in a module? |
| 14:42:06 | <Keelhaul> openmrs/admin/reports/reportSchemaXml.form |
| 14:42:15 | <Keelhaul> not sure whether it's in reporttemplate module or core |
| 14:42:38 | <bwolfe> core I think |
| 14:42:57 | <bwolfe> whats your schema doing ? |
| 14:43:15 | <Keelhaul> basically |
| 14:43:54 | <Keelhaul> stuff like "total of patients who have diabetes and who have had test X performed during a given time interval" |
| 14:44:13 | <Keelhaul> and also "total of patients who had that test and the results where in the target range" |
| 14:44:28 | <Keelhaul> the latter calls a macro that tests both ends of the normal range |
| 14:44:42 | *** atomicturtle1 has quit IRC |
| 14:44:48 | <bwolfe> how many patients do you have Keelhaul ? |
| 14:44:54 | <Keelhaul> just one in this db |
| 14:45:02 | <bwolfe> heh |
| 14:45:03 | <Keelhaul> it wont even let me save the schema |
| 14:45:12 | <bwolfe> because of the heap space error? |
| 14:45:16 | <Keelhaul> depending on which elements i put in it |
| 14:45:16 | <Keelhaul> yes |
| 14:45:17 | *** atomicturtle has joined #openmrs |
| 14:45:41 | <Keelhaul> the ones with the target range throw the heap space error most often i think |
| 14:46:27 | <bwolfe> pastebin your schema |
| 14:46:43 | <Keelhaul> hold on |
| 14:48:31 | <Keelhaul> http://rafb.net/p/VCWUK824.html |
| 14:48:45 | <Keelhaul> not sure why the 1.x entries are displaced |
| 14:49:01 | <Keelhaul> the 2.x ones are the ones cause the error |
| 14:49:25 | <Keelhaul> others seem to work fine |
| 14:49:41 | <Keelhaul> http://rafb.net/p/kosMzV66.html |
| 14:49:44 | <Keelhaul> these are the macros |
| 14:52:04 | <bwolfe> and TestHbA1cTargetLower are your "patient searches" ? |
| 14:52:21 | <Keelhaul> yes |
| 14:53:04 | <bwolfe> Keelhaul: I don't see anything glaringly wrong |
| 14:53:12 | <bwolfe> but I don't use the reportschema stuff very much (at all) |
| 14:53:24 | <bwolfe> so you'll have to get the input from darius/mike on the mailing list |
| 14:53:33 | <bwolfe> or someone else that has used the report schema stuff |
| 14:54:07 | <Keelhaul> yea |
| 14:54:13 | <Keelhaul> this is the first time i'm using it too |
| 14:56:04 | <Keelhaul> http://rafb.net/p/FifAyM76.html |
| 14:56:13 | <Keelhaul> thats the particular search you mentioned |
| 15:00:14 | <bwolfe> is this the right way to reference properties in the patient search object? $begin_date$ |
| 15:00:26 | <bwolfe> or is it ${begin_date} ? |
| 15:00:32 | <Keelhaul> i got it from the example on the wiki |
| 15:00:38 | <Keelhaul> and it seems to work |
| 15:01:08 | <Keelhaul> at least for the indicators that dont throw the error, it does or does not find the patient, depending on the dates i pass |
| 15:03:01 | <bwolfe> ah, ok, good |
| 15:15:40 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6257]: visitregister -- diagnosis count table completed <http://dev.openmrs.org/changeset/6257> |
| 15:16:08 | <Keelhaul> why dont docpaul and burke come here anymore |
| 15:19:22 | *** atomicturtle1 has joined #openmrs |
| 15:19:36 | *** atomicturtle has quit IRC |
| 15:22:11 | <bwolfe> Keelhaul: I dunno...too busy ? |
| 15:22:21 | <bwolfe> Keelhaul: they really come for support when its around gsoc time |
| 15:28:21 | <Keelhaul> hmm |
| 15:28:40 | <Keelhaul> bwolfe: is it good practice to have a module add new roles and privs automatically |
| 15:28:43 | <bwolfe> basic`: any attention on beautying the svn commit mails ? |
| 15:28:57 | <bwolfe> Keelhaul: you can do that via the context.xml automagically |
| 15:29:00 | <bwolfe> so yes, it is |
| 15:29:24 | <Keelhaul> roles too? |
| 15:35:04 | *** kapten_yuba has joined #openmrs |
| 15:35:37 | *** kapten_yuba has left #openmrs |
| 15:38:35 | <Keelhaul> bwolfe: i see no roles element in the config file wiki |
| 15:38:50 | <bwolfe> Keelhaul: ah...I lied about that one |
| 15:38:55 | <bwolfe> jsut privileges :-) |
| 15:39:00 | <Keelhaul> it'd be nice if they could be added there, and which privs should go with them |
| 15:39:32 | <Keelhaul> bwolfe: which one is called first, config.xml or sqldiff? |
| 15:39:48 | <bwolfe> Keelhaul: not sure |
| 15:40:00 | <Keelhaul> i guess i could add a line to sqldiff adding the role |
| 15:40:08 | <Keelhaul> but i dont tihnk i can add the priv to it right away |
| 15:47:43 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6258]: in patient matching module, changed activator to remove privileges after ⦠<http://dev.openmrs.org/changeset/6258> |
| 15:51:03 | *** Echidna has joined #openmrs |
| 15:52:44 | <Keelhaul> bwolfe: whats that "+1" people say, is there some counter in the mailer or is it just a figure of speech? =o |
| 15:53:04 | <bwolfe> Keelhaul: just a figure of speech |
| 15:53:26 | <bwolfe> Keelhaul: its "I agree. I would vote on it if you were actually asking for votes explicitly" |
| 15:53:37 | <Keelhaul> i see.. |
| 15:53:51 | <bwolfe> Keelhaul: its all Darius's fault...he's the one that kept saying just +1 in emails instead of "I agree". |
| 15:53:55 | <bwolfe> drives me crazy... |
| 15:54:08 | <Keelhaul> lol |
| 15:54:20 | <Keelhaul> well, as long as it |
| 15:54:27 | <Keelhaul> isnt the only thing he writes |
| 15:55:24 | <bwolfe> sometimes it is! :-) |
| 15:56:03 | <Keelhaul> bwolfe: : i think i saw people "agreeing" on forums by quoting an entire post w/o saying anything themselves |
| 15:56:36 | <bwolfe> heh, thats a tad worse |
| 15:57:01 | <Keelhaul> bwolfe: is there any harm in giving a patient the "view concepts" priv? |
| 15:57:48 | <bwolfe> Keelhaul: a patient technically doesn't have the ability to view concepts |
| 15:57:52 | <bwolfe> only users do |
| 15:58:08 | <Keelhaul> no |
| 15:58:30 | <Keelhaul> but i need to load a single obs at one point |
| 15:58:37 | <Keelhaul> and proxy privs dont seem to work here |
| 15:58:39 | <Keelhaul> for some reason |
| 15:58:45 | <Keelhaul> err single concept |
| 15:58:46 | <Keelhaul> not obs |
| 15:59:07 | <bwolfe> concepts are just the questions and potential answers, so giving people view rights is not a problem |
| 15:59:19 | <bwolfe> Keelhaul: check the log, it should say exactly what privilege is required |
| 15:59:49 | <Keelhaul> it says on the page itself |
| 15:59:51 | <Keelhaul> view concepts =) |
| 16:00:33 | <bwolfe> well there you go |
| 16:00:37 | <Echidna> hey i've had internet at home for 2 hours now |
| 16:00:42 | <Echidna> =) |
| 16:00:44 | <bwolfe> nice |
| 16:00:50 | <Echidna> pos cable service |
| 16:00:50 | <bwolfe> how long does it usually last ? |
| 16:00:56 | <Echidna> dunno |
| 16:01:00 | <Echidna> it usually works fine |
| 16:01:04 | <Echidna> but a week ago it went out |
| 16:01:14 | <Echidna> and then i get internet for a few second every few minutes |
| 16:03:13 | <bwolfe> Echidna: you sure its not your router flaking out ? |
| 16:03:54 | <Echidna> yes |
| 16:04:04 | <Echidna> the cable modem keeps disconnecting |
| 16:04:18 | <Echidna> they said it's a defect in the neighborhood and they have to dig or smt |
| 16:05:07 | <Echidna> this is so much better than mibbit |
| 16:05:08 | <Echidna> lol |
| 16:05:47 | <Echidna> hmm |
| 16:06:08 | <Echidna> if i add a proxy priv for loading the concept, it doesnt compain about lacking the priv anymore |
| 16:06:14 | <Echidna> but then it says invalid concept |
| 16:06:25 | <Echidna> does the conceptsearch widget need the priv too? |
| 16:11:47 | <bwolfe> Echidna: the proxy privilege is given to the current context (the currently logged in user) |
| 16:12:09 | <bwolfe> the search widget delegates to the concept services which checks the current context for the priv |
| 16:15:17 | <Echidna> oh hm |
| 16:15:41 | <Echidna> so i cant remove the proxy priv at all |
| 16:15:42 | <Echidna> =/ |
| 16:15:54 | <Echidna> which is de facto the same as giving the user a real priv |
| 16:17:57 | <bwolfe> why can't you remove it ? |
| 16:18:13 | *** atomicturtle1 has quit IRC |
| 16:21:09 | <Echidna> because the jsp that loads the widget keeps getting reloaded |
| 16:21:19 | <Echidna> i cant think of a moment to remove that priv |
| 16:21:30 | <Echidna> since i cant remove it in the controller |
| 16:27:39 | <bwolfe> whats your use case Echidna ? |
| 16:29:25 | <Echidna> patient logs in and has a link to adding new obs for his own record |
| 16:29:45 | <Echidna> that link will lead to a list of pre-defined forms, each has a static concept |
| 16:29:59 | <Echidna> e.g. for blood sugar |
| 16:30:09 | <Echidna> that concept needs ot be loaded |
| 16:30:17 | <Echidna> so far, i just gave the patient the view concepts priv |
| 16:30:20 | <Echidna> and everything worked fine |
| 16:47:47 | *** Keelhaul has quit IRC |
| 16:49:52 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6260]: visitregister: Addition of DWRMethods, Tag Library, Global Properites, ⦠<http://dev.openmrs.org/changeset/6260> || OpenMRS Changesets: Changeset [6259]: visitregister: Addition of DWRMethods, Tag Library, Global Properites, ⦠<http://dev.openmrs.org/changeset/6259> |
| 17:16:23 | *** atomicturtle has joined #openmrs |
| 17:16:59 | <Echidna> ok, i'm going home |
| 17:17:03 | <Echidna> bbl, if the internet permits |
| 17:20:10 | <nribeka> bwolfe, bmckown i don't understand the advantage of User / Patient / Person thing |
| 17:20:36 | <bmckown> what do you mean, nribeka ? |
| 17:21:57 | <nribeka> But after considering that it lets you cheat out of an extra join or two in large sql queries I began to appreciate it. :) |
| 17:23:05 | <bmckown> to my understanding, proper and good data modeling would mean instead of using the same id for user/person/patient etc you should use different id's and foreign key them. |
| 17:24:15 | <bmckown> but then... if you do the proper thing say you want the person_name and person_address from all patients with an encounter |
| 17:24:41 | <basic`> bwolfe: haven't had a chance to look (just finished my last final of the term)... i wasn't sure what was causing them to fail the last i tried it |
| 17:25:18 | <bmckown> (bwolfe is away for the moment) |
| 17:26:00 | <bmckown> or better say you want the person_name and person_address for all patients. |
| 17:27:32 | <bmckown> you can cheat by not always needing to join the patient table (sometimes) |
| 17:29:34 | <bmckown> because the same id is used as a key in the person table and the patient table. |
| 17:29:42 | <bwolfe> basic`: I suppose thats a good reason... :-) |
| 17:30:01 | <nribeka> ah ic ic |
| 17:30:33 | <bmckown> still not sure what my data model professor would think. he would probably have had a fit to see the shared key thing. |
| 17:31:11 | <bmckown> _Mastering_Data_Modeling_ by John Carlis |
| 17:32:36 | <bmckown> the author of the book and friend - my professor was Jake Chen |
| 17:33:20 | <bmckown> (Carlis is friend of the professor i mean) |
| 17:33:39 | <nribeka> i think i understand why |
| 17:34:09 | <bmckown> what do you opin, nribeka ? |
| 17:34:22 | <nribeka> well, we got some issue because the User / Patient problem bmckown |
| 17:34:37 | <bmckown> with patient matching? |
| 17:34:51 | <bmckown> or the hibernate user / patient problem. |
| 17:34:54 | <bmckown> ? |
| 17:36:13 | <nribeka> yeah. both :D |
| 17:36:16 | <nribeka> [2008-12-07 12:37:05]IllegalArgumentException in class: org.openmrs.Person, setter method of property: personChangedBy |
| 17:36:16 | <nribeka> [2008-12-07 12:37:05]expected type: org.openmrs.User, actual value: org.openmrs.Patient |
| 17:38:14 | <bmckown> ooh. yes. |
| 17:38:20 | <bmckown> not good. |
| 17:39:43 | <nribeka> any suggestions? bwolfe said yesterday ask him to update the database |
| 17:39:46 | <nribeka> hahaha ... |
| 17:40:18 | <bmckown> but that has more to do with the fact that Patient and User are child classes of Person and how hibernate deals with that no? I suppose a quick fix would be if they had different id's. I was under the impression that the other solution would be that they are not child classes. or modeled differently in hibernate maybe. |
| 17:41:59 | <nribeka> yes, bwolfe also said it is because User / Patient comes from Person and hibernate will load whichever is found first |
| 17:42:07 | <bmckown> i didn't necessarily have a solution... just wanted to mention that a solution that involves removing the shared primary key could have a performance hit - which would possibly affect us quite seriously in Eldoret, Kenya. |
| 17:43:08 | <nribeka> ah ic ic |
| 17:43:32 | <nribeka> so, we need to ask james arbaugh to update his data? |
| 17:44:21 | <bmckown> yea, maybe so. :-) |
| 17:45:30 | <nribeka> :( |
| 17:45:35 | <nribeka> that's bad :P |
| 17:47:23 | <bwolfe> nribeka: why is that bad? has he said he intentionally put that data in there like that ? |
| 17:47:33 | <bwolfe> nribeka: because he obviously didn't use the webapp to do it. :-D |
| 17:48:26 | <nribeka> ooo you think so bwolfe? |
| 17:48:34 | <nribeka> i will invite james to come in :) |
| 17:48:48 | <nribeka> james_regen, this is the explanation from bwolfe :P |
| 17:52:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6261]: visitregister -- everything basically in place. may need to change obs ⦠<http://dev.openmrs.org/changeset/6261> |
| 17:56:53 | *** njero has joined #openmrs |
| 17:56:53 | *** ChanServ sets mode: +v njero |
| 18:06:34 | *** nribeka has quit IRC |
| 18:07:44 | *** nribeka has joined #openmrs |
| 18:56:06 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1166 (defect created): Cohort Column broken in data exports <http://dev.openmrs.org/ticket/1166> || OpenMRS Tickets: Ticket #107 (task closed): Add support for complex obs to Obs.form <http://dev.openmrs.org/ticket/107#comment:5> |
| 19:28:09 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1161 (task closed): Complex Obs Needs Unit Tests <http://dev.openmrs.org/ticket/1161#comment:1> || OpenMRS Changesets: Changeset [6262]: complex-obs: Adding unit tests for complex obs - #1162 Deprecated all the ⦠<http://dev.openmrs.org/changeset/6262> |
| 19:41:47 | *** nribeka has quit IRC |
| 19:51:10 | *** [mharrison] has joined #openmrs |
| 20:21:33 | *** nribeka has joined #openmrs |
| 20:32:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1162 (task closed): Complex Obs Update Sql needs cleaned up <http://dev.openmrs.org/ticket/1162#comment:1> || OpenMRS Changesets: Changeset [6265]: complex-obs: Moved complex obs update sql to update-to-latest scripts - ⦠<http://dev.openmrs.org/changeset/6265> || OpenMRS Changesets: Changeset [6264]: visitregister: Cosmetic changes to registry form and fix of local header. <http://dev.openmrs.org/changeset/6264> || OpenMRS Changesets: Changeset [6263]: visitregister: Removal of ability to edit visit records on registry, user ⦠<http://dev.openmrs.org/changeset/6263> |
| 20:40:28 | *** kapten_yuba has joined #openmrs |
| 20:40:33 | *** kapten_yuba has left #openmrs |
| 21:04:15 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6254]: gmapsimageviewer: bugfix: check if any subimage has an annotation; if so, ⦠<http://dev.openmrs.org/changeset/6254> |
| 21:07:42 | *** r0bby has joined #openmrs |
| 21:07:42 | *** ChanServ sets mode: +v r0bby |
| 21:20:34 | *** james_regen has quit IRC |
| 21:33:35 | *** Echidna has quit IRC |
| 21:36:18 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6266]: visitregister -- added sorting to diagnosis table by map value, and ⦠<http://dev.openmrs.org/changeset/6266> |
| 21:38:40 | *** Echidna has joined #openmrs |
| 22:08:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1167 (defect created): Concept mappings are no longer editable <http://dev.openmrs.org/ticket/1167> |
| 22:41:43 | *** bwolfe has quit IRC |
| 22:49:27 | *** bmckown has quit IRC |
| 23:01:48 | *** kapten_yuba has joined #openmrs |
| 23:02:38 | *** kapten_yuba has left #openmrs |
| 23:04:49 | *** Mario__ has joined #openmrs |
| 23:07:56 | *** pygi has quit IRC |
| 23:12:25 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1168 (task created): Prepare the DevStudio 0.2 release <http://dev.openmrs.org/ticket/1168> || OpenMRS Tickets: Ticket #1077 (enhancement closed): config.xml editor <http://dev.openmrs.org/ticket/1077> || OpenMRS Changesets: Changeset [6267]: eclipse tools: handle save in source page and safety switch between ⦠<http://dev.openmrs.org/changeset/6267> |