IRC Chat : 2008-12-03 - OpenMRS

00:42:03 *** bmckown has quit IRC
00:42:30 *** nribeka has joined #openmrs
01:02:33 *** kapten_yuba has joined #openmrs
01:02:36 *** nribeka has quit IRC
01:02:52 *** kapten_yuba has left #openmrs
01:32:25 *** nribeka has joined #openmrs
01:51:27 *** [mharrison] has joined #openmrs
01:55:45 *** [mharrison] has quit IRC
02:02:22 *** [mharrison] has joined #openmrs
02:26:26 *** pygi has quit IRC
03:23:08 *** nribeka1 has joined #openmrs
03:43:38 *** nribeka has quit IRC
04:26:28 *** bwolfe has quit IRC
05:09:55 *** kapten_yuba has joined #openmrs
05:10:03 *** kapten_yuba has left #openmrs
06:01:34 *** nribeka has joined #openmrs
06:20:04 *** nribeka1 has quit IRC
07:39:45 *** [mharrison] has quit IRC
09:37:24 *** crazee has joined #openmrs
09:37:24 *** ChanServ sets mode: +v crazee
09:39:48 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: [b]Database version 1.5.0.01 download[/b] <http://forum.openmrs.org/viewtopic.php?f=11&t=415#p1449>
12:41:08 *** pygi has joined #openmrs
13:07:38 *** james_regen has joined #openmrs
13:07:38 *** ChanServ sets mode: +v james_regen
13:17:44 *** bwolfe has joined #openmrs
13:17:44 *** ChanServ sets mode: +o bwolfe
13:24:10 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6170]: -- chica * fixed compile error by throwing exception <http://dev.openmrs.org/changeset/6170>
13:58:23 *** nribeka2 has joined #openmrs
14:07:21 *** nribeka2 has quit IRC
14:07:38 *** nribeka2 has joined #openmrs
14:10:44 *** nribeka has quit IRC
14:19:21 *** bmckown has joined #openmrs
14:19:21 *** ChanServ sets mode: +o bmckown
14:21:02 *** bwolfe_ has joined #openmrs
14:21:02 *** ChanServ sets mode: +o bwolfe_
14:21:19 *** bwolfe has quit IRC
14:26:15 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Database version 1.5.0.01 download <http://forum.openmrs.org/viewtopic.php?f=11&t=415#p1450> || OpenMRS Changesets: Changeset [6172]: -- chica * fixed sql diff version <http://dev.openmrs.org/changeset/6172> || OpenMRS Changesets: Changeset [6171]: -- chica * added back some changes that got accidentally reverted <http://dev.openmrs.org/changeset/6171>
14:31:44 <bwolfe_> basic`: burke sent me what he has on a different server: /usr/bin/perl /usr/local/bin/svnnotify --repos-path "$1" --revision "$2" --from svn@openmrs.org --handler HTML::ColorDiff -x svn@openmrs.org -C -d
14:31:54 <bwolfe_> basic`: do you have the svnnotify script ?
14:58:18 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6173]: -- chica * fixed sqldiff version * fixed wording of error <http://dev.openmrs.org/changeset/6173>
15:18:12 *** Keelhaul has joined #openmrs
15:18:12 *** ChanServ sets mode: +v Keelhaul
15:23:13 <Keelhaul> bwolfe_: need your hibernate buffness =/
15:23:31 *** crazee has quit IRC
15:28:03 *** atomicturtle has joined #openmrs
15:30:21 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6175]: simplelabentry: Add Header inclusion after RequireConfigurationTag <http://dev.openmrs.org/changeset/6175> || OpenMRS Forum: Re: Database version 1.5.0.01 download <http://forum.openmrs.org/viewtopic.php?f=11&t=415#p1451> || OpenMRS Changesets: Changeset [6174]: simplelabentry: Add IllegalStateException handling to … <http://dev.openmrs.org/changeset/6174>
15:33:39 *** bwolfe__ has joined #openmrs
15:33:49 *** bwolfe__ is now known as bwolfe
15:33:57 *** ChanServ sets mode: +o bwolfe
15:34:06 *** bwolfe_ has quit IRC
15:34:46 <bwolfe> yes Keelhaul ?
15:34:49 <Keelhaul> hi
15:34:57 <Keelhaul> well remember the location extensions i added
15:35:03 <Keelhaul> not the ticket, the ones in my module
15:35:09 <Keelhaul> department, specialty and room
15:35:22 <Keelhaul> i'm getting lazyinitiationexceptions when trying to save existing ones
15:35:35 <Keelhaul> if i disable lazy, i get nonunique exceptions instead
15:36:38 <bwolfe> hmm
15:37:01 <bwolfe> are you still cascading up the tree ?
15:37:07 <bwolfe> ...I still think thats a bad idea
15:37:11 <Keelhaul> up?
15:37:12 <Keelhaul> or down
15:37:25 <bwolfe> I remember you doing it up the tree
15:37:33 <bwolfe> down seems feasible
15:37:34 <Keelhaul> they're set to cascade down the tree
15:37:41 <Keelhaul> all-delete-orphan
15:37:53 <Keelhaul> but i never cascaded up the tree
15:38:29 <Keelhaul> http://rafb.net/p/8MfSTI34.html
15:38:34 <bwolfe> hmm
15:38:48 <bwolfe> did you make your own service ?
15:38:55 <Keelhaul> i did now
15:38:56 <bwolfe> is it set to be @Transactional ?
15:39:00 <Keelhaul> yes
15:39:07 <Keelhaul> before, i extended LocationService
15:39:13 <Keelhaul> today i moved it all to a new service
15:39:14 <Keelhaul> no change
15:39:42 <bwolfe> I'm betting its with your cascade
15:39:54 <bwolfe> which line does it fail on with the lazyinitexception ?
15:40:41 <Keelhaul> if (department.getSpecialties() != null) {
15:40:41 <Keelhaul> for (Specialty s : department.getSpecialties()) {
15:40:44 <Keelhaul> the last one
15:41:00 <Keelhaul> after that it's supposed to set creator and datecreated if null
15:46:54 <Keelhaul> http://rafb.net/p/3N1JIK45.html this is my mapping
15:47:12 *** jmiranda has joined #openmrs
15:48:21 *** ChanServ sets mode: +o jmiranda
16:00:28 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Database version 1.5.0.01 download <http://forum.openmrs.org/viewtopic.php?f=11&t=415#p1452> || OpenMRS Changesets: Changeset [6176]: simplelabentry: Add Header inclusion after RequireConfigurationTag <http://dev.openmrs.org/changeset/6176>
16:01:15 *** nribeka2 has quit IRC
16:01:20 *** nribeka has joined #openmrs
16:04:25 *** nribeka1 has joined #openmrs
16:04:46 <bwolfe> Keelhaul: so a department can have 0 to n specialities ?
16:05:20 <bwolfe> where is that for loop you pasted? can you rafb it ?
16:05:33 <Keelhaul> hold on
16:06:06 <Keelhaul> http://rafb.net/p/C5wqn817.html
16:06:14 <Keelhaul> that's from LocationExtensionServiceImpl
16:07:21 <bwolfe> Keelhaul: and this has the @Transactional at the top of the class ?
16:07:47 <bwolfe> where is the code that is getting this object out ?
16:07:48 <Keelhaul> at the top of the parent interface, yes
16:08:08 <Keelhaul> getting out? =o
16:08:09 <Keelhaul> what do you mean
16:08:25 <Keelhaul> oh nm, the impl class has @Transactional as well
16:08:37 <Keelhaul> @Transactional
16:08:38 <Keelhaul> public class LocationExtensionServiceImpl implements LocationExtensionService {
16:14:18 *** bmckown has quit IRC
16:16:02 *** bmckown has joined #openmrs
16:16:02 *** irc.freenode.net sets mode: +o bmckown
16:21:41 <bwolfe> LocationExtensionService has it too, right ?
16:21:52 <Keelhaul> yes
16:22:01 <bwolfe> Keelhaul: by getting out I meant, whats the method look like where you do a getDepartments()
16:23:06 <Keelhaul> public Set<Specialty> getSpecialties() {
16:23:06 <Keelhaul> return specialties;
16:23:06 <Keelhaul> }
16:23:07 *** nribeka has quit IRC
16:45:38 <basic`> bwolfe: yeah, i could install that... it doesn't handle revprop changes though (afaik)
16:46:21 <bwolfe> basic`: oh, the two are one ?
16:46:42 <basic`> i was hoping for a solution that didn't need 2 scripts, but i couldn't find one that handles both emails
16:46:49 <bwolfe> Keelhaul: no, thats not what I meant. I meant the getDeparatments methdo on the service. can you rafb your whole service class ?
16:48:04 <Keelhaul> ok
16:48:27 <Keelhaul> http://rafb.net/p/oTUs8s71.html
16:52:46 *** atomicturtle has quit IRC
16:56:50 <bwolfe> Keelhaul: ok, so what happens to that list of departments between getDepartments and saveDepartments ?
16:57:44 <Keelhaul> just one department
16:58:03 <Keelhaul> it gets fetched as formbackingobject, altered, saveed
16:58:38 <Keelhaul> http://rafb.net/p/cpZLdi88.html
16:58:41 <Keelhaul> this is the controller
17:00:39 <bwolfe> Keelhaul: ok, how is that controller defined in the spring app xml ?
17:01:18 <Keelhaul> http://rafb.net/p/L7iT7u49.html
17:02:53 <bwolfe> try setting "sessionForm" to false. it will call formBackingObject twice (once when loading the page, again after submitting the page), but might prevent the lazyinitexception
17:03:13 <Keelhaul> hm
17:05:40 <Keelhaul> bwolfe: ok, no more exception
17:05:41 <Keelhaul> but why
17:06:16 <bwolfe> because the transaction was getting closed and opened again but the object stayed around.
17:06:41 <bwolfe> the object was attached to the first transaction (the loading of hte page) and then saved with the second transaction (the submitting of the form)
17:06:43 <Keelhaul> i also get a lazy exception when saving my custom encounters
17:06:56 <bwolfe> probably a similar thing
17:07:05 <Keelhaul> the encounter itself doesnt have to be extended, but if i use my own form, it gets a lazy exception on orders
17:07:19 <Keelhaul> even though my extension doesnt do anything with orders
17:08:00 *** atomicturtle has joined #openmrs
17:08:19 <Keelhaul> bwolfe: where are the form controllers defined in the main app?
17:09:06 <bwolfe> openmrs-servlet.xml
17:09:11 <bwolfe> control-r to findi t
17:09:15 <bwolfe> (in eclipse anyway)
17:09:23 <bwolfe> err control-shift-r
17:11:53 *** nribeka1 has quit IRC
17:12:15 <Keelhaul> argh
17:12:24 <Keelhaul> stupid eclipse opens xml files with that weird xml viewer
17:13:10 <Keelhaul> the regular encounter form controller has no sessionForm tag
17:13:15 <Keelhaul> i figure it defaults to false?
17:16:48 <bwolfe> Keelhaul: yeah, defaults to false
17:17:16 <Keelhaul> ok i'll see how it works out
17:17:29 <bwolfe> Keelhaul: you can xml files normally in eclipse by clicking that little tiny tab at the bottom of the editor window called "source"
17:17:37 <Keelhaul> my superior is supposed to have a call with burke and docpaul tomorrow, stuff has to work properly =P
17:18:17 <Keelhaul> theres also this thing i have with the 1.4.x branch
17:18:33 <Keelhaul> the web/WEB-INF folder disappeared from the package explorer
17:18:35 <Keelhaul> how can i get it back?
17:18:42 <Keelhaul> the dir is still physically there
17:18:43 <Keelhaul> just not listed
17:19:16 <bwolfe> no idea. I always use the "navigator" view instead of the dumb package explorer
17:19:45 <Keelhaul> heh
17:19:54 <Keelhaul> the explorer gives quick access to essential areas though
17:20:47 <bwolfe> thats what control-shift-t is for :-)
17:21:33 <Keelhaul> lol
17:21:38 <Keelhaul> btw
17:21:47 <Keelhaul> i had to get rid of my extended Location class
17:22:00 <Keelhaul> it was just extended to have a .getDepartments() method for convenience
17:22:09 <Keelhaul> but it somehow broke the default location editor
17:22:38 <Keelhaul> the validator was complaining that my Location != normal Location
17:22:52 <Keelhaul> even though the core code shouldnt even know of my extended class
17:23:49 <bwolfe> Keelhaul: that should probably be fixed in the LocationValidator
17:24:14 <bwolfe> the validator should check to see if the object can be cast to the other, not that its an instanceof
17:25:01 <Keelhaul> shouldnt it be the default Location class in the first place
17:25:18 <Keelhaul> or does that new class member automatically make it the new type
17:29:50 <bwolfe> Keelhaul: I don't follow your question
17:29:53 <bwolfe> what do you mean ?
17:31:04 <Keelhaul> my module used to extend Location, but why would that affect the default location management
17:31:15 <Keelhaul> it doesnt use my object type anywhere
17:31:22 <Keelhaul> yet the validator complains
17:32:00 <Keelhaul> bwolfe: http://rafb.net/p/tUqU2V69.html
17:32:05 <Keelhaul> would something like this do?
17:35:33 <bwolfe> Keelhaul: yeah, except there is a java method for it
17:35:46 <Keelhaul> oh
17:36:22 <bwolfe> Location.class.isAssignableFrom(
17:36:25 <bwolfe> I think thats it
17:39:17 <Keelhaul> ok good to know
17:39:39 <Keelhaul> great, with the lazy exceptions gone it's only one major bug left =)
17:39:40 <Keelhaul> thx
17:39:55 <Keelhaul> the other one is even more severe though
17:40:14 <Keelhaul> i have persons who are both patient and user
17:40:24 <Keelhaul> and they can enter new obs for themselves
17:40:32 <Keelhaul> which works fine
17:40:48 <Keelhaul> but when i assign those obs to a collection, something goes wrong
17:41:01 <Keelhaul> the parent object cant be listed properly anymore
17:41:32 <Keelhaul> if i change the creator id to someone else's (someone who is not a patient), everything goes back to normal
17:41:41 *** Mario_ has joined #openmrs
17:42:08 *** pygi has quit IRC
17:42:10 *** Mario_ is now known as pygi
17:45:53 <bwolfe> Keelhaul: yeah...unfortunately that is a /huge/ problem that I can't figure out :-/
17:46:22 <bwolfe> Keelhaul: I think there is a ticket out there for it
17:46:42 <Keelhaul> that's very unfortunate
17:46:50 <bwolfe> yes, yes it it
17:46:52 <bwolfe> *is
17:46:53 <Keelhaul> that's a rather major part of my thesis
17:47:02 <bwolfe> self adding ?
17:47:02 <Keelhaul> and the prof will have to see it in action eventually
17:47:04 <Keelhaul> yea
17:47:17 <bwolfe> well, its a hibernate thing
17:47:24 <bwolfe> it caches the first type of object it finds
17:47:33 *** nribeka has joined #openmrs
17:47:52 <bwolfe> and so it fetches the "person" as a "patient" first, then can't fetch it as a "user"
17:48:01 <bwolfe> so we need to fix it in core somehow
17:48:08 <Keelhaul> oh
17:48:10 <bwolfe> or figure out how to patch hibernate to not do that
17:48:27 <bwolfe> if you can propose a solution, I'll gladly take a look at it
17:48:39 <Keelhaul> if i can find the ticket first..
17:48:40 <Keelhaul> heh
17:51:58 <Keelhaul> http://dev.openmrs.org/ticket/489
17:52:00 <Keelhaul> this?
17:55:04 <Keelhaul> hmm
17:55:22 <Keelhaul> a "workaround" could be to set the creator id to 1 for patient-entered obs..
17:55:24 <Keelhaul> heh
17:56:30 <bwolfe> Keelhaul: 1 or some other random user id
17:58:15 <Keelhaul> well shouldnt be "random" heh, that might create confusion
17:58:25 <Keelhaul> a known dummy id or smt
18:18:34 *** bwolfe_ has joined #openmrs
18:18:34 *** ChanServ sets mode: +o bwolfe_
18:18:52 *** bwolfe has quit IRC
18:20:21 *** bmckown_ has joined #openmrs
18:20:36 *** bmckown has quit IRC
18:21:32 *** bmckown_ has quit IRC
18:34:50 *** [mharrison] has joined #openmrs
18:34:54 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6178]: -- atd * fixed uploadFormsController to process .XML extension * fixed … <http://dev.openmrs.org/changeset/6178> || OpenMRS Changesets: Changeset [6177]: -- dss * fixed error in getFilesInDirectory method <http://dev.openmrs.org/changeset/6177>
18:58:19 <Keelhaul> failed to lazily initialize a collection of role: org.openmrs.Concept.names, no session or session was closed
18:58:20 <Keelhaul> lol..
18:58:28 <Keelhaul> org.openmrs.Concept.getBestName(Concept.java:712)
18:58:31 <Keelhaul> that aint mine though
18:58:31 <Keelhaul> heh
19:02:24 <bwolfe_> Keelhaul: where did that happen ?
19:04:50 <Keelhaul> my custom obsformcontroller
19:05:28 <Keelhaul> maybe it's a priv issue
19:05:28 <Keelhaul> since this user doesnt has to use proxy privs to get through the controller
19:05:28 <Keelhaul> -doesnt
19:06:34 <jmiranda> i think it usually denotes a transaction issue
19:06:55 <bwolfe_> Keelhaul: yeah, feels like something changed with the whole hibernatefilter
19:07:12 <bwolfe_> Keelhaul: did you mess with the web.xml file ?
19:07:12 <jmiranda> you're referencing the collection outside the current session
19:07:14 <bwolfe_> Keelhaul: which version of openmrs are you using ?
19:07:24 <Keelhaul> no, i never touched web.xml
19:07:31 <Keelhaul> 1.4.20.6111
19:07:56 <bwolfe_> Keelhaul: have you changed anything in the core webapp ?
19:11:41 *** OpenMRSBot has joined #openmrs
19:11:43 *** ChanServ sets mode: +o OpenMRSBot
19:37:22 <Keelhaul> creating users from existing persons is somewhat inconvient, you have to know the age or dob to find him
19:37:30 <Keelhaul> inconvenient*
19:38:08 *** bwolfe__ has joined #openmrs
19:40:25 *** bwolfe_ has quit IRC
19:49:46 *** atomicturtle has left #openmrs
19:59:04 *** njero_ has joined #openmrs
20:04:59 *** njero_ has quit IRC
20:10:57 *** jmiranda has quit IRC
20:11:16 *** njero_ has joined #openmrs
20:11:25 *** jmiranda has joined #openmrs
20:15:53 *** njero has quit IRC
20:19:07 *** njero_ is now known as njero
20:19:21 *** ChanServ sets mode: +v njero
20:24:03 *** bwolfe__ is now known as bwolfe
20:24:05 *** ChanServ sets mode: +o bwolfe
21:01:25 *** njero has quit IRC
21:13:28 *** njero has joined #openmrs
21:13:28 *** ChanServ sets mode: +v njero
21:13:32 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6180]: openMRS-trunk: Date and Value substitution in "Action" strings and also … <http://dev.openmrs.org/changeset/6180> || OpenMRS Changesets: Changeset [6179]: eclipse tools: enhancements on the Servlets page of the config.xml editor … <http://dev.openmrs.org/changeset/6179>
21:23:25 *** james_regen has quit IRC
21:27:50 *** atomicturtle has joined #openmrs
21:35:07 <Keelhaul> bwolfe: who's the main guy for the reporting framework? mseaton?
21:35:20 <bwolfe> and djazayeri
21:35:23 <Keelhaul> ok
21:35:28 <Keelhaul> needa ask them something
21:35:41 <Keelhaul> apparently that thing cant calculate percentages =/
21:38:14 <basic`> bwolfe: ping
21:38:28 <bwolfe> pong
21:38:30 <basic`> i updated the post-commit to use the html/colordiff
21:38:53 <basic`> still working on the updated revprop commit
21:39:39 <bwolfe> awesome, will test a commit now
21:42:19 <bwolfe> basic`: I'm running out of random things I need to commit though...so I hope you get it right with this one. :-)
21:43:06 <basic`> haha, i hope so too
21:43:29 *** atomicturtle has left #openmrs
21:44:04 <Keelhaul> lol
21:44:23 <Keelhaul> make like a r0bby =P
21:44:54 <basic`> im also starting to wonder if maybe the revprop changes take long time becuase it's querying the trac database each time
21:45:43 <bwolfe> basic`: but the query is an instant thing if you do it at command line
21:46:02 <basic`> hmm
21:46:25 * basic` is running out of ideas for that... i guess i can try a different email script for that one
21:59:34 <nribeka> bwolfe, have u ever have this error message?
21:59:36 <nribeka> A collection with cascade="all-delete-orphan" was no longer referenced by the owning entity instance: org.openmrs.Person.addresses
22:02:31 *** jmiranda has quit IRC
22:04:03 *** [mharrison] has quit IRC
22:05:02 <basic`> bwolfe: any luck?
22:06:09 <bwolfe> basic`: it hasn't come through yet. did the mail fail again
22:06:10 <bwolfe> ?
22:07:35 <bwolfe> nribeka: yeah, you did a person.setAddresses(null) or person.setAddresses(new List(new PersonAddress())) instead of modifying the list object that was stored in person.getAddresses()
22:07:51 <bwolfe> nribeka: use person.addAddress(new PersonAddress())
22:11:30 <bwolfe> I've gotta run. I may or may not be on later. email me if you need me to test again.
22:13:51 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6181]: bitrock installer: Updated the files to 1.4.0 beta scripts <http://dev.openmrs.org/changeset/6181>
22:17:05 <basic`> bwolfe: doh, looks like it didnt work
22:30:18 *** bwolfe has quit IRC
23:36:44 *** Keelhaul has quit IRC
23:38:00 *** nribeka has left #openmrs