00:37:27
|
*** [mharrison] has joined #openmrs
|
01:13:25
|
*** nribeka1 has joined #openmrs
|
01:23:07
|
*** nribeka2 has joined #openmrs
|
01:28:00
|
*** nribeka has quit IRC
|
01:30:11
|
*** nribeka2 has quit IRC
|
01:35:10
|
<Keelhaul> bwolfe!
|
01:40:37
|
<bwolfe> Keelhaul!
|
01:40:44
|
<Keelhaul> hi
|
01:40:49
|
<Keelhaul> so i played with unit tests a bit
|
01:40:53
|
<Keelhaul> and still get errors
|
01:41:03
|
<bwolfe> hmm
|
01:41:10
|
<Keelhaul> but i think one of them is because junit doesnt work properly when there's a hierarchy of the same class
|
01:41:18
|
<Keelhaul> i had that with Encounter in my inpatient care module
|
01:41:25
|
<Keelhaul> unit tests failed, while the webapp worked fine
|
01:42:15
|
*** nribeka1 has quit IRC
|
01:43:20
|
<bwolfe> Keelhaul: that sounds like a weird thing for unit tests to fail on
|
01:45:06
|
<Keelhaul> bwolfe: http://rafb.net/p/sOqQMT96.html
|
01:45:53
|
<Keelhaul> assertion fails on 143 and 195
|
01:46:22
|
<Keelhaul> http://rafb.net/p/AwZQIf12.html
|
01:46:24
|
<Keelhaul> this is the dataset
|
01:46:56
|
<bwolfe> whats your location object look like ?
|
01:47:32
|
<Keelhaul> http://rafb.net/p/vLeObq97.html
|
01:49:05
|
<bwolfe> Keelhaul: did you modify the Location hashCode method ?
|
01:49:12
|
<bwolfe> hmm, nm
|
01:49:16
|
<Keelhaul> not that i know of
|
01:50:10
|
<Keelhaul> my tests are pretty similar for child locations and for child locationtags
|
01:50:17
|
<Keelhaul> those for tags dont give errors though
|
01:50:42
|
<bwolfe> does this line work? if (child != null && !(parentLocation != null && parentLocation.equals(child))) {
|
01:51:01
|
<Keelhaul> i also remember that when i had the same issue with parent/child encounters, the tests only failed when i used the xml dataset, not when i created the objects in the test
|
01:51:09
|
<bwolfe> if parentLocation is null, it won't drop into that if statement...
|
01:51:36
|
<Keelhaul> if parentLocation is null, then its not an issue
|
01:52:32
|
<Keelhaul> just shouldnt have the same location as parent and child
|
01:52:48
|
<Keelhaul> ideally, it should check the entire tree for the child candidate
|
01:53:01
|
<Keelhaul> havent gotten around to that though
|
01:53:26
|
<Keelhaul> or maybe it should be allowed, not sure
|
01:53:58
|
<Keelhaul> well not loops, but for example, if a department is subset of two institutions or smt
|
01:54:21
|
<bwolfe> but if parentLocation is null, it won't set the child location
|
01:55:29
|
<Keelhaul> yes it will
|
01:56:18
|
<Keelhaul> it wont if both parentLocation != null AND parentLocation == child are satisfied
|
01:56:33
|
<bwolfe> ah ok
|
01:57:47
|
*** nribeka has joined #openmrs
|
01:57:49
|
<Keelhaul> maybe a lazy loading issue?
|
01:58:23
|
<bwolfe> maybe
|
01:58:31
|
<Keelhaul> http://rafb.net/p/1VmSZB94.html
|
01:58:32
|
<bwolfe> you might want to use getParentLocation() instead of just parentLocation
|
01:58:35
|
<Keelhaul> thats the mappilg filel
|
01:59:13
|
<Keelhaul> i thought only sets make trouble there
|
02:07:59
|
<Keelhaul> bwolfe: how about i send you the patch? =P
|
02:08:18
|
* pygi thinks bwolfe likes patches
|
02:09:17
|
* bwolfe loves patches
|
02:09:42
|
<bwolfe> Keelhaul: you can send it to me if you want...but I'd rather you want it to the ticket :-)
|
02:10:05
|
<Keelhaul> heh
|
02:10:13
|
<Keelhaul> i mean to find the issue before the patch goes to the ticket
|
02:10:18
|
<Keelhaul> because i'm out of ideas
|
02:11:37
|
<Keelhaul> basically, what i did was: extend Location, add LocationTag, add/mod hbm files for both, extended api/dao, added new privs to openmrsconstants, added test class/dataset
|
02:11:41
|
<Keelhaul> thats it i think
|
02:17:51
|
<bwolfe> Keelhaul: the patch doesn't have to be perfect
|
02:18:06
|
<bwolfe> patches are usually iterated a few times before they are finally accepted
|
02:18:06
|
<Keelhaul> ok i'll just attach it then and explain wassup
|
02:18:28
|
<Keelhaul> whats hashCode() for?
|
02:20:07
|
<bwolfe> its used by maps to put the objects in the Map into "buckets:
|
02:20:12
|
<bwolfe> err "buckets"
|
02:20:51
|
<Keelhaul> what calls it, api and controllers dont
|
02:21:07
|
<bwolfe> just the java.util.Map file that I know of
|
02:21:16
|
<Keelhaul> ok
|
02:21:54
|
<Keelhaul> hmm
|
02:22:01
|
<Keelhaul> i cant find the ticket for locations anymore
|
02:27:12
|
<bwolfe> !169
|
02:27:12
|
<OpenMRSBot> bwolfe: Error: "169" is not a valid command.
|
02:27:17
|
<bwolfe> !ticket 169
|
02:27:17
|
<OpenMRSBot> bwolfe: Ticket #169: http://dev.openmrs.org/ticket/169
|
02:27:35
|
<Keelhaul> ty
|
02:39:58
|
<Keelhaul> ok patch added
|
03:09:48
|
<bwolfe> awesome
|
03:09:50
|
<bwolfe> thanks Keelhaul !
|
03:10:18
|
<Keelhaul> np, i hope it's what they had in mind
|
03:10:40
|
<Keelhaul> it's also in my interest because i'll have to adapt my module eventually
|
04:09:38
|
*** nribeka1 has joined #openmrs
|
04:11:58
|
*** bwolfe has quit IRC
|
04:12:02
|
*** nribeka1 has quit IRC
|
04:17:35
|
*** nribeka has quit IRC
|
04:42:05
|
*** Keelhaul has quit IRC
|
07:57:35
|
*** pygi has quit IRC
|
08:40:23
|
*** pygi has joined #openmrs
|
08:48:52
|
*** pygi has quit IRC
|
09:57:01
|
*** pygi has joined #openmrs
|
11:48:50
|
*** Ngref has joined #openmrs
|
11:49:30
|
*** Ngref has quit IRC
|
12:25:35
|
*** Keelhaul has joined #openmrs
|
12:25:35
|
*** ChanServ sets mode: +v Keelhaul
|
12:49:01
|
*** kapten_yuba has joined #openmrs
|
12:49:15
|
*** kapten_yuba has left #openmrs
|
12:51:20
|
*** james_regen has joined #openmrs
|
12:51:20
|
*** ChanServ sets mode: +v james_regen
|
13:23:23
|
<OpenMRSBot> Recent updates in the world of openmrs: News Blog: Calling all developers: a web survey just for you <http://blog.openmrs.org/?p=84>
|
13:47:07
|
*** njero has joined #openmrs
|
13:47:07
|
*** ChanServ sets mode: +v njero
|
14:11:29
|
*** bwolfe has joined #openmrs
|
14:11:29
|
*** ChanServ sets mode: +o bwolfe
|
15:05:25
|
*** kapten_yuba has joined #openmrs
|
15:05:29
|
*** kapten_yuba has left #openmrs
|
15:37:49
|
*** nribeka has joined #openmrs
|
16:35:34
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6093]: -- atd * added a check on the alternative form instance id bar code <http://dev.openmrs.org/changeset/6093>
|
17:01:26
|
*** bmckown has joined #openmrs
|
17:01:26
|
*** ChanServ sets mode: +o bmckown
|
17:03:08
|
*** nribeka has quit IRC
|
17:07:37
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6094]: -- chica * adding checking of alternate mrn bar codes * added better ⦠<http://dev.openmrs.org/changeset/6094>
|
17:32:18
|
*** nribeka has joined #openmrs
|
18:22:02
|
*** [mharrison] has quit IRC
|
19:15:45
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6096]: -- chica * fixed value type of chica study person attribute type <http://dev.openmrs.org/changeset/6096> || OpenMRS Changesets: Changeset [6095]: exceldataimport: Added necessary jars back into project. Committed all ⦠<http://dev.openmrs.org/changeset/6095>
|
19:23:59
|
*** nribeka1 has joined #openmrs
|
19:34:08
|
*** nribeka has quit IRC
|
19:40:52
|
*** nribeka1 has quit IRC
|
19:45:48
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1132 (defect created): Reset pwd on existing user does not sync correctly <http://dev.openmrs.org/ticket/1132>
|
20:07:01
|
*** nribeka has joined #openmrs
|
20:22:58
|
*** NeutronFluxLabs has joined #openmrs
|
20:23:09
|
*** NeutronFluxLabs has quit IRC
|
20:23:54
|
*** nribeka1 has joined #openmrs
|
20:26:58
|
*** nribeka2 has joined #openmrs
|
20:29:17
|
*** nribeka3 has joined #openmrs
|
20:31:37
|
*** nribeka4 has joined #openmrs
|
20:32:07
|
<nribeka4> wow lots of nribeka today :)
|
20:32:56
|
*** nribeka2 has quit IRC
|
20:33:29
|
<bwolfe> nribeka is everywhere!
|
20:35:02
|
<nribeka4> nribeka is in class :D
|
20:35:24
|
*** nribeka1 has quit IRC
|
20:44:54
|
*** nribeka has quit IRC
|
20:48:33
|
*** [mharrison] has joined #openmrs
|
21:00:03
|
*** nribeka3 has quit IRC
|
21:17:18
|
*** james_regen has quit IRC
|
21:27:39
|
*** [mharrison] has quit IRC
|
21:52:01
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1133 (enhancement created): Extension Point in <http://dev.openmrs.org/ticket/1133>
|
22:21:03
|
*** bmckown has quit IRC
|
22:45:46
|
*** bwolfe has quit IRC
|
22:46:44
|
*** nribeka4 has quit IRC
|
23:03:21
|
*** nribeka has joined #openmrs
|