| 00:43:07 | <basic`> r0bby: did you recieve a commit email yesterday? we tracked down the logs, it should have been sent to svn@openmrs.org and robby.oconnor@gmail.com from svn@openmrs.org. I'm guessing thats you? :) |
| 00:54:10 | <Keelhaul> does anyone know where the hbm.xml files are registered in the core app? |
| 00:54:27 | <Keelhaul> like config.xml in modules |
| 00:57:44 | *** bwolfe has joined #openmrs |
| 00:57:44 | *** ChanServ sets mode: +o bwolfe |
| 01:02:43 | *** nribeka has quit IRC |
| 01:03:59 | <Keelhaul> bwolfe! |
| 01:04:23 | <Keelhaul> [01:54:06] <+Keelhaul> does anyone know where the hbm.xml files are registered in the core app? |
| 01:04:23 | <Keelhaul> [01:54:23] <+Keelhaul> like config.xml in modules |
| 01:04:30 | <bwolfe> Keelhaul! |
| 01:04:49 | <bwolfe> yes, I do |
| 01:04:52 | <bwolfe> :-p |
| 01:05:04 | <Keelhaul> my unit tests fail w/o that, it seems |
| 01:06:02 | <basic`> bwolfe: ping |
| 01:06:23 | <basic`> did you recieve a commit email yesterday? we tracked down the logs, it should have been sent to svn@openmrs.org and robby.oconnor@gmail.com from svn@openmrs.org. |
| 01:09:54 | <Keelhaul> theoretically, it should be possible to create a hierarchy loop of locations.. |
| 01:23:43 | <Keelhaul> bwolfe: so? =) |
| 01:28:20 | *** atomicturtle has joined #openmrs |
| 01:28:59 | *** atomicturtle has left #openmrs |
| 01:50:23 | <r0bby> basic`: yes |
| 01:50:37 | <r0bby> I edited a commit msg |
| 01:50:46 | <r0bby> robby.oconnor is me |
| 01:53:19 | <r0bby> basic`: why |
| 01:54:08 | *** atomicturtle has joined #openmrs |
| 02:15:41 | *** nribeka has joined #openmrs |
| 02:18:22 | *** njero has quit IRC |
| 02:19:51 | <Keelhaul> ah hm |
| 02:20:16 | <Keelhaul> i wanted to define a concept for "waist circumference" |
| 02:20:31 | <Keelhaul> the normal value ranges are different for men and women though |
| 02:20:32 | <Keelhaul> lol |
| 02:36:55 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6086]: groovyforms: this should be static. <http://dev.openmrs.org/changeset/6086> |
| 02:45:23 | <Keelhaul> hm |
| 02:45:27 | <Keelhaul> cant cascade locations |
| 02:45:37 | <Keelhaul> because the depth is indefinite |
| 02:45:44 | <Keelhaul> unless i can do it recursively somehow |
| 03:16:20 | *** nribeka1 has joined #openmrs |
| 03:26:54 | *** nribeka1 has quit IRC |
| 03:27:21 | *** nribeka1 has joined #openmrs |
| 03:37:42 | *** nribeka has quit IRC |
| 03:51:11 | <bwolfe> basic`: only property edits are going through. commit emails are not. |
| 03:52:18 | <Keelhaul> bwolfe: two of my unit tests fail for uknown reasons |
| 03:52:49 | <Keelhaul> one is when i remove one of the two child locations, but the child count is not 1 for some reason |
| 03:53:09 | <Keelhaul> the other is when i purge a LocationTag, but when i retrieve it, it's not null |
| 03:53:15 | <Keelhaul> i have no clue |
| 03:53:18 | <Keelhaul> too tired now =/ |
| 03:54:02 | <bwolfe> Keelhaul: the roles are similar...its possible to have a loop. that is checked for at save time by looking through all parents for the same object |
| 03:54:49 | <bwolfe> Keelhaul: the hbm files are on the classpath and so they are found by spring. |
| 03:54:55 | <Keelhaul> yea found them already =P |
| 03:55:04 | <bwolfe> Keelhaul: I believe there is something in the openmrs-servlet.xml that says they are on the classpath |
| 03:55:13 | <Keelhaul> i was looking for appcontext where the hbm files are registered, actually |
| 03:55:16 | <Keelhaul> but i found that too |
| 03:55:49 | <bwolfe> Keelhaul: are the failings within one test ? or across multiple? |
| 03:56:03 | <bwolfe> do you know that the db is rolled back after each unit test method ? |
| 03:56:04 | <Keelhaul> two different |
| 03:56:12 | <Keelhaul> yes |
| 03:56:18 | <Keelhaul> they are completely independent of each other |
| 03:56:24 | <Keelhaul> each method creates its own stuff |
| 03:58:31 | <Keelhaul> http://rafb.net/p/4baEx831.html |
| 03:58:42 | <Keelhaul> lines 179 and 272 |
| 04:00:25 | <Keelhaul> as for the cascade saving |
| 04:00:43 | <Keelhaul> i ended up calling saveLocation recursively |
| 04:01:03 | <bwolfe> Keelhaul: hmm |
| 04:01:09 | <bwolfe> not sure we want to cascade to parents |
| 04:01:34 | <Keelhaul> well in one of the tests i have a parent->childA->childB hierarchy |
| 04:02:07 | <Keelhaul> if i do the usual for (Location child: parent.getChildLocations() { creator, datecreated etc} stuff |
| 04:02:21 | <Keelhaul> it woudl only cover the immediate children |
| 04:02:26 | <bwolfe> hahah: retireLocationTag(oldTag, "Spend more time with its family."); |
| 04:02:45 | <Keelhaul> if those have unsaveed children, there will be exceptions because creator and dateCreated are missing |
| 04:02:58 | <Keelhaul> oh i didnt add that line lol |
| 04:03:09 | <Keelhaul> i just copied and modified the retireLocation test |
| 04:03:13 | <Keelhaul> dunno who wrote it |
| 04:03:37 | <bwolfe> ah, so it was Brian probably |
| 04:03:52 | <bwolfe> unforunately you're copying tests from the un-refactored unit tests :-/ |
| 04:03:59 | <Keelhaul> yea |
| 04:04:06 | <Keelhaul> because refactored tests are lots |
| 04:04:07 | <Keelhaul> lol |
| 04:04:42 | <bwolfe> the tests will need to be trimmed down and limited to one little functionality test a-piece :-) |
| 04:04:56 | <Keelhaul> yea, i looked at the encounterservice tests |
| 04:05:01 | <Keelhaul> each method its own test |
| 04:05:20 | <Keelhaul> but i'd need an xml dataset for that |
| 04:05:24 | <Keelhaul> didnt wanna bother with that |
| 04:05:39 | <bwolfe> heh |
| 04:05:43 | <bwolfe> its pretty easy |
| 04:05:51 | <Keelhaul> yea, i did that for my modules |
| 04:06:09 | <bwolfe> you could make one for the entire test class..similar to what you did by calling the encounter xml in the first @Before method |
| 04:06:10 | <Keelhaul> i just wanted to see whether the stuff work |
| 04:06:14 | <Keelhaul> and it seems like it doesnt |
| 04:06:22 | <Keelhaul> i have no idea why those asserts fail |
| 04:06:52 | <bwolfe> Keelhaul: those might be because of hibernate caching and not saving to the actual db until the transaction is over |
| 04:07:08 | <Keelhaul> ok but |
| 04:07:37 | <Keelhaul> other tests with the same pattern pass |
| 04:07:56 | <r0bby> jingle bells |
| 04:07:56 | <Keelhaul> e.g. shouldLocation purges fine at the end, shouldLocationTag doesnt |
| 04:08:01 | <r0bby> I hate you all |
| 04:08:12 | <Keelhaul> batman smells, r0bby laid an egg? |
| 04:08:57 | <bwolfe> you could check the size of newRoot.getChildLocations() at line 175 |
| 04:09:23 | <Keelhaul> i did |
| 04:09:27 | <Keelhaul> it's also not 1 |
| 04:09:44 | <Keelhaul> seems like the problem is before saving/retrieving |
| 04:09:58 | <Keelhaul> but the removeChildLocation method is straightforward |
| 04:10:04 | <Keelhaul> cant see anything wrong |
| 04:10:34 | <bwolfe> Keelhaul: lets see it |
| 04:10:40 | <Keelhaul> http://rafb.net/p/iQS51A66.html |
| 04:11:07 | <Keelhaul> starting at line 480 |
| 04:11:08 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6087]: groovyforms: more static stuff <http://dev.openmrs.org/changeset/6087> |
| 04:11:56 | <bwolfe> Keelhaul: two things |
| 04:12:24 | <bwolfe> you should make "if (childLocations != null && " this "if (getChildLocations() != null && " due to hibernates lazy loading |
| 04:13:01 | <bwolfe> and then also because of hibernate, you need to do: "&& child.getParentLocation().equals(this))" instead of "&& child.getParentLocation() == this)" |
| 04:15:03 | <Keelhaul> oh |
| 04:15:08 | <Keelhaul> i have lazy=false in the mappings |
| 04:17:10 | <bwolfe> well, we can attack it tomorrow, I |
| 04:17:14 | <bwolfe> I've gotta run |
| 04:17:23 | <bwolfe> and you should be asleep! :-p |
| 04:17:27 | <Keelhaul> yea, ill want ER and sleep |
| 04:17:31 | <Keelhaul> bai |
| 04:17:33 | <Keelhaul> thx |
| 04:17:36 | <bwolfe> night |
| 04:21:47 | *** nribeka has joined #openmrs |
| 04:33:32 | *** nribeka1 has quit IRC |
| 04:38:10 | *** bwolfe has quit IRC |
| 05:14:52 | *** atomicturtle has left #openmrs |
| 05:29:42 | *** Keelhaul has quit IRC |
| 06:23:30 | *** pearlbear has quit IRC |
| 10:01:34 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1131 (task created): ConceptService.saveConcept should allow you to create a concept with a specified concept id <http://dev.openmrs.org/ticket/1131> |
| 11:05:39 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6088]: recommit after earlier code deleted <http://dev.openmrs.org/changeset/6088> |
| 11:21:07 | *** Mario_ has joined #openmrs |
| 11:21:57 | *** pygi has quit IRC |
| 11:22:03 | *** Mario_ is now known as pygi |
| 11:31:32 | *** pygi has quit IRC |
| 11:37:42 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6089]: recommit after earlier code deleted due to erros in commit <http://dev.openmrs.org/changeset/6089> |
| 12:17:04 | *** kapten_yuba has joined #openmrs |
| 12:17:08 | *** kapten_yuba has left #openmrs |
| 12:54:26 | *** Keelhaul has joined #openmrs |
| 12:54:26 | *** ChanServ sets mode: +v Keelhaul |
| 14:19:00 | *** bwolfe has joined #openmrs |
| 14:19:00 | *** ChanServ sets mode: +o bwolfe |
| 14:44:13 | *** ders has joined #openmrs |
| 14:59:40 | *** pygi has joined #openmrs |
| 15:25:14 | *** njero has joined #openmrs |
| 15:25:14 | *** ChanServ sets mode: +v njero |
| 17:13:52 | *** njero has quit IRC |
| 17:26:41 | *** njero has joined #openmrs |
| 17:26:41 | *** ChanServ sets mode: +v njero |
| 17:33:40 | *** ders has quit IRC |
| 17:34:54 | *** ders has joined #openmrs |
| 17:45:40 | *** njero has quit IRC |
| 18:42:26 | <Keelhaul> oh lol |
| 18:42:31 | <Keelhaul> openmrs facebook group |
| 19:27:12 | <bwolfe> Keelhaul: nice. |
| 19:27:20 | <bwolfe> Keelhaul: theres also an openmrs linkedin group |
| 19:28:14 | <Keelhaul> i dont know linkedin |
| 21:19:52 | *** njero has joined #openmrs |
| 21:19:52 | *** ChanServ sets mode: +v njero |
| 21:30:49 | *** atomicturtle has joined #openmrs |
| 23:53:23 | <Keelhaul> bwolfe: are you there? |