00:01:14
|
<pygi> just wanted to talk with some people, so I could prepare for next year GSoC effectively :)
|
00:01:50
|
<nribeka> all the mentors are gone pygi :D
|
00:02:15
|
<pygi> that's rude :p
|
00:02:20
|
<pygi> they're sleeping probably :D
|
00:02:40
|
<nribeka> late in night you might be able to catch bwolfe
|
00:02:45
|
<nribeka> where are u pygi?
|
00:02:50
|
<pygi> ah, yes, I remember him :p
|
00:02:52
|
<pygi> Croatia
|
00:02:54
|
<pygi> 1:02AM
|
00:02:57
|
<pygi> or something like that :p
|
00:03:36
|
<nribeka> ah ic ic
|
00:04:18
|
<pygi> and you?
|
00:04:43
|
<nribeka> Pittsburgh, US 7.04PM
|
00:12:05
|
<pygi> ah
|
00:12:06
|
<pygi> nie time
|
00:12:08
|
<pygi> nice time*
|
00:12:18
|
<nribeka> :D
|
00:49:07
|
<pygi> nribeka, what's funny? xD
|
00:49:16
|
<pygi> wanna do a marketing plan instead of me so I can go to sleep? :D
|
00:49:53
|
<nribeka> you can come in the morning tomorrow pygi :D
|
00:52:10
|
<pygi> nribeka, that's not the answer to my question :p
|
00:52:43
|
<nribeka> so what should i answer?
|
00:55:15
|
<pygi> <pygi> wanna do a marketing plan instead of me so I can go to sleep? :D
|
00:55:33
|
<nribeka> what kind of marketing plan?
|
00:55:36
|
<nribeka> i don't get it
|
00:55:36
|
<nribeka> :D
|
01:03:29
|
<pygi> nribeka, hm, well, I have to write a marketing plan for a product :p
|
01:04:11
|
<nribeka> ah ic ic
|
01:05:04
|
<pygi> so wanna do it? :p
|
01:05:07
|
<pygi> or am I on my own? :D
|
01:06:27
|
<nribeka> you're alone there i'm afraid ... :D
|
01:07:14
|
<pygi> damn :p
|
01:08:51
|
<nribeka> :D
|
01:38:58
|
*** nribeka has quit IRC
|
04:27:14
|
*** nribeka has joined #openmrs
|
08:18:39
|
*** nribeka has quit IRC
|
08:19:22
|
*** nribeka has joined #openmrs
|
09:04:46
|
*** nribeka has quit IRC
|
09:10:34
|
<pygi> morning
|
10:17:36
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6079]: Tagging [6078] as data-synchronization-1.0.1. <http://dev.openmrs.org/changeset/6079>
|
10:45:17
|
*** nribeka has joined #openmrs
|
10:48:04
|
*** nribeka has quit IRC
|
10:48:42
|
*** nribeka has joined #openmrs
|
10:49:05
|
*** nribeka has left #openmrs
|
11:51:42
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6080]: dataqualitytools: fixed bug that threw NPE for patients without a patient ⦠<http://dev.openmrs.org/changeset/6080>
|
12:44:51
|
*** james_regen has joined #openmrs
|
12:44:51
|
*** ChanServ sets mode: +v james_regen
|
13:31:35
|
*** bmckown has joined #openmrs
|
13:31:35
|
*** ChanServ sets mode: +o bmckown
|
13:57:02
|
*** nribeka1 has joined #openmrs
|
14:04:13
|
<pygi> nribeka1 is here again! :P
|
14:18:55
|
*** nribeka1 has quit IRC
|
14:31:53
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6082]: generatetestcases: Started with Generate Test Report Task <http://dev.openmrs.org/changeset/6082> || OpenMRS Changesets: Changeset [6081]: generatetestcases: Reloved issue #1087 (the user should be taken to the ⦠<http://dev.openmrs.org/changeset/6081>
|
14:35:24
|
*** Keelhaul has joined #openmrs
|
14:35:24
|
*** ChanServ sets mode: +v Keelhaul
|
14:51:51
|
*** pygi has quit IRC
|
15:35:59
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6083]: bitrock installer: Fixing call to 1.3.2 sql scripts <http://dev.openmrs.org/changeset/6083>
|
15:49:03
|
*** nribeka has joined #openmrs
|
16:40:03
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6084]: 1.3.x branch: * Backporting changeset [5416] for bug #1018. * ⦠<http://dev.openmrs.org/changeset/6084>
|
16:41:27
|
*** nribeka has quit IRC
|
16:44:35
|
*** bwolfe has joined #openmrs
|
16:44:35
|
*** ChanServ sets mode: +o bwolfe
|
17:10:15
|
*** pygi has joined #openmrs
|
17:13:11
|
<pygi> bwolfe, morning :p
|
17:21:16
|
*** nribeka has joined #openmrs
|
17:40:38
|
<bwolfe> hey pygi
|
17:40:46
|
<pygi> remember me? :)
|
17:40:58
|
<bwolfe> yeah, gsoc hopeful :-)
|
17:41:08
|
<bwolfe> except we didn't have any python for you...
|
17:41:34
|
<pygi> bwolfe, yea, so I'll prepare for next year :)
|
17:41:45
|
<pygi> wanted to bug you to gimme some suggestions for java books ...
|
17:42:43
|
<bwolfe> pygi: books to teach java ?
|
17:42:53
|
<bwolfe> or books in general?
|
17:43:55
|
<pygi> bwolfe, well, to teach me java obviously
|
17:44:01
|
<pygi> unless I'm mistaken openmrs is java :p
|
17:44:38
|
<bwolfe> yep, openmrs is java
|
17:45:00
|
<bwolfe> http://openmrs.org/wiki/Developer_Resources has some books...but they aren't really "learn java" books
|
17:45:19
|
<Keelhaul> o'reilly has a bunch i think
|
17:45:22
|
<Keelhaul> look on bittorrent
|
17:45:54
|
<pygi> ok, I'll read this Sprint thingy if you're using it and some other basic Java book
|
17:47:45
|
<Keelhaul> bwolfe: so you're really making that location hiearchy thing happen, huh
|
17:47:53
|
<pygi> that should be ok, no=
|
17:47:54
|
<pygi> ?
|
17:48:08
|
<bwolfe> pygi: yeah, we use a lot of Spring
|
17:48:30
|
<bwolfe> pygi: the sun java website has some pretty good tutorials too
|
17:48:33
|
<Keelhaul> i think java in general should be learned before spring
|
17:48:38
|
<bwolfe> Keelhaul: looks like it
|
17:48:57
|
<Keelhaul> bwolfe: that's unfortunate, i'd have to redo my module to use that =/
|
17:49:40
|
<pygi> Keelhaul, yup, probably :)
|
17:49:49
|
<bwolfe> Keelhaul: the "correct" solution would be to do that, yes
|
17:49:58
|
<bwolfe> but it wouldn't be "necessary":
|
17:50:09
|
<bwolfe> (minus :)
|
17:50:22
|
<Keelhaul> it would still work
|
17:51:24
|
<Keelhaul> not sure how i would go about converting the table contents into different tables
|
17:51:45
|
<Keelhaul> does mysql support loops etc now?
|
17:51:49
|
<Keelhaul> something like PL/SQL
|
17:51:51
|
* pygi goes lookup some books on amazon
|
17:53:02
|
<nribeka> java tutorial is a good start :)
|
17:54:49
|
<bwolfe> Keelhaul: what kind of loops are you wanting ?
|
17:55:42
|
<Keelhaul> something like "for each record in inpatientcare_department create new location with department.name = location.name, etc"
|
18:01:01
|
<Keelhaul> then i'd have to make my controllers go by the location_type tag instead of object type..
|
18:01:14
|
<bwolfe> Keelhaul: insert into location (name, description) (select name, desc from inpatientcare_department);
|
18:01:15
|
<Keelhaul> i remember someone in the mailing list being opposed to hard coding tags
|
18:01:30
|
<bwolfe> Keelhaul: your module creating tags is just the use-case we want to support
|
18:01:44
|
<Keelhaul> i guess
|
18:02:01
|
<bwolfe> hard coding tags means writing core openmrs code that demands that location_tag.tag_id = 1 be "room_type"
|
18:02:11
|
<Keelhaul> as for rooms, i'm still torn between keeping my Room objects or adding 1-2 new fields to the location table
|
18:02:52
|
<Keelhaul> ic
|
18:04:05
|
<Keelhaul> having a single type for the entire hierarchy has the advantage of being able to make your hierarchy as deep as you want
|
18:04:15
|
<Keelhaul> but heh, the typing is weak..
|
18:04:49
|
<Keelhaul> and i've run into some trouble with Encounter objects being parents of other Encounter objects
|
18:09:30
|
<Keelhaul> bwolfe: when do you think this will happen?
|
18:09:35
|
<Keelhaul> not in 1.4, right?
|
18:10:03
|
<bwolfe> not in 1.4
|
18:10:10
|
<bwolfe> if you code it up soon enough, it could go in 1.5 ;-)
|
18:10:28
|
<Keelhaul> unfortunately, i have to finish some other stuff =/
|
18:10:37
|
<Keelhaul> until then, someone will prolly have done it
|
18:11:16
|
<Keelhaul> do you want to just add it to the tables and the API?
|
18:11:16
|
<nribeka> what going to happen with dwr bwolfe? it surely going to break lots of module out there
|
18:11:26
|
<Keelhaul> or should the web app also make us of it
|
18:11:55
|
<bwolfe> Keelhaul: yes, both :-)
|
18:12:06
|
<bwolfe> Keelhaul: if you just want to do one, then only do the tables stuff
|
18:12:21
|
<bwolfe> nribeka: do you have it working ?
|
18:12:50
|
<Keelhaul> bwolfe: would be wise to let the discussion finish first =P
|
18:13:07
|
<nribeka> :D
|
18:13:15
|
<nribeka> ok Keelhaul :)
|
18:13:17
|
<bwolfe> Keelhaul: I think the location.parent_location is set
|
18:13:27
|
<bwolfe> Keelhaul: its whether we also have location_tag in there
|
18:13:38
|
<Keelhaul> location_type is set too?
|
18:13:43
|
<bwolfe> nribeka: does a smile mean "yes"?
|
18:13:44
|
<Keelhaul> or is _tag replacing it
|
18:13:52
|
<bwolfe> Keelhaul: tag replaces the _type
|
18:14:05
|
<Keelhaul> ew
|
18:14:13
|
<Keelhaul> need more than one tag at a time
|
18:14:15
|
<Keelhaul> then
|
18:14:20
|
<nribeka> yes in getting the patient. but not sure in other areas.
|
18:15:32
|
<nribeka> and adding regimen
|
18:21:29
|
<Keelhaul> might need many to many mapping between locations and tags then
|
18:21:59
|
<Keelhaul> i wonder how it will affect performance
|
18:22:02
|
<bwolfe> Keelhaul: yes, location_tag_map was suggested
|
18:23:15
|
<Keelhaul> my module will have to get a list of locations that are mapped to a tag that has the name "room" or something
|
18:23:24
|
<Keelhaul> instead of just all room records
|
18:40:55
|
*** Glen has joined #openmrs
|
18:42:00
|
<Keelhaul> http://rafb.net/p/LfMIfQ30.html
|
18:42:03
|
<Keelhaul> that should suffice
|
18:45:12
|
<Keelhaul> or should it rather be called "location_location_tag_map"?
|
18:50:51
|
*** Glen has quit IRC
|
18:52:35
|
<bwolfe> Keelhaul: location_tag_map is right I think
|
18:54:07
|
<Keelhaul> i'm not quite sure what KEY `location_tag_name` (`name`), is for
|
18:54:18
|
<Keelhaul> why make a key if theres no constraint
|
18:54:32
|
<Keelhaul> i got it from the original poster's proposal
|
19:00:15
|
*** bmckown has quit IRC
|
19:01:20
|
<bwolfe> Keelhaul: I think key means index
|
19:02:46
|
<Keelhaul> i guess its just there so no two tags can share the same name
|
19:44:20
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1129 (task created): Need selection file module <http://dev.openmrs.org/ticket/1129> || OpenMRS Tickets: Ticket #1128 (task created): person search widget should show some identifier <http://dev.openmrs.org/ticket/1128> || OpenMRS Forum: Re: No mapping for [/openmrs/admin/observations/encounter.form] <http://forum.openmrs.org/viewtopic.php?f=23&t=413#p1441>
|
20:16:22
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6085]: Deleting the patientvisitscheduler module so that sndichu can do a clean ⦠<http://dev.openmrs.org/changeset/6085> || OpenMRS Tickets: Ticket #1116 (defect closed): link to formimportexport module 1.5.2 broken <http://dev.openmrs.org/ticket/1116#comment:4>
|
20:30:58
|
<Keelhaul> bwolfe: private Set<LocationTag> tags; or private Set<LocationTag> locationTags;
|
20:32:50
|
<bwolfe> hmm
|
20:32:56
|
<bwolfe> I'll go with dealer's choice on that one :-)
|
20:33:26
|
<Keelhaul> i'm not sure how to add the sqldiffs
|
20:33:46
|
<Keelhaul> i'd have to up the db version manually
|
20:35:02
|
<bwolfe> Keelhaul: what do you mean?
|
20:35:46
|
<Keelhaul> the db changes i posted earlier
|
20:35:54
|
<Keelhaul> will have to go into sqldiff
|
20:36:21
|
<bwolfe> the sqldiff is mostly manual
|
20:36:26
|
<bwolfe> so I guess I don't know what you mean
|
20:36:35
|
<Keelhaul> oh
|
20:36:38
|
<Keelhaul> what i mean is
|
20:36:46
|
<Keelhaul> if i add a patch, should it include the changes to sqldiff
|
20:36:54
|
<Keelhaul> and if so, can i increase the revision myself
|
20:37:48
|
<bwolfe> yes, add your patch to the ticket with the sqldiff changes in that patch too
|
20:37:52
|
<bwolfe> yes, just increment the revision
|
20:38:20
|
<bwolfe> that revision might get modified before the final commit to trunk, it just depends on whether the other things get into trunk before that
|
20:41:33
|
<Keelhaul> do i have to test it? =P
|
20:43:05
|
<bwolfe> Keelhaul: yes
|
20:43:17
|
<bwolfe> and a few unit tests will help the process get to trunk faster ! :-)
|
20:44:23
|
<Keelhaul> i still havent figured out the @should stuff =/
|
20:45:53
|
<bwolfe> Keelhaul: hmm, perhaps I should write it up on the wiki: http://openmrs.org/wiki/Unit_Testing_with_@should
|
20:45:54
|
<OpenMRSBot> <http://ln-s.net/2UyD> (at openmrs.org)
|
20:46:27
|
<Keelhaul> hmm
|
20:46:27
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1130 (task created): Integrate Ivy into our Build system <http://dev.openmrs.org/ticket/1130>
|
20:46:33
|
<Keelhaul> a few new api methods would be handy
|
20:46:39
|
<Keelhaul> like getLocationsByTag
|
20:46:52
|
<bwolfe> agreed
|
20:47:09
|
<Keelhaul> ByTags even
|
20:47:25
|
<Keelhaul> (Set<LocationTag> tags)
|
20:52:42
|
<Keelhaul> can that be done by hibernate or do i have to filter them in the api impl
|
20:54:34
|
<bwolfe> Keelhaul: hibernate should be able to work the magic
|
20:55:02
|
<bwolfe> Keelhaul: look at the ConceptService.getConceptNameByTags(..) method(s). I think they should do something similar
|
20:56:06
|
<Keelhaul> ok
|
21:10:30
|
*** james_regen has quit IRC
|
21:17:07
|
<nribeka> bwolfe, we can use mavenide from codehaus :D
|
21:17:19
|
<bwolfe> nribeka: not sure what that is
|
21:17:43
|
<Keelhaul> was the openmrs formatter changed?
|
21:17:54
|
<bwolfe> yeah
|
21:17:58
|
<Keelhaul> it now does "if (bla) doSomething();"
|
21:17:59
|
<Keelhaul> in one line
|
21:19:00
|
<nribeka> i think the mavenide is used to manage maven config :)
|
21:20:35
|
<Keelhaul> hmm
|
21:20:40
|
<Keelhaul> the lines can be indefinitely long now?
|
21:20:54
|
<bwolfe> Keelhaul: its 125 now I think
|
21:21:20
|
<Keelhaul> damn
|
21:21:21
|
<Keelhaul> lol
|
21:22:31
|
<bwolfe> Keelhaul: 80 characters was so, well, 1980
|
21:22:45
|
<Keelhaul> true
|
21:22:48
|
<nribeka> bwolfe: lol
|
21:22:54
|
<Keelhaul> but i wonder how that will work out on my 12" laptop
|
21:23:01
|
<nribeka> hahaha ... lol
|
21:23:38
|
<bwolfe> Keelhaul: just use a very small font :-D
|
21:35:57
|
*** pearlbear has joined #openmrs
|
21:35:57
|
*** ChanServ sets mode: +v pearlbear
|
21:38:31
|
<Keelhaul> bwolfe: comments are still limited to 80
|
21:39:32
|
<bwolfe> I feel fine about aht
|
21:39:35
|
<bwolfe> *that
|
22:26:57
|
*** bwolfe has quit IRC
|
22:40:31
|
*** nribeka has quit IRC
|
22:40:52
|
*** nribeka has joined #openmrs
|