| 00:05:15 | *** njero has joined #openmrs |
| 00:05:15 | *** ChanServ sets mode: +v njero |
| 00:11:38 | *** njero has quit IRC |
| 00:12:12 | *** njero has joined #openmrs |
| 00:12:12 | *** ChanServ sets mode: +v njero |
| 00:22:10 | *** r0bby|vista has joined #openmrs |
| 00:53:25 | *** r0bby|vista has quit IRC |
| 01:06:33 | *** njero_ has joined #openmrs |
| 01:09:19 | *** njero has quit IRC |
| 02:02:12 | *** njero_ is now known as njero |
| 02:02:44 | *** ChanServ sets mode: +v njero |
| 02:34:09 | *** sioraiocht has quit IRC |
| 02:39:58 | *** Keelhaul has quit IRC |
| 03:43:05 | *** sioraiocht has joined #openmrs |
| 03:43:05 | *** ChanServ sets mode: +v sioraiocht |
| 04:32:38 | *** bmckown has quit IRC |
| 06:39:04 | *** upul has quit IRC |
| 06:45:43 | *** james_regen has joined #openmrs |
| 06:45:43 | *** ChanServ sets mode: +v james_regen |
| 07:03:39 | *** bwolfe has joined #openmrs |
| 07:03:39 | *** ChanServ sets mode: +o bwolfe |
| 08:04:57 | *** sprasanna has joined #openmrs |
| 08:59:57 | <sprasanna> bwolfe: Hi Ben |
| 09:00:45 | <bwolfe> hey sri |
| 09:00:54 | <sprasanna> bwolfe: i see this line "<c:forEachitems="${model.layoutTemplate.lines}"var="line">" in addressLayout.jsp but i want to know where the feed comes from... can you help me with that? |
| 09:02:01 | <bwolfe> what do you mean by "feed" ? |
| 09:03:23 | <sprasanna> the jsp file pulls the address component from somewhere to build the <input> tags for the page na... i need to know where it gets those data.. |
| 09:05:37 | <bwolfe> the object returned by model.getLayoutTemplate is an AddressTemplate object |
| 09:05:45 | <bwolfe> AddressTemplate extends LayoutTemplate |
| 09:05:54 | <bwolfe> LayoutTemplate has a method called getLines() |
| 09:06:15 | <bwolfe> getLines() returns the extremely ugly "List<List<Map<String,String>>>" !! |
| 09:06:47 | <sprasanna> oh thanks a lot ben |
| 09:22:48 | *** pearlbear has joined #openmrs |
| 09:22:48 | *** ChanServ sets mode: +v pearlbear |
| 09:53:36 | *** upul has joined #openmrs |
| 10:03:00 | *** sioraiocht has quit IRC |
| 10:17:49 | <upul> Hi bwolfe |
| 10:18:19 | <bwolfe> hey upul |
| 10:19:19 | <upul> it looks like table names are hardcoded in the source |
| 10:21:34 | <upul> about converting sql diff to xml format, problem will be not being able to test with each version |
| 10:22:49 | <bwolfe> upul: what do you mean by test with each version ? |
| 10:23:39 | <upul> convesion is possible, but can't check for mistakes with each version |
| 10:23:59 | <bwolfe> upul: hmm, I still don't know what you mean |
| 10:24:01 | <upul> when adding a sql diff entry that has been tested at that time by the added person |
| 10:24:29 | <upul> but we are not testing each one with each incremental version |
| 10:25:23 | <bwolfe> upul: I don't think converting to the xml is really worth it. if there was a way to call that file from liquibase as the first entry in the new liquibase format, that would work. it would give a common starting point for all future updates. |
| 10:26:28 | <bwolfe> upul: need to run. be back later |
| 10:26:32 | <upul> ok |
| 10:28:03 | *** nribeka has quit IRC |
| 10:30:02 | *** njero_ has joined #openmrs |
| 10:37:24 | *** njero has quit IRC |
| 10:41:04 | *** TorLye has joined #openmrs |
| 10:43:03 | *** njero has joined #openmrs |
| 10:43:03 | *** ChanServ sets mode: +v njero |
| 10:43:46 | *** njero_ has quit IRC |
| 11:01:36 | *** njero has quit IRC |
| 11:01:40 | *** njero_ has joined #openmrs |
| 11:14:49 | *** njero_ has quit IRC |
| 11:15:02 | *** bmckown has joined #openmrs |
| 11:15:02 | *** ChanServ sets mode: +o bmckown |
| 11:15:10 | *** njero has joined #openmrs |
| 11:15:11 | *** ChanServ sets mode: +v njero |
| 11:17:57 | *** TorLye_ has joined #openmrs |
| 11:19:27 | *** TorLye has quit IRC |
| 11:42:24 | <OpenMRSBot> Recent updates in the world of openmrs: Upul Godage: OpenMRS update <http://upulgsoc.wordpress.com/2008/08/12/openmrs-update/> |
| 11:46:34 | *** TorLye_ has quit IRC |
| 11:46:55 | *** TorLye has joined #openmrs |
| 11:49:35 | <sprasanna> bwolfe: y i dont find LayoutTemplate in javadoc api? |
| 11:50:35 | <bwolfe> sprasanna: I think its in the web layer |
| 11:50:46 | <bwolfe> sprasanna: because its an interface/presentatino kind of thing |
| 11:50:54 | <bwolfe> sprasanna: are you using eclipse ? |
| 11:51:01 | <sprasanna> bwolfe: yeah |
| 11:51:12 | <sprasanna> bwolfe: using eclipse |
| 11:51:23 | <bwolfe> sprasanna: if so, you can use control-shift-t, and then type in LayoutTemplate...or even just type in LaTem and you'll see it |
| 11:51:31 | *** njero_ has joined #openmrs |
| 11:52:19 | <sprasanna> bwolfe: its not an interface i guess |
| 11:52:27 | *** njero has quit IRC |
| 11:52:36 | <sprasanna> abstract class |
| 11:52:50 | <bwolfe> yes, abstract class that AddressTemplate and NameTempalte extend |
| 11:53:42 | <sprasanna> if i create a package like org.openmrs.layout.web with a class LayoutTemplate. will it override the existing one?? |
| 11:54:02 | <sprasanna> bwolfe: i tried but it dint work |
| 11:54:20 | <sprasanna> bwolfe: i just wanna confirm whether i am wrong at some place |
| 11:55:00 | <bwolfe> sprasanna: why do you want to override it ? |
| 11:55:07 | <bwolfe> sprasanna: why not just use it ? |
| 11:56:56 | <sprasanna> bwolfe: hmmm.. i just want to alter that getLines() method alone.. if i do that then i need not modify much in controller and addresslayout jsp |
| 11:57:36 | <bwolfe> sprasanna: I see |
| 11:57:47 | <bwolfe> well, you can't "override" a java class like that unfortuantely |
| 11:58:06 | <sprasanna> bwolfe: yeah i know that but gave it a try |
| 11:58:19 | <bwolfe> you might be able to set the template to use to your module class..which just extends TemplateLayout and overrides the getLines method |
| 11:58:49 | *** njero_ has quit IRC |
| 11:58:49 | <bwolfe> sprasanna: the spring bean defines the class to use: <bean id="addressTemplateRwanda" class="org.openmrs.layout.web.address.AddressTemplate"> |
| 11:58:59 | <bwolfe> sprasanna: are you defining your own address layout beans ? |
| 11:59:26 | <sprasanna> bwolfe: not yet but it seems i have to |
| 11:59:58 | <sprasanna> the line you just gave is it from rwanda registration module? |
| 12:00:45 | <bwolfe> sprasanna: its in openmrs-servlet.xml |
| 12:00:55 | <sprasanna> oh |
| 12:03:06 | <bwolfe> sprasanna: ideally those address and name beans in openmrs-servlet.xml are moved to global properties so they can be definied by the user....similar to what darius did with the regimens: http://dev.openmrs.org/ticket/702 |
| 12:04:41 | <bwolfe> brb |
| 12:04:43 | *** bwolfe has quit IRC |
| 12:12:16 | *** bwolfe has joined #openmrs |
| 12:12:16 | *** ChanServ sets mode: +o bwolfe |
| 12:12:29 | <OpenMRSBot> Recent updates in the world of openmrs: Upul Godage: OpenMRS database auto update <http://upulgsoc.wordpress.com/2008/08/13/openmrs-database-auto-update/> |
| 12:24:05 | <sprasanna> bwolfe: where can i find any example for modifyiing global properties? |
| 12:24:41 | <bwolfe> sprasanna: most global properties are edited on the global property administration screen |
| 12:25:07 | <bwolfe> sprasanna: but ideally you just put the globalpropertyportlet on a separate jsp page |
| 12:30:13 | <sprasanna> bwolfe: the default value for address format in global prop page is "general".. i can create something like this <bean id="addressHierarchyTemplate" class="org.openmrs.layout.web.address.AddressTemplate">... and i can set its properties in the module application context xml so what i want to now is when i load my module can i do something like this setProperty(layout.address.format) and setProperty("addresshierarchy") ?? |
| 12:35:18 | <bwolfe> sprasanna: this might work: |
| 12:35:47 | <bwolfe> create a bean in your modules application context like <bean id="addressTemplateUS" class="org.openmrs.layout.web.address.AddressTemplate"> (which is in openmrs-servlet.xml) |
| 12:36:09 | <bwolfe> your class="..." would be your implementation/extend of AddressTemplate that overrides the getLines method |
| 12:36:42 | <bwolfe> then the only thing you need to do is get your bean id into the addressSupport object |
| 12:38:31 | <bwolfe> sprasanna: we probably need to change AddressSupport.setLayoutTemplates(List) to do: this.layoutTemplates.addAllThatArentInTheList(layoutTemplates); (instead of just doing this.layoutTemplates = layoutTemplates) |
| 12:40:15 | <sprasanna> oh |
| 12:44:32 | <bwolfe> sprasanna: does that make sens e? |
| 12:44:46 | <bwolfe> sprasanna: did you follow the objects I was looking at in openmrs-servlet.xml ? |
| 12:44:51 | <sprasanna> yeah it makes |
| 12:44:53 | <sprasanna> sense |
| 12:45:27 | <sprasanna> yeah now im little bit confused with the AddressSupport.setLayoutTemplates |
| 12:47:47 | <bwolfe> sprasanna: how so ? |
| 12:48:03 | <sprasanna> i mean i dont understand that part clearly |
| 12:48:16 | <bwolfe> there will be only one AddressSupport object in the system because of how the contructor works |
| 12:48:36 | <bwolfe> the AddressSupport.layoutTemplates are the objects available to the user |
| 12:49:09 | <bwolfe> the user puts "usa" into their global properties table, and the "usa" template is looked up in the AddressSupport.layoutTemplates list |
| 12:51:17 | <sprasanna> but modifying the module application context xml doesnt work or i dunno i have done any mistake... |
| 12:52:03 | <bwolfe> sprasanna: what do you have in your modappcontext? is it committed to svn ? |
| 12:52:05 | *** bmckown has quit IRC |
| 12:52:38 | <sprasanna> i tried modyfing the property keys and values in addressTemplateGeneral |
| 12:52:52 | <sprasanna> bwolfe: no its not committed yet i am just working on it |
| 12:53:32 | <sprasanna> i did like this bwolfe: create a bean in your modules application context like <bean id="addressTemplateUS" class="org.openmrs.layout.web.address.AddressTemplate"> (which is in openmrs-servlet.xml) |
| 12:54:04 | *** bmckown has joined #openmrs |
| 12:54:04 | *** ChanServ sets mode: +o bmckown |
| 12:54:10 | <sprasanna> i just modified the addressTemplateGeneral but i dont see any difference in my addresslayout page... |
| 12:54:20 | <bwolfe> yours would be like: <bean id="addressTemplateWithHierarchy" class="org.openmrs.module.addresshierarchy.HierarchyTemplate"> |
| 12:55:13 | <bwolfe> and you would need <bean parent="addressSupport" > <property name="layoutTemplate"><list><bean id="addressTemplateWithHierarchy"/></list></property></bean> |
| 12:55:18 | <bwolfe> or something like htat |
| 12:56:00 | <bwolfe> but with how hte core code is now, after installing your module, AddressSupport.layoutTemplates would /only/ contain your addressTemplateWithHierarchy object |
| 12:58:13 | <sprasanna> is it?? you mean my xml will override the complete addressSupport bean? |
| 12:58:44 | <bwolfe> upul: if liquibase won't run our sql file, perhaps we could just put a precondition on the liquibase xml doc http://liquibase.org/manual/databasechangelog to check the global_property database_version for the last one in the update-to-latest-mysql.diff. then we tell users to run the update-to-latest file and restart the war file |
| 12:59:01 | <bwolfe> upul: then all future updates will just use the liquibase xml file |
| 12:59:22 | <upul> bwolfe: that sounds good |
| 12:59:40 | <bwolfe> sprasanna: <bean parent="addressSupport" > <property name="layoutTemplate"><list><bean id="addressTemplateWithHierarchy"/></list></property></bean> will use the already defined "addressSupport" object...and call setLayoutTemplates(list of one) |
| 13:02:02 | <bwolfe> upul: or you create a customchange java class to run it. :-) http://liquibase.org/manual/custom_refactoring_class (assuming the user is running mysql of course) |
| 13:02:03 | <OpenMRSBot> <http://ln-s.net/29Y5> (at liquibase.org) |
| 13:02:19 | <sprasanna> bwolfe: please have a look at this http://pastebin.com/d70939caa |
| 13:02:59 | <sprasanna> is there any mistake in tat xml? |
| 13:06:31 | <bwolfe> sprasanna: yeah, thats what I was thinking |
| 13:06:51 | <sprasanna> bwolfe: but unfortunately thats not working :( |
| 13:06:58 | <bwolfe> sprasanna: expect you shouldn't have <bean id="addressTemplateWithHierarchy" class="org.openmrs.layout.web.address.AddressTemplate"> the class attribute should be your own class from your module that overrides the getLines method |
| 13:07:59 | <bwolfe> brb |
| 13:08:10 | *** bwolfe has quit IRC |
| 13:14:22 | *** sioraiocht has joined #openmrs |
| 13:14:22 | *** ChanServ sets mode: +v sioraiocht |
| 13:14:27 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #974 (enhancement created): OpenMRS database auto update using Liquibase <http://dev.openmrs.org/ticket/974> |
| 13:25:34 | *** pearlbear has quit IRC |
| 13:25:39 | *** nribeka has joined #openmrs |
| 13:34:47 | *** upul has quit IRC |
| 13:43:28 | *** pearlbear has joined #openmrs |
| 13:43:28 | *** ChanServ sets mode: +v pearlbear |
| 14:06:48 | *** bwolfe has joined #openmrs |
| 14:06:48 | *** ChanServ sets mode: +o bwolfe |
| 14:14:36 | *** bwolfe has quit IRC |
| 15:12:40 | *** njero has joined #openmrs |
| 15:12:40 | *** ChanServ sets mode: +v njero |
| 15:12:41 | *** james_regen has quit IRC |
| 16:05:38 | *** sioraiocht has quit IRC |
| 16:06:07 | *** sioraiocht has joined #openmrs |
| 16:06:15 | *** ChanServ sets mode: +v sioraiocht |
| 16:10:14 | *** TorLye has quit IRC |
| 16:14:07 | *** sgrannis has joined #openmrs |
| 16:14:15 | *** ChanServ sets mode: +v sgrannis |
| 16:14:29 | <sgrannis> nribeka: how's it going :) |
| 16:16:56 | *** bmckown has quit IRC |
| 16:41:46 | *** sgrannis has quit IRC |
| 16:42:37 | *** pearlbear has quit IRC |
| 16:59:15 | <nribeka> sgrannis i think you have some email that you need to answer in the dev list :D |
| 16:59:21 | <nribeka> ups ... he's gone :D |
| 17:01:54 | *** nribeka has quit IRC |
| 18:49:50 | *** nribeka has joined #openmrs |
| 19:22:42 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #975 (task created): Trac doesn't keep log-in username/password <http://dev.openmrs.org/ticket/975> |
| 19:58:03 | *** sprasanna has quit IRC |
| 21:19:39 | *** upul has joined #openmrs |