01:13:18
|
*** james_regen has joined #openmrs
|
01:13:18
|
*** ChanServ sets mode: +v james_regen
|
01:23:08
|
*** njero has joined #openmrs
|
01:23:08
|
*** ChanServ sets mode: +v njero
|
02:02:41
|
*** bwolfe has joined #openmrs
|
02:02:41
|
*** ChanServ sets mode: +o bwolfe
|
02:04:23
|
*** njero_ has joined #openmrs
|
02:05:10
|
*** njero has quit IRC
|
02:37:39
|
*** nribeka has joined #openmrs
|
02:40:30
|
*** njero_ has quit IRC
|
02:41:28
|
*** bwolfe has quit IRC
|
02:51:59
|
*** atomicturtle has quit IRC
|
02:53:06
|
*** sioraiocht has joined #openmrs
|
03:01:24
|
<nribeka> gmornin
|
03:05:11
|
<james_regen> greetings!
|
03:18:50
|
*** sioraiocht has quit IRC
|
03:29:25
|
*** njero has joined #openmrs
|
03:29:25
|
*** ChanServ sets mode: +v njero
|
03:29:36
|
*** atomicturtle has joined #openmrs
|
04:01:31
|
*** bwolfe has joined #openmrs
|
04:01:31
|
*** ChanServ sets mode: +o bwolfe
|
04:01:33
|
*** bwolfe has quit IRC
|
04:02:28
|
*** bwolfe has joined #openmrs
|
04:02:28
|
*** bwolfe has quit IRC
|
04:28:30
|
*** nribeka has quit IRC
|
06:14:34
|
*** njero has quit IRC
|
06:41:02
|
*** bmckown has joined #openmrs
|
06:41:02
|
*** ChanServ sets mode: +o bmckown
|
07:23:39
|
*** bwolfe has joined #openmrs
|
07:23:39
|
*** ChanServ sets mode: +o bwolfe
|
07:45:59
|
*** sgrannis has joined #openmrs
|
07:46:44
|
*** sgrannis has quit IRC
|
07:51:58
|
<r0bby> bwolfe
|
07:52:05
|
<r0bby> could i just commit this?
|
07:52:20
|
<r0bby> it's a one liner
|
07:52:28
|
<r0bby> pulling the APPDATA env var in
|
07:52:43
|
<bwolfe> no
|
07:52:46
|
<bwolfe> ticket
|
07:52:48
|
<bwolfe> and patch
|
07:53:10
|
<bwolfe> it definitely does not fall under "obvious fixes"
|
07:53:26
|
<r0bby> but it is
|
07:53:38
|
<r0bby> when you see ot "{
|
07:53:44
|
<r0bby> :)
|
07:53:51
|
<bwolfe> no, its not. just because its small, it could effect many other things
|
07:53:56
|
<bwolfe> obvious are things like spelling errors
|
07:54:13
|
<bwolfe> or spacing/curly brace problems. or javadoc comment mismatches
|
07:55:05
|
<bwolfe> and I mainly don't want you do commit it because I disagree about using appdata. thats why I didn't address that option in the email :-p
|
07:55:40
|
<bwolfe> while you're in there making that ticket and patch, go ahead and put a link to something that says all windows machines did and will always have the APPDATA env var
|
07:56:15
|
<r0bby> it's assigned to you :)
|
07:56:38
|
<r0bby> bwolfe: it's obvious, they've had it
|
07:56:55
|
<bwolfe> thanks in advance for a link to that r0bby ;-)
|
07:56:55
|
<r0bby> since win95ish i think(?)
|
07:57:03
|
<r0bby> I dont know of a link
|
07:57:49
|
<r0bby> no such link exists...
|
07:58:31
|
<r0bby> but hard-coding was a horrid solution
|
07:58:44
|
<bmckown> quick check on RDP to dev server... "echo %APPDATA%" returns "Application Data"
|
07:58:57
|
<r0bby> yes
|
07:59:05
|
<r0bby> XP or VISTA?
|
07:59:06
|
<bmckown> that's Server 2003
|
07:59:35
|
<r0bby> C:\Users\rob>echo %APPDATA%
|
07:59:35
|
<r0bby> C:\Users\rob\AppData\Roaming
|
07:59:41
|
<r0bby> that's vista
|
08:00:18
|
<r0bby> so it's not universal
|
08:00:28
|
<r0bby> which is where my point lies
|
08:00:46
|
<bwolfe> r0bby: so APPDATA on vista is absolute ?
|
08:00:59
|
<bmckown> changing subject somewhat... however, properties.xml env.CATALINA_HOME does not work for Linux unless you specifically set that environment variable. It's kind of easier just to revert the changes on my local machine back to "/opt/tomcat"
|
08:01:03
|
<bwolfe> all the more reason to add an if for vista on there and use AppData
|
08:01:14
|
<r0bby> why not just use APPDATA?
|
08:01:25
|
<bwolfe> r0bby: so APPDATA on vista is absolute ?
|
08:01:32
|
<r0bby> yes
|
08:01:36
|
<bwolfe> thats why
|
08:01:45
|
<r0bby> String filepath = System.getProperty("user.home") + File.separator +
|
08:01:45
|
<r0bby> System.getenv("APPDATA") + File.separator +
|
08:01:46
|
<r0bby> "OpenMRS";
|
08:01:53
|
<r0bby> String filepath = System.getProperty("user.home") + File.separator +
|
08:01:53
|
<r0bby> System.getenv("APPDATA") + File.separator +
|
08:01:55
|
<r0bby> er
|
08:02:00
|
<r0bby> Result: "C:\Users\rob\C:\Users\rob\AppData\Roaming\OpenMRS"
|
08:02:05
|
<r0bby> that's groovyconsole
|
08:02:11
|
<r0bby> so it works as expoeected
|
08:02:20
|
<r0bby> oh shit yes
|
08:02:34
|
<r0bby> i didnt notice
|
08:02:39
|
<bmckown> Sorry, my bad... "echo %APPDATA%" returned "C:\Documents and Settings\bmckown\Application Data"
|
08:03:01
|
<r0bby> so we can remove user.home alltogether
|
08:03:15
|
<bmckown> okay... i'm going back to work. :-)
|
08:03:35
|
<bwolfe> why is it in the Roaming subfolder ?
|
08:03:48
|
<bwolfe> will that change if you log in with a different profile ?
|
08:03:57
|
<r0bby> i have no idea
|
08:07:06
|
<r0bby> i'm preparing another patch
|
08:07:15
|
<r0bby> just pulling appdata
|
08:07:26
|
<r0bby> let me get somebody on winxp top test
|
08:07:30
|
<r0bby> but it SHOULD work
|
08:10:58
|
<r0bby> updated
|
08:14:21
|
<bwolfe> I still don't know how reliable that is
|
08:14:36
|
<bwolfe> it would work on our Win 2003 server
|
08:14:41
|
<bwolfe> dont' have xp handy to test on that
|
08:14:49
|
<r0bby> wait
|
08:14:55
|
<r0bby> my parents have xp let me test
|
08:15:21
|
<r0bby> if it works on XP we're good to go
|
08:15:31
|
<r0bby> works on XP
|
08:16:17
|
<r0bby> (I hjad somebody else test for me before i realized my parents had it)
|
08:25:25
|
<bwolfe> but r0bby, what if someone is trying to use that on Windows NT 4.0 SP6 UK ??
|
08:25:27
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #970 (defect created): Application Data directory should not be hard-coded <http://dev.openmrs.org/ticket/970>
|
08:25:35
|
<bwolfe> what are they to do?? :-p
|
08:25:40
|
<bwolfe> http://en.wikipedia.org/wiki/Environment_variable
|
08:25:42
|
<OpenMRSBot> <http://ln-s.net/28Fp> (at en.wikipedia.org)
|
08:26:37
|
<bwolfe> r0bby: apart of NT 4, looks like the LocalSystem account doesn't have an APPDATA value
|
08:26:39
|
<r0bby> C:\Documents and Settings\username\Application Data
|
08:26:45
|
<bwolfe> http://www.s-code.com/forum/Topic1496-3-1.aspx
|
08:26:49
|
<r0bby> erm
|
08:26:56
|
<r0bby> what are the odds we run on nt4
|
08:27:15
|
<bwolfe> a lot of people use the default tomcat setup...which runs tomcat as the LocalService account
|
08:27:23
|
<bwolfe> (not many nt4 users, that was a joke)
|
08:28:19
|
<r0bby> hrm
|
08:28:26
|
* r0bby checks
|
08:32:08
|
<r0bby> Windows NT 4.0 SP6 UK.
|
08:32:12
|
<r0bby> oh only in the UK
|
08:32:16
|
<r0bby> those crazy brits
|
08:33:36
|
<r0bby> james_regen
|
08:33:37
|
<r0bby> er
|
08:35:31
|
<r0bby> but hard-coding regardless is a bad idea
|
08:35:45
|
<r0bby> on win32 it gives an absolute path
|
08:36:02
|
<r0bby> bwolfe a lot of people use the default tomcat setup...which runs tomcat as the LocalService account
|
08:36:05
|
<r0bby> 14:28 @bwolfe (not many nt4 users, that was a joke)
|
08:36:09
|
<r0bby> er crap
|
08:36:15
|
<bmckown> pushing an hour on this subject
|
08:36:18
|
<bwolfe> are you saying it gives something other than an abs path on non win32 ?
|
08:36:40
|
<james_regen> robby: yes?
|
08:36:46
|
<bmckown> r0bby.. get back to work
|
08:36:51
|
<bmckown> hehe
|
08:36:52
|
<bwolfe> does that bother you bmckown ?
|
08:36:57
|
<bmckown> i'm teasing.
|
08:36:59
|
<r0bby> bwolfe: ?
|
08:37:02
|
<bwolfe> r0bby is consumed
|
08:37:06
|
<r0bby> not sure :P
|
08:37:11
|
<bwolfe> he must follow the rabbit hole !
|
08:37:17
|
<bmckown> yes
|
08:37:18
|
<r0bby> I know linux doesn't use that crud :P
|
08:37:32
|
<r0bby> bmckown: come and make me
|
08:37:37
|
* bmckown hugs r0bby
|
08:37:38
|
<r0bby> brrrrrrrrrrrrrrrrrrrrrrrrring it
|
08:37:49
|
<bmckown> r0bby is my friend
|
08:37:57
|
<bmckown> whether or not he likes me.
|
08:38:10
|
<r0bby> I never said i didn't like you
|
08:38:17
|
<bmckown> i didn't ask either
|
08:38:19
|
<r0bby> trust me i'm up front about what i think
|
08:38:48
|
<bmckown> okay... i gotta get back to the code
|
08:40:39
|
<r0bby> bwolfe: did you see my lovely method :D
|
08:40:48
|
<bwolfe> which one ?
|
08:40:54
|
* r0bby has more utility methods than he knows what to w/ :)
|
08:43:02
|
<r0bby> I have anew friend: GStrings
|
08:43:22
|
<r0bby> new File("${getControllerDirectory(id).canonicalPath}${File.separator}${GroovyFormsContainer.getForm(id)?.controllerClazzName}.groovy")
|
08:43:28
|
<r0bby> how readable is trhat :)
|
08:43:57
|
<r0bby> I got lazy and didn't feel like checking for null
|
08:44:16
|
<r0bby> so ?. is safe de-referencing
|
08:44:57
|
<bwolfe> I'm going to go with "not readable"
|
08:45:09
|
* r0bby doesn't care :)
|
08:45:19
|
<r0bby> I hate String concatenation :)
|
08:46:07
|
<bwolfe> File file = new File(directory, fileInThatDirectory();
|
08:46:18
|
<r0bby> meh
|
08:46:25
|
<r0bby> but then I wouldn't be able to use GStrings!
|
08:47:04
|
<r0bby> it's like perfect :D
|
08:47:17
|
<r0bby> it's part of what makes groovy so groovy :)
|
08:47:43
|
<r0bby> and why declare the type twice
|
08:47:48
|
<r0bby> it's inferred :)
|
08:48:42
|
<bwolfe> r0bby: you force me to read groovy, so I force you to read java
|
08:49:13
|
<r0bby> I read java anyways... :P
|
08:49:31
|
<r0bby> hell 90% of groovy code os valid java
|
08:49:38
|
<r0bby> with the erxceptiom for the java foreach
|
08:49:53
|
<r0bby> and for(init;conf;inc) for loop
|
08:50:01
|
<r0bby> s/conf/cond/
|
08:50:11
|
<r0bby> and a few other things
|
08:50:16
|
<r0bby> different == bahavior
|
08:50:24
|
<r0bby> '==' i should say
|
08:50:36
|
<r0bby> "str" == new String("str")
|
08:50:38
|
<r0bby> true
|
08:50:56
|
<r0bby> er wait bad example
|
08:51:04
|
<r0bby> er no
|
08:51:07
|
<r0bby> wait i blow
|
08:57:28
|
*** njero has joined #openmrs
|
08:57:28
|
*** ChanServ sets mode: +v njero
|
09:01:41
|
<r0bby> so bwolfe
|
09:01:46
|
<r0bby> mobing the JSP
|
09:01:57
|
<r0bby> should it happen once in the form's lifetime
|
09:02:04
|
<r0bby> (and when it is modified?
|
09:02:11
|
<r0bby> loadingf classes ios fine
|
09:02:24
|
<r0bby> I have that directory on the classpath
|
09:02:52
|
<bwolfe> I don't see why it would need to move more than once
|
09:02:56
|
<bwolfe> or at least once per edit
|
09:03:47
|
<r0bby> who does the antlr stuff
|
09:03:51
|
<r0bby> I wanna come onboard
|
09:04:02
|
<r0bby> and learn antlr been meaning to
|
09:04:23
|
<r0bby> I know how to write grammars -- but not proficient
|
09:05:28
|
<r0bby> http://dev.openmrs.org/changeset/5196
|
09:05:30
|
<r0bby> opinion?
|
09:05:58
|
<r0bby> moveJSPIntoContextPath()
|
09:06:06
|
<bwolfe> r0bby: "opinon?" isn't a valid question
|
09:06:29
|
<bwolfe> please expound
|
09:06:42
|
<r0bby> I wanted your opiniopn
|
09:06:44
|
<bwolfe> vibha anand wrote the antlr stuff
|
09:06:59
|
<bwolfe> and I don't know what you want my opinion on
|
09:07:03
|
<bwolfe> or why you want my opinion for that matter :-p
|
09:07:08
|
<r0bby> not sure
|
09:07:13
|
<r0bby> I think i'm losing my mind
|
09:07:52
|
<r0bby> hey ben wanna mentor me next year :)
|
09:08:59
|
<bwolfe> not if you lose your mind
|
09:12:28
|
<r0bby> bwolfe: you do realize, myt mind is gone already
|
09:14:30
|
<r0bby> NIIIIC#WE
|
09:15:44
|
<r0bby> if you do def x = "this.that"; x = x - "."; println x
|
09:15:47
|
<r0bby> no more period!!!
|
09:20:45
|
<r0bby> weird case
|
09:20:51
|
<r0bby> it only replaces the first occurance
|
09:29:55
|
<bwolfe> x = x -- "."
|
09:30:12
|
<bwolfe> would be cool if it worked like that
|
09:32:04
|
<r0bby> yeh
|
09:32:20
|
<r0bby> return version.replaceAll(/\./, "")
|
09:32:22
|
<r0bby> :)
|
09:32:33
|
<r0bby> no double escape :)
|
09:33:02
|
<r0bby> http://groovy.codehaus.org/groovy-jdk/
|
09:33:04
|
<r0bby> er
|
09:33:17
|
<r0bby> http://groovy.codehaus.org/groovy-jdk/java/lang/String.html#replaceAll(java.lang.String%20regex,%20groovy.lang.Closure%20closure)
|
09:33:18
|
<OpenMRSBot> <http://ln-s.net/28Gn> (at groovy.codehaus.org)
|
09:33:21
|
<r0bby> :D
|
09:33:33
|
<r0bby> groovy is ana amzing language
|
09:34:18
|
<r0bby> I sound like a fanboy
|
09:34:25
|
<r0bby> ruby is gonna be mynetx thong
|
09:34:32
|
<r0bby> njero, i'll help you out
|
09:34:40
|
<r0bby> but before i must finish mine
|
09:34:49
|
<r0bby> but I have the kinks worked out
|
09:35:06
|
<r0bby> bwolfe, portlets should i look at other examples
|
09:35:11
|
<r0bby> patient dash
|
09:35:27
|
<r0bby> I know burke doesn't feel it's needed, but i do
|
09:35:49
|
<bwolfe> again, I don't know what you're asking r0bby. please expound
|
09:35:50
|
<r0bby> Im not quite sure i see where burke is going
|
09:35:59
|
<r0bby> bwolfe: dont make me expand
|
09:36:01
|
<r0bby> read my mind
|
09:36:09
|
<r0bby> what am I thinking
|
09:36:17
|
<r0bby> :P
|
09:36:25
|
* bwolfe groans
|
09:36:27
|
* bwolfe has work to do
|
09:36:35
|
* r0bby giggles
|
09:36:38
|
<r0bby> so do I
|
09:36:44
|
* bwolfe considers leaving the chat so r0bby stops asking questions before thinking
|
09:36:49
|
<r0bby> nO!!!
|
09:36:57
|
* r0bby has irc on one monitor ide aon the other
|
09:37:01
|
* r0bby goes to work
|
09:50:24
|
<r0bby> ...
|
09:50:32
|
<r0bby> openmrs won't start (the webapp)
|
09:52:32
|
<r0bby> http://papernapkin.org/pastebin/view/2155/
|
09:55:21
|
<bwolfe> you are correct
|
09:55:34
|
<r0bby> what's going on..
|
09:55:50
|
<r0bby> it doesn't syaart
|
09:55:56
|
<bwolfe> restart tocmat
|
09:55:59
|
<bwolfe> remove the war file
|
09:56:04
|
<bwolfe> remove the directory
|
09:56:09
|
<r0bby> ok
|
09:56:09
|
<bwolfe> there are many options you have
|
09:56:14
|
<bwolfe> do a clean build
|
09:56:18
|
<bwolfe> don't load your modules
|
09:56:21
|
<bwolfe> etc
|
09:56:22
|
<bwolfe> etc
|
09:56:49
|
<r0bby> ok thanks ben
|
09:57:47
|
*** james_regen has quit IRC
|
10:06:04
|
* r0bby taps his foot
|
10:18:16
|
<bmckown> as in "tap dance" ?
|
10:29:32
|
<r0bby> hah
|
10:29:35
|
<r0bby> I know what it was
|
10:29:44
|
<r0bby> apparently it breaks if it cant find the app data dir
|
10:30:08
|
<r0bby> cute
|
10:30:08
|
<bmckown> r0bby
|
10:30:17
|
<bmckown> what to you prefer?
|
10:30:34
|
<bmckown> amrsreporttools .... or .... ampathreporttools
|
10:30:49
|
* r0bby doesnt care
|
10:30:54
|
<bmckown> pick one
|
10:30:59
|
<r0bby> first
|
10:31:01
|
<bmckown> okay
|
10:31:03
|
<r0bby> i hate long names
|
10:31:05
|
<bmckown> same here
|
10:33:21
|
*** sioraiocht has joined #openmrs
|
10:37:24
|
<r0bby> haha bug
|
10:37:25
|
<r0bby> C:\Windows\system32\config\systemprofile\AppData\Roaming\OpenMRS\modules
|
10:38:33
|
<r0bby> since im runnign as a service i suppose that;s correct
|
10:39:57
|
<r0bby> is that we want?
|
10:40:08
|
<bwolfe> probably not
|
10:40:36
|
<r0bby> but that is how windows vista does it
|
10:40:38
|
<r0bby> i think
|
10:41:38
|
<bwolfe> yet another reason I would prefer to use user.home + AppData
|
10:41:58
|
<r0bby> okay
|
10:42:06
|
<r0bby> it does say Windows Vista
|
10:42:16
|
* r0bby codes up yet another patch
|
10:42:24
|
<r0bby> sorry :S
|
10:43:05
|
<r0bby> I'm contributing :)
|
10:45:43
|
<bwolfe> :-)
|
10:48:39
|
<r0bby> OHH there's a constant for VISTA!
|
10:50:53
|
<r0bby> god I hate windows
|
10:58:14
|
<r0bby> bwolfe: how's this for a compromise
|
10:58:25
|
<r0bby> if vista i do the APPDATA env var?
|
10:58:28
|
<r0bby> compromise
|
10:58:48
|
<r0bby> otherwise we do the fallback (the current behavior
|
10:58:55
|
<r0bby> because vista is weird w/ profiles
|
11:07:13
|
*** bmckown has quit IRC
|
11:09:21
|
*** bwolfe has quit IRC
|
11:14:36
|
*** atomicturtle has quit IRC
|
11:17:23
|
<r0bby> heh/jerk
|
11:18:20
|
*** sioraiocht has quit IRC
|
11:26:20
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Problem with RemoteFormEntry Module Implementation <http://forum.openmrs.org/viewtopic.php?f=9&t=391#p1344>
|
12:45:23
|
*** r0bby has quit IRC
|
12:45:23
|
*** njero has quit IRC
|
12:45:23
|
*** [m_harrison] has quit IRC
|
12:45:23
|
*** jacobb has quit IRC
|
12:45:23
|
*** Phantal has quit IRC
|
12:47:38
|
*** njero has joined #openmrs
|
12:47:38
|
*** [m_harrison] has joined #openmrs
|
12:47:38
|
*** jacobb has joined #openmrs
|
12:47:38
|
*** Phantal has joined #openmrs
|
12:47:38
|
*** r0bby has joined #openmrs
|
12:47:38
|
*** irc.freenode.net sets mode: +vv njero r0bby
|
13:05:28
|
*** njero has quit IRC
|
14:22:39
|
*** [m_harrison] is now known as [mharrison]
|
15:32:16
|
*** huntp has joined #openmrs
|
16:34:55
|
*** sprasanna has joined #openmrs
|
17:57:41
|
*** nribeka has joined #openmrs
|
18:21:49
|
*** huntp has quit IRC
|
18:59:03
|
*** sprasanna has quit IRC
|