| 00:32:41 | *** upul has quit IRC |
| 00:43:45 | *** Keelhaul has quit IRC |
| 01:56:07 | *** udai has quit IRC |
| 02:07:24 | *** nribeka has quit IRC |
| 02:09:17 | *** nribeka has joined #openmrs |
| 02:35:26 | *** nribeka has quit IRC |
| 03:33:05 | *** sioraiocht has joined #openmrs |
| 03:33:05 | *** ChanServ sets mode: +v sioraiocht |
| 05:21:11 | *** eray has joined #openmrs |
| 05:38:05 | *** sioraiocht has quit IRC |
| 05:40:48 | *** sioraiocht has joined #openmrs |
| 05:40:48 | *** ChanServ sets mode: +v sioraiocht |
| 06:17:29 | *** maveriick has joined #openmrs |
| 06:56:58 | <maveriick> hi evreybody |
| 07:23:06 | *** nribeka has joined #openmrs |
| 07:25:46 | *** bwolfe has joined #openmrs |
| 07:25:46 | *** OpenMRSBot sets mode: +o bwolfe |
| 07:25:46 | *** ChanServ sets mode: +o bwolfe |
| 07:25:47 | <OpenMRSBot> Hey there Ben! |
| 07:55:07 | *** Wiss has joined #openmrs |
| 07:57:56 | <maveriick> hi bwolfe |
| 08:00:33 | <bwolfe> hey maveriick |
| 08:01:36 | <maveriick> After a while I'm back to the patient search ticket : ticket #516... |
| 08:01:48 | <maveriick> I did solved it with a Global_property... |
| 08:01:50 | <bwolfe> !ticket 516 |
| 08:01:50 | <OpenMRSBot> bwolfe: Ticket #516: http://dev.openmrs.org/ticket/516 |
| 08:02:13 | <bwolfe> ah, cool |
| 08:02:22 | <maveriick> But the current logic is - if global property is not defined or set to an invalid number -- i.e., not 1-5), then default to 2 |
| 08:02:45 | <bwolfe> hmm |
| 08:02:53 | <bwolfe> that should be fine...I still prefer 3 :-) |
| 08:03:02 | <maveriick> But in OpenmrsSearch dojo widget ..there is a property names minSearchCharacters |
| 08:03:06 | <maveriick> which is 2 ... |
| 08:03:18 | <bwolfe> hmm...seems I contradict myself |
| 08:03:36 | <maveriick> Yup pretty much ... |
| 08:04:01 | <maveriick> If we set it via Global Property then we shouldn't check this hard coded in widget |
| 08:04:17 | <maveriick> Now whats your suggestion? |
| 08:04:37 | <bwolfe> yes, the javascript files should check the global property |
| 08:04:44 | <bwolfe> there is a taglib you can use in the javascript |
| 08:04:51 | <bwolfe> which javascript file is that in ? |
| 08:05:28 | <bwolfe> <openmrs:globalPropertyproperty="______"/> should print out the value of the given _____ global property. I'm not 100% on this, so do a quick search in openmrs for that |
| 08:05:34 | <maveriick> OpenmrsSearch.js.withjstl |
| 08:05:44 | <bwolfe> or look in /web/web-inf/tablib/openmrs.tld to see what it is named |
| 08:05:53 | <maveriick> <openmrs:globalProperty key= |
| 08:06:07 | <bwolfe> ok, because it is a .withjstl file, you can use taglibs and other jsp things in it. |
| 08:33:09 | *** Keelhaul has joined #openmrs |
| 08:33:09 | *** ChanServ sets mode: +v Keelhaul |
| 08:33:23 | <maveriick> bwolfe, is there any way to debug the widget code? |
| 08:53:54 | <maveriick> bwolfe, I think we should not let user search less than two characters.... |
| 08:54:09 | <maveriick> It will require far more changes and may have side effects .... |
| 08:59:04 | *** sioraiocht has quit IRC |
| 08:59:52 | <bwolfe> maveriick: debugging is tough |
| 09:00:07 | <bwolfe> there are conflicts in our header code and hte widgets I think |
| 09:00:33 | <bwolfe> so you have to use a blank page and turn on dojo debugging in the /web/scripts/debug.js file |
| 09:00:48 | <bwolfe> maveriick: are you saying that the js shouldn't check the global property? |
| 09:00:51 | *** sioraiocht has joined #openmrs |
| 09:00:51 | *** ChanServ sets mode: +v sioraiocht |
| 09:01:06 | <maveriick> I have done the changes ....and its checking the global property.... |
| 09:01:13 | <bwolfe> cool |
| 09:02:53 | <maveriick> But in the onInputChange method ....there is a check which prevents the ajax event triggering if the text length is 1 |
| 09:05:07 | <bwolfe> ok..and you're leaving that as is? |
| 09:05:42 | <maveriick> I changed that to this.text.length >= 1 from this.text.length > 1 |
| 09:07:38 | *** sioraiocht has quit IRC |
| 09:17:32 | <bwolfe> ok |
| 09:17:36 | <bwolfe> sounds good |
| 09:17:39 | *** bwolfe has quit IRC |
| 09:18:37 | <Keelhaul> searching with 1 char heh? |
| 09:19:25 | <maveriick> Thats what directed by bmamlin :-) |
| 09:20:20 | <maveriick> Only one problem exists ....it can't search with 1 digit say '2' .....says invalid checkdigit... |
| 09:21:01 | <Keelhaul> =o |
| 09:22:31 | *** Wiss_ has joined #openmrs |
| 09:30:28 | *** Wiss has quit IRC |
| 10:21:52 | *** eray has left #openmrs |
| 10:30:10 | *** Keelhaul has quit IRC |
| 10:55:11 | *** nribeka has quit IRC |
| 11:00:06 | *** nribeka has joined #openmrs |
| 11:00:54 | *** eray has joined #openmrs |
| 11:01:05 | *** eray has left #openmrs |
| 11:11:21 | *** maveriick has quit IRC |
| 12:15:36 | *** pombreda has quit IRC |
| 13:04:35 | *** Wiss_ has quit IRC |
| 13:12:44 | *** udai has joined #openmrs |
| 13:36:05 | *** pombreda has joined #openmrs |
| 13:36:05 | *** ChanServ sets mode: +v pombreda |
| 14:04:29 | *** bmckown has joined #openmrs |
| 14:04:29 | *** ChanServ sets mode: +o bmckown |
| 14:13:26 | *** bmckown has quit IRC |
| 15:02:55 | *** masonf has joined #openmrs |
| 15:06:58 | *** ChanServ sets mode: +v atomicturtle |
| 15:59:08 | *** udai has quit IRC |
| 16:07:29 | *** pombreda has quit IRC |
| 16:34:21 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [3911]: xformsorbeon module: changed errorList to errorMap <http://dev.openmrs.org/changeset/3911> |
| 16:56:16 | *** Wiss has joined #openmrs |
| 16:57:05 | *** Wiss has quit IRC |
| 16:57:21 | *** Wiss has joined #openmrs |
| 18:04:42 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Form Entry 3.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=formentry&version=&3.1> |
| 19:00:14 | *** Wiss has quit IRC |
| 19:08:45 | *** bwolfe has joined #openmrs |
| 19:08:45 | *** ChanServ sets mode: +o bwolfe |
| 19:08:45 | *** OpenMRSBot sets mode: +o bwolfe |
| 19:08:46 | <OpenMRSBot> Hey there Ben! |
| 19:09:24 | <bwolfe> hey there bot |
| 19:18:13 | <r0bby> the bot loves you more than me :< |
| 19:18:22 | *** Feez has quit IRC |
| 19:18:25 | <r0bby> OpenMRSBot: can haz love? |
| 19:18:25 | <OpenMRSBot> r0bby: Error: "can" is not a valid command. |
| 19:18:30 | <r0bby> ouch |
| 19:19:51 | <bwolfe> heh |
| 19:20:09 | <bwolfe> register with the bot r0bby |
| 19:20:16 | <bwolfe> then I can add a greeting for you :-p |
| 19:24:29 | <napi> !hello |
| 19:24:29 | <OpenMRSBot> napi: Error: "hello" is not a valid command. |
| 19:24:33 | <napi> !whoami |
| 19:24:33 | <OpenMRSBot> napi: napi |
| 19:24:36 | <napi> woo |
| 19:24:41 | <napi> !greeting |
| 19:24:41 | <OpenMRSBot> napi: Error: "greeting" is not a valid command. |
| 19:27:37 | *** napi has left #openmrs |
| 19:27:37 | *** napi has joined #openmrs |
| 19:28:11 | <napi> aww it didn't work |
| 19:28:23 | <napi> !herald get |
| 19:28:23 | <OpenMRSBot> napi: hi napi! |
| 19:28:36 | *** napi has left #openmrs |
| 19:28:36 | *** napi has joined #openmrs |
| 19:28:40 | * napi slaps OpenMRSBot |
| 20:03:05 | *** HongJun has joined #openmrs |
| 20:05:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [3913]: formentry module: Fixed compiler error in JUnit test class. <http://dev.openmrs.org/changeset/3913> || OpenMRS Changesets: Changeset [3912]: formentry module: Implemented changes that are required in order to use ⦠<http://dev.openmrs.org/changeset/3912> |
| 20:49:52 | *** HongJun has quit IRC |
| 21:30:08 | *** bwolfe has quit IRC |
| 22:17:09 | *** nribeka has quit IRC |
| 22:19:04 | *** nribeka has joined #openmrs |
| 23:37:02 | *** pombreda has joined #openmrs |
| 23:37:02 | *** ChanServ sets mode: +v pombreda |
| 23:45:16 | *** nribeka has quit IRC |
| 23:46:14 | *** nribeka has joined #openmrs |
| 23:48:16 | *** nribeka has quit IRC |
| 23:49:17 | *** nribeka has joined #openmrs |